simplycop 1.12.20 → 1.12.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9d7b1dfbe91cd595f0491440519bdaf520cb4dfe9048ab500e5ed37f9a83eda2
-  data.tar.gz: ed90b05962cb6537ff3370271a67659771232fcce4a35f535231b4bcd67f134e
+  metadata.gz: 68e568f306249b37bfb255cdd58ec03e209b2f1e0d81be18c8ef015dab756c4d
+  data.tar.gz: 84681f62a6470b474340dc9ab33310721a2caf41ada7245d2ab17c39e37b9038
 SHA512:
-  metadata.gz: 20cf2ce53fc721de021c0be9f0fb63e119504b44599dfe3ce6f0d39afc6d5ba9cb79fcd9b91331dc3cd8852b51f4e998d7ae90206674cacd002cdba62963026b
-  data.tar.gz: 4468e20beee4c4c03a12fc80599f92498a192f84d2842e8e8ce8aa056f1b59091eccdd2ae43905be36c4447c0d31e18af4b81cb74de99927dc6824431ad6864d
+  metadata.gz: f139da031074eb065eb31ecf446da61ce67c4fb33e7286dd601e8a236d44cdf3473e048b20f3936f615236e4a7ac866cfdb614bca263236fc17b33b04072898e
+  data.tar.gz: 8a02a4aef2f054cec5b66af68d2a922bf6cd0481c6337c51d3aff1de4ca82bbdfb6b0cd978537d639889475aec737e88f2bae86482bbc39b37d05caf7e402a84

data/.simplycop.yml

@@ -25,21 +25,166 @@ AllCops:
 Gemspec/DeprecatedAttributeAssignment: # new in 1.30
   Enabled: true
 
+Layout/AccessModifierIndentation:
+  Enabled: true
+
+Layout/ArgumentAlignment:
+  Enabled: true
+
+Layout/ArrayAlignment:
+  Enabled: true
+
+Layout/AssignmentIndentation:
+  Enabled: true
+
+Layout/BeginEndAlignment:
+  Enabled: true
+
+Layout/BlockAlignment:
+  Enabled: true
+
+Layout/BlockEndNewline:
+  Enabled: true
+
+Layout/CaseIndentation:
+  Enabled: true
+
+# Discussion needed about preferred structure. Dozens of fails on each repo if we stick with default, all but 4 on Chopin are autocorrectable
+# Layout/ClassStructure:
+#   Enabled: true
+
+Layout/ClosingHeredocIndentation:
+  Enabled: true
+
+Layout/ClosingParenthesisIndentation:
+  Enabled: true
+
+Layout/CommentIndentation:
+  Enabled: true
+
+Layout/ConditionPosition:
+  Enabled: true
+
+Layout/DefEndAlignment:
+  Enabled: true
+
+Layout/DotPosition:
+  Enabled: true
+
+Layout/ElseAlignment:
+  Enabled: true
+
+Layout/EmptyComment:
+  Enabled: true
+
+Layout/EmptyLineAfterGuardClause:
+  Enabled: true
+
+# To discuss. Suggest should be true but 500+ autocorrectable fails on Chopin. None on others 
+# Layout/EmptyLineAfterMagicComment:
+#   Enabled: true
+
 Layout/EmptyLineAfterMultilineCondition:
   Enabled: true
 
+Layout/EmptyLineBetweenDefs:
+  Enabled: true
+
+Layout/EmptyLines:
+  Enabled: true
+
+Layout/EmptyLinesAroundAccessModifier:
+  Enabled: true
+
+Layout/EmptyLinesAroundArguments:
+  Enabled: true
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
+Layout/EmptyLinesAroundBeginBody:
+  Enabled: true
+
+Layout/EmptyLinesAroundBlockBody:
+  Enabled: true
+
+Layout/EmptyLinesAroundClassBody:
+  Enabled: true  
+
+Layout/EmptyLinesAroundExceptionHandlingKeywords:
+  Enabled: true
+
+Layout/EmptyLinesAroundMethodBody:
+  Enabled: true  
+
+Layout/EmptyLinesAroundModuleBody:
+  Enabled: true
+
+Layout/EndAlignment:
+  Enabled: true
+
+Layout/EndOfLine:
+  Enabled: true
+
+Layout/ExtraSpacing:
+  Enabled: true
+
+Layout/FirstArgumentIndentation:
+  Enabled: true
+
+Layout/FirstArrayElementIndentation:
+  Enabled: true
+
 Layout/FirstArrayElementLineBreak:
   Enabled: true
 
 Layout/FirstMethodArgumentLineBreak:
   Enabled: true
 
+Layout/FirstHashElementIndentation:
+  Enabled: true
+
 Layout/FirstHashElementLineBreak:
   Enabled: true
 
+# To discuss - 200+ fails on CoCo, none elsewhere
+# Layout/FirstMethodArgumentLineBreak:
+#   Enabled: true
+
+# To discuss - 100+ fails on Chopin, handful on others
+# Layout/FirstMethodParameterLineBreak:
+#   Enabled: true
+
+Layout/FirstParameterIndentation:
+  Enabled: true
+
+Layout/HashAlignment:
+  Enabled: true
+
 Layout/HeredocArgumentClosingParenthesis:
   Enabled: true
 
+Layout/HeredocIndentation:
+  Enabled: true
+
+Layout/IndentationConsistency:
+  Enabled: true
+
+Layout/IndentationStyle:
+  Enabled: true
+
+Layout/IndentationWidth:
+  Enabled: true
+
+Layout/InitialIndentation:
+  Enabled: true
+
+Layout/LeadingCommentSpace:
+  Enabled: true
+
+Layout/LeadingEmptyLines:
+  Enabled: true
+
 Layout/LineContinuationLeadingSpace:
   Enabled: true
 
@@ -49,9 +194,148 @@ Layout/LineContinuationSpacing:
 Layout/LineEndStringConcatenationIndentation:
   Enabled: true
 
+# To discuss: configure line length? At default 120: 6805 fails on Chopin, 3 on Rater, 179 on CoCo
+# Layout/LineLength
+#   Enabled: false
+Layout/MultilineArrayBraceLayout:
+  Enabled: true
+  
+# To discuss: 100s of fails on each repo but autocorrectable  
+# Layout/MultilineArrayLineBreaks:
+#   Enabled: true
+
+# To discuss: 100s of fails on each repo but autocorrectable  
+# Layout/MultilineAssignmentLayout:
+#   Enabled: true
+  
+Layout/MultilineBlockLayout:
+  Enabled: true
+  
+Layout/MultilineHashBraceLayout:
+  Enabled: true
+
+# To discuss: 100s of fails on each repo but autocorrectable  
+# Layout/MultilineHashKeyLineBreaks:
+#   Enabled: true
+
+# To discuss: 1000s of fails on each repo but autocorrectable  
+# Layout/MultilineMethodArgumentLineBreaks:
+#   Enabled: true
+  
+Layout/MultilineMethodCallBraceLayout:
+  Enabled: true
+  
+Layout/MultilineMethodCallIndentation:
+  Enabled: true
+  
+Layout/MultilineMethodDefinitionBraceLayout:
+  Enabled: true
+
+# To discuss: 100s of fails on each repo but autocorrectable
+# Layout/MultilineMethodParameterLineBreaks:
+#   Enabled: true
+  
+Layout/MultilineOperationIndentation:
+  Enabled: true
+
+Layout/ParameterAlignment:
+  Enabled: true
+
+# For discussion: 1000s of fails, all autocorrectable
+# Layout/RedundantLineBreak:
+#   Enabled: true
+
+Layout/RescueEnsureAlignment:
+  Enabled: true
+
+# For discussion: 1000s of fails, all autocorrectable
+# Layout/SingleLineBlockChain:
+#   Enabled: true
+
+Layout/SpaceAfterColon:
+  Enabled: true
+
+Layout/SpaceAfterComma:
+  Enabled: true
+
+Layout/SpaceAfterMethodName:
+  Enabled: true
+
+Layout/SpaceAfterNot:
+  Enabled: true
+
+Layout/SpaceAfterSemicolon:
+  Enabled: true
+
+Layout/SpaceAroundBlockParameters:
+  Enabled: true
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Layout/SpaceAroundKeyword:
+  Enabled: true
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Layout/SpaceAroundOperators:
+  Enabled: true
+
+Layout/SpaceBeforeBlockBraces:
+  Enabled: true
+
 Layout/SpaceBeforeBrackets:
   Enabled: true
 
+Layout/SpaceBeforeComma:
+  Enabled: true
+
+Layout/SpaceBeforeComment:
+  Enabled: true
+
+Layout/SpaceBeforeFirstArg:
+  Enabled: true
+
+Layout/SpaceBeforeSemicolon:
+  Enabled: true
+
+Layout/SpaceInLambdaLiteral:
+  Enabled: true
+
+Layout/SpaceInsideArrayLiteralBrackets:
+  Enabled: true
+
+Layout/SpaceInsideArrayPercentLiteral:
+  Enabled: true
+
+Layout/SpaceInsideBlockBraces:
+  Enabled: true
+
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: true
+
+Layout/SpaceInsideParens:
+  Enabled: true
+
+Layout/SpaceInsidePercentLiteralDelimiters:
+  Enabled: true
+
+Layout/SpaceInsideRangeLiteral:
+  Enabled: true
+
+Layout/SpaceInsideReferenceBrackets:
+  Enabled: true
+
+Layout/SpaceInsideStringInterpolation:
+  Enabled: true
+
+Layout/TrailingEmptyLines:
+  Enabled: true
+
+Layout/TrailingWhitespace:
+  Enabled: true
+
 Lint/AmbiguousAssignment:
   Enabled: true
 

data/.simplycop_rspec.yml

@@ -117,6 +117,9 @@ Capybara/SpecificMatcher:
 FactoryBot/ConsistentParenthesesStyle:
   Enabled: true
 
+FactoryBot/CreateList:
+  Enabled: false
+
 FactoryBot/FactoryNameStyle:
   Enabled: true
 

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.12.20'
+  VERSION = '1.12.21'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.12.20
+  version: 1.12.21
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-05-22 00:00:00.000000000 Z
+date: 2023-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop