simplycop 1.12.18 → 1.12.21

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: bb0162eb0b49f4c38b6a0e5a3adb01ffcd6d58ba0ba4f0cf56fae6869229b974
4
- data.tar.gz: 152f92c09cb44a1f852cd694e5676da8c5ea15766f9d0129010925663f485f11
3
+ metadata.gz: 68e568f306249b37bfb255cdd58ec03e209b2f1e0d81be18c8ef015dab756c4d
4
+ data.tar.gz: 84681f62a6470b474340dc9ab33310721a2caf41ada7245d2ab17c39e37b9038
5
5
  SHA512:
6
- metadata.gz: 3b5387269617071c3b578ea6b9833e7431b256bdc05b79e82b59378ff6a9bfd1723b89aca949b4dc042169d6ef34cd88763021b4155b96c16726b6fdca047620
7
- data.tar.gz: efdb8ba24eac8850c568844b3614451ad5acb51ac6f30298a1b38294a378921bef5c5aee68bdddf639b2d8208ed171e1041b2e34ce258776339761fcf11582d0
6
+ metadata.gz: f139da031074eb065eb31ecf446da61ce67c4fb33e7286dd601e8a236d44cdf3473e048b20f3936f615236e4a7ac866cfdb614bca263236fc17b33b04072898e
7
+ data.tar.gz: 8a02a4aef2f054cec5b66af68d2a922bf6cd0481c6337c51d3aff1de4ca82bbdfb6b0cd978537d639889475aec737e88f2bae86482bbc39b37d05caf7e402a84
@@ -14,7 +14,7 @@ jobs:
14
14
  runs-on: ubuntu-latest
15
15
 
16
16
  steps:
17
- - uses: simplybusiness/version-forget-me-not@v2.3.0
17
+ - uses: simplybusiness/version-forget-me-not@v2
18
18
  env:
19
19
  ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
20
20
  VERSION_FILE_PATH: "lib/simplycop/version.rb"
data/.simplycop.yml CHANGED
@@ -25,21 +25,166 @@ AllCops:
25
25
  Gemspec/DeprecatedAttributeAssignment: # new in 1.30
26
26
  Enabled: true
27
27
 
28
+ Layout/AccessModifierIndentation:
29
+ Enabled: true
30
+
31
+ Layout/ArgumentAlignment:
32
+ Enabled: true
33
+
34
+ Layout/ArrayAlignment:
35
+ Enabled: true
36
+
37
+ Layout/AssignmentIndentation:
38
+ Enabled: true
39
+
40
+ Layout/BeginEndAlignment:
41
+ Enabled: true
42
+
43
+ Layout/BlockAlignment:
44
+ Enabled: true
45
+
46
+ Layout/BlockEndNewline:
47
+ Enabled: true
48
+
49
+ Layout/CaseIndentation:
50
+ Enabled: true
51
+
52
+ # Discussion needed about preferred structure. Dozens of fails on each repo if we stick with default, all but 4 on Chopin are autocorrectable
53
+ # Layout/ClassStructure:
54
+ # Enabled: true
55
+
56
+ Layout/ClosingHeredocIndentation:
57
+ Enabled: true
58
+
59
+ Layout/ClosingParenthesisIndentation:
60
+ Enabled: true
61
+
62
+ Layout/CommentIndentation:
63
+ Enabled: true
64
+
65
+ Layout/ConditionPosition:
66
+ Enabled: true
67
+
68
+ Layout/DefEndAlignment:
69
+ Enabled: true
70
+
71
+ Layout/DotPosition:
72
+ Enabled: true
73
+
74
+ Layout/ElseAlignment:
75
+ Enabled: true
76
+
77
+ Layout/EmptyComment:
78
+ Enabled: true
79
+
80
+ Layout/EmptyLineAfterGuardClause:
81
+ Enabled: true
82
+
83
+ # To discuss. Suggest should be true but 500+ autocorrectable fails on Chopin. None on others
84
+ # Layout/EmptyLineAfterMagicComment:
85
+ # Enabled: true
86
+
28
87
  Layout/EmptyLineAfterMultilineCondition:
29
88
  Enabled: true
30
89
 
90
+ Layout/EmptyLineBetweenDefs:
91
+ Enabled: true
92
+
93
+ Layout/EmptyLines:
94
+ Enabled: true
95
+
96
+ Layout/EmptyLinesAroundAccessModifier:
97
+ Enabled: true
98
+
99
+ Layout/EmptyLinesAroundArguments:
100
+ Enabled: true
101
+
102
+ Layout/EmptyLinesAroundAttributeAccessor:
103
+ Enabled: true
104
+
105
+ Layout/EmptyLinesAroundBeginBody:
106
+ Enabled: true
107
+
108
+ Layout/EmptyLinesAroundBlockBody:
109
+ Enabled: true
110
+
111
+ Layout/EmptyLinesAroundClassBody:
112
+ Enabled: true
113
+
114
+ Layout/EmptyLinesAroundExceptionHandlingKeywords:
115
+ Enabled: true
116
+
117
+ Layout/EmptyLinesAroundMethodBody:
118
+ Enabled: true
119
+
120
+ Layout/EmptyLinesAroundModuleBody:
121
+ Enabled: true
122
+
123
+ Layout/EndAlignment:
124
+ Enabled: true
125
+
126
+ Layout/EndOfLine:
127
+ Enabled: true
128
+
129
+ Layout/ExtraSpacing:
130
+ Enabled: true
131
+
132
+ Layout/FirstArgumentIndentation:
133
+ Enabled: true
134
+
135
+ Layout/FirstArrayElementIndentation:
136
+ Enabled: true
137
+
31
138
  Layout/FirstArrayElementLineBreak:
32
139
  Enabled: true
33
140
 
34
141
  Layout/FirstMethodArgumentLineBreak:
35
142
  Enabled: true
36
143
 
144
+ Layout/FirstHashElementIndentation:
145
+ Enabled: true
146
+
37
147
  Layout/FirstHashElementLineBreak:
38
148
  Enabled: true
39
149
 
150
+ # To discuss - 200+ fails on CoCo, none elsewhere
151
+ # Layout/FirstMethodArgumentLineBreak:
152
+ # Enabled: true
153
+
154
+ # To discuss - 100+ fails on Chopin, handful on others
155
+ # Layout/FirstMethodParameterLineBreak:
156
+ # Enabled: true
157
+
158
+ Layout/FirstParameterIndentation:
159
+ Enabled: true
160
+
161
+ Layout/HashAlignment:
162
+ Enabled: true
163
+
40
164
  Layout/HeredocArgumentClosingParenthesis:
41
165
  Enabled: true
42
166
 
167
+ Layout/HeredocIndentation:
168
+ Enabled: true
169
+
170
+ Layout/IndentationConsistency:
171
+ Enabled: true
172
+
173
+ Layout/IndentationStyle:
174
+ Enabled: true
175
+
176
+ Layout/IndentationWidth:
177
+ Enabled: true
178
+
179
+ Layout/InitialIndentation:
180
+ Enabled: true
181
+
182
+ Layout/LeadingCommentSpace:
183
+ Enabled: true
184
+
185
+ Layout/LeadingEmptyLines:
186
+ Enabled: true
187
+
43
188
  Layout/LineContinuationLeadingSpace:
44
189
  Enabled: true
45
190
 
@@ -49,9 +194,148 @@ Layout/LineContinuationSpacing:
49
194
  Layout/LineEndStringConcatenationIndentation:
50
195
  Enabled: true
51
196
 
197
+ # To discuss: configure line length? At default 120: 6805 fails on Chopin, 3 on Rater, 179 on CoCo
198
+ # Layout/LineLength
199
+ # Enabled: false
200
+ Layout/MultilineArrayBraceLayout:
201
+ Enabled: true
202
+
203
+ # To discuss: 100s of fails on each repo but autocorrectable
204
+ # Layout/MultilineArrayLineBreaks:
205
+ # Enabled: true
206
+
207
+ # To discuss: 100s of fails on each repo but autocorrectable
208
+ # Layout/MultilineAssignmentLayout:
209
+ # Enabled: true
210
+
211
+ Layout/MultilineBlockLayout:
212
+ Enabled: true
213
+
214
+ Layout/MultilineHashBraceLayout:
215
+ Enabled: true
216
+
217
+ # To discuss: 100s of fails on each repo but autocorrectable
218
+ # Layout/MultilineHashKeyLineBreaks:
219
+ # Enabled: true
220
+
221
+ # To discuss: 1000s of fails on each repo but autocorrectable
222
+ # Layout/MultilineMethodArgumentLineBreaks:
223
+ # Enabled: true
224
+
225
+ Layout/MultilineMethodCallBraceLayout:
226
+ Enabled: true
227
+
228
+ Layout/MultilineMethodCallIndentation:
229
+ Enabled: true
230
+
231
+ Layout/MultilineMethodDefinitionBraceLayout:
232
+ Enabled: true
233
+
234
+ # To discuss: 100s of fails on each repo but autocorrectable
235
+ # Layout/MultilineMethodParameterLineBreaks:
236
+ # Enabled: true
237
+
238
+ Layout/MultilineOperationIndentation:
239
+ Enabled: true
240
+
241
+ Layout/ParameterAlignment:
242
+ Enabled: true
243
+
244
+ # For discussion: 1000s of fails, all autocorrectable
245
+ # Layout/RedundantLineBreak:
246
+ # Enabled: true
247
+
248
+ Layout/RescueEnsureAlignment:
249
+ Enabled: true
250
+
251
+ # For discussion: 1000s of fails, all autocorrectable
252
+ # Layout/SingleLineBlockChain:
253
+ # Enabled: true
254
+
255
+ Layout/SpaceAfterColon:
256
+ Enabled: true
257
+
258
+ Layout/SpaceAfterComma:
259
+ Enabled: true
260
+
261
+ Layout/SpaceAfterMethodName:
262
+ Enabled: true
263
+
264
+ Layout/SpaceAfterNot:
265
+ Enabled: true
266
+
267
+ Layout/SpaceAfterSemicolon:
268
+ Enabled: true
269
+
270
+ Layout/SpaceAroundBlockParameters:
271
+ Enabled: true
272
+
273
+ Layout/SpaceAroundEqualsInParameterDefault:
274
+ Enabled: true
275
+
276
+ Layout/SpaceAroundKeyword:
277
+ Enabled: true
278
+
279
+ Layout/SpaceAroundMethodCallOperator:
280
+ Enabled: true
281
+
282
+ Layout/SpaceAroundOperators:
283
+ Enabled: true
284
+
285
+ Layout/SpaceBeforeBlockBraces:
286
+ Enabled: true
287
+
52
288
  Layout/SpaceBeforeBrackets:
53
289
  Enabled: true
54
290
 
291
+ Layout/SpaceBeforeComma:
292
+ Enabled: true
293
+
294
+ Layout/SpaceBeforeComment:
295
+ Enabled: true
296
+
297
+ Layout/SpaceBeforeFirstArg:
298
+ Enabled: true
299
+
300
+ Layout/SpaceBeforeSemicolon:
301
+ Enabled: true
302
+
303
+ Layout/SpaceInLambdaLiteral:
304
+ Enabled: true
305
+
306
+ Layout/SpaceInsideArrayLiteralBrackets:
307
+ Enabled: true
308
+
309
+ Layout/SpaceInsideArrayPercentLiteral:
310
+ Enabled: true
311
+
312
+ Layout/SpaceInsideBlockBraces:
313
+ Enabled: true
314
+
315
+ Layout/SpaceInsideHashLiteralBraces:
316
+ Enabled: true
317
+
318
+ Layout/SpaceInsideParens:
319
+ Enabled: true
320
+
321
+ Layout/SpaceInsidePercentLiteralDelimiters:
322
+ Enabled: true
323
+
324
+ Layout/SpaceInsideRangeLiteral:
325
+ Enabled: true
326
+
327
+ Layout/SpaceInsideReferenceBrackets:
328
+ Enabled: true
329
+
330
+ Layout/SpaceInsideStringInterpolation:
331
+ Enabled: true
332
+
333
+ Layout/TrailingEmptyLines:
334
+ Enabled: true
335
+
336
+ Layout/TrailingWhitespace:
337
+ Enabled: true
338
+
55
339
  Lint/AmbiguousAssignment:
56
340
  Enabled: true
57
341
 
@@ -175,6 +459,9 @@ Style/AccessorGrouping:
175
459
  Style/Alias:
176
460
  Enabled: false
177
461
 
462
+ Style/AndOr:
463
+ Enabled: true
464
+
178
465
  Style/ArgumentsForwarding:
179
466
  Enabled: true
180
467
 
@@ -184,43 +471,192 @@ Style/ArrayCoercion:
184
471
  Style/ArrayIntersect:
185
472
  Enabled: true
186
473
 
474
+ Style/ArrayJoin:
475
+ Enabled: true
476
+
477
+ Style/AsciiComments:
478
+ Enabled: true
479
+ AllowedChars: [£, ©]
480
+
481
+ Style/Attr:
482
+ Enabled: true
483
+
484
+ # Requires fixes in Chopin and Rater
485
+ # Style/AutoResourceCleanup:
486
+ # Enabled: true
487
+
488
+ # Requires discussion
489
+ # Style/BarePercentLiterals:
490
+
491
+ Style/BeginBlock:
492
+ Enabled: true
493
+
187
494
  Style/BisectedAttrAccessor:
188
495
  Enabled: true
189
496
 
497
+ Style/BlockComments:
498
+ Enabled: true
499
+
500
+ # Requires discussion - 1000+ offences in Chopin alone, unless options set
501
+ # Style/BlockDelimiters:
502
+
503
+ Style/CaseEquality:
504
+ Enabled: true
505
+
190
506
  Style/CaseLikeIf:
191
507
  Enabled: true
192
508
 
509
+ Style/CharacterLiteral:
510
+ Enabled: true
511
+
512
+ # Requires discussion
513
+ # Style/ClassAndModuleChildren:
514
+
515
+ Style/ClassCheck:
516
+ Enabled: true
517
+
518
+ Style/ClassEqualityComparison:
519
+ Enabled: true
520
+
521
+ Style/ClassMethods:
522
+ Enabled: true
523
+
524
+ # Requires discussion - multiple fails on Chopin/Rater/CoCo when left at default
525
+ # Style/ClassMethodsDefinitions:
526
+ # Enabled: true
527
+
528
+ Style/ClassVars:
529
+ Enabled: true
530
+
193
531
  Style/CollectionCompact:
194
532
  Enabled: true
195
533
 
534
+ # Requires discussion - multiple fails on Chopin/Rater/CoCo when left at default
535
+ # Style/CollectionMethods:
536
+
196
537
  Style/ColonMethodCall:
197
538
  Enabled: true
198
539
  Severity: warning
199
540
 
541
+ Style/ColonMethodDefinition:
542
+ Enabled: true
543
+
200
544
  Style/CombinableLoops:
201
545
  Enabled: true
202
546
 
547
+ Style/CommandLiteral:
548
+ Enabled: true
549
+
550
+ Style/CommentAnnotation:
551
+ Enabled: true
552
+
553
+ Style/CommentedKeyword:
554
+ Enabled: true
555
+
556
+ # TODO: Single fail on Rater
557
+ # Style/ComparableClamp:
558
+ # Enabled: true
559
+
203
560
  Style/ConcatArrayLiterals:
204
561
  Enabled: true
205
562
 
206
563
  Style/ConditionalAssignment:
207
564
  Enabled: true
208
565
 
566
+ # Requires discussion - 1000+ offences in Chopin alone, unless options set
567
+ # Style/ConstantVisibility:
568
+
569
+ # For discussion
570
+ # Style/Copyright:
571
+
572
+ Style/DataInheritance:
573
+ Enabled: true
574
+
575
+ # Requires discussion - multiple fails on Chopin/Rater/CoCo if true
576
+ # Style/DateTime:
577
+ # Enabled: false
578
+
579
+ Style/DefWithParentheses:
580
+ Enabled: true
581
+
582
+ Style/Dir:
583
+ Enabled: true
584
+
585
+ Style/DirEmpty:
586
+ Enabled: true
587
+
588
+ # For discussion - - multiple fails on Chopin/Rater/CoCo
589
+ # Style/DisableCopsWithinSourceCodeDirective:
590
+
209
591
  Style/DocumentDynamicEvalDefinition:
210
592
  Enabled: false
211
593
 
212
594
  Style/Documentation:
213
595
  Enabled: false
214
596
 
597
+ # Requires discussion - suggest false as 7000+ offences in Chopin alone
598
+ # Style/DocumentationMethod:
599
+ # Enabled: false
600
+
601
+ Style/DoubleCopDisableDirective:
602
+ Enabled: true
603
+
604
+ Style/DoubleNegation:
605
+ Enabled: true
606
+
607
+ # Suggest true but 100+ fails on Rater, none on Chopin or CoCo
608
+ # Style/EachForSimpleLoop:
609
+ # Enabled: true
610
+
611
+ Style/EachWithObject:
612
+ Enabled: true
613
+
614
+ Style/EmptyBlockParameter:
615
+ Enabled: true
616
+
617
+ Style/EmptyCaseCondition:
618
+ Enabled: true
619
+
620
+ Style/EmptyElse:
621
+ Enabled: true
622
+
215
623
  Style/EmptyHeredoc: # new in 1.32
216
624
  Enabled: true
217
625
 
626
+ Style/EmptyLambdaParameter:
627
+ Enabled: true
628
+
629
+ Style/EmptyLiteral:
630
+ Enabled: true
631
+
632
+ Style/EmptyMethod:
633
+ Enabled: true
634
+
635
+ Style/Encoding:
636
+ Enabled: true
637
+
638
+ Style/EndBlock:
639
+ Enabled: true
640
+
218
641
  Style/EndlessMethod:
219
642
  Enabled: true
220
643
 
221
644
  Style/EnvHome:
222
645
  Enabled: true
223
646
 
647
+ Style/EvalWithLocation:
648
+ Enabled: true
649
+
650
+ Style/EvenOdd:
651
+ Enabled: true
652
+
653
+ # Added in version 1.51, unable to check v Chopin, CoCo, Rater yet
654
+ # Style/ExactRegexpMatch:
655
+ # Enabled: true
656
+
657
+ Style/ExpandPathArguments:
658
+ Enabled: true
659
+
224
660
  Style/ExplicitBlockArgument:
225
661
  Enabled: true
226
662
 
@@ -230,12 +666,18 @@ Style/ExponentialNotation:
230
666
  Style/FetchEnvVar:
231
667
  Enabled: true
232
668
 
669
+ Style/FileEmpty:
670
+ Enabled: true
671
+
233
672
  Style/FileRead: # new in 1.24
234
673
  Enabled: true
235
674
 
236
675
  Style/FileWrite:
237
676
  Enabled: true
238
677
 
678
+ Style/FloatDivision:
679
+ Enabled: true
680
+
239
681
  Style/For:
240
682
  Enabled: true
241
683
 
@@ -251,6 +693,9 @@ Style/FrozenStringLiteralComment:
251
693
  Style/GlobalStdStream:
252
694
  Enabled: true
253
695
 
696
+ Style/GlobalVars:
697
+ Enabled: true
698
+
254
699
  Style/GuardClause:
255
700
  Enabled: false
256
701
 
@@ -269,30 +714,72 @@ Style/HashExcept:
269
714
  Style/HashLikeCase:
270
715
  Enabled: false
271
716
 
717
+ # For discussion - 11000+ fails on Chopin if true by default
718
+ # Style/HashSyntax:
719
+ # Enabled: false
720
+
272
721
  Style/HashTransformKeys:
273
722
  Enabled: true
274
723
 
275
724
  Style/HashTransformValues:
276
725
  Enabled: true
277
726
 
727
+ Style/IdenticalConditionalBranches:
728
+ Enabled: true
729
+
278
730
  Style/IfInsideElse:
279
731
  Enabled: true
280
732
 
281
733
  Style/IfUnlessModifier:
282
734
  Enabled: false
283
735
 
736
+ Style/IfUnlessModifierOfIfUnless:
737
+ Enabled: true
738
+
284
739
  Style/IfWithBooleanLiteralBranches:
285
740
  Enabled: true
286
741
 
742
+ Style/IfWithSemicolon:
743
+ Enabled: true
744
+
745
+ # For dicussion - 100s of fails on Chopin, CoCo, Rater
746
+ # Style/ImplicitRuntimeError:
747
+ # Enabled: false
748
+
749
+ Style/InfiniteLoop:
750
+ Enabled: true
751
+
752
+ # For discussion - suggest false as 1000s of fails
753
+ # Style/InlineComment:
754
+ # Enabled: false
755
+
756
+ Style/InverseMethods:
757
+ Enabled: true
758
+
759
+ # Manageable number of fails on Chopin, CoCo, Rater, suggest true
760
+ # Style/InvertibleUnlessCondition:
761
+ # Enabled: true
762
+
287
763
  Style/InPatternThen: # new in 1.16
288
764
  Enabled: true
289
765
 
766
+ # For discussion - multiple fails but most could be solved by excluding spec files
767
+ # Style/IpAddresses:
768
+ # Enabled: true
769
+ # Exclude: [*spec.rb]
770
+
290
771
  Style/KeywordParametersOrder:
291
772
  Enabled: true
292
773
 
774
+ Style/Lambda:
775
+ Enabled: true
776
+
293
777
  Style/LambdaCall:
294
778
  Enabled: true
295
779
 
780
+ Style/LineEndConcatenation:
781
+ Enabled: true
782
+
296
783
  Style/MagicCommentFormat: # new in 1.35
297
784
  Enabled: true
298
785
 
@@ -302,21 +789,90 @@ Style/MapCompactWithConditionalBlock: # new in 1.30
302
789
  Style/MapToHash:
303
790
  Enabled: true
304
791
 
792
+ # TODO: small number of fixes in Chopin
793
+ # Style/MapToSet:
794
+ # Enabled: true
795
+
796
+ # For discussion - 1000s of fails, suggest false
797
+ # Style/MethodCallWithArgsParentheses:
798
+ # Enabled: false
799
+
800
+ Style/MethodCallWithoutArgsParentheses:
801
+ Enabled: false
802
+
803
+ # For discussion - 100s of fails, suggest false
804
+ # Style/MethodCalledOnDoEndBlock:
805
+ # Enabled: false
806
+
305
807
  Style/MethodDefParentheses:
306
808
  Enabled: true
307
809
 
810
+ Style/MinMax:
811
+ Enabled: true
812
+
813
+ # For discussion - multiple fails, suggest true
814
+ # Style/MinMaxComparison:
815
+ # Enabled: true
816
+
817
+ # For discussion - 100s of fails with default true
818
+ # Style/MissingElse:
819
+ # Enabled: true
820
+
821
+ Style/MissingRespondToMissing:
822
+ Enabled: true
823
+
824
+ Style/MixinGrouping:
825
+ Enabled: true
826
+
827
+ Style/MixinUsage:
828
+ Enabled: true
829
+
830
+ Style/ModuleFunction:
831
+ Enabled: true
832
+
833
+ Style/MultilineBlockChain:
834
+ Enabled: true
835
+
836
+ Style/MultilineIfModifier:
837
+ Enabled: true
838
+
839
+ Style/MultilineIfThen:
840
+ Enabled: true
841
+
308
842
  Style/MultilineInPatternThen: # new in 1.16
309
843
  Enabled: true
310
844
 
845
+ Style/MultilineMemoization:
846
+ Enabled: true
847
+
848
+ # For discussion - suggest true, but 100s of fails in Chopin and handful in CoCo
849
+ # Style/MultilineMethodSignature:
850
+ # Enabled: true
851
+
311
852
  Style/MultilineTernaryOperator:
312
853
  Enabled: true
313
854
 
855
+ Style/MultilineWhenThen:
856
+ Enabled: true
857
+
858
+ Style/MultipleComparison:
859
+ Enabled: true
860
+
314
861
  Style/MutableConstant:
315
862
  Enabled: false
316
863
 
864
+ Style/NegatedIf:
865
+ Enabled: true
866
+
317
867
  Style/NegatedIfElseCondition:
318
868
  Enabled: true
319
869
 
870
+ Style/NegatedUnless:
871
+ Enabled: true
872
+
873
+ Style/NegatedWhile:
874
+ Enabled: true
875
+
320
876
  Style/NestedFileDirname: # new in 1.26
321
877
  Enabled: true
322
878
 
@@ -329,39 +885,91 @@ Style/NestedParenthesizedCalls:
329
885
  Style/NestedTernaryOperator:
330
886
  Enabled: true
331
887
 
888
+ Style/Next:
889
+ Enabled: true
890
+
891
+ Style/NilComparison:
892
+ Enabled: true
893
+
332
894
  Style/NilLambda:
333
895
  Enabled: true
334
896
 
897
+ Style/NonNilCheck:
898
+ Enabled: true
899
+
900
+ Style/Not:
901
+ Enabled: true
902
+
335
903
  Style/NumberedParameters: # new in 1.22
336
904
  Enabled: true
337
905
 
338
906
  Style/NumberedParametersLimit: # new in 1.22
339
907
  Enabled: true
340
908
 
909
+ Style/NumericLiteralPrefix:
910
+ Enabled: true
911
+
912
+ Style/NumericLiterals:
913
+ Enabled: true
914
+
341
915
  Style/NumericPredicate:
342
916
  Enabled: false
343
917
 
344
918
  Style/ObjectThen: # new in 1.28
345
919
  Enabled: true
346
920
 
921
+ Style/OneLineConditional:
922
+ Enabled: true
923
+
347
924
  Style/OpenStructUse:
348
925
  Enabled: true
349
926
 
350
927
  Style/OperatorMethodCall:
351
928
  Enabled: true
352
929
 
930
+ # For discussion - suggest true, but dozens of fails on Chopin and handful on Coco, Rater
931
+ # Style/OptionHash:
932
+ # Enabled: true
933
+
353
934
  Style/OptionalArguments:
354
935
  Enabled: true
355
936
 
356
937
  Style/OptionalBooleanParameter:
357
938
  Enabled: true
358
939
 
940
+ Style/OrAssignment:
941
+ Enabled: true
942
+
943
+ Style/ParallelAssignment:
944
+ Enabled: true
945
+
359
946
  Style/ParenthesesAroundCondition:
360
947
  Enabled: true
361
948
 
949
+ Style/PercentLiteralDelimiters:
950
+ Enabled: true
951
+
952
+ Style/PercentQLiterals:
953
+ Enabled: true
954
+
955
+ Style/PerlBackrefs:
956
+ Enabled: true
957
+
958
+ Style/PreferredHashMethods:
959
+ Enabled: true
960
+
961
+ Style/Proc:
962
+ Enabled: true
963
+
362
964
  Style/QuotedSymbols:
363
965
  Enabled: true
364
966
 
967
+ Style/RaiseArgs:
968
+ Enabled: true
969
+
970
+ Style/RandomWithOffset:
971
+ Enabled: true
972
+
365
973
  Style/RedundantArgument:
366
974
  Enabled: false
367
975
 
@@ -371,6 +979,15 @@ Style/RedundantAssignment:
371
979
  Style/RedundantBegin:
372
980
  Enabled: true
373
981
 
982
+ Style/RedundantCapitalW:
983
+ Enabled: true
984
+
985
+ Style/RedundantCondition:
986
+ Enabled: true
987
+
988
+ Style/RedundantConditional:
989
+ Enabled: true
990
+
374
991
  Style/RedundantConstantBase:
375
992
  Enabled: false
376
993
 
@@ -389,15 +1006,27 @@ Style/RedundantFetchBlock:
389
1006
  Style/RedundantFileExtensionInRequire:
390
1007
  Enabled: true
391
1008
 
1009
+ Style/RedundantFreeze:
1010
+ Enabled: true
1011
+
1012
+ Style/RedundantHeredocDelimiterQuotes:
1013
+ Enabled: true
1014
+
392
1015
  Style/RedundantInitialize:
393
1016
  Enabled: true
394
1017
 
395
1018
  Style/RedundantInterpolation:
396
1019
  Enabled: false
397
1020
 
1021
+ Style/RedundantLineContinuation:
1022
+ Enabled: true
1023
+
398
1024
  Style/RedundantParentheses:
399
1025
  Enabled: true
400
1026
 
1027
+ Style/RedundantPercentQ:
1028
+ Enabled: true
1029
+
401
1030
  Style/RedundantRegexpCharacterClass:
402
1031
  Enabled: true
403
1032
 
@@ -408,27 +1037,74 @@ Style/RedundantReturn:
408
1037
  Enabled: true
409
1038
  Severity: warning
410
1039
 
1040
+ Style/RedundantSelf:
1041
+ Enabled: true
1042
+
411
1043
  Style/RedundantSelfAssignment:
412
1044
  Enabled: true
413
1045
 
414
1046
  Style/RedundantSelfAssignmentBranch:
415
1047
  Enabled: true
416
1048
 
1049
+ Style/RedundantSort:
1050
+ Enabled: true
1051
+
1052
+ Style/RedundantSortBy:
1053
+ Enabled: true
1054
+
417
1055
  Style/RedundantStringEscape:
418
1056
  Enabled: true
419
1057
 
1058
+ # For discussion - CoCo, Rater OK, manageable amount of autocorrectable in Chopin if set true
1059
+ # Style/RegexpLiteral:
1060
+ # Enabled: true
1061
+
1062
+ # For discussion - dozens of fails, suggest false as autocorrect also unsafe
1063
+ # Style/RequireOrder:
1064
+ # Enabled: false
1065
+
1066
+ Style/RescueModifier:
1067
+ Enabled: true
1068
+
1069
+ Style/RescueStandardError:
1070
+ Enabled: true
1071
+
1072
+ # For discussion - suggest false as fails in all three if set true
1073
+ # Style/ReturnNil:
1074
+ # Enabled: false
1075
+
420
1076
  Style/SafeNavigation:
421
1077
  Enabled: false
422
1078
 
1079
+ Style/Sample:
1080
+ Enabled: true
1081
+
423
1082
  Style/SelectByRegexp:
424
1083
  Enabled: true
425
1084
 
426
1085
  Style/SelfAssignment:
427
1086
  Enabled: true
428
1087
 
1088
+ Style/Semicolon:
1089
+ Enabled: true
1090
+
1091
+ # For discussion - 100s of fails on Chopin, some on CoCo
1092
+ # Style/Send:
1093
+ # Enabled: true
1094
+
1095
+ Style/SignalException:
1096
+ Enabled: true
1097
+
429
1098
  Style/SingleArgumentDig:
430
1099
  Enabled: true
431
1100
 
1101
+ # TODO: Small number of autocorrectables on Chopin and Rater
1102
+ # Style/SingleLineBlockParams:
1103
+ # Enabled: true
1104
+
1105
+ Style/SingleLineMethods:
1106
+ Enabled: true
1107
+
432
1108
  Style/SlicingWithRange:
433
1109
  Enabled: false
434
1110
 
@@ -439,26 +1115,126 @@ Style/SpecialGlobalVars:
439
1115
  Enabled: true
440
1116
  Severity: warning
441
1117
 
1118
+ Style/StabbyLambdaParentheses:
1119
+ Enabled: true
1120
+
1121
+ # For discussion - 100s of fails across Rater, Chopin, CoCo, so suggest false
1122
+ # Style/StaticClass:
1123
+ # Enabled: false
1124
+
1125
+ # TODO: Small number of autocorrects in Chopin
1126
+ Style/StderrPuts:
1127
+ Enabled: true
1128
+
442
1129
  Style/StringChars:
443
1130
  Enabled: true
444
1131
 
445
1132
  Style/StringConcatenation:
446
1133
  Enabled: true
447
1134
 
1135
+ # For discussion - 10000s of fails in Chopin and Rater so suggest false
1136
+ # Style/StringHashKeys:
1137
+ # Enabled: false
1138
+
448
1139
  Style/StringLiterals:
449
1140
  Enabled: false
450
1141
 
1142
+ Style/StringLiteralsInInterpolation:
1143
+ Enabled: true
1144
+
1145
+ Style/StringMethods:
1146
+ Enabled: true
1147
+
1148
+ Style/Strip:
1149
+ Enabled: true
1150
+
1151
+ Style/StructInheritance:
1152
+ Enabled: true
1153
+
451
1154
  Style/SwapValues:
452
1155
  Enabled: true
453
1156
 
454
1157
  Style/SymbolArray:
455
1158
  EnforcedStyle: brackets
456
1159
 
1160
+ Style/SymbolLiteral:
1161
+ Enabled: true
1162
+
1163
+ Style/SymbolProc:
1164
+ Enabled: true
1165
+
1166
+ Style/TernaryParentheses:
1167
+ Enabled: true
1168
+
1169
+ # For discussion - suggest should be true or at least warn but large number of fails on repos
1170
+ # Style/TopLevelMethodDefinition:
1171
+ # Enabled: true
1172
+
1173
+ Style/TrailingBodyOnClass:
1174
+ Enabled: true
1175
+
1176
+ Style/TrailingBodyOnMethodDefinition:
1177
+ Enabled: true
1178
+
1179
+ Style/TrailingBodyOnModule:
1180
+ Enabled: true
1181
+
1182
+ # For discussion - 100s of fails on Chopin, none on others
1183
+ # Style/TrailingCommaInArguments:
1184
+ # Enabled: true
1185
+
1186
+ # For discussion - 72 fails on Chopin, none on others
1187
+ # Style/TrailingCommaInArrayLiteral:
1188
+ # Enabled: true
1189
+
1190
+ Style/TrailingCommaInBlockArgs:
1191
+ Enabled: true
1192
+
1193
+ # For discussion - 100s of fails on Chopin and Coco, none on Rater
1194
+ # Style/TrailingCommaInHashLiteral:
1195
+ # Enabled: true
1196
+
1197
+ Style/TrailingMethodEndStatement:
1198
+ Enabled: true
1199
+
1200
+ Style/TrailingUnderscoreVariable:
1201
+ Enabled: true
1202
+
1203
+ Style/TrivialAccessors:
1204
+ Enabled: true
1205
+
457
1206
  Style/UnlessElse:
458
1207
  Enabled: true
459
1208
 
1209
+ # Single fail on each of Chopin and Rater
1210
+ # Style/UnlessLogicalOperators:
1211
+ # Enabled: true
1212
+
1213
+ Style/UnpackFirst:
1214
+ Enabled: true
1215
+
1216
+ Style/VariableInterpolation:
1217
+ Enabled: true
1218
+
1219
+ Style/WhenThen:
1220
+ Enabled: true
1221
+
1222
+ Style/WhileUntilDo:
1223
+ Enabled: true
1224
+
1225
+ Style/WhileUntilModifier:
1226
+ Enabled: true
1227
+
460
1228
  Style/WordArray:
461
1229
  EnforcedStyle: brackets
462
1230
 
1231
+ # For discussion - causes no fails but maybe some may like it?
1232
+ # Style/YodaCondition:
1233
+ # Enabled: true
1234
+
1235
+ # For discussion with above - causes multiple fails
1236
+ # Style/YodaExpression:
1237
+ # Enabled: true
1238
+
463
1239
  Style/ZeroLengthPredicate:
464
1240
  Enabled: true
data/.simplycop_rspec.yml CHANGED
@@ -117,6 +117,9 @@ Capybara/SpecificMatcher:
117
117
  FactoryBot/ConsistentParenthesesStyle:
118
118
  Enabled: true
119
119
 
120
+ FactoryBot/CreateList:
121
+ Enabled: false
122
+
120
123
  FactoryBot/FactoryNameStyle:
121
124
  Enabled: true
122
125
 
@@ -7,5 +7,5 @@
7
7
  #
8
8
 
9
9
  module Simplycop
10
- VERSION = '1.12.18'
10
+ VERSION = '1.12.21'
11
11
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: simplycop
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.12.18
4
+ version: 1.12.21
5
5
  platform: ruby
6
6
  authors:
7
7
  - Simply Business
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2023-05-12 00:00:00.000000000 Z
11
+ date: 2023-05-23 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rubocop