simplycop 1.12.17 → 1.12.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9c0c68345a301a886cac2b640d560b1bf52ea18203bf5ed62b640f833ad26373
-  data.tar.gz: 2f655616a9ec154726cb71151679bde8a9fac5ba777a94a5842d1632f9a49407
+  metadata.gz: 9d7b1dfbe91cd595f0491440519bdaf520cb4dfe9048ab500e5ed37f9a83eda2
+  data.tar.gz: ed90b05962cb6537ff3370271a67659771232fcce4a35f535231b4bcd67f134e
 SHA512:
-  metadata.gz: e7c939a503ccc79483144b55f91b8de8d65e02ed259fdc2e4525ac39f3e10ca9fac15e51cdf4539fd944d1b5799b853b03010f609b0a4146231051549d6904f6
-  data.tar.gz: c5e10aeb3d5a408a55211794a4bacc1a62b2cbf898edfc3973358526253aa0df00f48163edeb741c338d1535f8cfd384bd3449c707ab8651e4acb4fd93f29633
+  metadata.gz: 20cf2ce53fc721de021c0be9f0fb63e119504b44599dfe3ce6f0d39afc6d5ba9cb79fcd9b91331dc3cd8852b51f4e998d7ae90206674cacd002cdba62963026b
+  data.tar.gz: 4468e20beee4c4c03a12fc80599f92498a192f84d2842e8e8ce8aa056f1b59091eccdd2ae43905be36c4447c0d31e18af4b81cb74de99927dc6824431ad6864d

data/.github/workflows/version_forget_me_not.yml

@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: simplybusiness/version-forget-me-not@v2.3.0
+      - uses: simplybusiness/version-forget-me-not@v2
         env:
           ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           VERSION_FILE_PATH: "lib/simplycop/version.rb"

data/.simplycop.yml

@@ -21,6 +21,10 @@ AllCops:
   ExtraDetails: true
 # Adapted from: https://github.com/simplybusiness/how-we-roll/blob/master/development/RUBYSTYLEGUIDE.markdown
 
+
+Gemspec/DeprecatedAttributeAssignment: # new in 1.30
+  Enabled: true
+
 Layout/EmptyLineAfterMultilineCondition:
   Enabled: true
 
@@ -61,6 +65,9 @@ Lint/AmbiguousOperatorPrecedence:
 Lint/AmbiguousRange:
   Enabled: true
 
+Lint/ConstantOverwrittenInRescue: # new in 1.31
+  Enabled: true
+
 Lint/DeprecatedConstants:
   Enabled: true
 
@@ -82,9 +89,15 @@ Lint/EmptyBlock:
 Lint/EmptyClass:
   Enabled: true
 
+Lint/EmptyInPattern: # new in 1.16
+  Enabled: true
+
 Lint/HeredocMethodCallPosition:
   Enabled: true
 
+Lint/IncompatibleIoSelectWithFiberScheduler: # new in 1.21
+  Enabled: true
+
 Lint/LambdaWithoutLiteralBlock:
   Enabled: true
 
@@ -141,10 +154,11 @@ Metrics/ParameterLists:
   CountKeywordArgs: false
   Enabled: true
 
-Naming/InclusiveLanguage:
+Naming/BlockForwarding: # new in 1.24
   Enabled: true
 
-###### COPS REVIEWED ABOVE THIS LINE ######
+Naming/InclusiveLanguage:
+  Enabled: true
 
 Security/CompoundHash:
   Enabled: true
@@ -161,6 +175,9 @@ Style/AccessorGrouping:
 Style/Alias:
   Enabled: false
 
+Style/AndOr:
+  Enabled: true
+
 Style/ArgumentsForwarding:
   Enabled: true
 
@@ -170,40 +187,192 @@ Style/ArrayCoercion:
 Style/ArrayIntersect:
   Enabled: true
 
+Style/ArrayJoin:
+  Enabled: true
+
+Style/AsciiComments:
+  Enabled: true
+  AllowedChars: [£, ©]
+
+Style/Attr:
+  Enabled: true
+
+# Requires fixes in Chopin and Rater
+# Style/AutoResourceCleanup:
+#   Enabled: true 
+
+# Requires discussion
+# Style/BarePercentLiterals:
+
+Style/BeginBlock:
+  Enabled: true
+
 Style/BisectedAttrAccessor:
   Enabled: true
 
+Style/BlockComments:
+  Enabled: true
+
+# Requires discussion - 1000+ offences in Chopin alone, unless options set
+# Style/BlockDelimiters:
+
+Style/CaseEquality:
+  Enabled: true
+
 Style/CaseLikeIf:
   Enabled: true
 
+Style/CharacterLiteral:
+  Enabled: true
+
+# Requires discussion
+# Style/ClassAndModuleChildren:
+
+Style/ClassCheck:
+  Enabled: true
+
+Style/ClassEqualityComparison:
+  Enabled: true
+
+Style/ClassMethods:
+  Enabled: true
+
+# Requires discussion - multiple fails on Chopin/Rater/CoCo when left at default
+# Style/ClassMethodsDefinitions:
+#   Enabled: true
+
+Style/ClassVars:
+  Enabled: true
+
 Style/CollectionCompact:
   Enabled: true
 
+# Requires discussion - multiple fails on Chopin/Rater/CoCo when left at default
+# Style/CollectionMethods:
+
 Style/ColonMethodCall:
   Enabled: true
   Severity: warning
 
+Style/ColonMethodDefinition:
+  Enabled: true
+
 Style/CombinableLoops:
   Enabled: true
 
+Style/CommandLiteral:
+  Enabled: true
+
+Style/CommentAnnotation:
+  Enabled: true
+
+Style/CommentedKeyword:
+  Enabled: true
+
+# TODO: Single fail on Rater
+# Style/ComparableClamp:
+#   Enabled: true
+
 Style/ConcatArrayLiterals:
   Enabled: true
 
 Style/ConditionalAssignment:
   Enabled: true
 
+# Requires discussion - 1000+ offences in Chopin alone, unless options set
+# Style/ConstantVisibility:
+
+# For discussion
+# Style/Copyright:
+
+Style/DataInheritance:
+  Enabled: true
+
+# Requires discussion - multiple fails on Chopin/Rater/CoCo if true
+# Style/DateTime:
+#   Enabled: false
+
+Style/DefWithParentheses:
+  Enabled: true
+
+Style/Dir:
+  Enabled: true
+
+Style/DirEmpty:
+  Enabled: true
+
+# For discussion - - multiple fails on Chopin/Rater/CoCo
+# Style/DisableCopsWithinSourceCodeDirective:
+
 Style/DocumentDynamicEvalDefinition:
   Enabled: false
 
 Style/Documentation:
   Enabled: false
 
+# Requires discussion - suggest false as 7000+ offences in Chopin alone
+# Style/DocumentationMethod:
+# Enabled: false
+
+Style/DoubleCopDisableDirective:
+  Enabled: true
+
+Style/DoubleNegation:
+  Enabled: true
+
+# Suggest true but 100+ fails on Rater, none on Chopin or CoCo
+# Style/EachForSimpleLoop:
+#   Enabled: true
+
+Style/EachWithObject:
+  Enabled: true
+
+Style/EmptyBlockParameter:
+  Enabled: true
+
+Style/EmptyCaseCondition:
+  Enabled: true
+
+Style/EmptyElse:
+  Enabled: true
+
+Style/EmptyHeredoc: # new in 1.32
+  Enabled: true
+
+Style/EmptyLambdaParameter:
+  Enabled: true
+
+Style/EmptyLiteral:
+  Enabled: true
+
+Style/EmptyMethod:
+  Enabled: true
+
+Style/Encoding:
+  Enabled: true
+
+Style/EndBlock:
+  Enabled: true
+
 Style/EndlessMethod:
   Enabled: true
 
 Style/EnvHome:
   Enabled: true
 
+Style/EvalWithLocation:
+  Enabled: true
+
+Style/EvenOdd:
+  Enabled: true
+
+# Added in version 1.51, unable to check v Chopin, CoCo, Rater yet
+# Style/ExactRegexpMatch:
+#   Enabled: true
+
+Style/ExpandPathArguments:
+  Enabled: true
+
 Style/ExplicitBlockArgument:
   Enabled: true
 
@@ -213,9 +382,18 @@ Style/ExponentialNotation:
 Style/FetchEnvVar:
   Enabled: true
 
+Style/FileEmpty:
+  Enabled: true
+
+Style/FileRead: # new in 1.24
+  Enabled: true
+
 Style/FileWrite:
   Enabled: true
 
+Style/FloatDivision:
+  Enabled: true
+
 Style/For:
   Enabled: true
 
@@ -231,6 +409,9 @@ Style/FrozenStringLiteralComment:
 Style/GlobalStdStream:
   Enabled: true
 
+Style/GlobalVars:
+  Enabled: true
+
 Style/GuardClause:
   Enabled: false
 
@@ -249,42 +430,168 @@ Style/HashExcept:
 Style/HashLikeCase:
   Enabled: false
 
+# For discussion - 11000+ fails on Chopin if true by default
+# Style/HashSyntax:
+#   Enabled: false
+
 Style/HashTransformKeys:
   Enabled: true
 
 Style/HashTransformValues:
   Enabled: true
 
+Style/IdenticalConditionalBranches:
+  Enabled: true
+
 Style/IfInsideElse:
   Enabled: true
 
 Style/IfUnlessModifier:
   Enabled: false
 
+Style/IfUnlessModifierOfIfUnless:
+  Enabled: true
+
 Style/IfWithBooleanLiteralBranches:
   Enabled: true
 
+Style/IfWithSemicolon:
+  Enabled: true
+
+# For dicussion - 100s of fails on Chopin, CoCo, Rater
+# Style/ImplicitRuntimeError:
+#   Enabled: false
+
+Style/InfiniteLoop:
+  Enabled: true
+
+# For discussion - suggest false as 1000s of fails
+# Style/InlineComment:
+#   Enabled: false
+
+Style/InverseMethods:
+  Enabled: true
+
+# Manageable number of fails on Chopin, CoCo, Rater, suggest true
+# Style/InvertibleUnlessCondition:
+#   Enabled: true
+
+Style/InPatternThen: # new in 1.16
+  Enabled: true
+
+# For discussion - multiple fails but most could be solved by excluding spec files
+# Style/IpAddresses:
+#   Enabled: true
+#   Exclude: [*spec.rb]
+
 Style/KeywordParametersOrder:
   Enabled: true
 
+Style/Lambda:
+  Enabled: true
+
 Style/LambdaCall:
   Enabled: true
 
+Style/LineEndConcatenation:
+  Enabled: true
+
+Style/MagicCommentFormat: # new in 1.35
+  Enabled: true
+
+Style/MapCompactWithConditionalBlock: # new in 1.30
+  Enabled: true
+
 Style/MapToHash:
   Enabled: true
 
+# TODO: small number of fixes in Chopin
+# Style/MapToSet:
+#   Enabled: true
+
+# For discussion - 1000s of fails, suggest false
+# Style/MethodCallWithArgsParentheses:
+#   Enabled: false
+
+Style/MethodCallWithoutArgsParentheses:
+  Enabled: false
+
+# For discussion - 100s of fails, suggest false
+# Style/MethodCalledOnDoEndBlock:
+#   Enabled: false
+
 Style/MethodDefParentheses:
   Enabled: true
 
+Style/MinMax:
+  Enabled: true
+
+# For discussion - multiple fails, suggest true
+# Style/MinMaxComparison:
+#   Enabled: true
+
+# For discussion - 100s of fails with default true
+# Style/MissingElse:
+#   Enabled: true
+
+Style/MissingRespondToMissing:
+  Enabled: true
+
+Style/MixinGrouping:
+  Enabled: true
+
+Style/MixinUsage:
+  Enabled: true
+
+Style/ModuleFunction:
+  Enabled: true
+
+Style/MultilineBlockChain:
+  Enabled: true
+
+Style/MultilineIfModifier:
+  Enabled: true
+
+Style/MultilineIfThen:
+  Enabled: true
+
+Style/MultilineInPatternThen: # new in 1.16
+  Enabled: true
+
+Style/MultilineMemoization:
+  Enabled: true
+
+# For discussion - suggest true, but 100s of fails in Chopin and handful in CoCo
+# Style/MultilineMethodSignature:
+#   Enabled: true
+
 Style/MultilineTernaryOperator:
   Enabled: true
 
+Style/MultilineWhenThen:
+  Enabled: true
+
+Style/MultipleComparison:
+  Enabled: true
+
 Style/MutableConstant:
   Enabled: false
 
+Style/NegatedIf:
+  Enabled: true
+
 Style/NegatedIfElseCondition:
   Enabled: true
 
+Style/NegatedUnless:
+  Enabled: true
+
+Style/NegatedWhile:
+  Enabled: true
+
+Style/NestedFileDirname: # new in 1.26
+  Enabled: true
+
 Style/NestedModifier:
   Enabled: true
 
@@ -294,30 +601,91 @@ Style/NestedParenthesizedCalls:
 Style/NestedTernaryOperator:
   Enabled: true
 
+Style/Next:
+  Enabled: true
+
+Style/NilComparison:
+  Enabled: true
+
 Style/NilLambda:
   Enabled: true
 
+Style/NonNilCheck:
+  Enabled: true
+
+Style/Not:
+  Enabled: true
+
+Style/NumberedParameters: # new in 1.22
+  Enabled: true
+
+Style/NumberedParametersLimit: # new in 1.22
+  Enabled: true
+
+Style/NumericLiteralPrefix:
+  Enabled: true
+
+Style/NumericLiterals:
+  Enabled: true
+
 Style/NumericPredicate:
   Enabled: false
 
+Style/ObjectThen: # new in 1.28
+  Enabled: true
+
+Style/OneLineConditional:
+  Enabled: true
+
 Style/OpenStructUse:
   Enabled: true
 
 Style/OperatorMethodCall:
   Enabled: true
 
+# For discussion - suggest true, but dozens of fails on Chopin and handful on Coco, Rater
+# Style/OptionHash:
+#   Enabled: true
+
 Style/OptionalArguments:
   Enabled: true
 
 Style/OptionalBooleanParameter:
   Enabled: true
 
+Style/OrAssignment:
+  Enabled: true
+
+Style/ParallelAssignment:
+  Enabled: true
+
 Style/ParenthesesAroundCondition:
   Enabled: true
 
+Style/PercentLiteralDelimiters:
+  Enabled: true
+
+Style/PercentQLiterals:
+  Enabled: true
+
+Style/PerlBackrefs:
+  Enabled: true
+
+Style/PreferredHashMethods:
+  Enabled: true
+
+Style/Proc:
+  Enabled: true
+
 Style/QuotedSymbols:
   Enabled: true
 
+Style/RaiseArgs:
+  Enabled: true
+
+Style/RandomWithOffset:
+  Enabled: true
+
 Style/RedundantArgument:
   Enabled: false
 
@@ -327,6 +695,15 @@ Style/RedundantAssignment:
 Style/RedundantBegin:
   Enabled: true
 
+Style/RedundantCapitalW:
+  Enabled: true
+
+Style/RedundantCondition:
+  Enabled: true
+
+Style/RedundantConditional:
+  Enabled: true
+
 Style/RedundantConstantBase:
   Enabled: false
 
@@ -345,15 +722,27 @@ Style/RedundantFetchBlock:
 Style/RedundantFileExtensionInRequire:
   Enabled: true
 
+Style/RedundantFreeze:
+  Enabled: true
+
+Style/RedundantHeredocDelimiterQuotes:
+  Enabled: true
+
 Style/RedundantInitialize:
   Enabled: true
 
 Style/RedundantInterpolation:
   Enabled: false
 
+Style/RedundantLineContinuation:
+  Enabled: true
+
 Style/RedundantParentheses:
   Enabled: true
 
+Style/RedundantPercentQ:
+  Enabled: true
+
 Style/RedundantRegexpCharacterClass:
   Enabled: true
 
@@ -364,27 +753,74 @@ Style/RedundantReturn:
   Enabled: true
   Severity: warning
 
+Style/RedundantSelf:
+  Enabled: true
+
 Style/RedundantSelfAssignment:
   Enabled: true
 
 Style/RedundantSelfAssignmentBranch:
   Enabled: true
 
+Style/RedundantSort:
+  Enabled: true
+
+Style/RedundantSortBy:
+  Enabled: true
+
 Style/RedundantStringEscape:
   Enabled: true
 
+# For discussion - CoCo, Rater OK, manageable amount of autocorrectable in Chopin if set true
+# Style/RegexpLiteral:
+#   Enabled: true
+
+# For discussion - dozens of fails, suggest false as autocorrect also unsafe
+# Style/RequireOrder:
+#   Enabled: false
+
+Style/RescueModifier:
+  Enabled: true
+
+Style/RescueStandardError:
+  Enabled: true
+
+# For discussion - suggest false as fails in all three if set true
+# Style/ReturnNil:
+#   Enabled: false
+
 Style/SafeNavigation:
   Enabled: false
 
+Style/Sample:
+  Enabled: true
+
 Style/SelectByRegexp:
   Enabled: true
 
 Style/SelfAssignment:
   Enabled: true
 
+Style/Semicolon:
+  Enabled: true
+
+# For discussion - 100s of fails on Chopin, some on CoCo
+# Style/Send:
+#   Enabled: true
+
+Style/SignalException:
+  Enabled: true
+
 Style/SingleArgumentDig:
   Enabled: true
 
+# TODO: Small number of autocorrectables on Chopin and Rater
+# Style/SingleLineBlockParams:
+#   Enabled: true
+
+Style/SingleLineMethods:
+  Enabled: true
+
 Style/SlicingWithRange:
   Enabled: false
 
@@ -395,71 +831,126 @@ Style/SpecialGlobalVars:
   Enabled: true
   Severity: warning
 
+Style/StabbyLambdaParentheses:
+  Enabled: true
+
+# For discussion - 100s of fails across Rater, Chopin, CoCo, so suggest false
+# Style/StaticClass:
+#   Enabled: false
+
+# TODO: Small number of autocorrects in Chopin
+Style/StderrPuts:
+  Enabled: true
+
 Style/StringChars:
   Enabled: true
 
 Style/StringConcatenation:
   Enabled: true
 
+# For discussion - 10000s of fails in Chopin and Rater so suggest false
+# Style/StringHashKeys:
+#   Enabled: false
+
 Style/StringLiterals:
   Enabled: false
 
+Style/StringLiteralsInInterpolation:
+  Enabled: true
+
+Style/StringMethods:
+  Enabled: true
+
+Style/Strip:
+  Enabled: true
+
+Style/StructInheritance:
+  Enabled: true
+
 Style/SwapValues:
   Enabled: true
 
 Style/SymbolArray:
   EnforcedStyle: brackets
 
-Style/UnlessElse:
+Style/SymbolLiteral:
   Enabled: true
 
-Style/WordArray:
-  EnforcedStyle: brackets
-
-Style/ZeroLengthPredicate:
+Style/SymbolProc:
   Enabled: true
 
-Gemspec/DeprecatedAttributeAssignment: # new in 1.30
+Style/TernaryParentheses:
   Enabled: true
 
-Lint/ConstantOverwrittenInRescue: # new in 1.31
+# For discussion - suggest should be true or at least warn but large number of fails on repos
+# Style/TopLevelMethodDefinition:
+#   Enabled: true
+
+Style/TrailingBodyOnClass:
   Enabled: true
 
-Lint/EmptyInPattern: # new in 1.16
+Style/TrailingBodyOnMethodDefinition:
   Enabled: true
 
-Lint/IncompatibleIoSelectWithFiberScheduler: # new in 1.21
+Style/TrailingBodyOnModule:
   Enabled: true
 
-Naming/BlockForwarding: # new in 1.24
+# For discussion - 100s of fails on Chopin, none on others
+# Style/TrailingCommaInArguments:
+#   Enabled: true
+
+# For discussion - 72 fails on Chopin, none on others
+# Style/TrailingCommaInArrayLiteral:
+#   Enabled: true
+
+Style/TrailingCommaInBlockArgs:
   Enabled: true
 
-Style/EmptyHeredoc: # new in 1.32
+# For discussion - 100s of fails on Chopin and Coco, none on Rater
+# Style/TrailingCommaInHashLiteral:
+#   Enabled: true
+
+Style/TrailingMethodEndStatement:
   Enabled: true
 
-Style/FileRead: # new in 1.24
+Style/TrailingUnderscoreVariable:
   Enabled: true
 
-Style/InPatternThen: # new in 1.16
+Style/TrivialAccessors:
   Enabled: true
 
-Style/MagicCommentFormat: # new in 1.35
+Style/UnlessElse:
   Enabled: true
 
-Style/MapCompactWithConditionalBlock: # new in 1.30
+# Single fail on each of Chopin and Rater
+# Style/UnlessLogicalOperators:
+#   Enabled: true
+
+Style/UnpackFirst:
   Enabled: true
 
-Style/MultilineInPatternThen: # new in 1.16
+Style/VariableInterpolation:
   Enabled: true
 
-Style/NestedFileDirname: # new in 1.26
+Style/WhenThen:
   Enabled: true
 
-Style/NumberedParameters: # new in 1.22
+Style/WhileUntilDo:
   Enabled: true
 
-Style/NumberedParametersLimit: # new in 1.22
+Style/WhileUntilModifier:
   Enabled: true
 
-Style/ObjectThen: # new in 1.28
+Style/WordArray:
+  EnforcedStyle: brackets
+
+# For discussion - causes no fails but maybe some may like it?
+# Style/YodaCondition:
+#   Enabled: true
+
+# For discussion with above - causes multiple fails
+# Style/YodaExpression:
+#   Enabled: true
+
+Style/ZeroLengthPredicate:
   Enabled: true

data/.simplycop_rspec.yml

@@ -16,23 +16,6 @@ RSpec/ChangeByZero:
 RSpec/ClassCheck:
   Enabled: true
 
-RSpec/Capybara:
-  Enabled: true
-  Include:
-    - spec/integration/*.rb
-
-RSpec/Capybara/NegationMatcher:
-  Enabled: true
-
-RSpec/Capybara/SpecificActions:
-  Enabled: true
-
-RSpec/Capybara/SpecificFinders:
-  Enabled: true
-
-RSpec/Capybara/SpecificMatcher:
-  Enabled: true
-
 RSpec/DescribeClass:
   Enabled: false
 
@@ -54,16 +37,6 @@ RSpec/ExcessiveDocstringSpacing:
 RSpec/ExpectOutput:
   Enabled: false
 
-RSpec/FactoryBot/ConsistentParenthesesStyle:
-  Enabled: true
-
-RSpec/FactoryBot/FactoryNameStyle:
-  Enabled: true
-
-# Prefer explicit factorybot call
-RSpec/FactoryBot/SyntaxMethods:
-  Enabled: false
-
 RSpec/FilePath:
   Enabled: false
 
@@ -119,3 +92,34 @@ RSpec/Rails/InferredSpecType:
 
 RSpec/VerifiedDoubleReference:
   Enabled: true
+
+# Capybara
+
+RSpec/Capybara:
+  Enabled: true
+  Include:
+    - spec/integration/*.rb
+
+Capybara/NegationMatcher:
+  Enabled: true
+
+Capybara/SpecificActions:
+  Enabled: true
+
+Capybara/SpecificFinders:
+  Enabled: true
+
+Capybara/SpecificMatcher:
+  Enabled: true
+
+# FactoryBot
+
+FactoryBot/ConsistentParenthesesStyle:
+  Enabled: true
+
+FactoryBot/FactoryNameStyle:
+  Enabled: true
+
+# Prefer explicit factorybot call
+FactoryBot/SyntaxMethods:
+  Enabled: false

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.12.17'
+  VERSION = '1.12.20'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.12.17
+  version: 1.12.20
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-05-05 00:00:00.000000000 Z
+date: 2023-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop