simplycop 1.12.13 → 1.12.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7bcd75c07282d6105cb8cb92d7bce94f45c15d39f267bf728cd865eb83db72b6
-  data.tar.gz: 989276d266d83938c63b3106b868ae155ddf62dd24d53ed6eefb46c0d48b7318
+  metadata.gz: 4fa519dff2b48643ea25372e649d86b6d8719f5555f1fde7d3deeda55f584259
+  data.tar.gz: b68b2ffc4da368fcb2814c70f04ba93c36d6b86058a0e3800db89e081746dc5f
 SHA512:
-  metadata.gz: c61acf3adf95dd5264021d1ad8cb02f5eb413e2a61fd1bd038d27cec7fe1b2f649636a7915b055dea263feac315b8e0ddca8bf3bc990bd675d7366a48bfd4ac8
-  data.tar.gz: a7d64eea7f27910436e7efb3687d4bbac219ab6fd5dd519402d3ad11f90834f568720a194084b4c1b3c28ad019b43da5a84c9304afe9ba2468f4378efdccc0d7
+  metadata.gz: e0c2a9ba168b62e87277f878df05b6fb3af767b7ce84fafadbebef117d3c72d251fbb29f7d017e04dae0765283030050c2bc01554aef3cab6fa9fb36a742771a
+  data.tar.gz: 0aee5bf7dae61d592e31d9fda09340cd3166485814c7e042b8601b7f6a76dbb291afc4bb2618171805113ca6c5aed9e63ac47c12373e42b7c49e2491898eb98a

data/.github/workflows/ci.yml

@@ -19,7 +19,7 @@ jobs:
 
     strategy:
       matrix:
-        ruby-version: ['3.0', '3.1', '3.2', jruby]
+        ruby-version: ['2.7', '3.0', '3.1', '3.2', jruby]
 
     steps:
     - uses: actions/checkout@v3

data/.ruby-version

@@ -1 +1 @@
-3.0.4
+2.7.8

data/.simplycop_rspec.yml

@@ -1,9 +1,38 @@
 require:
   - rubocop-rspec
 
+RSpec/BeEq:
+  Enabled: true
+
 RSpec/BeforeAfterAll:
   Enabled: false
 
+RSpec/BeNil:
+  Enabled: true
+
+RSpec/ChangeByZero:
+  Enabled: true
+
+RSpec/ClassCheck:
+  Enabled: true
+
+RSpec/Capybara:
+  Enabled: true
+  Include:
+    - spec/integration/*.rb
+
+RSpec/Capybara/NegationMatcher:
+  Enabled: true
+
+RSpec/Capybara/SpecificActions:
+  Enabled: true
+
+RSpec/Capybara/SpecificFinders:
+  Enabled: true
+
+RSpec/Capybara/SpecificMatcher:
+  Enabled: true
+
 RSpec/DescribeClass:
   Enabled: false
 
@@ -13,15 +42,34 @@ RSpec/DescribeMethod:
 RSpec/DescribedClass:
   Enabled: false
 
+RSpec/DuplicatedMetadata:
+  Enabled: true
+
 RSpec/ExampleLength:
   Enabled: false
 
+RSpec/ExcessiveDocstringSpacing:
+  Enabled: true
+
 RSpec/ExpectOutput:
   Enabled: false
 
+RSpec/FactoryBot/ConsistentParenthesesStyle:
+  Enabled: true
+
+RSpec/FactoryBot/FactoryNameStyle:
+  Enabled: true
+
+# Prefer explicit factorybot call
+RSpec/FactoryBot/SyntaxMethods:
+  Enabled: false
+
 RSpec/FilePath:
   Enabled: false
 
+RSpec/IdenticalEqualityAssertion:
+  Enabled: true
+
 RSpec/InstanceVariable:
   Enabled: false
 
@@ -38,6 +86,9 @@ RSpec/NestedGroups:
   Enabled: true
   Max: 4
 
+RSpec/NoExpectationExample:
+  Enabled: true
+
 RSpec/NotToNot:
   Enabled: false
 
@@ -47,8 +98,24 @@ RSpec/ScatteredSetup:
 RSpec/StubbedMock:
   Enabled: false
 
+RSpec/SortMetadata:
+  Enabled: true
+
+# Bug https://github.com/rubocop/rubocop-rspec/issues/1521
+RSpec/PendingWithoutReason:
+  Enabled: false
+
 RSpec/SubjectDeclaration: # new in 2.5
   Enabled: true
 
 RSpec/Rails/AvoidSetupHook: # new in 2.4
   Enabled: true
+
+RSpec/Rails/HaveHttpStatus:
+  Enabled: true
+
+RSpec/Rails/InferredSpecType:
+  Enabled: true
+
+RSpec/VerifiedDoubleReference:
+  Enabled: true

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.12.13'
+  VERSION = '1.12.15'
 end

data/simplycop.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.version       = Simplycop::VERSION
   spec.authors       = ['Simply Business']
   spec.email         = ['tech@simplybusiness.co.uk']
-  spec.required_ruby_version = '>= 3.0.4'
+  spec.required_ruby_version = '>= 2.7'
   spec.license       = 'MIT'
   spec.summary       = 'Provides a single point of reference for common rubocop rules.'
   spec.description   = 'Require this gem in your application to use Simply Business common rubocop rules.'
@@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'rubocop', '~> 1.42'
-  spec.add_dependency 'rubocop-rails', '~> 2.15'
-  spec.add_dependency 'rubocop-rspec', '~> 2.12'
+  spec.add_dependency 'rubocop-rails', '~> 2.17'
+  spec.add_dependency 'rubocop-rspec', '~> 2.16'
   spec.add_development_dependency 'bundler', '>= 2.2.15'
   spec.add_development_dependency 'rake', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.10'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.12.13
+  version: 1.12.15
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-04-20 00:00:00.000000000 Z
+date: 2023-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -30,28 +30,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.15'
+        version: '2.17'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.15'
+        version: '2.17'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.12'
+        version: '2.16'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.12'
+        version: '2.16'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -154,7 +154,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.0.4
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="