simplycop 1.12.12 → 1.12.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ce3bdee49231080927211b78cec2fd6d076ed5f9a436a02e3bad30885feea9b2
-  data.tar.gz: a6005981ec02d757b99d232263a14f16f2741e44b1149fb2e02db0a2a4f204b8
+  metadata.gz: 81791402713e30674d8eb5dad084403245144a057fb20a853a6bae54de1ad0de
+  data.tar.gz: de02d689bf85e8688e6eff3679eccfb32cb63f3dd96186c56e4a8b223c091b18
 SHA512:
-  metadata.gz: 22ffc7345e993d9c35c2e45d09718942a369609cb51f54ae9614cbecf6a15d4baf1d151fdfbf77e255c5d8370d994838af40575b9f89fbdb4cd829a9c38fdc23
-  data.tar.gz: 3b0d60d41152c6468297251706f93f3130429d8213686630679ca95b5a66844de499e813cf9e6abb84d303616e3a7b0b36cc61c1c552de34b3137df88c5ec1cd
+  metadata.gz: 5ca68ef630434db92fd3061830f2838e279e707a5174572034a439dfaf13ff93c354aacedcff663ed1c7c552a88456a115c5b86ad2ac6b8ba1896b9849f6f6f7
+  data.tar.gz: fcf1c9c832e18ae52609837ce4657b72ba32eb85168ef526dcaf3c497b1b9dff54153aa0b851fd1f9b3620e94e1d83b6c65ae335945f65b172f6d0b8498b87ed

data/.simplycop.yml

@@ -36,6 +36,15 @@ Layout/FirstHashElementLineBreak:
 Layout/HeredocArgumentClosingParenthesis:
   Enabled: true
 
+Layout/LineContinuationLeadingSpace:
+  Enabled: true
+
+Layout/LineContinuationSpacing:
+  Enabled: true
+
+Layout/LineEndStringConcatenationIndentation:
+  Enabled: true
+
 Layout/SpaceBeforeBrackets:
   Enabled: true
 
@@ -46,12 +55,24 @@ Lint/AmbiguousBlockAssociation:
   Exclude:
     - spec/**/*
 
+Lint/AmbiguousOperatorPrecedence:
+  Enabled: true
+
+Lint/AmbiguousRange:
+  Enabled: true
+
 Lint/DeprecatedConstants:
   Enabled: true
 
 Lint/DuplicateBranch:
   Enabled: true
 
+Lint/DuplicateMagicComment:
+  Enabled: true
+
+Lint/DuplicateMethods:
+  Enabled: true
+
 Lint/DuplicateRegexpCharacterClassElement:
   Enabled: true
 
@@ -70,6 +91,9 @@ Lint/LambdaWithoutLiteralBlock:
 Lint/NoReturnInBeginEndBlocks:
   Enabled: true
 
+Lint/NonAtomicFileOperation:
+  Enabled: true
+
 Lint/NumberedParameterAssignment:
   Enabled: true
 
@@ -79,6 +103,15 @@ Lint/OrAssignmentToConstant:
 Lint/RedundantDirGlobSort:
   Enabled: true
 
+Lint/RefinementImportMethods:
+  Enabled: true
+
+Lint/RequireRangeParentheses:
+  Enabled: true
+
+Lint/RequireRelativeSelfPath:
+  Enabled: true
+
 Lint/SymbolConversion:
   Enabled: true
 
@@ -94,6 +127,9 @@ Lint/UnexpectedBlockArity:
 Lint/UnmodifiedReduceAccumulator:
   Enabled: true
 
+Lint/UselessRuby2Keywords:
+  Enabled: true
+
 Metrics/BlockLength:
   Exclude:
     - spec/**/*.rb
@@ -101,8 +137,24 @@ Metrics/BlockLength:
 Metrics/ClassLength:
   Max: 512
 
+Metrics/ParameterLists:
+  CountKeywordArgs: false
+  Enabled: true
+
+Naming/InclusiveLanguage:
+  Enabled: true
+
 ###### COPS REVIEWED ABOVE THIS LINE ######
 
+Security/CompoundHash:
+  Enabled: true
+
+Security/IoMethods:
+  Enabled: true
+
+Style/AccessModifierDeclarations:
+  Enabled: false
+
 Style/AccessorGrouping:
   Enabled: true
 
@@ -115,6 +167,9 @@ Style/ArgumentsForwarding:
 Style/ArrayCoercion:
   Enabled: true
 
+Style/ArrayIntersect:
+  Enabled: true
+
 Style/BisectedAttrAccessor:
   Enabled: true
 
@@ -131,6 +186,9 @@ Style/ColonMethodCall:
 Style/CombinableLoops:
   Enabled: true
 
+Style/ConcatArrayLiterals:
+  Enabled: true
+
 Style/ConditionalAssignment:
   Enabled: true
 
@@ -143,12 +201,21 @@ Style/Documentation:
 Style/EndlessMethod:
   Enabled: true
 
+Style/EnvHome:
+  Enabled: true
+
 Style/ExplicitBlockArgument:
   Enabled: true
 
 Style/ExponentialNotation:
   Enabled: false
 
+Style/FetchEnvVar:
+  Enabled: true
+
+Style/FileWrite:
+  Enabled: true
+
 Style/For:
   Enabled: true
 
@@ -191,6 +258,9 @@ Style/HashTransformValues:
 Style/IfInsideElse:
   Enabled: true
 
+Style/IfUnlessModifier:
+  Enabled: false
+
 Style/IfWithBooleanLiteralBranches:
   Enabled: true
 
@@ -200,6 +270,9 @@ Style/KeywordParametersOrder:
 Style/LambdaCall:
   Enabled: true
 
+Style/MapToHash:
+  Enabled: true
+
 Style/MethodDefParentheses:
   Enabled: true
 
@@ -227,6 +300,12 @@ Style/NilLambda:
 Style/NumericPredicate:
   Enabled: false
 
+Style/OpenStructUse:
+  Enabled: true
+
+Style/OperatorMethodCall:
+  Enabled: true
+
 Style/OptionalArguments:
   Enabled: true
 
@@ -236,6 +315,9 @@ Style/OptionalBooleanParameter:
 Style/ParenthesesAroundCondition:
   Enabled: true
 
+Style/QuotedSymbols:
+  Enabled: true
+
 Style/RedundantArgument:
   Enabled: false
 
@@ -248,6 +330,12 @@ Style/RedundantBegin:
 Style/RedundantConstantBase:
   Enabled: false
 
+Style/RedundantDoubleSplatHashBraces:
+  Enabled: true
+
+Style/RedundantEach:
+  Enabled: true
+
 Style/RedundantException:
   Enabled: true
 
@@ -257,6 +345,9 @@ Style/RedundantFetchBlock:
 Style/RedundantFileExtensionInRequire:
   Enabled: true
 
+Style/RedundantInitialize:
+  Enabled: true
+
 Style/RedundantInterpolation:
   Enabled: false
 
@@ -276,6 +367,18 @@ Style/RedundantReturn:
 Style/RedundantSelfAssignment:
   Enabled: true
 
+Style/RedundantSelfAssignmentBranch:
+  Enabled: true
+
+Style/RedundantStringEscape:
+  Enabled: true
+
+Style/SafeNavigation:
+  Enabled: false
+
+Style/SelectByRegexp:
+  Enabled: true
+
 Style/SelfAssignment:
   Enabled: true
 

data/.simplycop_rspec.yml

@@ -1,9 +1,38 @@
 require:
   - rubocop-rspec
 
+RSpec/BeEq:
+  Enabled: true
+
 RSpec/BeforeAfterAll:
   Enabled: false
 
+RSpec/BeNil:
+  Enabled: true
+
+RSpec/ChangeByZero:
+  Enabled: true
+
+RSpec/ClassCheck:
+  Enabled: true
+
+RSpec/Capybara:
+  Enabled: true
+  Include:
+    - spec/integration/*.rb
+
+RSpec/Capybara/NegationMatcher:
+  Enabled: true
+
+RSpec/Capybara/SpecificActions:
+  Enabled: true
+
+RSpec/Capybara/SpecificFinders:
+  Enabled: true
+
+RSpec/Capybara/SpecificMatcher:
+  Enabled: true
+
 RSpec/DescribeClass:
   Enabled: false
 
@@ -13,15 +42,34 @@ RSpec/DescribeMethod:
 RSpec/DescribedClass:
   Enabled: false
 
+RSpec/DuplicatedMetadata:
+  Enabled: true
+
 RSpec/ExampleLength:
   Enabled: false
 
+RSpec/ExcessiveDocstringSpacing:
+  Enabled: true
+
 RSpec/ExpectOutput:
   Enabled: false
 
+RSpec/FactoryBot/ConsistentParenthesesStyle:
+  Enabled: true
+
+RSpec/FactoryBot/FactoryNameStyle:
+  Enabled: true
+
+# Prefer explicit factorybot call
+RSpec/FactoryBot/SyntaxMethods:
+  Enabled: false
+
 RSpec/FilePath:
   Enabled: false
 
+RSpec/IdenticalEqualityAssertion:
+  Enabled: true
+
 RSpec/InstanceVariable:
   Enabled: false
 
@@ -38,6 +86,9 @@ RSpec/NestedGroups:
   Enabled: true
   Max: 4
 
+RSpec/NoExpectationExample:
+  Enabled: true
+
 RSpec/NotToNot:
   Enabled: false
 
@@ -47,8 +98,24 @@ RSpec/ScatteredSetup:
 RSpec/StubbedMock:
   Enabled: false
 
+RSpec/SortMetadata:
+  Enabled: true
+
+# Bug https://github.com/rubocop/rubocop-rspec/issues/1521
+RSpec/PendingWithoutReason:
+  Enabled: false
+
 RSpec/SubjectDeclaration: # new in 2.5
   Enabled: true
 
 RSpec/Rails/AvoidSetupHook: # new in 2.4
   Enabled: true
+
+RSpec/Rails/HaveHttpStatus:
+  Enabled: true
+
+RSpec/Rails/InferredSpecType:
+  Enabled: true
+
+RSpec/VerifiedDoubleReference:
+  Enabled: true

data/lib/simplycop/custom_cops/dont_print_all_env.rb

@@ -14,10 +14,10 @@ module CustomCops
     #   # good
     #   puts ENV['SOME_KEY']
     #   puts ENVIRON['SOME_KEY']
-    MSG = 'Printing all Environment Variables is extremely risky'\
-    ' If this code has been run, then it is likely that secrets have been'\
-    ' exposed in plaintext. Please alert `#infosec` about this so it can be'\
-    ' investigated immediately.'\
+    MSG = 'Printing all Environment Variables is extremely risky ' \
+          'If this code has been run, then it is likely that secrets have been ' \
+          'exposed in plaintext. Please alert `#infosec` about this so it can be ' \
+          'investigated immediately.' \
 
     def_node_matcher :convert_env_to_hash_or_array?, <<~PATTERN
       (send (const nil? {:ENVIRON :ENV}) {:to_h :to_a :to_hash})

data/lib/simplycop/security/reject_all_requests_local.rb

@@ -9,10 +9,10 @@ module Security
       source = node.source
       file_name = node.loc.operator.to_s
 
-      add_offense(node, location: :selector) if found_match(source) && black_listed?(file_name)
+      add_offense(node, location: :selector) if found_match(source) && block_listed?(file_name)
     end
 
-    def black_listed?(string)
+    def block_listed?(string)
       RAILS_ENV.each_with_object([]) do |env, results|
         results << string.include?(env)
       end.any?(true)

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.12.12'
+  VERSION = '1.12.14'
 end

data/simplycop.gemspec

@@ -17,9 +17,9 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 1.35'
-  spec.add_dependency 'rubocop-rails', '~> 2.15'
-  spec.add_dependency 'rubocop-rspec', '~> 2.12'
+  spec.add_dependency 'rubocop', '~> 1.42'
+  spec.add_dependency 'rubocop-rails', '~> 2.17'
+  spec.add_dependency 'rubocop-rspec', '~> 2.16'
   spec.add_development_dependency 'bundler', '>= 2.2.15'
   spec.add_development_dependency 'rake', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.10'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.12.12
+  version: 1.12.14
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-03-28 00:00:00.000000000 Z
+date: 2023-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,42 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.35'
+        version: '1.42'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.35'
+        version: '1.42'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.15'
+        version: '2.17'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.15'
+        version: '2.17'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.12'
+        version: '2.16'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.12'
+        version: '2.16'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement