simplycop 1.12.11 → 1.12.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b4f0037507c93720c3290f662ab00d85da6853f1e04a56f536181c52f1de11aa
-  data.tar.gz: 9e7e65ffa5ca97f135691c74f913c919ffe5ea885185b8b5d233778479fde7f0
+  metadata.gz: 7bcd75c07282d6105cb8cb92d7bce94f45c15d39f267bf728cd865eb83db72b6
+  data.tar.gz: 989276d266d83938c63b3106b868ae155ddf62dd24d53ed6eefb46c0d48b7318
 SHA512:
-  metadata.gz: f2f404919d9cd8bd20099854b4164676e48d20c6142b091b71ac864db6bee65d405f6f39a08977292cbb9703ddafc26e8fa28e10667a5b4869aab9cdb54f9695
-  data.tar.gz: 35333a7faa3778d97c3f5c21450107c6206905dee3b35512ff35cf505db11827ceed1f4aa5d0bb26773dfdd9c53f7ee52d95c45bbfa37db6150fed153a142b06
+  metadata.gz: c61acf3adf95dd5264021d1ad8cb02f5eb413e2a61fd1bd038d27cec7fe1b2f649636a7915b055dea263feac315b8e0ddca8bf3bc990bd675d7366a48bfd4ac8
+  data.tar.gz: a7d64eea7f27910436e7efb3687d4bbac219ab6fd5dd519402d3ad11f90834f568720a194084b4c1b3c28ad019b43da5a84c9304afe9ba2468f4378efdccc0d7

data/.github/workflows/ci.yml

@@ -12,7 +12,7 @@ permissions:
 
 jobs:
   build:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
     defaults:
       run:
         working-directory: ./

data/.github/workflows/publish_gem.yml

@@ -9,7 +9,7 @@ permissions:
 jobs:
   build:
     name: Build and Publish
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
       - name: Set up Ruby 3.0

data/.github/workflows/version_forget_me_not.yml

@@ -11,7 +11,7 @@ permissions:
   statuses: write
 jobs:
   build:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
 
     steps:
       - uses: simplybusiness/version-forget-me-not@v2.3.0

data/.simplycop.yml

@@ -36,6 +36,15 @@ Layout/FirstHashElementLineBreak:
 Layout/HeredocArgumentClosingParenthesis:
   Enabled: true
 
+Layout/LineContinuationLeadingSpace:
+  Enabled: true
+
+Layout/LineContinuationSpacing:
+  Enabled: true
+
+Layout/LineEndStringConcatenationIndentation:
+  Enabled: true
+
 Layout/SpaceBeforeBrackets:
   Enabled: true
 
@@ -46,12 +55,24 @@ Lint/AmbiguousBlockAssociation:
   Exclude:
     - spec/**/*
 
+Lint/AmbiguousOperatorPrecedence:
+  Enabled: true
+
+Lint/AmbiguousRange:
+  Enabled: true
+
 Lint/DeprecatedConstants:
   Enabled: true
 
 Lint/DuplicateBranch:
   Enabled: true
 
+Lint/DuplicateMagicComment:
+  Enabled: true
+
+Lint/DuplicateMethods:
+  Enabled: true
+
 Lint/DuplicateRegexpCharacterClassElement:
   Enabled: true
 
@@ -70,6 +91,9 @@ Lint/LambdaWithoutLiteralBlock:
 Lint/NoReturnInBeginEndBlocks:
   Enabled: true
 
+Lint/NonAtomicFileOperation:
+  Enabled: true
+
 Lint/NumberedParameterAssignment:
   Enabled: true
 
@@ -79,6 +103,15 @@ Lint/OrAssignmentToConstant:
 Lint/RedundantDirGlobSort:
   Enabled: true
 
+Lint/RefinementImportMethods:
+  Enabled: true
+
+Lint/RequireRangeParentheses:
+  Enabled: true
+
+Lint/RequireRelativeSelfPath:
+  Enabled: true
+
 Lint/SymbolConversion:
   Enabled: true
 
@@ -94,6 +127,9 @@ Lint/UnexpectedBlockArity:
 Lint/UnmodifiedReduceAccumulator:
   Enabled: true
 
+Lint/UselessRuby2Keywords:
+  Enabled: true
+
 Metrics/BlockLength:
   Exclude:
     - spec/**/*.rb
@@ -101,8 +137,24 @@ Metrics/BlockLength:
 Metrics/ClassLength:
   Max: 512
 
+Metrics/ParameterLists:
+  CountKeywordArgs: false
+  Enabled: true
+
+Naming/InclusiveLanguage:
+  Enabled: true
+
 ###### COPS REVIEWED ABOVE THIS LINE ######
 
+Security/CompoundHash:
+  Enabled: true
+
+Security/IoMethods:
+  Enabled: true
+
+Style/AccessModifierDeclarations:
+  Enabled: false
+
 Style/AccessorGrouping:
   Enabled: true
 
@@ -115,6 +167,9 @@ Style/ArgumentsForwarding:
 Style/ArrayCoercion:
   Enabled: true
 
+Style/ArrayIntersect:
+  Enabled: true
+
 Style/BisectedAttrAccessor:
   Enabled: true
 
@@ -131,6 +186,9 @@ Style/ColonMethodCall:
 Style/CombinableLoops:
   Enabled: true
 
+Style/ConcatArrayLiterals:
+  Enabled: true
+
 Style/ConditionalAssignment:
   Enabled: true
 
@@ -143,12 +201,21 @@ Style/Documentation:
 Style/EndlessMethod:
   Enabled: true
 
+Style/EnvHome:
+  Enabled: true
+
 Style/ExplicitBlockArgument:
   Enabled: true
 
 Style/ExponentialNotation:
   Enabled: false
 
+Style/FetchEnvVar:
+  Enabled: true
+
+Style/FileWrite:
+  Enabled: true
+
 Style/For:
   Enabled: true
 
@@ -191,6 +258,9 @@ Style/HashTransformValues:
 Style/IfInsideElse:
   Enabled: true
 
+Style/IfUnlessModifier:
+  Enabled: false
+
 Style/IfWithBooleanLiteralBranches:
   Enabled: true
 
@@ -200,6 +270,9 @@ Style/KeywordParametersOrder:
 Style/LambdaCall:
   Enabled: true
 
+Style/MapToHash:
+  Enabled: true
+
 Style/MethodDefParentheses:
   Enabled: true
 
@@ -227,6 +300,12 @@ Style/NilLambda:
 Style/NumericPredicate:
   Enabled: false
 
+Style/OpenStructUse:
+  Enabled: true
+
+Style/OperatorMethodCall:
+  Enabled: true
+
 Style/OptionalArguments:
   Enabled: true
 
@@ -236,6 +315,9 @@ Style/OptionalBooleanParameter:
 Style/ParenthesesAroundCondition:
   Enabled: true
 
+Style/QuotedSymbols:
+  Enabled: true
+
 Style/RedundantArgument:
   Enabled: false
 
@@ -248,6 +330,12 @@ Style/RedundantBegin:
 Style/RedundantConstantBase:
   Enabled: false
 
+Style/RedundantDoubleSplatHashBraces:
+  Enabled: true
+
+Style/RedundantEach:
+  Enabled: true
+
 Style/RedundantException:
   Enabled: true
 
@@ -257,6 +345,9 @@ Style/RedundantFetchBlock:
 Style/RedundantFileExtensionInRequire:
   Enabled: true
 
+Style/RedundantInitialize:
+  Enabled: true
+
 Style/RedundantInterpolation:
   Enabled: false
 
@@ -276,6 +367,18 @@ Style/RedundantReturn:
 Style/RedundantSelfAssignment:
   Enabled: true
 
+Style/RedundantSelfAssignmentBranch:
+  Enabled: true
+
+Style/RedundantStringEscape:
+  Enabled: true
+
+Style/SafeNavigation:
+  Enabled: false
+
+Style/SelectByRegexp:
+  Enabled: true
+
 Style/SelfAssignment:
   Enabled: true
 

data/lib/simplycop/custom_cops/dont_print_all_env.rb

@@ -14,10 +14,10 @@ module CustomCops
     #   # good
     #   puts ENV['SOME_KEY']
     #   puts ENVIRON['SOME_KEY']
-    MSG = 'Printing all Environment Variables is extremely risky'\
-    ' If this code has been run, then it is likely that secrets have been'\
-    ' exposed in plaintext. Please alert `#infosec` about this so it can be'\
-    ' investigated immediately.'\
+    MSG = 'Printing all Environment Variables is extremely risky ' \
+          'If this code has been run, then it is likely that secrets have been ' \
+          'exposed in plaintext. Please alert `#infosec` about this so it can be ' \
+          'investigated immediately.' \
 
     def_node_matcher :convert_env_to_hash_or_array?, <<~PATTERN
       (send (const nil? {:ENVIRON :ENV}) {:to_h :to_a :to_hash})

data/lib/simplycop/security/reject_all_requests_local.rb

@@ -9,10 +9,10 @@ module Security
       source = node.source
       file_name = node.loc.operator.to_s
 
-      add_offense(node, location: :selector) if found_match(source) && black_listed?(file_name)
+      add_offense(node, location: :selector) if found_match(source) && block_listed?(file_name)
     end
 
-    def black_listed?(string)
+    def block_listed?(string)
       RAILS_ENV.each_with_object([]) do |env, results|
         results << string.include?(env)
       end.any?(true)

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.12.11'
+  VERSION = '1.12.13'
 end

data/simplycop.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 1.35'
+  spec.add_dependency 'rubocop', '~> 1.42'
   spec.add_dependency 'rubocop-rails', '~> 2.15'
   spec.add_dependency 'rubocop-rspec', '~> 2.12'
   spec.add_development_dependency 'bundler', '>= 2.2.15'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.12.11
+  version: 1.12.13
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-02-14 00:00:00.000000000 Z
+date: 2023-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.35'
+        version: '1.42'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.35'
+        version: '1.42'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement