simplycop 1.11.0 → 1.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 931184d38bc368e3dd104e118681d39da16b01906d2e3821203e13ab92d4a42c
-  data.tar.gz: 2f544d5c8ea7ea65d1dfd0b63369dc59d955d6db55f0af79e9c4f6ff58aa1fef
+  metadata.gz: 1affbd4f4cebe9f2a6f13d2564e1e622e5b3d32fe7798c7c61bb296f7b32c69c
+  data.tar.gz: 922c233a1022af02c3e6a3b9e0194feaf1e39829443a7883ffa59fe4baedeb74
 SHA512:
-  metadata.gz: dad9f1e435b539bea066f0b8007c43b13be1262ccc82fb7984eab83029f52a63660a7cc5a9b5d196be40b1f5185dfa0209fa8f9481be767b438310f2c8e590af
-  data.tar.gz: b0d917f28147c32ce184a988b994d55bf2408e284baa8cc6302181f804244d7fa454ae0c28982a224b485800cee3c026f4b491c0fc369db08ef334ac3f14353f
+  metadata.gz: 746a3e50610f0e85acd6b44944496028b3b0bb3ab12eecffb4f9fbb9e7259824da93066461e224933f07625fd4a835732b55d734d198cebb48c5727ad456ac57
+  data.tar.gz: 0adc0489f9491733c3a3e57c0ef6cf28064699531711c2a56847660b2e0417028dee92e742c74aa8b574fe2b9776b89163e8bfdc8b9dd62a583621f918c2b271

data/.github/workflows/dobby-actions.yml

@@ -7,23 +7,8 @@ permissions:
   contents: read
 jobs:
   pr_commented:
-    runs-on: ubuntu-20.04
-    if: startsWith(github.event.comment.body, '/dobby')
-    env:
-      BUNDLE_WITHOUT: "development:test"
-    steps:
-      - name: Chekcout action
-        uses: actions/checkout@v3
-        with:
-          repository: 'simplybusiness/dobby'
-          ref: 'v3.0.0'
-      - name: Set up ruby
-        uses: ruby/setup-ruby@v1
-        with:
-          bundler-cache: true
-      - name: Bump version
-        uses: simplybusiness/dobby@v3.0.1
-        env:
-          DOBBY_APP_ID: ${{ secrets.DOBBY_APP_ID }}
-          DOBBY_PRIVATE_KEY: ${{ secrets.DOBBY_PRIVATE_KEY }}
-          VERSION_FILE_PATH: lib/simplycop/version.rb
+      uses: simplybusiness/github-action-reusable-workflows/.github/workflows/dobby.yaml@v1
+      with:
+        version_file_path: ./lib/simplycop/version.rb
+      secrets: inherit
+      

data/.simplycop.yml

@@ -313,3 +313,48 @@ Style/WordArray:
 
 Style/ZeroLengthPredicate:
   Enabled: true
+
+Gemspec/DeprecatedAttributeAssignment: # new in 1.30
+  Enabled: true
+
+Lint/ConstantOverwrittenInRescue: # new in 1.31
+  Enabled: true
+
+Lint/EmptyInPattern: # new in 1.16
+  Enabled: true
+
+Lint/IncompatibleIoSelectWithFiberScheduler: # new in 1.21
+  Enabled: true
+
+Naming/BlockForwarding: # new in 1.24
+  Enabled: true
+
+Style/EmptyHeredoc: # new in 1.32
+  Enabled: true
+
+Style/FileRead: # new in 1.24
+  Enabled: true
+
+Style/InPatternThen: # new in 1.16
+  Enabled: true
+
+Style/MagicCommentFormat: # new in 1.35
+  Enabled: true
+
+Style/MapCompactWithConditionalBlock: # new in 1.30
+  Enabled: true
+
+Style/MultilineInPatternThen: # new in 1.16
+  Enabled: true
+
+Style/NestedFileDirname: # new in 1.26
+  Enabled: true
+
+Style/NumberedParameters: # new in 1.22
+  Enabled: true
+
+Style/NumberedParametersLimit: # new in 1.22
+  Enabled: true
+
+Style/ObjectThen: # new in 1.28
+  Enabled: true

data/.simplycop_rails.yml

@@ -61,3 +61,42 @@ Rails/WhereExists:
 # Conflicts with Mongoid
 Rails/WhereNot:
   Enabled: false
+
+Rails/ActionControllerTestCase: # new in 2.14
+  Enabled: true
+
+Rails/AddColumnIndex: # new in 2.11
+  Enabled: true
+
+Rails/DotSeparatedKeys: # new in 2.15
+  Enabled: true
+
+Rails/DuplicateAssociation: # new in 2.14
+  Enabled: true
+
+Rails/DuplicateScope: # new in 2.14
+  Enabled: true
+
+Rails/EagerEvaluationLogMessage: # new in 2.11
+  Enabled: true
+
+Rails/ExpandedDateRange: # new in 2.11
+  Enabled: true
+
+Rails/I18nLazyLookup: # new in 2.14
+  Enabled: true
+
+Rails/MigrationClassName: # new in 2.14
+  Enabled: true
+
+Rails/RedundantTravelBack: # new in 2.12
+  Enabled: true
+
+Rails/ToFormattedS: # new in 2.15
+  Enabled: true
+
+Rails/TransactionExitStatement: # new in 2.14
+  Enabled: true
+
+Rails/UnusedIgnoredColumns: # new in 2.11
+  Enabled: true

data/.simplycop_rspec.yml

@@ -46,3 +46,9 @@ RSpec/ScatteredSetup:
 
 RSpec/StubbedMock:
   Enabled: false
+
+RSpec/SubjectDeclaration: # new in 2.5
+  Enabled: true
+
+RSpec/Rails/AvoidSetupHook: # new in 2.4
+  Enabled: true

data/lib/simplycop/security/check_for_vulnerable_code.rb

@@ -5,7 +5,7 @@ module Security
     def self.read_file
       gem_path = File.expand_path("#{File.dirname(__FILE__)}../../../../")
 
-      file = File.open("#{gem_path}/vuln_db.json", "r").read.strip
+      file = File.read("#{gem_path}/vuln_db.json").strip
       json = JSON.parse(file)
       json["vulnerabilities"]["rails"]
     end

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.11.0'
+  VERSION = '1.12.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.11.0
+  version: 1.12.1
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-08-15 00:00:00.000000000 Z
+date: 2022-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop