simply_paginate 0.0.4 → 0.0.5

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 39276d355bff6efc4caf226f0c12651ceb5f57cb
+  data.tar.gz: 74c736370477949887a729652a116d43ff0cf880
+SHA512:
+  metadata.gz: 828ca2c53d150cd0e29e9da3aea11e573dd89e843a3d663ccaa2bfe3e4b7a9e24bb647f5a030ba50b5e7daa6899a9d63eeae4c6f3dc7887d09eaa07fd744d164
+  data.tar.gz: 61ded93564918688aecc72ca5d1243b02464bc536303f5e053459b6dd4355cfa341bc292b247b2641844a69bb2774ef1f1e3ee9dc77940cae7ad42bb6b1c3d79

data/.gitignore

@@ -3,7 +3,6 @@
 .bundle
 .config
 .yardoc
-Gemfile.lock
 InstalledFiles
 _yardoc
 coverage

data/.travis.yml

@@ -1,11 +1,6 @@
 language: ruby
 rvm:
+  - 2.2
+  - 2.1
+  - 2.0
   - 1.9.3
-  - 1.9.2
-  - jruby-18mode
-  - jruby-19mode
-  - rbx-18mode
-  - rbx-19mode
-  - jruby-head
-  - 1.8.7
-  - ree

data/Gemfile

@@ -2,3 +2,4 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in simply_paginate.gemspec
 gemspec
+

data/Gemfile.lock

@@ -0,0 +1,35 @@
+PATH
+  remote: .
+  specs:
+    simply_paginate (0.0.5)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    diff-lcs (1.2.5)
+    rake (10.0.4)
+    rspec (3.5.0)
+      rspec-core (~> 3.5.0)
+      rspec-expectations (~> 3.5.0)
+      rspec-mocks (~> 3.5.0)
+    rspec-core (3.5.3)
+      rspec-support (~> 3.5.0)
+    rspec-expectations (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-mocks (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-support (3.5.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  bundler (~> 1.3)
+  rake
+  rspec
+  simply_paginate!
+
+BUNDLED WITH
+   1.12.5

data/Rakefile

@@ -1,10 +1,7 @@
 require 'bundler/gem_tasks'
 require 'rake/testtask'
+require 'rspec/core/rake_task'
 
-task :default => [:spec]
+RSpec::Core::RakeTask.new(:spec)
 
-Rake::TestTask.new :spec do |test|
-  test.libs = ['lib', 'spec']
-  test.verbose = true
-  test.test_files = FileList['spec/*_spec.rb']
-end
+task :default => :spec

data/lib/simply_paginate/page.rb

@@ -8,8 +8,8 @@ module SimplyPaginate
       @size = size
 
       @move_page = lambda do |number|
-        new_index = @index + number
-        Page.new(new_index, @collection, @size) unless (new_index == 0) || (new_index > (@collection.count.to_f / @size.to_f).ceil)
+        new_index = index + number
+        Page.new(new_index, collection, size) unless (new_index <= 0) || (new_index > (collection.count.to_f / size.to_f).ceil)
       end
     end
 
@@ -29,7 +29,7 @@ module SimplyPaginate
     end
 
     def ==(other)
-      (index == other.index) && (elements == other.elements) if other.respond_to?(:index) && other.respond_to?(:elements)
+      (index == other.index) && (elements == other.elements)
     end
   end
 end

data/lib/simply_paginate/paginator.rb

@@ -33,19 +33,19 @@ module SimplyPaginate
       (@collection.count.to_f / @per_page.to_f).ceil
     end
 
-    def [](pos)
-      Page.new(pos, @collection) unless pos == 0 || pos > total_pages
+    def [](index)
+      Page.new(index, @collection, @per_page) unless collection.empty? || index <= 0 || index > total_pages
     end
 
     ## Iteration
 
     def next!
-      raise NoMethodError.new("You need to start before iterating") unless @current
-      @current = @current.next
+      raise NoMethodError.new("You need to start before iterating") unless current
+      @current = current.next
     end
 
     def next?
-      @current != nil
+      current != nil
     end
 
     def start

data/lib/simply_paginate/version.rb

@@ -1,3 +1,3 @@
 module SimplyPaginate
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/simply_paginate.gemspec

@@ -19,6 +19,6 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "minitest"
+  spec.add_development_dependency "rspec"
   spec.add_development_dependency "rake"
 end

data/spec/page_spec.rb

@@ -1,39 +1,94 @@
-require 'spec_helper'
+require_relative 'spec_helper'
 
 include SimplyPaginate
 
 describe Page do
-  include Helpers
+  context "when is empty" do
+    let(:page) { Page.new(0, []) }
+    subject { page }
 
-  let(:first_page) { build_page 1 }
+    describe "#elements" do
+      specify { expect(subject.elements).to be_nil }
+    end
 
-  let(:second_page) { build_page 2 }
+    describe "#next" do
+      specify { expect(subject.next).to be_nil }
+    end
 
-  let(:last_page) { build_page 4 }
+    describe "#previous" do
+      specify { expect(subject.previous).to be_nil }
+    end
 
-  it "must represent a specific page on a collection" do
-    first_page.elements.must_equal [1, 2, 3]
-    first_page.index.must_equal SimplyPaginate::FIRST_PAGE_INDEX
-  end
+    describe "#==" do
+      subject { page == other_page }
+      let(:other_page) { double }
 
-  it "must be able to retrieve it's elements" do
-    first_page.elements.must_equal [1, 2, 3]
-  end
+      context "when they are equal" do
 
-  it "must be able to compare with other page" do
-    first_page.must_equal first_page
-    first_page.wont_equal second_page
-    first_page.wont_equal Page.new(1, page_array_collection, 5)
-    first_page.must_equal Page.new(1, [1, 2, 3], 3)
-  end
+        before(:each) do
+          allow(other_page).to receive(:index).and_return(0)
+          allow(other_page).to receive(:elements).and_return(nil)
+        end
+
+        specify { expect(subject).to eq(true) }
+      end
 
-  it "must be able to move forward" do
-    first_page.next.must_equal second_page
-    last_page.next.must_be_nil
+      context "when they are different" do
+        context "and the second has different values" do
+          before(:each) do
+            allow(other_page).to receive(:index).and_return(1)
+            allow(other_page).to receive(:elements).and_return([])
+          end
+
+          specify { expect(subject).to eq(false) }
+        end
+      end
+    end
   end
 
-  it "must be able to move backwards" do
-    first_page.previous.must_be_nil
-    second_page.previous.must_equal first_page
+  context "when has elements" do
+    let(:page) { Page.new(1, [1,2,3,4,5,6,7,8,9], 3) }
+    subject { page }
+
+    describe "#elements" do
+      specify { expect(subject.elements).to eq([1,2,3]) }
+    end
+
+    describe "#next" do
+      specify { expect(subject.next).to be_instance_of(Page) }
+      specify { expect(subject.next.index).to eq(subject.index + 1) }
+    end
+
+    describe "#previous" do
+      before(:each) { allow(page).to receive(:index).and_return(2) }
+
+      specify { expect(subject.previous).to be_instance_of(Page) }
+      specify { expect(subject.previous.index).to eq(subject.index - 1) }
+    end
+
+    describe "#==" do
+      let(:other_page) { double }
+      subject { page == other_page }
+
+      context "when both are equal" do
+        before(:each) do
+          allow(other_page).to receive(:index).and_return(1)
+          allow(other_page).to receive(:elements).and_return([1,2,3])
+        end
+
+        specify { expect(subject).to eq(true) }
+      end
+
+      context "when they are different" do
+        context "because the second has different values" do
+          before(:each) do
+            allow(other_page).to receive(:index).and_return(1)
+            allow(other_page).to receive(:elements).and_return([])
+          end
+
+          specify { expect(subject).to eq(false) }
+        end
+      end
+    end
   end
 end

data/spec/paginator_spec.rb

@@ -1,77 +1,76 @@
-require 'spec_helper'
+require_relative 'spec_helper'
 
-Paginator.per_page = 3
+include SimplyPaginate
 
 describe Paginator do
-  include Helpers
+  let(:paginator) { Paginator.new([1,2,3,4,5,6,7,8,9], 3) }
+  subject { paginator }
 
-  let(:pages) { Paginator.new page_array_collection }
+  describe "#[]" do
+    let (:index) { 1 }
+    context "there are no elements to paginate" do
+      before(:each) { allow(subject).to receive(:collection).and_return([]) }
 
-  let(:first_page) { build_page 1 }
+      specify { expect(subject[index]).to be_nil }
+    end
 
-  let(:last_page) { build_page 4 }
+    context "there is at least one element" do
+      let(:elements) { [1] }
+      before(:each) { allow(subject).to receive(:collection).and_return(elements) }
 
-  it "must be able to iterate using each" do
-    count = 0
-    results = []
+      specify { expect(subject[index]).to be_instance_of(Page) }
+    end
 
-    pages.each do |page|
-      page.wont_be_nil
-      results << page.elements
+    context "index is zero" do
+      let(:zero_index) { 0 }
+      specify { expect(subject[zero_index]).to be_nil }
+    end
 
-      count += 1
+    context "index is negative" do
+      let(:negative_index) { -1 }
+      specify { expect(subject[negative_index]).to be_nil }
     end
 
-    count.must_equal 4
-    results.must_equal [[1,2,3], [4,5,6], [7,8,9], [10]]
+    context "index greater than amount of pages" do
+      specify { expect(subject[4]).to be_nil }
+    end
   end
 
-  it "must be able to tell how many pages there are" do
-    pages.total_pages.must_equal 4
-  end
+  describe "iteration" do
+    describe "next!" do
+      context "iteration hasn't started" do
+        specify { expect { subject.next! }.to raise_error("You need to start before iterating") }
+      end
 
-  it "must be able to retrieve a certain page" do
-    pages[0].must_be_nil
-    pages[1].wont_be_nil
-    pages[1].must_equal first_page
-    pages[4].must_equal last_page
-    pages[5].must_be_nil
-  end
+      context "iteration started" do
+        before(:each) { subject.start }
 
-  it "must be able to retrieve the first page" do
-    pages.first.must_equal first_page
-  end
+        specify do
+          expect(subject.next!).to be_instance_of(Page)
+        end
+      end
 
-  it "must be able to retrieve the last page" do
-    pages.last.must_equal pages[4]
-  end
+      context "there are no more pages" do
+        before(:each) { allow(subject).to receive(:current).and_return(nil) }
 
-  describe "when iterating using 'start', 'next!' and 'next?'" do
-    it "must need to start before moving to the next " do
-      lambda { pages.next! }.must_raise NoMethodError
-    end
-
-    it "must move to the next page using 'next!'" do
-      iteration_pages = pages
-      iteration_pages.start
-      iteration_pages.next!
-      iteration_pages.current.must_equal build_page(2)
+        specify { expect { subject.next! }.to raise_error("You need to start before iterating") }
+      end
     end
+  end
 
-    it "must retrieve the current page using 'current'" do
-      iteration_pages = pages
-      iteration_pages.current.must_be_nil
-      iteration_pages.start
-      iteration_pages.current.must_equal first_page
+  describe "initialize" do
+    describe "without setting a per page" do
+      specify "it falls back to class level per_page" do
+        paginator = Paginator.new([0,1,2,3,4,5,6,7,8,9])
+        expect(paginator.first.elements.count).to eq(10)
+      end
     end
 
-    it "must retrieve if we can get a next value using 'next?'" do
-      iteration_pages = pages
-      iteration_pages.next?.must_equal false
-      iteration_pages.start
-      iteration_pages.next?.must_equal true
-      4.times { iteration_pages.next! }
-      iteration_pages.next?.must_equal false
+    describe "setting a per page" do
+      specify "it falls back to class level per_page" do
+        paginator = Paginator.new([0,1,2,3,4,5,6,7,8,9], 3)
+        expect(paginator.first.elements.count).to eq(3)
+      end
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,13 +1,2 @@
-require 'bundler'
-require 'minitest/autorun'
-Bundler.require
-
-module Helpers
-  def page_array_collection
-    [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
-  end
-
-  def build_page(number)
-    lambda { Page.new number, page_array_collection, 3 }.call
-  end
-end
+require 'rspec'
+require 'simply_paginate'

metadata

@@ -1,62 +1,55 @@
 --- !ruby/object:Gem::Specification
 name: simply_paginate
 version: !ruby/object:Gem::Version
-  version: 0.0.4
-  prerelease: 
+  version: 0.0.5
 platform: ruby
 authors:
 - Álvaro F. Lara
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-26 00:00:00.000000000 Z
+date: 2016-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: This gem is a simple paginator for Enumerable collections
@@ -66,9 +59,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
+- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -86,30 +80,28 @@ files:
 homepage: https://github.com/guiman/simply_paginate
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.5.1
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: You enumerate it we will simply paginate it
 test_files:
 - spec/page_spec.rb
 - spec/paginator_spec.rb
 - spec/spec_helper.rb
-has_rdoc: