simplify_rb 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e13939f627822e4b0114f8d60c15a31788f0a03d
-  data.tar.gz: 41a9e75f2bd598f291849286f468b9bfd42b9829
+  metadata.gz: 0f79646c8c01d7c69d1d64e96be6ef6035815879
+  data.tar.gz: 7d2c38e4bcdab4d114cd4c193539ed9f6a9a7a7c
 SHA512:
-  metadata.gz: 3e4a59ca16d463d9b236add0318e1ebad3fe5907652001bd7a85b8c7e9a542168be5d1a5dc4c266cf13fa79f8216f5e327e778723ecfc5934addae64aefd7789
-  data.tar.gz: 1ccd9699ab4066cb5903191334ea39a21d2425aa9788934bce288f7204a8aceaae1f826c1f53c7cb2122f50ca31fed3469e097353f4b5600a76674e578fdecc4
+  metadata.gz: ac827d96699828338bbc0bf5826a592fb3f1a40ab16e7233aa407f9d7ba5520fa84cf00088b18551cb0176a8117a423cf1476d23c50b296604619f79f769a2bf
+  data.tar.gz: 6ecb8581a96851cc2e539428cec861a5763f1b964abdab02e2b709deec8d463849586fa317dc807c72eb3c9feeadbba34bd5d9360a7ca37f851c3e1f8e494647

data/README.md

@@ -1,6 +1,8 @@
 # SimplifyRb - Polyline simplification
 
-SimplifyRb is a Ruby port of [simplify.js](https://github.com/mourner/simplify-js) by Vladimir Agafonkin. 
+[![Codeship Status for odlp/simplify_rb](https://www.codeship.io/projects/2a8ed250-47d5-0132-a14f-46b32a25e7b0/status)](https://www.codeship.io/projects/45709)
+
+SimplifyRb is a Ruby port of [simplify.js](https://github.com/mourner/simplify-js) by Vladimir Agafonkin.
 
 You can use this gem to reduce the number of points in a complex polyline / polygon, making use of an optimized Douglas-Peucker algorithm.
 
@@ -23,11 +25,15 @@ Or install it yourself as:
 ```ruby
 require 'simplify_rb'
 
+points = [{x: 51.5256, y: -0.0875}, {x: 51.7823, y: -0.0912}]
+tolerance = 1
+high_quality = true
+
 SimplifyRb.simplify(points, tolerance, high_quality)
 ```
 
-```points```: An array of hashes, containing x,y coordinates: ```{x: 51.5256, y: -0.0875}```
+```points```: An array of hashes, containing x,y coordinates.
 
-```tolerance```: (optional, 1 by default): Affects the amount of simplification that occurs (the smaller, the less simplification)
+```tolerance```: (optional, 1 by default): Affects the amount of simplification that occurs (the smaller, the less simplification).
 
-```highestQuality```: (optional, False by default): Flag to exclude the distance pre-processing. Produces higher quality results when true is passed, but runs slower
+```high_quality```: (optional, False by default): Flag to exclude the distance pre-processing. Produces higher quality results when true is passed, but runs slower.

data/lib/simplify_rb/version.rb

@@ -1,3 +1,3 @@
 class SimplifyRb
-  VERSION = "0.1.0"
+  VERSION = "0.1.2"
 end

data/lib/simplify_rb.rb

@@ -3,15 +3,17 @@ require "simplify_rb/version"
 class SimplifyRb
   # Main method
   def self.simplify (points, tolerance=1, highest_quality=false)
+    raise ArgumentError.new('Points must be an array') unless points.is_a? Array
+
     return points if points.length <= 1
 
-    points = symbolize_keys(points) unless keys_are_symbols?(points.map{|p| p.keys})
+    points = symbolize_keys(points) unless keys_are_symbols?(points.map(&:keys))
 
     sq_tolerance = tolerance * tolerance
-  
+
     # Optimisation step 1
     points = simplifyRadialDist(points, sq_tolerance) unless highest_quality
-    
+
     # Optimisation step 2
     simplifyDouglasPeucker(points, sq_tolerance)
   end
@@ -31,11 +33,10 @@ class SimplifyRb
 
   # Simplification using optimized Douglas-Peucker algorithm with recursion elimination
   def self.simplifyDouglasPeucker (points, sq_tolerance)
-    length  = points.length
-    first   = 0
-    last    = length - 1
-    index   = nil
-    stack   = []
+    first = 0
+    last  = points.length - 1
+    index = nil
+    stack = []
 
     points.first[:keep] = true
     points.last[:keep]  = true
@@ -58,12 +59,10 @@ class SimplifyRb
         stack.push(first, index, index, last)
       end
 
-      last  = stack.pop
-      first = stack.pop
-
+      first, last = stack.pop(2)
     end # end while
 
-    points.keep_if { |p| p[:keep] && p.delete(:keep) }
+    points.select { |p| p[:keep] && p.delete(:keep) }
   end
 
   # Square distance between two points
@@ -87,6 +86,7 @@ class SimplifyRb
       if t > 1
         x = point_2[:x]
         y = point_2[:y]
+
       elsif t > 0
         x += dx * t
         y += dy * t

data/simplify_rb.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |spec|
   spec.name          = "simplify_rb"
   spec.version       = SimplifyRb::VERSION
   spec.authors       = ["odlp"]
-  spec.description   = "You can use this gem to reduce the number of points in a complex polyline / polygon, making use of an optimized Douglas-Peucker algorithm."
+  spec.description   = "You can use this gem to reduce the number of points in a complex polyline / polygon, making use of an optimized Douglas-Peucker algorithm. Ruby port of Simplify.js."
   spec.summary       = "Polyline simplification library. Ruby port of Simplify.js."
   spec.homepage      = "https://github.com/odlp/simplify_rb"
   spec.license       = "MIT"

data/spec/simplify_rb_spec.rb

@@ -4,11 +4,11 @@ describe SimplifyRb do
   context "simplifies points correctly with the given tolerance" do
     before(:each) {@test_data = SimplifyTestData::points}
 
-    it "with the fast strategy (default)" do
+    it "uses the fast strategy by default" do
       expect(SimplifyRb.simplify(@test_data, 5)).to eq(SimplifyTestData::result_fast)
     end
 
-    it "with the high quality strategy" do
+    it "uses the high quality strategy when the flag is passed" do
       expect(SimplifyRb.simplify(@test_data, 5, true)).to eq(SimplifyTestData::result_high_quality)
     end
   end
@@ -23,21 +23,27 @@ describe SimplifyRb do
     expect(SimplifyRb.simplify([])).to eq([])
   end
 
-  context "#keys_are_symbols?" do
-    it "should return false if any key is not a Symbol" do
+  it "raises an argument error if the points are passsed as an array" do
+    data = {x: 1, y: 2}
+
+    expect { SimplifyRb.simplify(data) }.to raise_error(ArgumentError, "Points must be an array")
+  end
+
+  describe "#keys_are_symbols?" do
+    it "returns false if any key is not a Symbol" do
       expect(SimplifyRb.keys_are_symbols? [:a, 'b', :c]).to equal(false)
     end
 
-    it "should return true if all the keys are Symbols" do
+    it "returns return true if all the keys are Symbols" do
       expect(SimplifyRb.keys_are_symbols? [:a, :b, :c]).to equal(true)
     end
   end
 
-  context "#symbolize_keys" do
-    it "should convert all of the collection's keys to symbols" do
+  describe "#symbolize_keys" do
+    it "converts all of the collection's keys to symbols" do
       collection = [{'a' => 1, 'b' => 2}, {'c' => 3}]
 
       expect(SimplifyRb.symbolize_keys(collection)).to eq([{a: 1, b: 2}, {c: 3}])
     end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplify_rb
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - odlp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-24 00:00:00.000000000 Z
+date: 2015-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -53,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3'
 description: You can use this gem to reduce the number of points in a complex polyline
-  / polygon, making use of an optimized Douglas-Peucker algorithm.
+  / polygon, making use of an optimized Douglas-Peucker algorithm. Ruby port of Simplify.js.
 email: 
 executables: []
 extensions: []