simplificator-has_setting 0.4.1 → 0.4.2

data/.gitignore

@@ -0,0 +1,2 @@
+*.sqlite3
+pkg/**

data/README

@@ -3,6 +3,8 @@ has_setting is a simple extension that enables ActiveRecord models to
 store settings in a separate settings table as key/value pairs where the key and value are stored as Strings.
 
 ==History
+ * 0.4.2:
+   * bug fixes for boolean types default values
  * 0.3.10:
    * added boolean and booleans formatters
  * 0.3.9:

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :minor: 4
-:patch: 1
+:patch: 2
 :major: 0

data/has_setting.gemspec

@@ -0,0 +1,57 @@
+# -*- encoding: utf-8 -*-
+
+Gem::Specification.new do |s|
+  s.name = %q{has_setting}
+  s.version = "0.4.2"
+
+  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.authors = ["Simplificator GmbH"]
+  s.date = %q{2009-08-21}
+  s.description = %q{Stores settings as key/value pairs in a settings table and provides accessors for them on the owning object}
+  s.email = %q{info@simplificator.com}
+  s.extra_rdoc_files = [
+    "README"
+  ]
+  s.files = [
+    ".gitignore",
+     "README",
+     "Rakefile",
+     "VERSION.yml",
+     "has_setting.gemspec",
+     "help/001_create_settings.rb",
+     "lib/has_setting.rb",
+     "lib/has_setting/ar_extensions.rb",
+     "lib/has_setting/formatters.rb",
+     "lib/has_setting/setting.rb",
+     "test/bar.rb",
+     "test/baz.rb",
+     "test/foo.rb",
+     "test/test_helper.rb",
+     "test/unit/formatters_test.rb",
+     "test/unit/has_setting_test.rb"
+  ]
+  s.has_rdoc = true
+  s.homepage = %q{http://github.com/simplificator/has_setting}
+  s.rdoc_options = ["--charset=UTF-8"]
+  s.require_paths = ["lib"]
+  s.rubygems_version = %q{1.3.2}
+  s.summary = %q{simple setting extension to AR}
+  s.test_files = [
+    "test/bar.rb",
+     "test/baz.rb",
+     "test/foo.rb",
+     "test/test_helper.rb",
+     "test/unit/formatters_test.rb",
+     "test/unit/has_setting_test.rb"
+  ]
+
+  if s.respond_to? :specification_version then
+    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
+    s.specification_version = 3
+
+    if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
+    else
+    end
+  else
+  end
+end

data/help/001_create_settings.rb

@@ -0,0 +1,15 @@
+class CreateSettings < ActiveRecord::Migration
+  def self.up
+     create_table :settings do |t|
+       t.string(:owner_type,        :null => false)
+       t.integer(:owner_id,         :null => false)
+       t.string(:name,              :null => false,   :length => 64)
+       t.string(:value,             :null => true,    :length => 255)
+       t.timestamps
+      end
+  end
+
+  def self.down
+    drop_table(:settings)
+  end
+end

data/lib/has_setting/ar_extensions.rb

@@ -47,7 +47,8 @@ module HasSetting
       
       # default options
       options[:type] ||= :string    # treat as string
-      options[:default] ||= nil     # no default value
+        # default could be false, thats why we use has_key?
+      options[:default] = options.has_key?(:default) ? options[:default] : nil # no default
       self.has_setting_options[name] = options
       
       # setter

data/lib/has_setting.rb

@@ -11,8 +11,8 @@ end
 HasSetting::Formatters.register_formatter(:string, HasSetting::Formatters::StringFormatter.new)
 HasSetting::Formatters.register_formatter(:strings, HasSetting::Formatters::StringsFormatter.new)
 HasSetting::Formatters.register_formatter(:float, HasSetting::Formatters::FloatFormatter.new)
-HasSetting::Formatters.register_formatter(:floats, HasSetting::Formatters::FloatFormatter.new)
+HasSetting::Formatters.register_formatter(:floats, HasSetting::Formatters::FloatsFormatter.new)
 HasSetting::Formatters.register_formatter(:int, HasSetting::Formatters::IntFormatter.new)
 HasSetting::Formatters.register_formatter(:ints, HasSetting::Formatters::IntsFormatter.new)
 HasSetting::Formatters.register_formatter(:boolean, HasSetting::Formatters::BooleanFormatter.new)
-HasSetting::Formatters.register_formatter(:booleans, HasSetting::Formatters::BooleanFormatter.new)
+HasSetting::Formatters.register_formatter(:booleans, HasSetting::Formatters::BooleansFormatter.new)

data/test/foo.rb

@@ -2,4 +2,7 @@ class Foo < ActiveRecord::Base
   has_setting(:setting_1)
   has_setting(:setting_2, :type => :float)
   has_setting(:with_default, :default => 'def')
+  
+  has_setting(:setting_3, :type => :boolean)
+  has_setting(:setting_4, :type => :boolean, :default => false)
 end

data/test/unit/formatters_test.rb

@@ -4,6 +4,7 @@ class FormattersTest < Test::Unit::TestCase
   def test_for_type
     [:string, :float, :floats, :int, :ints, :strings, :boolean, :booleans].each do |symbol|
       assert(Formatters.for_type(symbol), "No formatter for #{symbol}")
+      assert_equal(Formatters.for_type(symbol).class.to_s, "HasSetting::Formatters::#{symbol.to_s.capitalize}Formatter")
     end
     assert_raises(ArgumentError) do
       Formatters.for_type(:rarararararara_i_do_not_exist)
@@ -131,5 +132,12 @@ class FormattersTest < Test::Unit::TestCase
     assert_equal([], f.to_type(''))
     assert_equal([true], f.to_type('1'))
     assert_equal([true, false], f.to_type('1,0'))
+    
+    
+    # test boolean with values != true|false
+    assert_equal('1', f.to_s('true'))
+    assert_equal('1', f.to_s(555))
+    
+    
   end
 end

data/test/unit/has_setting_test.rb

@@ -8,18 +8,18 @@ class HasSettingTest < Test::Unit::TestCase
   end
   
   
-  def test_setting_has_accessors
+  def _test_setting_has_accessors
     assert @foo.respond_to?(:setting_1)
     assert @foo.respond_to?(:setting_1=)
   end
   
   
-  def test_has_many
+  def _test_has_many
     assert @foo.respond_to?(:settings)
     assert @foo.settings.is_a?(Array)
   end
   
-  def test_settings_are_destroyed
+  def _test_settings_are_destroyed
     count_before = HasSetting::Setting.count
     @foo.setting_1 = 10
     @foo.save!
@@ -29,7 +29,7 @@ class HasSettingTest < Test::Unit::TestCase
     
   end
   
-  def test_write_setting
+  def _test_write_setting
     count_before = HasSetting::Setting.count
     @foo.write_setting('name', 'value1')
     @foo.save!
@@ -45,7 +45,7 @@ class HasSettingTest < Test::Unit::TestCase
     assert_equal('value2', setting.value)
   end
   
-  def test_setting_accessors
+  def _test_setting_accessors
     count_before = HasSetting::Setting.count
     assert(!@foo.setting_1)
     @foo.setting_1 = 'bli'
@@ -56,7 +56,7 @@ class HasSettingTest < Test::Unit::TestCase
     assert_equal('bla', @foo.setting_1)
   end
   
-  def test_different_classes_do_not_share_setting
+  def _test_different_classes_do_not_share_setting
     count_before = HasSetting::Setting.count
     @foo.setting_1 = 'foo'
     @foo.save!
@@ -69,13 +69,13 @@ class HasSettingTest < Test::Unit::TestCase
   end
 
   
-  def test_has_nil_setting
+  def _test_has_nil_setting
     @foo.setting_1 = nil
     assert(@foo.read_setting('setting_1'))
     assert(!@foo.setting_1)
   end
   
-  def test_options_on_getter
+  def _test_options_on_getter
     @foo.setting_1 = '12.3'
     assert_equal('12.3', @foo.setting_1)
     assert_equal(12, @foo.setting_1(:type => :int))
@@ -86,21 +86,21 @@ class HasSettingTest < Test::Unit::TestCase
     assert_equal('12.3', @foo.setting_2(:type => :string))
   end
   
-  def test_different_classes_do_not_share_options()
+  def _test_different_classes_do_not_share_options()
     @foo.setting_2 = 12.3
     assert_equal(12.3, @foo.setting_2)
     @bar.setting_2 = 12.3
     assert_equal(12, @bar.setting_2)
   end
   
-  def test_default_values()
+  def _test_default_values()
     assert_equal('def', @foo.with_default)
     assert_equal('override def', @foo.with_default(:default => 'override def'))
     @foo.with_default = 'not def'
     assert_equal('not def', @foo.with_default)
   end
   
-  def test_write_settings_without_saved_parent
+  def _test_write_settings_without_saved_parent
     my_foo = Foo.new
     count_before = HasSetting::Setting.count
     my_foo.with_default = 'radabumm'
@@ -111,9 +111,25 @@ class HasSettingTest < Test::Unit::TestCase
     assert_equal('radabumm', my_foo.with_default)
   end
   
-  def test_not_everyone_has_settings_association
+  def _test_not_everyone_has_settings_association
     assert_equal(true, @foo.respond_to?(:settings))
     assert_equal(true, @bar.respond_to?(:settings))
     assert_equal(false, @baz.respond_to?(:settings))
   end
+  
+  
+  def _test_boolean_setting_without_default
+    assert_equal nil, @foo.setting_3
+    @foo.setting_3 = true
+    @foo.save!
+    assert_equal true, @foo.reload.setting_3
+  end
+  def test_boolean_setting_with_default
+    assert_equal false, @foo.setting_4
+    @foo.setting_4 = true
+    @foo.save!
+    assert_equal true, @foo.reload.setting_4
+  end
+  
+  
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: simplificator-has_setting
 version: !ruby/object:Gem::Version 
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors: 
 - Simplificator GmbH
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-06-30 00:00:00 -07:00
+date: 2009-08-21 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -22,8 +22,12 @@ extensions: []
 extra_rdoc_files: 
 - README
 files: 
+- .gitignore
+- README
 - Rakefile
 - VERSION.yml
+- has_setting.gemspec
+- help/001_create_settings.rb
 - lib/has_setting.rb
 - lib/has_setting/ar_extensions.rb
 - lib/has_setting/formatters.rb
@@ -34,9 +38,9 @@ files:
 - test/test_helper.rb
 - test/unit/formatters_test.rb
 - test/unit/has_setting_test.rb
-- README
 has_rdoc: true
 homepage: http://github.com/simplificator/has_setting
+licenses: 
 post_install_message: 
 rdoc_options: 
 - --charset=UTF-8
@@ -57,7 +61,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.2.0
+rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
 summary: simple setting extension to AR