simpler_workflow 0.2.0 → 0.2.1

data/lib/simpler_workflow/activity.rb

@@ -52,8 +52,10 @@ module SimplerWorkflow
       logger.info("Performing task #{name}")
       @perform_task.call(task)
     rescue => e
-      logger.error e.message
-      logger.error e.backtrace.join("\n")
+      context = to_activity_type
+      context[:input] = task.input
+      context[:activity_id] = task.activity_id
+      SimplerWorkflow.exception_reporter.report(e, context)
       task.fail! :reason => e.message[0..250], :details => {:failure_policy => failure_policy}.to_json
     end
 
@@ -104,8 +106,11 @@ module SimplerWorkflow
               retry
             end
           rescue => e
-            logger.error(e.message)
-            logger.error(e.backtrace.join("\n"))
+            context = to_activity_type
+            context[:input] = task.input
+            context[:activity_id] = task.activity_id
+            SimplerWorkflow.exception_reporter.report(e, context)
+            raise e
           end
         end
       end

data/lib/simpler_workflow/default_exception_reporter.rb

@@ -0,0 +1,26 @@
+# Default exception handler. Just logs to the logger and re-raise
+# so the exception can be managed as usual.
+
+module SimplerWorkflow
+  class DefaultExceptionReporter
+    attr_accessor :reporter, :tag
+
+    def initialize(&block)
+      @reporter = block if block_given?
+    end
+
+    def report(e, context = {})
+      if reporter
+        reporter.call(e, context)
+      else
+        SimplerWorkflow.logger.error("[#{tag}] Exception: #{e.message}")
+        SimplerWorkflow.logger.error("[#{tag}] Context: #{context.inspect}") unless context.empty?
+        SimplerWorkflow.logger.error("[#{tag}] Backtrace:\n#{e.backtrace.join("\n")}")
+      end
+    end
+
+    def tag
+      @tag || "SimplerWorkflow"
+    end
+  end
+end

data/lib/simpler_workflow/version.rb

@@ -1,3 +1,3 @@
 module SimplerWorkflow
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/lib/simpler_workflow/workflow.rb

@@ -75,8 +75,15 @@ module SimplerWorkflow
             else
               retry
             end
+          rescue => e
+            context = {
+              :workflow_execution => decision_task.workflow_execution,
+              :workflow => to_workflow_type,
+              :decision_task => decision_task
+            }
+            SimplerWorkflow.exception_reporter.report(e, context)
+            raise e
           end
-          nil
         end
       end
     end
@@ -145,6 +152,10 @@ module SimplerWorkflow
       end
     end
 
+    def to_workflow_type
+      { :name => name, :version => version }
+    end
+
     def start_workflow(input, options = {})
       options[:input] = input
       domain.workflow_types[name.to_s, version].start_execution(options)

data/lib/simpler_workflow.rb

@@ -38,11 +38,24 @@ module SimplerWorkflow
     @child_processes ||= []
   end
 
+  def exception_reporter(&block)
+    if block_given?
+      @exception_reporter = DefaultExceptionReporter.new(&block)
+    end
+
+    @exception_reporter || DefaultExceptionReporter.new
+  end
+
+  def exception_reporter=(exception_handler)
+    @exception_reporter = exception_handler
+  end
+
   autoload :Version,  'simpler_workflow/version'
   autoload :Domain,   'simpler_workflow/domain'
   autoload :Workflow, 'simpler_workflow/workflow'
   autoload :Activity, 'simpler_workflow/activity'
   autoload :OptionsAsMethods, 'simpler_workflow/options_as_methods'
+  autoload :DefaultExceptionReporter, 'simpler_workflow/default_exception_reporter'
 end
 
 class Map

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simpler_workflow
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-22 00:00:00.000000000 Z
+date: 2012-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk
@@ -112,6 +112,7 @@ files:
 - lib/aws/simple_workflow/decision_task_additions.rb
 - lib/simpler_workflow.rb
 - lib/simpler_workflow/activity.rb
+- lib/simpler_workflow/default_exception_reporter.rb
 - lib/simpler_workflow/domain.rb
 - lib/simpler_workflow/options_as_methods.rb
 - lib/simpler_workflow/tasks.rb
@@ -125,7 +126,7 @@ files:
 - spec/spec_helper.rb
 homepage: https://github.com/fredjean/simpler_workflow
 licenses: []
-post_install_message: ! "simpler_workflow 0.2.0\n========================\n\nHave
+post_install_message: ! "simpler_workflow 0.2.1\n========================\n\nHave
   a look at https://github.com/fredjean/simpler_workflow/wiki/MIgrating-to-0.2.0 if
   you\nare upgrading from a 0.1.x version of the gem. There is a fundamental change
   in how the \nactivity and decision loops are run. You may need to adjust your application
@@ -140,18 +141,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -1625844284378708087
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -1625844284378708087
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23