simplecov 0.15.0 → 0.16.0

data/spec/lines_classifier_spec.rb

@@ -1,103 +0,0 @@
-require "helper"
-require "simplecov/lines_classifier"
-
-describe SimpleCov::LinesClassifier do
-  describe "#classify" do
-    describe "relevant lines" do
-      it "determines code as relevant" do
-        classified_lines = subject.classify [
-          "module Foo",
-          "  class Baz",
-          "    def Bar",
-          "      puts 'hi'",
-          "    end",
-          "  end",
-          "end",
-        ]
-
-        expect(classified_lines.length).to eq 7
-        expect(classified_lines).to all be_relevant
-      end
-    end
-
-    describe "not-relevant lines" do
-      it "determines whitespace is not-relevant" do
-        classified_lines = subject.classify [
-          "",
-          "  ",
-          "\t\t",
-        ]
-
-        expect(classified_lines.length).to eq 3
-        expect(classified_lines).to all be_irrelevant
-      end
-
-      describe "comments" do
-        it "determines comments are not-relevant" do
-          classified_lines = subject.classify [
-            "#Comment",
-            " # Leading space comment",
-            "\t# Leading tab comment",
-          ]
-
-          expect(classified_lines.length).to eq 3
-          expect(classified_lines).to all be_irrelevant
-        end
-
-        it "doesn't mistake interpolation as a comment" do
-          classified_lines = subject.classify [
-            'puts "#{var}"',
-          ]
-
-          expect(classified_lines.length).to eq 1
-          expect(classified_lines).to all be_relevant
-        end
-      end
-
-      describe ":nocov: blocks" do
-        it "determines :nocov: blocks are not-relevant" do
-          classified_lines = subject.classify [
-            "# :nocov:",
-            "def hi",
-            "end",
-            "# :nocov:",
-          ]
-
-          expect(classified_lines.length).to eq 4
-          expect(classified_lines).to all be_irrelevant
-        end
-
-        it "determines all lines after a non-closing :nocov: as not-relevant" do
-          classified_lines = subject.classify [
-            "# :nocov:",
-            "puts 'Not relevant'",
-            "# :nocov:",
-            "puts 'Relevant again'",
-            "puts 'Still relevant'",
-            "# :nocov:",
-            "puts 'Not relevant till the end'",
-            "puts 'Ditto'",
-          ]
-
-          expect(classified_lines.length).to eq 8
-
-          expect(classified_lines[0..2]).to all be_irrelevant
-          expect(classified_lines[3..4]).to all be_relevant
-          expect(classified_lines[5..7]).to all be_irrelevant
-        end
-      end
-    end
-  end
-
-  RSpec::Matchers.define :be_relevant do
-    match do |actual|
-      actual == SimpleCov::LinesClassifier::RELEVANT
-    end
-  end
-
-  RSpec::Matchers.define :be_irrelevant do
-    match do |actual|
-      actual == SimpleCov::LinesClassifier::NOT_RELEVANT
-    end
-  end
-end

data/spec/multi_formatter_spec.rb

@@ -1,20 +0,0 @@
-require "helper"
-
-require "simplecov/formatter/multi_formatter"
-
-describe SimpleCov::Formatter::MultiFormatter do
-  describe ".[]" do
-    # Regression test for https://github.com/colszowka/simplecov/issues/428
-    it "constructs a formatter with multiple children" do
-      # Silence deprecation warnings.
-      allow(described_class).to receive(:warn)
-
-      children = [
-        SimpleCov::Formatter::SimpleFormatter,
-        SimpleCov::Formatter::SimpleFormatter,
-      ]
-
-      expect(described_class[*children].new.formatters).to eq(children)
-    end
-  end
-end

data/spec/raw_coverage_spec.rb

@@ -1,92 +0,0 @@
-require "helper"
-
-if SimpleCov.usable?
-  describe SimpleCov::RawCoverage do
-    describe "with two faked coverage resultsets" do
-      before do
-        @resultset1 = {
-          source_fixture("sample.rb") => [nil, 1, 1, 1, nil, nil, 1, 1, nil, nil],
-          source_fixture("app/models/user.rb") => [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil],
-          source_fixture("app/controllers/sample_controller.rb") => [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil],
-          source_fixture("resultset1.rb") => [1, 1, 1, 1],
-          source_fixture("parallel_tests.rb") => [nil, 0, nil, 0],
-          source_fixture("conditionally_loaded_1.rb") => [nil, 0, 1],  # loaded only in the first resultset
-          source_fixture("three.rb") => [nil, 1, 1],
-        }
-
-        @resultset2 = {
-          source_fixture("sample.rb") => [1, nil, 1, 1, nil, nil, 1, 1, nil, nil],
-          source_fixture("app/models/user.rb") => [nil, 1, 5, 1, nil, nil, 1, 0, nil, nil],
-          source_fixture("app/controllers/sample_controller.rb") => [nil, 3, 1, nil, nil, nil, 1, 0, nil, nil],
-          source_fixture("resultset2.rb") => [nil, 1, 1, nil],
-          source_fixture("parallel_tests.rb") => [nil, nil, 0, 0],
-          source_fixture("conditionally_loaded_2.rb") => [nil, 0, 1],  # loaded only in the second resultset
-          source_fixture("three.rb") => [nil, 1, 4],
-        }
-
-        @resultset3 = {
-          source_fixture("three.rb") => [nil, 1, 2],
-        }
-      end
-
-      context "a merge" do
-        subject do
-          SimpleCov::RawCoverage.merge_results(@resultset1, @resultset2, @resultset3)
-        end
-
-        it "has proper results for sample.rb" do
-          expect(subject[source_fixture("sample.rb")]).to eq([1, 1, 2, 2, nil, nil, 2, 2, nil, nil])
-        end
-
-        it "has proper results for user.rb" do
-          expect(subject[source_fixture("app/models/user.rb")]).to eq([nil, 2, 6, 2, nil, nil, 2, 0, nil, nil])
-        end
-
-        it "has proper results for sample_controller.rb" do
-          expect(subject[source_fixture("app/controllers/sample_controller.rb")]).to eq([nil, 4, 2, 1, nil, nil, 2, 0, nil, nil])
-        end
-
-        it "has proper results for resultset1.rb" do
-          expect(subject[source_fixture("resultset1.rb")]).to eq([1, 1, 1, 1])
-        end
-
-        it "has proper results for resultset2.rb" do
-          expect(subject[source_fixture("resultset2.rb")]).to eq([nil, 1, 1, nil])
-        end
-
-        it "has proper results for parallel_tests.rb" do
-          expect(subject[source_fixture("parallel_tests.rb")]).to eq([nil, nil, nil, 0])
-        end
-
-        it "has proper results for conditionally_loaded_1.rb" do
-          expect(subject[source_fixture("conditionally_loaded_1.rb")]).to eq([nil, 0, 1])
-        end
-
-        it "has proper results for conditionally_loaded_2.rb" do
-          expect(subject[source_fixture("conditionally_loaded_2.rb")]).to eq([nil, 0, 1])
-        end
-
-        it "has proper results for three.rb" do
-          expect(subject[source_fixture("three.rb")]).to eq([nil, 3, 7])
-        end
-      end
-    end
-
-    it "merges frozen resultsets" do
-      resultset1 = {
-        source_fixture("sample.rb").freeze => [nil, 1, 1, 1, nil, nil, 1, 1, nil, nil].freeze,
-        source_fixture("app/models/user.rb").freeze => [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil].freeze,
-      }.freeze
-
-      resultset2 = {
-        source_fixture("sample.rb").freeze => [1, nil, 1, 1, nil, nil, 1, 1, nil, nil].freeze,
-      }.freeze
-
-      merged_result = SimpleCov::RawCoverage.merge_results(resultset1, resultset2)
-      expect(merged_result.keys).to eq(resultset1.keys)
-      expect(merged_result.values.map(&:frozen?)).to eq([false, false])
-      expect(merged_result[source_fixture("sample.rb")]).to eq([1, 1, 2, 2, nil, nil, 2, 2, nil, nil])
-      expect(merged_result[source_fixture("app/models/user.rb")]).to eq([nil, 1, 1, 1, nil, nil, 1, 0, nil, nil])
-    end
-  end
-end

data/spec/result_merger_spec.rb

@@ -1,171 +0,0 @@
-require "helper"
-require "tempfile"
-require "timeout"
-
-if SimpleCov.usable?
-  describe SimpleCov::ResultMerger do
-    before do
-      SimpleCov::ResultMerger.clear_resultset
-      File.delete(SimpleCov::ResultMerger.resultset_path) if File.exist?(SimpleCov::ResultMerger.resultset_path)
-    end
-
-    describe "with two faked coverage resultsets" do
-      before do
-        @resultset1 = {
-          source_fixture("sample.rb") => [nil, 1, 1, 1, nil, nil, 1, 1, nil, nil],
-          source_fixture("app/models/user.rb") => [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil],
-          source_fixture("app/controllers/sample_controller.rb") => [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil],
-          source_fixture("resultset1.rb") => [1, 1, 1, 1],
-          source_fixture("parallel_tests.rb") => [nil, 0, nil, 0],
-          source_fixture("conditionally_loaded_1.rb") => [nil, 0, 1],  # loaded only in the first resultset
-        }
-
-        @resultset2 = {
-          source_fixture("sample.rb") => [1, nil, 1, 1, nil, nil, 1, 1, nil, nil],
-          source_fixture("app/models/user.rb") => [nil, 1, 5, 1, nil, nil, 1, 0, nil, nil],
-          source_fixture("app/controllers/sample_controller.rb") => [nil, 3, 1, nil, nil, nil, 1, 0, nil, nil],
-          source_fixture("resultset2.rb") => [nil, 1, 1, nil],
-          source_fixture("parallel_tests.rb") => [nil, nil, 0, 0],
-          source_fixture("conditionally_loaded_2.rb") => [nil, 0, 1],  # loaded only in the second resultset
-        }
-      end
-
-      # See Github issue #6
-      it "returns an empty hash when the resultset cache file is empty" do
-        File.open(SimpleCov::ResultMerger.resultset_path, "w+") { |f| f.puts "" }
-        expect(SimpleCov::ResultMerger.resultset).to be_empty
-      end
-
-      # See Github issue #6
-      it "returns an empty hash when the resultset cache file is not present" do
-        system "rm #{SimpleCov::ResultMerger.resultset_path}" if File.exist?(SimpleCov::ResultMerger.resultset_path)
-        expect(SimpleCov::ResultMerger.resultset).to be_empty
-      end
-
-      context "and results generated from those" do
-        before do
-          system "rm #{SimpleCov::ResultMerger.resultset_path}" if File.exist?(SimpleCov::ResultMerger.resultset_path)
-          @result1 = SimpleCov::Result.new(@resultset1)
-          @result1.command_name = "result1"
-          @result2 = SimpleCov::Result.new(@resultset2)
-          @result2.command_name = "result2"
-        end
-
-        context "with stored results" do
-          before do
-            SimpleCov::ResultMerger.store_result(@result1)
-            SimpleCov::ResultMerger.store_result(@result2)
-          end
-
-          it "has stored data in resultset_path JSON file" do
-            expect(File.readlines(SimpleCov::ResultMerger.resultset_path).length).to be > 50
-          end
-
-          it "returns a hash containing keys ['result1' and 'result2'] for resultset" do
-            expect(SimpleCov::ResultMerger.resultset.keys.sort).to eq %w[result1 result2]
-          end
-
-          it "returns proper values for merged_result" do
-            expect(SimpleCov::ResultMerger.merged_result.source_files.find { |s| s.filename =~ /user/ }.lines.map(&:coverage)).to eq([nil, 2, 6, 2, nil, nil, 2, 0, nil, nil])
-          end
-
-          context "with second result way above the merge_timeout" do
-            before do
-              @result2.created_at = Time.now - 172_800 # two days ago
-              SimpleCov::ResultMerger.store_result(@result2)
-            end
-
-            it "has only one result in SimpleCov::ResultMerger.results" do
-              expect(SimpleCov::ResultMerger.results.length).to eq(1)
-            end
-          end
-        end
-      end
-    end
-
-    describe ".store_result" do
-      it "refreshes the resultset" do
-        set = SimpleCov::ResultMerger.resultset
-        SimpleCov::ResultMerger.store_result({})
-        new_set = SimpleCov::ResultMerger.resultset
-        expect(new_set).not_to be(set)
-      end
-
-      it "persists to disk" do
-        SimpleCov::ResultMerger.store_result("a" => [1])
-        SimpleCov::ResultMerger.clear_resultset
-        new_set = SimpleCov::ResultMerger.resultset
-        expect(new_set).to eq("a" => [1])
-      end
-
-      it "synchronizes writes" do
-        expect(SimpleCov::ResultMerger).to receive(:synchronize_resultset)
-        SimpleCov::ResultMerger.store_result({})
-      end
-    end
-
-    describe ".resultset" do
-      it "caches" do
-        set = SimpleCov::ResultMerger.resultset
-        new_set = SimpleCov::ResultMerger.resultset
-        expect(new_set).to be(set)
-      end
-
-      it "synchronizes reads" do
-        expect(SimpleCov::ResultMerger).to receive(:synchronize_resultset)
-        SimpleCov::ResultMerger.resultset
-      end
-    end
-
-    describe ".synchronize_resultset" do
-      it "is reentrant (i.e. doesn't block its own process)" do
-        # without @resultset_locked, this spec would fail and
-        # `.store_result` wouldn't work
-        expect do
-          Timeout.timeout(1) do
-            SimpleCov::ResultMerger.synchronize_resultset do
-              SimpleCov::ResultMerger.synchronize_resultset do
-              end
-            end
-          end
-        end.not_to raise_error
-      end
-
-      it "blocks other processes" do
-        file = Tempfile.new("foo")
-
-        other_process = open("|ruby -e " + Shellwords.escape(<<-CODE) + " 2>/dev/null")
-          require "simplecov"
-          SimpleCov.coverage_dir(#{SimpleCov.coverage_dir.inspect})
-
-          # ensure the parent process has enough time to get a
-          # lock before we do
-          sleep 0.5
-
-          $stdout.sync = true
-          puts "running" # see `sleep`s in parent process
-
-          SimpleCov::ResultMerger.synchronize_resultset do
-            File.open(#{file.path.inspect}, "a") { |f| f.write("process 2\n") }
-          end
-        CODE
-
-        SimpleCov::ResultMerger.synchronize_resultset do
-          # wait until the child process is going, and then wait some more
-          # so we can be sure it blocks on the lock we already have.
-          sleep 0.1 until other_process.gets == "running\n"
-          sleep 1
-
-          # despite the sleeps, this will be written first since we got
-          # the first lock
-          File.open(file.path, "a") { |f| f.write("process 1\n") }
-        end
-
-        # wait for it to finish
-        other_process.gets
-
-        expect(file.read).to eq("process 1\nprocess 2\n")
-      end
-    end
-  end
-end

data/spec/result_spec.rb

@@ -1,209 +0,0 @@
-require "helper"
-
-if SimpleCov.usable?
-  describe "result" do
-    context "with a (mocked) Coverage.result" do
-      before do
-        @prev_filters = SimpleCov.filters
-        SimpleCov.filters = []
-        @prev_groups = SimpleCov.groups
-        SimpleCov.groups = {}
-        @prev_formatter = SimpleCov.formatter
-        SimpleCov.formatter = nil
-      end
-
-      after do
-        SimpleCov.filters   = @prev_filters
-        SimpleCov.groups    = @prev_groups
-        SimpleCov.formatter = @prev_formatter
-      end
-
-      let(:original_result) do
-        {
-          source_fixture("sample.rb") => [nil, 1, 1, 1, nil, nil, 1, 1, nil, nil],
-          source_fixture("app/models/user.rb") => [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil],
-          source_fixture("app/controllers/sample_controller.rb") => [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil],
-        }
-      end
-
-      context "a simple cov result initialized from that" do
-        subject { SimpleCov::Result.new(original_result) }
-
-        it "has 3 filenames" do
-          expect(subject.filenames.count).to eq(3)
-        end
-
-        it "has 3 source files" do
-          expect(subject.source_files.count).to eq(3)
-          subject.source_files.each do |source_file|
-            expect(source_file).to be_a SimpleCov::SourceFile
-          end
-        end
-
-        it "returns an instance of SimpleCov::FileList for source_files and files" do
-          expect(subject.files).to be_a SimpleCov::FileList
-          expect(subject.source_files).to be_a SimpleCov::FileList
-        end
-
-        it "has files equal to source_files" do
-          expect(subject.files).to eq(subject.source_files)
-        end
-
-        it "has accurate covered percent" do
-          # in our fixture, there are 13 covered line (result in 1) in all 15 relevant line (result in non-nil)
-          expect(subject.covered_percent).to eq(86.66666666666667)
-        end
-
-        it "has accurate covered percentages" do
-          expect(subject.covered_percentages).to eq([80.0, 80.0, 100.0])
-        end
-
-        it "has accurate least covered file" do
-          expect(subject.least_covered_file).to match(/sample_controller.rb/)
-        end
-
-        [:covered_percent, :covered_percentages, :least_covered_file, :covered_strength, :covered_lines, :missed_lines, :total_lines].each do |msg|
-          it "responds to #{msg}" do
-            expect(subject).to respond_to(msg)
-          end
-        end
-
-        context "dumped with to_hash" do
-          it "is a hash" do
-            expect(subject.to_hash).to be_a Hash
-          end
-
-          context "loaded back with from_hash" do
-            let(:dumped_result) do
-              SimpleCov::Result.from_hash(subject.to_hash)
-            end
-
-            it "has 3 source files" do
-              expect(dumped_result.source_files.count).to eq(subject.source_files.count)
-            end
-
-            it "has the same covered_percent" do
-              expect(dumped_result.covered_percent).to eq(subject.covered_percent)
-            end
-
-            it "has the same covered_percentages" do
-              expect(dumped_result.covered_percentages).to eq(subject.covered_percentages)
-            end
-
-            it "has the same timestamp" do
-              expect(dumped_result.created_at.to_i).to eq(subject.created_at.to_i)
-            end
-
-            it "has the same command_name" do
-              expect(dumped_result.command_name).to eq(subject.command_name)
-            end
-
-            it "has the same original_result" do
-              expect(dumped_result.original_result).to eq(subject.original_result)
-            end
-          end
-        end
-      end
-
-      context "with some filters set up" do
-        before do
-          SimpleCov.add_filter "sample.rb"
-        end
-
-        it "has 2 files in a new simple cov result" do
-          expect(SimpleCov::Result.new(original_result).source_files.length).to eq(2)
-        end
-
-        it "has 80 covered percent" do
-          expect(SimpleCov::Result.new(original_result).covered_percent).to eq(80)
-        end
-
-        it "has [80.0, 80.0] covered percentages" do
-          expect(SimpleCov::Result.new(original_result).covered_percentages).to eq([80.0, 80.0])
-        end
-      end
-
-      context "with groups set up for all files" do
-        before do
-          SimpleCov.add_group "Models", "app/models"
-          SimpleCov.add_group "Controllers", ["app/controllers"]
-          SimpleCov.add_group "Other" do |src_file|
-            File.basename(src_file.filename) == "sample.rb"
-          end
-        end
-
-        subject do
-          SimpleCov::Result.new(original_result)
-        end
-
-        it "has 3 groups" do
-          expect(subject.groups.length).to eq(3)
-        end
-
-        it "has user.rb in 'Models' group" do
-          expect(File.basename(subject.groups["Models"].first.filename)).to eq("user.rb")
-        end
-
-        it "has sample_controller.rb in 'Controllers' group" do
-          expect(File.basename(subject.groups["Controllers"].first.filename)).to eq("sample_controller.rb")
-        end
-
-        context "and simple formatter being used" do
-          before do
-            SimpleCov.formatter = SimpleCov::Formatter::SimpleFormatter
-          end
-
-          it "returns a formatted string with result.format!" do
-            expect(subject.format!).to be_a String
-          end
-        end
-
-        context "and multi formatter being used" do
-          before do
-            SimpleCov.formatters = [
-              SimpleCov::Formatter::SimpleFormatter,
-              SimpleCov::Formatter::SimpleFormatter,
-            ]
-          end
-
-          it "returns an array containing formatted string with result.format!" do
-            formatted = subject.format!
-            expect(formatted.count).to eq(2)
-            expect(formatted.first).to be_a String
-          end
-        end
-      end
-
-      context "with groups set up that do not match all files" do
-        before do
-          SimpleCov.configure do
-            add_group "Models", "app/models"
-            add_group "Controllers", "app/controllers"
-          end
-        end
-
-        subject { SimpleCov::Result.new(original_result) }
-
-        it "has 3 groups" do
-          expect(subject.groups.length).to eq(3)
-        end
-
-        it "has 1 item per group" do
-          subject.groups.each_value do |files|
-            expect(files.length).to eq(1)
-          end
-        end
-
-        it 'has sample.rb in "Ungrouped" group' do
-          expect(File.basename(subject.groups["Ungrouped"].first.filename)).to eq("sample.rb")
-        end
-
-        it "returns all groups as instances of SimpleCov::FileList" do
-          subject.groups.each_value do |files|
-            expect(files).to be_a SimpleCov::FileList
-          end
-        end
-      end
-    end
-  end
-end

data/spec/return_codes_spec.rb

@@ -1,34 +0,0 @@
-require "helper"
-
-# Make sure that exit codes of tests are propagated properly
-# See https://github.com/colszowka/simplecov/issues/5
-describe "return codes" do
-  context "inside fixtures/frameworks" do
-    around do |test|
-      Dir.chdir(File.join(File.dirname(__FILE__), "fixtures", "frameworks")) do
-        FileUtils.rm_rf("./coverage")
-        test.call
-      end
-    end
-
-    it "has return code 0 when running testunit_good.rb" do
-      `ruby testunit_good.rb`
-      expect($?.exitstatus).to be_zero
-    end
-
-    it "has return code 0 when running rspec_good.rb" do
-      `rspec rspec_good.rb`
-      expect($?.exitstatus).to be_zero
-    end
-
-    it "has non-0 return code when running testunit_bad.rb" do
-      `ruby testunit_bad.rb`
-      expect($?.exitstatus).not_to be_zero
-    end
-
-    it "has return code 1 when running rspec_bad.rb" do
-      `rspec rspec_bad.rb`
-      expect($?.exitstatus).not_to be_zero
-    end
-  end
-end