simplecov 0.14.0 → 0.14.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8e97e7dcf1f3c003a18fe662722aa6afb4c22a4f
-  data.tar.gz: 53416d84e2f00e0d4b9da2a9ffd8f92f01eaf084
+  metadata.gz: bda7293a0b718da578a1e9b6897393d21d955fbf
+  data.tar.gz: d81ac2993a335e716a47a19dd648fe635cc4a635
 SHA512:
-  metadata.gz: 5553c580dc83af525bde5a86cba9648a0bb61a5340d5047f17aaf0c933375a4594b5b0094321374e3215d2dd617717e9d5aa0b8c27fe9a2937b06cf2eb757700
-  data.tar.gz: 290a8fd21178bbb5cf125a8b06d3ac844cc886c56bda739bb3056166b760afef308c1504cdde5277cc7ebfb877abbb505353b71bf0f9be3b9b2dfc9977cce580
+  metadata.gz: 6e25b2151aec02177f9a6dd1f14366d44ad1ab2158d8502c65bbf2db4e2672a1926eaba1107580f4a642ad99d79f57d421d54759bed341099ec4a1a4cb9a3a04
+  data.tar.gz: 34fe7bc261f7e105b230652e5b8ceed4e4b179bf7f36e5424c51cf7767e14ae91173a01b9da2e89707bd147ab212f85367e28791cfa1bbfcac3d055660e2ca43

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+0.14.1 2017-03-18 ([changes](https://github.com/colszowka/simplecov/compare/v0.14.0...v0.14.1))
+========
+
+## Bugfixes
+
+* Files that were skipped as a whole/had no relevant coverage could lead to Float errors. See [#564](https://github.com/colszowka/simplecov/pull/564) (thanks to @stevehanson for the report in [#563](https://github.com/colszowka/simplecov/issues/563))
+
 0.14.0 2017-03-15 ([changes](https://github.com/colszowka/simplecov/compare/v0.13.0...v0.14.0))
 ==========
 

data/lib/simplecov/source_file.rb

@@ -125,13 +125,13 @@ module SimpleCov
     end
 
     def covered_strength
-      return 0.0 if no_lines?
+      return 0.0 if relevant_lines.zero?
 
       round_float(lines_strength / relevant_lines.to_f, 1)
     end
 
     def no_lines?
-      lines.length.zero? || lines.length == never_lines.size
+      lines.length.zero? || (lines.length == never_lines.size)
     end
 
     def lines_strength

data/lib/simplecov/version.rb

@@ -1,5 +1,5 @@
 module SimpleCov
-  version = "0.14.0"
+  version = "0.14.1"
 
   def version.to_a
     split(".").map(&:to_i)

data/spec/fixtures/never.rb

@@ -0,0 +1,2 @@
+# This class is purely some
+# comments

data/spec/fixtures/skipped.rb

@@ -0,0 +1,4 @@
+# Not relevant
+# :nocov:
+# Hash.new
+# :nocov:

data/spec/fixtures/skipped_and_executed.rb

@@ -0,0 +1,8 @@
+# So much skippping
+# :nocov:
+class Foo
+  def bar
+    0
+  end
+end
+#:nocov:

data/spec/source_file_spec.rb

@@ -73,5 +73,69 @@ if SimpleCov.usable?
         expect(captured_output).to match(/^Warning: coverage data provided/)
       end
     end
+
+    context "a file that is never relevant" do
+      COVERAGE_FOR_NEVER_RB = [nil, nil].freeze
+
+      subject do
+        SimpleCov::SourceFile.new(source_fixture("never.rb"), COVERAGE_FOR_NEVER_RB)
+      end
+
+      it "has 0.0 covered_strength" do
+        expect(subject.covered_strength).to eq 0.0
+      end
+
+      it "has 0.0 covered_percent" do
+        expect(subject.covered_percent).to eq 100.0
+      end
+    end
+
+    context "a file where nothing is ever executed mixed with skipping #563" do
+      COVERAGE_FOR_SKIPPED_RB = [nil, nil, nil, nil].freeze
+
+      subject do
+        SimpleCov::SourceFile.new(source_fixture("skipped.rb"), COVERAGE_FOR_SKIPPED_RB)
+      end
+
+      it "has 0.0 covered_strength" do
+        expect(subject.covered_strength).to eq 0.0
+      end
+
+      it "has 0.0 covered_percent" do
+        expect(subject.covered_percent).to eq 0.0
+      end
+    end
+
+    context "a file where everything is skipped and missed #563" do
+      COVERAGE_FOR_SKIPPED_RB_2 = [nil, nil, 0, nil].freeze
+
+      subject do
+        SimpleCov::SourceFile.new(source_fixture("skipped.rb"), COVERAGE_FOR_SKIPPED_RB_2)
+      end
+
+      it "has 0.0 covered_strength" do
+        expect(subject.covered_strength).to eq 0.0
+      end
+
+      it "has 0.0 covered_percent" do
+        expect(subject.covered_percent).to eq 0.0
+      end
+    end
+
+    context "a file where everything is skipped/irrelevamt but executed #563" do
+      COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB = [nil, nil, 1, 1, 0, nil, nil, nil].freeze
+
+      subject do
+        SimpleCov::SourceFile.new(source_fixture("skipped_and_executed.rb"), COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB)
+      end
+
+      it "has 0.0 covered_strength" do
+        expect(subject.covered_strength).to eq 0.0
+      end
+
+      it "has 0.0 covered_percent" do
+        expect(subject.covered_percent).to eq 0.0
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplecov
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.14.1
 platform: ruby
 authors:
 - Christoph Olszowka
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-15 00:00:00.000000000 Z
+date: 2017-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -187,9 +187,12 @@ files:
 - spec/fixtures/frameworks/testunit_bad.rb
 - spec/fixtures/frameworks/testunit_good.rb
 - spec/fixtures/iso-8859.rb
+- spec/fixtures/never.rb
 - spec/fixtures/resultset1.rb
 - spec/fixtures/resultset2.rb
 - spec/fixtures/sample.rb
+- spec/fixtures/skipped.rb
+- spec/fixtures/skipped_and_executed.rb
 - spec/fixtures/utf-8.rb
 - spec/helper.rb
 - spec/last_run_spec.rb