simplecov-parallel 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4fdc5794fb5634ad9c97afcdf6783daf7d1220cd
-  data.tar.gz: 055eb756b87784b13681d0fc9bcf54bc3558f30b
+  metadata.gz: ef73c5648b57532f6b44d43cafd921779a969366
+  data.tar.gz: 6b542836cc4264a7a60ae18c4b61b0a8a6dd1ba0
 SHA512:
-  metadata.gz: ca8662037eed8bce87500d0c9958506b76599d291cb9098e03fb7c7c770f5ac6e9193d72d02bf96d0f342ba308a2b223e0546d2ac29a72af9163dfb8b8a4c8d6
-  data.tar.gz: 4bd82d8cb9c78f9ef55d7f4a115bb795ef14313c330fa8a7f4a9b6ec8f19b52ead689a58e654f98f34d75d505bcd1893d6b104ede5c7d0fcd999c05e1e9e0b49
+  metadata.gz: 0e2bb376613c10b3c27aa4035a993983e3f2239f6406e12106778ec60835f47d2eb6728cdeae1d2cabe1f0314a57334d1ed543877988b8b5cacf4500fc4f33a2
+  data.tar.gz: 6af0c497e862afd8e6c482c62756c1a72d08f233570accb4a9afc9ecb33e4bf6e968cfbfcb20542c32f06b522190644fd76dfa658b9c5d9ece51331dc053c32a

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Development
 
+## v0.1.2
+
+* Refactor method stashing.
+
 ## v0.1.1
 
 * Fix a bug in method stashing of `SimpleCov::ResultMerger#resultset_path`.

data/README.md

@@ -6,6 +6,7 @@
 # SimpleCov::Parallel
 
 **SimpleCov::Parallel** is a [SimpleCov](https://github.com/colszowka/simplecov) extension for parallelism support.
+It automatically transfers each node coverage data to a single master node and merges the data.
 Currently only [CircleCI parallelism](https://circleci.com/docs/parallelism/) is supported.
 
 ## Installation

data/lib/simplecov/parallel/adapter/circleci.rb

@@ -78,24 +78,44 @@ module SimpleCov
           # SimpleCov.root and SimpleCov.coverage_dir does not work well because .root is used in
           # the root filter, which is invoked from SimpleCov::Result#initialize.
           # https://github.com/colszowka/simplecov/blob/v0.12.0/lib/simplecov/defaults.rb#L9
-          method_name = :resultset_path
-          original_method = SimpleCov::ResultMerger.method(method_name)
-          singleton_class = SimpleCov::ResultMerger.singleton_class
+          method_stasher = MethodStasher.new(SimpleCov::ResultMerger, :resultset_path)
+          method_stasher.stash
 
-          singleton_class.__send__(:undef_method, method_name)
-          singleton_class.__send__(:define_method, method_name) { File.join(dir, '.resultset.json') }
+          SimpleCov::ResultMerger.define_singleton_method(:resultset_path) do
+            File.join(dir, '.resultset.json')
+          end
 
           begin
             yield
           ensure
-            singleton_class.__send__(:undef_method, method_name)
-            singleton_class.__send__(:define_method, method_name, original_method)
+            method_stasher.pop
           end
         end
 
         def current_node
           ::CircleCI::Parallel.current_node
         end
+
+        MethodStasher = Struct.new(:object, :method_name) do
+          def stash
+            @original_method = object.method(method_name)
+            klass.__send__(:undef_method, method_name)
+          end
+
+          def pop
+            if klass.__send__(:method_defined?, method_name)
+              klass.__send__(:undef_method, method_name)
+            end
+
+            klass.__send__(:define_method, method_name, @original_method)
+          end
+
+          private
+
+          def klass
+            object.singleton_class
+          end
+        end
       end
     end
   end

data/lib/simplecov/parallel/version.rb

@@ -3,7 +3,7 @@ module SimpleCov
     module Version
       MAJOR = 0
       MINOR = 1
-      PATCH = 1
+      PATCH = 2
 
       def self.to_s
         [MAJOR, MINOR, PATCH].join('.')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simplecov-parallel
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Yuji Nakayama