simplecov-mcp 1.0.0 → 2.0.0

data/spec/commands/base_command_spec.rb

@@ -14,12 +14,8 @@ RSpec.describe SimpleCovMcp::Commands::BaseCommand do
       end
 
       # Expose protected methods for testing
-      def public_handle_with_path(args, name, &block)
-        handle_with_path(args, name, &block)
-      end
-
-      def public_fetch_raw(model, path)
-        fetch_raw(model, path)
+      def public_handle_with_path(args, name, &)
+        handle_with_path(args, name, &)
       end
     end
   end
@@ -33,8 +29,8 @@ RSpec.describe SimpleCovMcp::Commands::BaseCommand do
 
         # Stub the block to raise Errno::ENOENT
         expect do
-          test_command.public_handle_with_path(args, 'test') do |path|
-            raise Errno::ENOENT.new('No such file or directory')
+          test_command.public_handle_with_path(args, 'test') do |_path|
+            raise Errno::ENOENT, 'No such file or directory'
           end
         end.to raise_error(SimpleCovMcp::FileNotFoundError, 'File not found: lib/missing.rb')
       end
@@ -43,8 +39,8 @@ RSpec.describe SimpleCovMcp::Commands::BaseCommand do
         args = ['some/other/path.rb']
 
         expect do
-          test_command.public_handle_with_path(args, 'test') do |path|
-            raise Errno::ENOENT.new('No such file or directory')
+          test_command.public_handle_with_path(args, 'test') do |_path|
+            raise Errno::ENOENT, 'No such file or directory'
           end
         end.to raise_error(SimpleCovMcp::FileNotFoundError, /some\/other\/path\.rb/)
       end
@@ -56,8 +52,8 @@ RSpec.describe SimpleCovMcp::Commands::BaseCommand do
 
         # Stub the block to raise Errno::EACCES
         expect do
-          test_command.public_handle_with_path(args, 'test') do |path|
-            raise Errno::EACCES.new('Permission denied')
+          test_command.public_handle_with_path(args, 'test') do |_path|
+            raise Errno::EACCES, 'Permission denied'
           end
         end.to raise_error(SimpleCovMcp::FilePermissionError, 'Permission denied: lib/secret.rb')
       end
@@ -66,8 +62,8 @@ RSpec.describe SimpleCovMcp::Commands::BaseCommand do
         args = ['/root/protected.rb']
 
         expect do
-          test_command.public_handle_with_path(args, 'test') do |path|
-            raise Errno::EACCES.new('Permission denied')
+          test_command.public_handle_with_path(args, 'test') do |_path|
+            raise Errno::EACCES, 'Permission denied'
           end
         end.to raise_error(SimpleCovMcp::FilePermissionError, /\/root\/protected\.rb/)
       end
@@ -78,7 +74,7 @@ RSpec.describe SimpleCovMcp::Commands::BaseCommand do
         args = []
 
         expect do
-          test_command.public_handle_with_path(args, 'summary') do |path|
+          test_command.public_handle_with_path(args, 'summary') do |_path|
             # Should not reach here
           end
         end.to raise_error(SimpleCovMcp::UsageError, /summary <path>/)
@@ -100,7 +96,7 @@ RSpec.describe SimpleCovMcp::Commands::BaseCommand do
       it 'shifts the path from args' do
         args = ['lib/foo.rb', 'extra', 'args']
 
-        test_command.public_handle_with_path(args, 'test') do |path|
+        test_command.public_handle_with_path(args, 'test') do |_path|
           # Block execution
         end
 
@@ -108,80 +104,4 @@ RSpec.describe SimpleCovMcp::Commands::BaseCommand do
       end
     end
   end
-
-  describe '#fetch_raw' do
-    let(:model) { SimpleCovMcp::CoverageModel.new(root: root, resultset: 'coverage') }
-
-    context 'when model.raw_for raises an exception' do
-      it 'returns nil instead of propagating the error' do
-        # Stub model.raw_for to raise an exception
-        allow(model).to receive(:raw_for).and_raise(StandardError, 'Something went wrong')
-
-        result = test_command.public_fetch_raw(model, 'lib/nonexistent.rb')
-
-        expect(result).to be_nil
-      end
-
-      it 'handles RuntimeError' do
-        allow(model).to receive(:raw_for).and_raise(RuntimeError, 'Runtime error')
-
-        result = test_command.public_fetch_raw(model, 'lib/foo.rb')
-
-        expect(result).to be_nil
-      end
-
-      it 'handles ArgumentError' do
-        allow(model).to receive(:raw_for).and_raise(ArgumentError, 'Invalid argument')
-
-        result = test_command.public_fetch_raw(model, 'lib/foo.rb')
-
-        expect(result).to be_nil
-      end
-    end
-
-    context 'when successful' do
-      it 'returns the raw coverage data' do
-        result = test_command.public_fetch_raw(model, 'lib/foo.rb')
-
-        expect(result).to be_a(Hash)
-        expect(result).to have_key('lines')
-        expect(result['lines']).to be_an(Array)
-      end
-
-      it 'caches the result for subsequent calls' do
-        # First call should hit the model
-        expect(model).to receive(:raw_for).with('lib/foo.rb').once.and_call_original
-
-        result1 = test_command.public_fetch_raw(model, 'lib/foo.rb')
-        result2 = test_command.public_fetch_raw(model, 'lib/foo.rb')
-
-        expect(result1).to eq(result2)
-      end
-
-      it 'caches different paths separately' do
-        result1 = test_command.public_fetch_raw(model, 'lib/foo.rb')
-        result2 = test_command.public_fetch_raw(model, 'lib/bar.rb')
-
-        expect(result1).not_to eq(result2)
-      end
-
-      it 'does not cache nil results from exceptions' do
-        # Set up the stub to raise an error
-        call_count = 0
-        allow(model).to receive(:raw_for).with('lib/missing.rb') do
-          call_count += 1
-          raise StandardError, 'File not found'
-        end
-
-        result1 = test_command.public_fetch_raw(model, 'lib/missing.rb')
-        result2 = test_command.public_fetch_raw(model, 'lib/missing.rb')
-
-        expect(result1).to be_nil
-        expect(result2).to be_nil
-        # Note: Due to current implementation, nil results are NOT cached,
-        # so raw_for is called each time an exception occurs
-        expect(call_count).to eq(2)
-      end
-    end
-  end
 end

data/spec/commands/command_factory_spec.rb

@@ -13,7 +13,9 @@ RSpec.describe SimpleCovMcp::Commands::CommandFactory do
         ['summary', SimpleCovMcp::Commands::SummaryCommand],
         ['raw', SimpleCovMcp::Commands::RawCommand],
         ['uncovered', SimpleCovMcp::Commands::UncoveredCommand],
-        ['detailed', SimpleCovMcp::Commands::DetailedCommand]
+        ['detailed', SimpleCovMcp::Commands::DetailedCommand],
+        ['totals', SimpleCovMcp::Commands::TotalsCommand],
+        ['total', SimpleCovMcp::Commands::TotalsCommand] # Alias
       ].each do |command_name, command_class|
         it "creates a #{command_class.name.split('::').last} for \"#{command_name}\"" do
           command = described_class.create(command_name, cli_context)
@@ -27,7 +29,7 @@ RSpec.describe SimpleCovMcp::Commands::CommandFactory do
         [
           'invalid_cmd',
           'invalid command',
-          /list | summary <path> | raw <path> | uncovered <path> | detailed <path> | version/
+          /list \| summary <path> \| raw <path> \| uncovered <path>/
         ],
         [nil,           'nil command',            nil],
         ['',            'empty string command',   nil],
@@ -47,7 +49,7 @@ RSpec.describe SimpleCovMcp::Commands::CommandFactory do
       commands = described_class.available_commands
       expect(commands).to be_an(Array)
       expect(commands).to contain_exactly('list', 'version', 'summary', 'raw', 'uncovered',
-        'detailed')
+        'detailed', 'totals', 'total', 'validate')
     end
 
     it 'returns the keys from COMMAND_MAP' do
@@ -67,6 +69,8 @@ RSpec.describe SimpleCovMcp::Commands::CommandFactory do
       expect(described_class::COMMAND_MAP['raw']).to eq(SimpleCovMcp::Commands::RawCommand)
       expect(described_class::COMMAND_MAP['uncovered']).to eq(SimpleCovMcp::Commands::UncoveredCommand)
       expect(described_class::COMMAND_MAP['detailed']).to eq(SimpleCovMcp::Commands::DetailedCommand)
+      expect(described_class::COMMAND_MAP['totals']).to eq(SimpleCovMcp::Commands::TotalsCommand)
+      expect(described_class::COMMAND_MAP['total']).to eq(SimpleCovMcp::Commands::TotalsCommand)
     end
   end
 end

data/spec/commands/detailed_command_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
+require_relative '../shared_examples/formatted_command_examples'
 
 RSpec.describe SimpleCovMcp::Commands::DetailedCommand do
   let(:root) { (FIXTURES_DIR / 'project1').to_s }
@@ -10,39 +11,24 @@ RSpec.describe SimpleCovMcp::Commands::DetailedCommand do
   before do
     cli_context.config.root = root
     cli_context.config.resultset = 'coverage'
-    cli_context.config.json = false
+    cli_context.config.format = :table
     cli_context.config.source_mode = nil
   end
 
   describe '#execute' do
-    it 'prints the detailed coverage table' do
-      output = nil
+    context 'with table format' do
+      it 'prints the detailed coverage table' do
+        output = capture_command_output(command, ['lib/foo.rb'])
 
-      silence_output do |stdout, _stderr|
-        command.execute(['lib/foo.rb'])
-        output = stdout.string
+        expect(output).to include('File: lib/foo.rb', 'Line', 'Covered')
       end
-
-      expect(output).to include('File: lib/foo.rb')
-      expect(output).to include('Line')
-      expect(output).to include('Covered')
     end
 
-    it 'emits JSON when requested, including stale metadata' do
-      cli_context.config.json = true
-      stub_staleness_check('L')
-
-      json_output = nil
-      silence_output do |stdout, _stderr|
-        command.execute(['lib/foo.rb'])
-        json_output = stdout.string
-      end
+    context 'with stale data' do
+      before { stub_staleness_check('L') }
 
-      payload = JSON.parse(json_output)
-      expect(payload['file']).to eq('lib/foo.rb')
-      expect(payload['lines']).to be_an(Array)
-      expect(payload['summary']).to include('covered' => 2, 'total' => 3, 'pct' => 66.67)
-      expect(payload['stale']).to eq('L')
+      it_behaves_like 'a command with formatted output', ['lib/foo.rb'],
+        { 'file' => 'lib/foo.rb', 'lines' => nil, 'summary' => nil, 'stale' => 'L' }
     end
   end
 end

data/spec/commands/list_command_spec.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require_relative '../shared_examples/formatted_command_examples'
+
+RSpec.describe SimpleCovMcp::Commands::ListCommand do
+  let(:root) { (FIXTURES_DIR / 'project1').to_s }
+  let(:cli_context) { SimpleCovMcp::CoverageCLI.new }
+  let(:command) { described_class.new(cli_context) }
+
+  before do
+    cli_context.config.root = root
+    cli_context.config.resultset = 'coverage'
+    cli_context.config.format = :table
+  end
+
+  describe '#execute' do
+    context 'with table format' do
+      it 'outputs a formatted table' do
+        output = capture_command_output(command, [])
+
+        expect(output).to include('│', 'lib/foo.rb', 'lib/bar.rb')
+      end
+    end
+
+    it_behaves_like 'a command with formatted output', [], ['files', 'counts']
+  end
+end

data/spec/commands/raw_command_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
+require_relative '../shared_examples/formatted_command_examples'
 
 RSpec.describe SimpleCovMcp::Commands::RawCommand do
   let(:root) { (FIXTURES_DIR / 'project1').to_s }
@@ -10,37 +11,59 @@ RSpec.describe SimpleCovMcp::Commands::RawCommand do
   before do
     cli_context.config.root = root
     cli_context.config.resultset = 'coverage'
-    cli_context.config.json = false
+    cli_context.config.format = :table
   end
 
   describe '#execute' do
-    it 'prints the raw coverage lines for the requested file' do
-      output = nil
+    context 'with table format' do
+      it 'prints the raw coverage lines for the requested file' do
+        output = capture_command_output(command, ['lib/foo.rb'])
 
-      silence_output do |stdout, _stderr|
-        command.execute(['lib/foo.rb'])
-        output = stdout.string
+        expect(output).to include('│', 'lib/foo.rb', 'Line', 'Coverage')
       end
+    end
+
+    context 'when the file is fully covered' do
+      it 'still prints the raw table' do
+        mock_presenter(
+          SimpleCovMcp::Presenters::CoverageRawPresenter,
+          absolute_payload: {
+            'file' => 'lib/perfect.rb',
+            'lines' => [1, 1, 1],
+            'stale' => false
+          },
+          relative_path: 'lib/perfect.rb'
+        )
 
-      expect(output).to include('File: lib/foo.rb')
-      # Example match: "[1, 0, nil, 2]"
-      expect(output).to match(/\[1,\s0,\snil,\s2\]/)
+        output = capture_command_output(command, ['lib/perfect.rb'])
+
+        expect(output).to include('│', '│    1 │        1 │')
+        expect(output).not_to include('All lines covered!')
+      end
     end
 
-    it 'emits JSON when requested, including stale metadata' do
-      cli_context.config.json = true
-      stub_staleness_check('L')
+    context 'with JSON output' do
+      before { cli_context.config.format = :json }
 
-      json_output = nil
-      silence_output do |stdout, _stderr|
-        command.execute(['lib/foo.rb'])
-        json_output = stdout.string
+      it 'emits JSON with specific line data' do
+        stub_staleness_check('L') # Needed for stale data
+
+        output = capture_command_output(command, ['lib/foo.rb'])
+
+        payload = JSON.parse(output)
+        expect(payload['file']).to eq('lib/foo.rb')
+        expect(payload['lines']).to be_an(Array)
+        expect(payload['lines'][0]).to eq(1) # specific value
+        expect(payload['lines'][1]).to eq(0) # specific value
+        expect(payload['stale']).to eq('L')
       end
+    end
+
+    context 'with stale data (other formats)' do
+      before { stub_staleness_check('L') }
 
-      payload = JSON.parse(json_output)
-      expect(payload['file']).to eq('lib/foo.rb')
-      expect(payload['lines']).to eq([1, 0, nil, 2])
-      expect(payload['stale']).to eq('L')
+      # Use an array for expected_json_keys as we don't need exact value matching for these generic format tests
+      it_behaves_like 'a command with formatted output', ['lib/foo.rb'], ['file', 'lines', 'stale']
     end
   end
 end

data/spec/commands/summary_command_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
+require_relative '../shared_examples/formatted_command_examples'
 
 RSpec.describe SimpleCovMcp::Commands::SummaryCommand do
   let(:root) { (FIXTURES_DIR / 'project1').to_s }
@@ -10,38 +11,24 @@ RSpec.describe SimpleCovMcp::Commands::SummaryCommand do
   before do
     cli_context.config.root = root
     cli_context.config.resultset = 'coverage'
-    cli_context.config.json = false
+    cli_context.config.format = :table
     cli_context.config.source_mode = nil
   end
 
   describe '#execute' do
-    it 'prints a coverage summary line with a relative path' do
-      output = nil
+    context 'with table format' do
+      it 'prints a coverage summary line with a relative path' do
+        output = capture_command_output(command, ['lib/foo.rb'])
 
-      silence_output do |stdout, _stderr|
-        command.execute(['lib/foo.rb'])
-        output = stdout.string
+        expect(output).to include('│', '66.67%', 'lib/foo.rb')
       end
-
-      # Example match: "   66.67%       2/3       lib/foo.rb"
-      expect(output).to match(/66\.67%.*2\/3.*lib\/foo\.rb/)
     end
 
-    it 'emits JSON when requested, including stale metadata' do
-      cli_context.config.json = true
-      stub_staleness_check('L')
-
-      json_output = nil
-      silence_output do |stdout, _stderr|
-        command.execute(['lib/foo.rb'])
-        json_output = stdout.string
-      end
+    context 'with stale data' do
+      before { stub_staleness_check('L') }
 
-      payload = JSON.parse(json_output)
-      expect(payload['file']).to eq('lib/foo.rb')
-      expect(payload['summary']).to include('covered' => 2, 'total' => 3, 'pct' => 66.67)
-      expect(payload).to have_key('stale')
-      expect(payload['stale']).to eq('L')
+      it_behaves_like 'a command with formatted output', ['lib/foo.rb'],
+        { 'file' => 'lib/foo.rb', 'summary' => nil, 'stale' => 'L' }
     end
   end
 end

data/spec/commands/totals_command_spec.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require_relative '../shared_examples/formatted_command_examples'
+
+RSpec.describe SimpleCovMcp::Commands::TotalsCommand do
+  let(:root) { (FIXTURES_DIR / 'project1').to_s }
+  let(:cli_context) { SimpleCovMcp::CoverageCLI.new }
+  let(:command) { described_class.new(cli_context) }
+
+  before do
+    cli_context.config.root = root
+    cli_context.config.resultset = 'coverage'
+    cli_context.config.format = :table
+  end
+
+  describe '#execute' do
+    context 'with table format' do
+      it 'prints aggregated totals for the project' do
+        output = capture_command_output(command, [])
+
+        expect(output).to include('│', 'Lines', '50.00%')
+      end
+    end
+
+    it_behaves_like 'a command with formatted output', [], ['lines', 'files', 'percentage']
+
+    it 'raises when unexpected arguments are provided' do
+      expect do
+        command.execute(['extra'])
+      end.to raise_error(SimpleCovMcp::UsageError, include('totals'))
+    end
+  end
+end

data/spec/commands/uncovered_command_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
+require_relative '../shared_examples/formatted_command_examples'
 
 RSpec.describe SimpleCovMcp::Commands::UncoveredCommand do
   let(:root) { (FIXTURES_DIR / 'project1').to_s }
@@ -10,40 +11,45 @@ RSpec.describe SimpleCovMcp::Commands::UncoveredCommand do
   before do
     cli_context.config.root = root
     cli_context.config.resultset = 'coverage'
-    cli_context.config.json = false
+    cli_context.config.format = :table
     cli_context.config.source_mode = nil
   end
 
   describe '#execute' do
-    it 'prints uncovered line numbers with the summary' do
-      output = nil
+    context 'with table format' do
+      it 'prints uncovered line numbers with the summary' do
+        output = capture_command_output(command, ['lib/bar.rb'])
 
-      silence_output do |stdout, _stderr|
-        command.execute(['lib/foo.rb'])
-        output = stdout.string
+        expect(output).to include('│', 'lib/bar.rb', '33.33%')
       end
-
-      expect(output).to include('File:            lib/foo.rb')
-      expect(output).to include('Uncovered lines: 2')
-      # Example match: "Summary:         66.67%       2/3"
-      expect(output).to match(/Summary:\s+66\.67%.*2\/3/)
     end
 
-    it 'emits JSON when requested, including stale metadata' do
-      cli_context.config.json = true
-      stub_staleness_check('L')
+    context 'when the file is fully covered' do
+      before do
+        mock_presenter(
+          SimpleCovMcp::Presenters::CoverageUncoveredPresenter,
+          absolute_payload: {
+            'file' => 'lib/perfect.rb',
+            'uncovered' => [],
+            'summary' => { 'covered' => 10, 'total' => 10, 'percentage' => 100.0 }
+          },
+          relative_path: 'lib/perfect.rb'
+        )
+      end
+
+      it 'prints a success message instead of a table' do
+        output = capture_command_output(command, ['lib/perfect.rb'])
 
-      json_output = nil
-      silence_output do |stdout, _stderr|
-        command.execute(['lib/foo.rb'])
-        json_output = stdout.string
+        expect(output).to include('All lines covered!', '100.00%')
+        expect(output).not_to include('│')
       end
+    end
+
+    context 'with stale data' do
+      before { stub_staleness_check('L') }
 
-      payload = JSON.parse(json_output)
-      expect(payload['file']).to eq('lib/foo.rb')
-      expect(payload['uncovered']).to eq([2])
-      expect(payload['summary']).to include('covered' => 2, 'total' => 3, 'pct' => 66.67)
-      expect(payload['stale']).to eq('L')
+      it_behaves_like 'a command with formatted output', ['lib/foo.rb'],
+        { 'file' => 'lib/foo.rb', 'uncovered' => [2], 'summary' => nil, 'stale' => 'L' }
     end
   end
 end