simplecov-mcp 0.3.0 → 1.0.0

data/spec/file_based_mcp_tools_spec.rb

@@ -0,0 +1,99 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require_relative 'shared_examples/file_based_mcp_tools'
+
+# Load all the tool classes that will be tested
+require 'simplecov_mcp/tools/coverage_summary_tool'
+require 'simplecov_mcp/tools/coverage_raw_tool'
+require 'simplecov_mcp/tools/uncovered_lines_tool'
+require 'simplecov_mcp/tools/coverage_detailed_tool'
+
+RSpec.describe 'File-based MCP Tools' do
+  # Test each file-based tool using the shared example with its specific configuration
+  FILE_BASED_TOOL_CONFIGS.each do |tool_name, config|
+    describe config[:tool_class] do
+      it_behaves_like 'a file-based MCP tool', config
+    end
+  end
+
+  # Test that all file-based tools handle the same parameters consistently
+  describe 'parameter consistency' do
+    let(:server_context) { instance_double('ServerContext').as_null_object }
+
+    before do
+      setup_mcp_response_stub
+    end
+
+    it 'all file-based tools accept the same basic parameters' do
+      # Test that all tools can be called with the same parameter signature
+      FILE_BASED_TOOL_CONFIGS.each do |tool_name, config|
+        model = instance_double(SimpleCovMcp::CoverageModel)
+        allow(SimpleCovMcp::CoverageModel).to receive(:new).and_return(model)
+        allow(model).to receive(config[:model_method]).and_return(config[:mock_data])
+        allow(model).to receive(:relativize) { |payload| payload }
+        allow(model).to receive(:staleness_for).and_return(false)
+
+        expect do
+          config[:tool_class].call(
+            path: 'lib/example.rb',
+            root: '.',
+            resultset: 'coverage',
+            server_context: server_context
+          )
+        end.not_to raise_error
+      end
+    end
+
+    it 'all file-based tools return JSON resources with consistent structure' do
+      FILE_BASED_TOOL_CONFIGS.each do |tool_name, config|
+        model = instance_double(SimpleCovMcp::CoverageModel)
+        allow(SimpleCovMcp::CoverageModel).to receive(:new).and_return(model)
+        allow(model).to receive(config[:model_method]).and_return(config[:mock_data])
+        allow(model).to receive(:relativize) { |payload| payload }
+        allow(model).to receive(:staleness_for).and_return(false)
+
+        response = config[:tool_class].call(path: 'lib/foo.rb', server_context: server_context)
+
+        # All should have the same basic MCP text structure
+        expect(response.payload).to be_an(Array)
+        expect(response.payload.first['type']).to eq('text')
+        expect(response.payload.first).to have_key('text')
+
+        # All should return valid JSON
+        expect { JSON.parse(response.payload.first['text']) }.not_to raise_error
+      end
+    end
+  end
+
+  # Performance/behavior comparison tests
+  describe 'cross-tool consistency' do
+    let(:server_context) { instance_double('ServerContext').as_null_object }
+
+    before do
+      setup_mcp_response_stub
+    end
+
+    it 'tools that include summary data return consistent summary format' do
+      summary_tools = FILE_BASED_TOOL_CONFIGS.select do |_, config|
+        config[:expected_keys].include?('summary')
+      end
+
+      summary_tools.each do |tool_name, config|
+        model = instance_double(SimpleCovMcp::CoverageModel)
+        allow(SimpleCovMcp::CoverageModel).to receive(:new).and_return(model)
+        allow(model).to receive(config[:model_method]).and_return(config[:mock_data])
+        allow(model).to receive(:relativize) { |payload| payload }
+        allow(model).to receive(:staleness_for).and_return(false)
+
+        response = config[:tool_class].call(path: 'lib/foo.rb', server_context: server_context)
+        data = JSON.parse(response.payload.first['text'])
+
+        if data.key?('summary')
+          expect(data['summary']).to include('covered', 'total', 'pct')
+          expect(data['summary']['pct']).to be_a(Numeric)
+        end
+      end
+    end
+  end
+end

data/spec/fixtures/project1/lib/bar.rb

@@ -1,4 +1,3 @@
 puts 'bar line 1 (uncovered)'
 puts 'bar line 2 (uncovered)'
 puts 'bar line 3'
-

data/spec/fixtures/project1/lib/foo.rb

@@ -2,4 +2,3 @@ puts 'foo line 1'
 puts 'foo line 2 (uncovered)'
 
 puts 'foo line 4'
-

data/spec/help_tool_spec.rb

@@ -1,21 +1,13 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'simple_cov_mcp/tools/help_tool'
+require 'simplecov_mcp/tools/help_tool'
 
 RSpec.describe SimpleCovMcp::Tools::HelpTool do
   let(:server_context) { instance_double('ServerContext').as_null_object }
 
   before do
-    response_class = Class.new do
-      attr_reader :payload, :meta
-
-      def initialize(payload)
-        @payload = payload
-        @meta = nil
-      end
-    end
-    stub_const('MCP::Tool::Response', response_class)
+    setup_mcp_response_stub
   end
 
   it 'returns guidance for each registered tool' do
@@ -23,24 +15,26 @@ RSpec.describe SimpleCovMcp::Tools::HelpTool do
     expect(response.meta).to be_nil
 
     payload = response.payload.first
-    expect(payload['type']).to eq('resource')
-    expect(payload['resource']).to include('mimeType' => 'application/json')
-    data = JSON.parse(payload['resource']['text'])
+    expect(payload['type']).to eq('text')
+    data = JSON.parse(payload['text'])
     tool_names = data['tools'].map { |entry| entry['tool'] }
 
-    expect(tool_names).to include('coverage_summary_tool', 'uncovered_lines_tool', 'all_files_coverage_tool', 'coverage_table_tool', 'version_tool')
+    expect(tool_names).to include('coverage_summary_tool', 'uncovered_lines_tool',
+      'all_files_coverage_tool', 'coverage_table_tool', 'version_tool')
     expect(data['tools']).to all(include('use_when', 'avoid_when', 'inputs', 'example'))
   end
 
   it 'filters entries when a query is provided' do
     response = described_class.call(query: 'uncovered', server_context: server_context)
     payload = response.payload.first
-    expect(payload['type']).to eq('resource')
-    data = JSON.parse(payload['resource']['text'])
+    expect(payload['type']).to eq('text')
+    data = JSON.parse(payload['text'])
 
     expect(data['tools']).not_to be_empty
     expect(data['tools']).to all(satisfy do |entry|
-      combined = [entry['tool'], entry['label'], entry['use_when'], entry['avoid_when']].compact.join(' ').downcase
+      combined =
+        [entry['tool'], entry['label'], entry['use_when'], entry['avoid_when']]
+        .compact.join(' ').downcase
       combined.include?('uncovered')
     end)
     expect(data['tools'].map { |entry| entry['tool'] }).to include('uncovered_lines_tool')