simple_workflow 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7b0aaefffccf2f6cae0b554c08bdfdd59535a2a2
-  data.tar.gz: 8be9945fb088a813a4e79c83378137957f99c924
+  metadata.gz: 98730ae8a0dc257bc752e21b17522e68077937be
+  data.tar.gz: 4ba378f8a83519a7ac7cbf218dd7ead4c85c39ff
 SHA512:
-  metadata.gz: 5b82cee1cbdfe7841ca5f22dc0bb885e321c287d1da1e12d727d66a76dabd5e84dcbb32f1d5adf56d02879b090f961d679a90401b15737f39687837b35bd5f55
-  data.tar.gz: 89fcca43ee312be2d4e188b8bddc5c60996eaba10778eb0d07da7d4e9e7460169a2dac1d1c022b0735b8805cd5d935afe532c38b97c335f5cbdc67e0c3a66e9a
+  metadata.gz: 0603ef92e165afcf6c7cc25cbc26f4a9ddfb34ab5e8f9a952dcc079377ce9dfbe27e7690880e30a838ff99f364f927aa45d39048f371625113495c54fc0d8762
+  data.tar.gz: 2608dc6a44158c2f4d780038882fe7984dd8f0502cecdf72be9f3feed8965b4e12660293e6cca6bf63da161f94841e11665853f939bc8be17c1fb134c1c2f600

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    simple_workflow (1.1.0)
+    simple_workflow (1.1.1)
       rails (~> 4.0)
 
 GEM
@@ -46,6 +46,7 @@ GEM
     arel (6.0.3)
     builder (3.2.2)
     concurrent-ruby (1.0.1)
+    concurrent-ruby (1.0.1-java)
     docile (1.1.5)
     erubis (2.7.0)
     globalid (0.3.6)
@@ -69,6 +70,7 @@ GEM
       ruby-progressbar
     nokogiri (1.6.7.2)
       mini_portile2 (~> 2.0.0.rc2)
+    nokogiri (1.6.7.2-java)
     rack (1.6.4)
     rack-test (0.6.3)
       rack (>= 1.0)
@@ -112,6 +114,7 @@ GEM
       sprockets (>= 3.0.0)
     thor (0.19.1)
     thread_safe (0.3.5)
+    thread_safe (0.3.5-java)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
 

data/History.rdoc

@@ -1,6 +1,13 @@
+== 1.1.1 2016-04-17
+
+=== Fixes
+
+* Fix location of `reset_workflow` method
+
+
 == 1.1.0 2016-04-17
 
-=== Feature
+=== Features
 
 * Rewrite as Rails Engine middleware
 * Add support for Ruby 2.3 and JRuby 9000

data/README.md

@@ -1,6 +1,7 @@
 simple_workflow
 ===============
 
+[![Gem Version](https://badge.fury.io/rb/simple_workflow.svg)](https://badge.fury.io/rb/simple_workflow)
 [![Build Status](https://travis-ci.org/donv/simple_workflow.svg?branch=master)](https://travis-ci.org/donv/simple_workflow)
 
 * http://github.com/donv/simple_workflow
@@ -58,7 +59,7 @@ or in Gemfile
 
 (The MIT License)
 
-Copyright (c) 2009-2012 Uwe Kubosch
+Copyright (c) 2009-2016 Uwe Kubosch
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/lib/simple_workflow/controller.rb

@@ -67,14 +67,10 @@ module SimpleWorkflow::Controller
     return nil unless detours
     detour = detours.pop
     logger.debug "popped detour: #{detour.inspect} #{session[:detours].size} more"
-    reset_workflow if detours.empty?
+    reset_workflow(session) if detours.empty?
     detour
   end
 
-  def reset_workflow
-    session.delete(:detours)
-  end
-
   def redirect_to_post(options)
     url = url_for options
     render :text => <<EOF, :layout => false

data/lib/simple_workflow/detour.rb

@@ -8,4 +8,8 @@ module SimpleWorkflow::Detour
     session[:detours] << options
     Rails.logger.try(:debug, "Added detour (#{session[:detours].try(:size) || 0}): #{options.inspect}")
   end
+
+  def reset_workflow(session)
+    session.delete(:detours)
+  end
 end

data/lib/simple_workflow/middleware.rb

@@ -51,7 +51,7 @@ class SimpleWorkflow::Middleware
         break unless ws >= 2048 || (ss >= 3072 && session[:detours] && session[:detours].size > 0)
         Rails.logger.warn "Workflow too large (#{ws}/#{ss}).  Dropping oldest detour."
         session[:detours].shift
-        reset_workflow if session[:detours].empty?
+        reset_workflow(session) if session[:detours].empty?
       end
       Rails.logger.debug "session: #{ss} bytes, workflow(#{session[:detours].try(:size) || 0}): #{ws} bytes"
     end

data/lib/simple_workflow/version.rb

@@ -1,3 +1,3 @@
 module SimpleWorkflow
-  VERSION = '1.1.0'
+  VERSION = '1.1.1'
 end

data/test/middleware_test.rb

@@ -60,6 +60,18 @@ class MiddlewareTest < MiniTest::Test
         env['rack.session'].to_hash['detours'])
   end
 
+  def test_huge_detour_over_4k
+    query = "/orders/TeYphD2wcYyBDFaKTnmAog/edit?detour%5Baction%5D=index&detour%5Bcommit%5D=Search&detour%5Bcontroller%5D=order_drilldown&detour%5Bdrilldown_search%5D%5Bdimensions%5D%5B%5D=arrival&detour%5Bdrilldown_search%5D%5Bdimensions%5D%5B%5D=delay&detour%5Bdrilldown_search%5D%5Bdisplay_type%5D=NONE&detour%5Bdrilldown_search%5D%5Bfields%5D%5Bactual_time%5D=1&detour%5Bdrilldown_search%5D%5Bfields%5D%5Bcomments%5D=1&detour%5Bdrilldown_search%5D%5Bfields%5D%5Bdelay%5D=1&detour%5Bdrilldown_search%5D%5Bfields%5D%5Bdescription%5D=1&detour%5Bdrilldown_search%5D%5Bfields%5D%5Bdirection%5D=0&detour%5Bdrilldown_search%5D%5Bfields%5D%5Bdrop_off_stand%5D=0&detour%5Bdrilldown_search%5D%5Bfields%5D%5Bestimated%5D=1&detour%5Bdrilldown_search%5D%5Bfields%5D%5Bfirst_vehicle%5D=1&detour%5Bdrilldown_search%5D%5Bfields%5D%5Bofb%5D=0&detour%5Bdrilldown_search%5D%5Bfields%5D%5Bonb%5D=0&detour%5Bdrilldown_search%5D%5Bfields%5D%5Boperation%5D=0&detour%5Bdrilldown_search%5D%5Bfields%5D%5Bpick_up%5D=1&detour%5Bdrilldown_search%5D%5Bfields%5D%5Bpick_up_stand%5D=0&detour%5Bdrilldown_search%5D%5Bfields%5D%5Bplanned%5D=0&detour%5Bdrilldown_search%5D%5Bfields%5D%5Bprobable%5D=1&detour%5Bdrilldown_search%5D%5Bfields%5D%5Bscheduled%5D=1&detour%5Bdrilldown_search%5D%5Bfields%5D%5Bsta%5D=0&detour%5Bdrilldown_search%5D%5Bfields%5D%5Btime%5D=0&detour%5Bdrilldown_search%5D%5Bfilter%5D%5Barrival%5D%5B%5D=Arrival&detour%5Bdrilldown_search%5D%5Bfilter%5D%5Barrival%5D%5B%5D=Departure&detour%5Bdrilldown_search%5D%5Bfilter%5D%5Bcalendar_date%5D%5B%5D=2016-03-01&detour%5Bdrilldown_search%5D%5Blist%5D=1&detour%5Bdrilldown_search%5D%5Blist_change_times%5D=0&detour%5Bdrilldown_search%5D%5Border_by_value%5D=0&detour%5Bdrilldown_search%5D%5Bpercent%5D=1&detour%5Bdrilldown_search%5D%5Bselect_value%5D=COUNT&detour%5Bdrilldown_search%5D%5Btitle%5D=OSL+Daily+Delay+Report+2016-04-16#{'+etc' * 200}&detour%5Butf8%5D=%E2%9C%93"
+    env = env_for(query)
+
+    status, headers, response = @stack.call env
+
+    assert_equal 200, status
+    assert_equal(env, headers)
+    assert_equal 'app response', response
+    assert_equal(%w(session_id), headers['rack.session'].to_hash.keys)
+  end
+
   private
 
   def env_for(url, opts={})

data/test/test_app.rb

@@ -3,7 +3,7 @@ require 'rails'
 class TestApp < Rails::Application
   config.action_dispatch.cookies_serializer = :json
   config.action_dispatch.key_generator = ActiveSupport::KeyGenerator.new('secret')
-  config.logger = Logger.new('log/test.log')
+  config.logger = Logger.new(File.expand_path('../log/test.log', __dir__))
   config.secret_key_base = 'secret key base'
   # config.secret_token = 'secret token'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simple_workflow
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Uwe Kubosch