simple_wallet 0.1.2 → 0.1.3

data/test/services/transfer_service_test.rb

@@ -0,0 +1,193 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+describe SimpleWallet::TransferService do
+  let(:from_account) { create(:simple_wallet_account) }
+  let(:to_account) { create(:simple_wallet_account) }
+
+  let(:amount) { 25 }
+  let(:note) { "Here is your alms." }
+
+  let(:transfer) do
+    SimpleWallet::TransferService.new(
+      from: from_account,
+      to: to_account,
+      amount: amount,
+      note: note
+    )
+  end
+
+  before do
+    SimpleWallet::AccountCreditingService.new(
+      account: from_account,
+      amount: +1_000_000,
+      note: "AI income"
+    ).credit
+
+    from_account&.reload
+  end
+
+  describe "Validation" do
+    describe "when from account is blank" do
+      let(:from_account) { nil }
+
+      it "returns false and adds an error" do
+        refute transfer.transfer
+        assert_includes transfer.errors[:from], "can't be blank"
+      end
+    end
+
+    describe "when to account is blank" do
+      let(:to_account) { nil }
+
+      it "returns false and adds an error" do
+        refute transfer.transfer
+        assert_includes transfer.errors[:to], "can't be blank"
+      end
+    end
+
+    describe "when amount is zero" do
+      let(:amount) { 0 }
+
+      it "returns false and adds an error" do
+        refute transfer.transfer
+        assert_includes transfer.errors[:amount], "must be greater than 0"
+      end
+    end
+
+    describe "when amount is negative" do
+      let(:amount) { -35 }
+
+      it "returns false and adds an error" do
+        refute transfer.transfer
+        assert_includes transfer.errors[:amount], "must be greater than 0"
+      end
+    end
+
+    describe "when amount is greater than :from account balance" do
+      let(:amount) { from_account.balance + 5 }
+
+      it "returns false and adds an error" do
+        refute transfer.transfer
+        assert_includes transfer.errors[:amount], "exceeds available balance"
+      end
+    end
+
+    describe "when note is blank" do
+      let(:note) { "" }
+
+      it "returns false and adds an error" do
+        refute transfer.transfer
+        assert_includes transfer.errors[:note], "can't be blank"
+      end
+    end
+  end
+
+  describe "#transfer" do
+    describe "when operation is valid" do
+      it "creates debiting transfer for :from account and crediting transfer to :to account" do
+        assert_difference -> { from_account.transactions.count }, 1 do
+          assert_difference -> { to_account.transactions.count }, 1 do
+            assert transfer.transfer
+          end
+        end
+
+        from_account.transactions.last.tap do |transaction|
+          assert_equal "SimpleWallet::Transaction::Debit", transaction.type
+          assert_nil transaction.source
+          assert_equal -25, transaction.amount
+          assert_equal 1000000, transaction.pre_account_balance
+          assert_equal "Here is your alms.", transaction.note
+        end
+
+        to_account.transactions.last.tap do |transaction|
+          assert_equal "SimpleWallet::Transaction::Credit", transaction.type
+          assert_nil transaction.source
+          assert_equal 25, transaction.amount
+          assert_equal 0, transaction.pre_account_balance
+          assert_equal "Here is your alms.", transaction.note
+        end
+      end
+
+      it "tells accounts to recalculate their balances" do
+        assert_equal 1_000_000, from_account.reload.balance
+        assert_equal 0, to_account.reload.balance
+
+        assert transfer.transfer
+
+        assert_equal 999975, from_account.reload.balance
+        assert_equal 25, to_account.reload.balance
+      end
+    end
+
+    describe "when operation is not valid" do
+      let(:note) { "" }
+
+      it "doesn't create new transfer transaction for any account" do
+        assert_no_difference(-> { from_account.transactions.count }) do
+          assert_no_difference(-> { to_account.transactions.count }) do
+            refute transfer.transfer
+          end
+        end
+      end
+
+      it "doesn't change any account's balance" do
+        assert_no_changes(-> { from_account.reload.balance }) do
+          assert_no_changes(-> { to_account.reload.balance }) do
+            refute transfer.transfer
+          end
+        end
+      end
+    end
+
+    describe "when something goes wrong when we credit :to account" do
+      before do
+        # Let's break something to simulate this:
+        transfer.send(:crediting_service).send(:crediting_transaction).note = ""
+      end
+
+      it "doesn't create new transfer transaction for any account" do
+        assert_no_difference(-> { from_account.transactions.count }) do
+          assert_no_difference(-> { to_account.transactions.count }) do
+            refute transfer.transfer
+          end
+        end
+
+        assert_includes transfer.errors[:note], "can't be blank"
+      end
+
+      it "doesn't change any account's balance" do
+        assert_no_changes(-> { from_account.reload.balance }) do
+          assert_no_changes(-> { to_account.reload.balance }) do
+            refute transfer.transfer
+          end
+        end
+
+        assert_includes transfer.errors[:note], "can't be blank"
+      end
+    end
+
+    describe "when unexpected error happens" do
+      it "doesn't create new transactions for any account" do
+        transfer.stub(:after_operation, ->(*args) { raise "Oops" }) do
+          assert_no_difference(-> { from_account.transactions.count }) do
+            assert_no_difference(-> { to_account.transactions.count }) do
+              assert_raises(RuntimeError) { transfer.transfer }
+            end
+          end
+        end
+      end
+
+      it "doesn't change any account's balance" do
+        transfer.stub(:after_operation, ->(*args) { raise "Oops" }) do
+          assert_no_changes(-> { from_account.reload.balance }) do
+            assert_no_changes(-> { to_account.reload.balance }) do
+              assert_raises(RuntimeError) { transfer.transfer }
+            end
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simple_wallet
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Marcin Urbanski
@@ -41,6 +41,7 @@ files:
 - app/services/simple_wallet/account_crediting_service.rb
 - app/services/simple_wallet/account_debiting_service.rb
 - app/services/simple_wallet/service.rb
+- app/services/simple_wallet/transfer_service.rb
 - config/locales/simple_wallet.en.yml
 - db/migrate/20260329170901_create_simple_wallet_account.rb
 - db/migrate/20260329181402_create_simple_wallet_transactions.rb
@@ -96,6 +97,7 @@ files:
 - test/models/transaction/debit_test.rb
 - test/services/account_crediting_service_test.rb
 - test/services/account_debiting_service_test.rb
+- test/services/transfer_service_test.rb
 - test/test_helper.rb
 homepage: https://github.com/murbanski/simple_wallet
 licenses:
@@ -171,4 +173,5 @@ test_files:
 - test/models/transaction/debit_test.rb
 - test/services/account_crediting_service_test.rb
 - test/services/account_debiting_service_test.rb
+- test/services/transfer_service_test.rb
 - test/test_helper.rb