simple_wallet 0.1.1 → 0.1.2

data/test/services/account_crediting_service_test.rb

@@ -0,0 +1,113 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+describe SimpleWallet::AccountCreditingService do
+  let(:account) { create(:simple_wallet_account) }
+  let(:amount) { 35 }
+  let(:note) { "My custom transaction note" }
+
+  let(:crediting) do
+    SimpleWallet::AccountCreditingService.new(
+      account: account,
+      amount: amount,
+      note: note,
+    )
+  end
+
+  describe "Validation" do
+    describe "when account is blank" do
+      let(:account) { nil }
+
+      it "returns false and adds an error" do
+        refute crediting.credit
+        assert_includes crediting.errors[:account], "can't be blank"
+      end
+    end
+
+    describe "when amount is zero" do
+      let(:amount) { 0 }
+
+      it "returns false and adds an error" do
+        refute crediting.credit
+        assert_includes crediting.errors[:amount], "must be greater than 0"
+      end
+    end
+
+    describe "when amount is negative" do
+      let(:amount) { -35 }
+
+      it "returns false and adds an error" do
+        refute crediting.credit
+        assert_includes crediting.errors[:amount], "must be greater than 0"
+      end
+    end
+
+    describe "when note is blank along with source" do
+      let(:note) { "" }
+
+      it "returns false and adds an error" do
+        refute crediting.credit
+        assert_includes crediting.errors[:note], "can't be blank"
+      end
+    end
+  end
+
+  describe "#credit" do
+    describe "when operation is valid" do
+      it "creates new Credit transaction for given account" do
+        assert_difference -> { account.transactions.count }, 1 do
+          assert crediting.credit
+        end
+
+        account.transactions.last.tap do |transaction|
+          assert_equal "SimpleWallet::Transaction::Credit", transaction.type
+          assert_nil transaction.source
+          assert_equal 35, transaction.amount
+          assert_equal 0, transaction.pre_account_balance
+          assert_equal "My custom transaction note", transaction.note
+        end
+      end
+
+      it "tells account to recalculate its balance" do
+        assert_equal 0, account.reload.balance
+        assert crediting.credit
+        assert_equal 35, account.reload.balance
+      end
+    end
+
+    describe "when operation is not valid" do
+      let(:note) { "" }
+
+      it "doesn't create new Credit transaction for given account" do
+        assert_no_difference(-> { account.transactions.count }) do
+          refute crediting.credit
+        end
+      end
+
+      it "doesn't change account's balance" do
+        assert_no_difference(-> { account.reload.balance }) do
+          refute crediting.credit
+        end
+      end
+    end
+
+    describe "when unexpected error happens" do
+      it "doesn't create new Credit transaction for given account" do
+        crediting.stub(:after_operation, ->(*args) { raise "Oops" }) do
+          assert_no_difference(-> { account.transactions.count }) do
+            assert_raises(RuntimeError) { crediting.credit }
+          end
+        end
+      end
+
+      it "doesn't change account's balance" do
+        crediting.stub(:after_operation, ->(*args) { raise "Oops" }) do
+          assert_no_changes(-> { account.reload.balance }) do
+            assert_raises(RuntimeError) { crediting.credit }
+          end
+        end
+      end
+    end
+  end
+end

data/test/services/account_debiting_service_test.rb

@@ -0,0 +1,158 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+describe SimpleWallet::AccountDebitingService do
+  let(:account) { create(:simple_wallet_account) }
+  let(:amount) { 35 }
+  let(:note) { "My custom transaction note" }
+
+  let(:debiting) do
+    SimpleWallet::AccountDebitingService.new(
+      account: account,
+      amount: amount,
+      note: note,
+    )
+  end
+
+  before do
+    SimpleWallet::AccountCreditingService.new(
+      account: account,
+      amount: +100,
+      note: "Bonus!"
+    ).credit
+
+    account&.reload
+  end
+
+  describe "Validation" do
+    describe "when account is blank" do
+      let(:account) { nil }
+
+      it "returns false and adds an error" do
+        refute debiting.debit
+        assert_includes debiting.errors[:account], "can't be blank"
+      end
+    end
+
+    describe "when account has no sufficient funds" do
+      let(:amount) { 500 }
+
+      it "returns false and adds an error" do
+        refute debiting.debit
+        assert_includes debiting.errors[:amount], "exceeds available balance"
+      end
+    end
+
+    describe "when amount is zero" do
+      let(:amount) { 0 }
+
+      it "returns false and adds an error" do
+        refute debiting.debit
+        assert_includes debiting.errors[:amount], "must be greater than 0"
+      end
+    end
+
+    describe "when amount is negative" do
+      let(:amount) { -35 }
+
+      it "returns false and adds an error" do
+        refute debiting.debit
+        assert_includes debiting.errors[:amount], "must be greater than 0"
+      end
+    end
+
+    describe "when note is blank along with source" do
+      let(:note) { "" }
+
+      it "returns false and adds an error" do
+        refute debiting.debit
+        assert_includes debiting.errors[:note], "can't be blank"
+      end
+    end
+  end
+
+  describe "#debit" do
+    describe "when operation is valid" do
+      it "creates new debit transaction for given account and source" do
+        assert_difference -> { account.transactions.count }, 1 do
+          assert debiting.debit
+        end
+
+        assert debiting.debit
+        account.transactions.last.tap do |transaction|
+          assert_equal "SimpleWallet::Transaction::Debit", transaction.type
+          assert_nil transaction.source
+          assert_equal -35, transaction.amount
+          assert_equal 100, transaction.pre_account_balance
+          assert_equal "My custom transaction note", transaction.note
+        end
+      end
+
+      it "tells account to recalculate its balance" do
+        assert_equal 100, account.reload.balance
+        assert debiting.debit
+        assert_equal 65, account.reload.balance
+      end
+
+      describe "when :up_to_account_balance option is set and we try to debit more than account's balance" do
+        let(:debiting) do
+          SimpleWallet::AccountDebitingService.new(
+            account: account,
+            amount: 250,
+            note: "Penalty for cheating!",
+            up_to_account_balance: true
+          )
+        end
+
+        it "creates new debit transaction with amount up to SimpleWallet's balance" do
+          assert_difference -> { account.transactions.count }, 1 do
+            assert debiting.debit
+          end
+
+          account.transactions.last.tap do |transaction|
+            assert_equal "SimpleWallet::Transaction::Debit", transaction.type
+            assert_nil transaction.source
+            assert_equal -100, transaction.amount
+            assert_equal 100, transaction.pre_account_balance
+            assert_equal "Penalty for cheating!", transaction.note
+          end
+        end
+      end
+    end
+  end
+
+  describe "when operation is not valid" do
+    let(:amount) { 500 }
+
+    it "doesn't create new debit transaction for given account" do
+      assert_no_difference(-> { account.transactions.count }) do
+        refute debiting.debit
+      end
+    end
+
+    it "doesn't change account's balance" do
+      assert_no_difference(-> { account.reload.balance }) do
+        refute debiting.debit
+      end
+    end
+  end
+
+  describe "when unexpected error happens" do
+    it "doesn't create new debit transaction for given account" do
+      debiting.stub(:after_operation, ->(*args) { raise "Oops" }) do
+        assert_no_difference(-> { account.transactions.count }) do
+          assert_raises(RuntimeError) { debiting.debit }
+        end
+      end
+    end
+
+    it "doesn't change account's balance" do
+      debiting.stub(:after_operation, ->(*args) { raise "Oops" }) do
+        assert_no_changes(-> { account.reload.balance }) do
+          assert_raises(RuntimeError) { debiting.debit }
+        end
+      end
+    end
+  end
+end

data/test/test_helper.rb

@@ -12,6 +12,7 @@ FactoryBot.find_definitions
 
 class Minitest::Test
   include FactoryBot::Syntax::Methods
+  include ActiveSupport::Testing::Assertions
 end
 
 Shoulda::Matchers.configure do |config|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simple_wallet
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Marcin Urbanski
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-04-05 00:00:00.000000000 Z
+date: 2026-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -38,6 +38,10 @@ files:
 - app/models/simple_wallet/transaction.rb
 - app/models/simple_wallet/transaction/credit.rb
 - app/models/simple_wallet/transaction/debit.rb
+- app/services/simple_wallet/account_crediting_service.rb
+- app/services/simple_wallet/account_debiting_service.rb
+- app/services/simple_wallet/service.rb
+- config/locales/simple_wallet.en.yml
 - db/migrate/20260329170901_create_simple_wallet_account.rb
 - db/migrate/20260329181402_create_simple_wallet_transactions.rb
 - lib/simple_wallet.rb
@@ -90,6 +94,8 @@ files:
 - test/models/account_test.rb
 - test/models/transaction/credit_test.rb
 - test/models/transaction/debit_test.rb
+- test/services/account_crediting_service_test.rb
+- test/services/account_debiting_service_test.rb
 - test/test_helper.rb
 homepage: https://github.com/murbanski/simple_wallet
 licenses:
@@ -163,4 +169,6 @@ test_files:
 - test/models/account_test.rb
 - test/models/transaction/credit_test.rb
 - test/models/transaction/debit_test.rb
+- test/services/account_crediting_service_test.rb
+- test/services/account_debiting_service_test.rb
 - test/test_helper.rb