simple_update_field 1.2.0 → 2.0.0

data/README.creole

@@ -21,7 +21,7 @@ based resource calls.
 }}}
 * You will need to re-start a running server for the Gemfile change to take effect
 === View Side
-* There are 3 custom attributes that will be used. An Example follows
+* There are 3 custom attributes on a *span* that will be used. An Example follows
 {{{
 <div class='phrase'>
       <span editable-resource-attribute="text"
@@ -86,6 +86,7 @@ There are 2 steps to integration with javascript.
 //= require simple_update_field
 }}}
 * The second step is to invoke the the Simple Update Field on the appropriate elements
+** this can be done in application.js aswell or in a new file in the app/assets/javascript directory
 ** A CSS selector of the jQuery style is assumed.
 ## For the above Phrase view code this could work :
 {{{
@@ -102,7 +103,7 @@ $(document).ready(function() {
 
 
 == Roadmap
-
+* Have it work for any element without modifying structure (ie needs no wrapper)
 * form field helper
 * error handling of ajax call
 

data/VERSION

@@ -1 +1 @@
-1.2.0
+2.0.0

data/simple_update_field.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "simple_update_field"
-  s.version = "1.2.0"
+  s.version = "2.0.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Curtis Schofield"]
-  s.date = "2012-04-25"
+  s.date = "2012-04-27"
   s.description = "Your resources text attributes will gain inplace update ability with keybindings for quick editing"
   s.email = "curtis@ram9.cc"
   s.extra_rdoc_files = [

data/vendor/assets/javascripts/simple_update_field.js

@@ -1,38 +1,39 @@
 SimpleUpdateField = function(selector) {
   var self = this
   self.selector = selector
-
-  var create_tag_with = function(tag_name,node) {
-    var elem = $('<'+tag_name+'/>');
-    var attributes = node.get(0).attributes
-    for(var i = attributes.length-1; i >=0;i--) {
-      elem.attr(attributes[i].nodeName, attributes[i].nodeValue)
+  self.current_input = function () {
+    var last_clicked = $(self.selector + ' > input')
+    if (last_clicked.size() == 0) {
+      return null
+    } else {
+      return last_clicked
     }
-
-    elem.data(node.data())
-    elem.data('editable-was',node.get(0).tagName)
-
-    node.replaceWith(function() {
-      return elem
-    })
-    return elem
   }
+  // Given a node with text() create an input that has the nodes text as it's value
+  // and record a memo about what the original-text is 
+  //
+  var create_input_from = function(node) {
 
-  var replace_input_from = function(node) {
-    var element = create_tag_with('input',node)
-
-    element.data('original-text',node.text())
-    element.val(node.text().trim())
-
-    return element
+    var input_node = $("<input/>")
+    var attributes = node.get(0).attributes
+    for(var i = attributes.length-1; i >=0; i--) {
+      if(attributes[i].nodeName.indexOf('editable') == 0) {
+        input_node.attr(attributes[i].nodeName, attributes[i].nodeValue)
+      }
+    }
+    input_node.data('original-text',node.text())
+    input_node.val(node.text().trim())
 
+    return input_node
   }
 
   self.begin_edit_event = function(event) {
       var clicked_node = $(this);
-      var new_node = replace_input_from(clicked_node);
-      install_edit_complete_notions(new_node)
-      new_node.focus();
+      var input_node = create_input_from(clicked_node);
+      clicked_node.text("")
+      clicked_node.append(input_node)
+      install_edit_complete_notions(input_node)
+      input_node.focus();
   }
   var is_rollback_changes  = function() {
     if (self.last_keydown_event) {
@@ -66,10 +67,11 @@ SimpleUpdateField = function(selector) {
     }
   }
   self.rollback_edit_event = function(event) {
-    var finished_node = $(this)
-    var element = create_tag_with(finished_node.data('editable-was'),finished_node)
-    element.text(element.data('original-text'))
-    install_edit_notions(element)
+    var finished_input_node = $(this)
+
+    finished_input_node.parent().text(finished_input_node.data('original-text')) // the input we create had a memo about it's original text
+    finished_input_node.remove() // remove the input field that we created such that the node is unchanged
+
   }
   self.commit_to_remote_resource = function(node) {
     uri        = node.attr('editable-resource-uri')
@@ -82,26 +84,30 @@ SimpleUpdateField = function(selector) {
     data[name][attribute] = node.val().trim()
     $.ajax({url:uri,data:data,type:'PUT'})
   }
+
   self.complete_edit_event = function(event) {
-    
-    var finished_node = $(this)
-    commit_to_remote_resource(finished_node)
-    var element = create_tag_with(finished_node.data('editable-was'),finished_node)
-    element.text(finished_node.val())
-    install_edit_notions(element)
-    
+
+    var finished_input_node = $(this)
+    var parent = finished_input_node.parent();
+
+    commit_to_remote_resource(finished_input_node)
+    parent.text(finished_input_node.val()) // set the elements character data back to text
+
+    finished_input_node.remove() // remove the input field that we created such that the node is unchanged
+
+
     // If tab key was hit during the edit phase
     // we want to redirect this blur to be a click on the next
     // sibling
     if(is_blur_tab_redirect()) {
-      move_to_next_sibling(element)
+      move_to_next_sibling(parent)
     }
 
     // Cleanup - cross event state
     // there was no last keydown event
     self.last_keydown_event = undefined;
   }
-  
+
   var install_edit_notions = function(selector) {
 
     $(selector).bind('click.editable',begin_edit_event)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simple_update_field
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 2.0.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-25 00:00:00.000000000Z
+date: 2012-04-27 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70164641191780 !ruby/object:Gem::Requirement
+  requirement: &70219322332160 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 2.8.0
   type: :development
   prerelease: false
-  version_requirements: *70164641191780
+  version_requirements: *70219322332160
 - !ruby/object:Gem::Dependency
   name: rdoc
-  requirement: &70164641188880 !ruby/object:Gem::Requirement
+  requirement: &70219322329300 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: '3.12'
   type: :development
   prerelease: false
-  version_requirements: *70164641188880
+  version_requirements: *70219322329300
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70164641186320 !ruby/object:Gem::Requirement
+  requirement: &70219322306340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 1.1.0
   type: :development
   prerelease: false
-  version_requirements: *70164641186320
+  version_requirements: *70219322306340
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &70164641165080 !ruby/object:Gem::Requirement
+  requirement: &70219322304760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,7 +54,7 @@ dependencies:
         version: 1.8.3
   type: :development
   prerelease: false
-  version_requirements: *70164641165080
+  version_requirements: *70219322304760
 description: Your resources text attributes will gain inplace update ability with
   keybindings for quick editing
 email: curtis@ram9.cc
@@ -92,7 +92,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2576101730221014213
+      hash: 2017553997290528289
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: