simple_state_machine 0.5.2 → 0.5.3

data/README.rdoc

@@ -74,8 +74,8 @@ You can rescue exceptions and specify the failure state
   event :download_data, :pending => :downloaded,
         Service::ConnectionError => :download_failed
 
-  download_data! # catches Service::ConnectionError
-  state          # => "download_failed"
+  download_data # catches Service::ConnectionError
+  state         # => "download_failed"
 
 === Catching all from states
 If an event should transition from all states you can use :all
@@ -115,6 +115,7 @@ To add a state machine with ActiveRecord persistence:
     end
 
 This generates the following event methods
+- invite
 - invite!
 - confirm_invitation!
 
@@ -124,7 +125,7 @@ And the following methods to query the state:
 - active?
 
 If you want to be more verbose you can also use:
-- invite_and_save  (behave like ActiveRecord save)
+- invite_and_save  (is equal to invite  and behaves like ActiveRecord save)
 - invite_and_save! (is equal to invite! and behaves like save!)
 
 == Mountable Example

data/lib/simple_state_machine/active_record.rb

@@ -10,6 +10,7 @@ module SimpleStateMachine::ActiveRecord
     # * {event_name}_and_save
     # * {event_name}_and_save!
     # * {event_name}!
+    # * {event_name}
     def decorate transition
       super transition
       event_name = transition.event_name.to_s
@@ -30,6 +31,7 @@ module SimpleStateMachine::ActiveRecord
             end
           end
         end
+        @subject.send :alias_method, "#{transition.event_name}", event_name_and_save
       end
       event_name_and_save_bang = "#{event_name_and_save}!"
       unless @subject.method_defined?(event_name_and_save_bang)
@@ -54,11 +56,7 @@ module SimpleStateMachine::ActiveRecord
     protected
 
       def alias_event_methods event_name
-        @subject.send(:define_method, "cannot_call_#{event_name}") do |*args|
-          raise "You cannot call #{event_name}. Use #{event_name}! instead"
-        end
         @subject.send :alias_method, "without_managed_state_#{event_name}", event_name
-        @subject.send :alias_method, event_name, "cannot_call_#{event_name}"
       end
 
       def define_state_setter_method; end

data/lib/simple_state_machine/version.rb

@@ -1,3 +1,3 @@
 module SimpleStateMachine
-  VERSION = "0.5.2"
+  VERSION = "0.5.3"
 end

data/spec/active_record_spec.rb

@@ -164,10 +164,20 @@ describe ActiveRecord do
   end
 
   describe "event" do
+    it "persists transitions" do
+      user = User.create!(:name => 'name')
+      user.invite.should == true
+      User.find(user.id).should be_invited
+      User.find(user.id).activation_code.should_not be_nil
+    end
 
-    it "raises an error" do
+    it "returns false, keeps state and keeps errors if event adds errors" do
       user = User.create!(:name => 'name')
-      expect { user.invite }.to raise_error(RuntimeError, "You cannot call invite. Use invite! instead")
+      user.invite_and_save!
+      user.should be_invited
+      user.confirm_invitation('x').should == false
+      user.should be_invited
+      user.errors.entries.should == [['activation_code', 'is invalid']]
     end
 
   end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: simple_state_machine
 version: !ruby/object:Gem::Version 
-  hash: 15
+  hash: 13
   prerelease: 
   segments: 
   - 0
   - 5
-  - 2
-  version: 0.5.2
+  - 3
+  version: 0.5.3
 platform: ruby
 authors: 
 - Marek de Heus