simple_spark 1.0.5 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d9d658ec10ada82c8d1923eef68a5a4063529801
-  data.tar.gz: 2be52f459b756448defdd33174fb16099a7a96e1
+  metadata.gz: 4fa620f08807116bdbc70379d8700292ff0814c1
+  data.tar.gz: d354432057364db7e46b8501c29d88482745bc42
 SHA512:
-  metadata.gz: 636cb92b6458d45736a125179fef0cbc66eaa82c3d4fa9d25d2a44af2dc6f6da8f974e26e464a69e220723c6f958a6ccc913bb2f2cec707a5df58b33c2b9df63
-  data.tar.gz: e6a60ed21f086e3d44935a20aa83962601ef4460a3af923907469b0298baacb78da2d085247192d23668760e0326944c1f62aba183410554774715af0c95905a
+  metadata.gz: 53d945762da13ff21a69372454fafe0bb40c75b43b2754bbab4c3f15a37e9e8378bba06aac91a33175f7ea51508603877342de6fbf35f03b7f8dfeaa8c433750
+  data.tar.gz: 1dcb853059b6ea5ac9409cbd6d8b1a970c6cbe68560a263905a502e38c4a64c4127837a24bab26024cee4df119fc0a4fef2fd8baead48d4edf74736899170c4e

data/README.md

@@ -522,7 +522,7 @@ simple_spark.sending_domains.list
 Create a new Sending Domain
 
 ```ruby
-simple_spark.sending_domains.create('mail.mydomain.com')
+simple_spark.sending_domains.create({domain: 'mail.mydomain.com'})
 ```
 
 <a href="https://developers.sparkpost.com/api/#/reference/sending-domains/create-and-list" target="_blank">see SparkPost API Documentation</a>
@@ -560,7 +560,7 @@ token(s) against the stored token(s) for the specified sending domain.
 
 ```ruby
 properties = { "dkim_verify": true, "spf_verify": true }
-simple_spark.sending_domains.retrieve('mail.mydomain.com', properties)
+simple_spark.sending_domains.verify('mail.mydomain.com', properties)
 ```
 
 <a href="https://developers.sparkpost.com/api/#/reference/sending-domains/verify" target="_blank">see SparkPost API Documentation</a>
@@ -628,7 +628,7 @@ params = {
   from: '2013-04-20T07:12',
   to: '2018-04-20T07:12'
 }
-simple_spark.suppression_list.create_or_update(params)
+simple_spark.suppression_list.search(params)
 ```
 
 <a href="https://developers.sparkpost.com/api/suppression-list#suppression-list-search-get" target="_blank">see SparkPost API Documentation</a>
@@ -807,6 +807,10 @@ simple_spark.templates.delete(yourtemplateid)
 
 ## Changelog
 
+### 1.0.6
+
+- Exceptions now return SparkPost results object too
+
 ### 1.0.5
 
 - Add Account API Endpoint

data/lib/simple_spark/client.rb

@@ -71,7 +71,7 @@ module SimpleSpark
 
       response_body = JSON.parse(response.body)
       if response_body['errors']
-        Exceptions::Error.fail_with_exception_for_status(response.status, response_body['errors'])
+        Exceptions::Error.fail_with_exception_for_status(response.status, response_body['errors'], response_body['results'])
       else
         if extract_results
           response_body['results'] ? response_body['results'] : {}

data/lib/simple_spark/exceptions.rb

@@ -8,15 +8,20 @@ module SimpleSpark
     #   puts e.object # => { id: '1' }
     # end
     class Error < StandardError
-      attr_reader :object
+      attr_reader :object, :results
 
-      def initialize(object = nil)
+      def initialize(object = nil, results = {})
         @object = object
+        @results = results
+      end
+      
+      def transmission_id
+        results['id']
       end
 
-      def self.fail_with_exception_for_status(status, errors)
+      def self.fail_with_exception_for_status(status, errors, results)
         exception = status_codes[status.to_s] || status_codes['default']
-        fail exception.new(errors), errors.map { |e| "#{e['message']} #{status} (Error Code: #{e['code']})" + (e['description'] ? ": #{e['description']}" : '') }.join(', ')
+        fail exception.new(errors, results), errors.map { |e| "#{e['message']} #{status} (Error Code: #{e['code']})" + (e['description'] ? ": #{e['description']}" : '') }.join(', ')
       end
 
       def self.status_codes

data/lib/simple_spark/version.rb

@@ -1,3 +1,3 @@
 module SimpleSpark
-  VERSION = '1.0.5'
+  VERSION = '1.0.6'
 end

data/spec/simple_spark/exceptions_spec.rb

@@ -4,7 +4,8 @@ describe SimpleSpark::Exceptions::Error do
   describe :fail_with_exception_for_status do
     it 'will respond with the SparkPost error code' do
       errors = [{'message' => "Test Error Message", 'code' => 3005}]
-      expect{SimpleSpark::Exceptions::Error.fail_with_exception_for_status(400, errors)}.to raise_error(SimpleSpark::Exceptions::BadRequest, "Test Error Message 400 (Error Code: 3005)")
+      results = [{"total_rejected_recipients": 1, "total_accepted_recipients": 0, "id": "123" }]
+      expect{SimpleSpark::Exceptions::Error.fail_with_exception_for_status(400, errors, results)}.to raise_error(SimpleSpark::Exceptions::BadRequest, "Test Error Message 400 (Error Code: 3005)")
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simple_spark
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
 platform: ruby
 authors:
 - Jak Charlton
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-12 00:00:00.000000000 Z
+date: 2017-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json