simple_service 2.1.3 → 2.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 80b6b2d5cf8a166fb7c3666d0b71347526a0b9c7
-  data.tar.gz: 1e52375eca8157659afe17c69cf5c053bddde9df
+SHA256:
+  metadata.gz: d3f4dc247883ae9ebda40616abae2ecada0f44e3a81babb3fe8f99f4ddd072cf
+  data.tar.gz: 1c238edcfa08c34cc0fe9d166b2cb9d4c8d8803d2f0b84e26265433bd2bc59d0
 SHA512:
-  metadata.gz: '03186be2699de59c7d3f88d7a1df830fed42ec735c21bfb44f9e0c56678ab8b567097be327f0544adb653cc641db25bcff78f13ee716c6f8b49d2d39710372c4'
-  data.tar.gz: f8437b785fe9419de4b88c74bb40437184ef92a31532f8e23a105fd2be464587aac5f194e12ac542b2151807eedc85f7c9ee6ecfb9a6c341603d8e06093af3d6
+  metadata.gz: 53c0ccac4184ad5be6e3a849b94a1dc5c2fb419937a500db3edbe59762cdd54e23ca1dffa411d5362636683dc9ec6aa3aa2b4a68297cd61e28c59330a2cc36ff
+  data.tar.gz: 0071e4847fa116a5fcbcc8235528a2a630d974c421b21b199bd4f496ebcc508aa8ee5949bc7f7d7974f0dc58ef83a3b2e33a46a5983538400edcdee6c3d93a38

data/.github/workflows/gem-push.yml

@@ -0,0 +1,45 @@
+name: Ruby Gem
+
+on:
+  push:
+    branches: [ "master" ]
+  pull_request:
+    branches: [ "master" ]
+
+jobs:
+  build:
+    name: Build + Publish
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      packages: write
+
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Ruby 2.6
+      uses: actions/setup-ruby@v1
+      with:
+        ruby-version: 2.6.x
+
+    - name: Publish to GPR
+      run: |
+        mkdir -p $HOME/.gem
+        touch $HOME/.gem/credentials
+        chmod 0600 $HOME/.gem/credentials
+        printf -- "---\n:github: ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials
+        gem build *.gemspec
+        gem push --KEY github --host https://rubygems.pkg.github.com/${OWNER} *.gem
+      env:
+        GEM_HOST_API_KEY: "Bearer ${{secrets.GITHUB_TOKEN}}"
+        OWNER: ${{ github.repository_owner }}
+
+    - name: Publish to RubyGems
+      run: |
+        mkdir -p $HOME/.gem
+        touch $HOME/.gem/credentials
+        chmod 0600 $HOME/.gem/credentials
+        printf -- "---\n:rubygems_api_key: ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials
+        gem build *.gemspec
+        gem push *.gem
+      env:
+        GEM_HOST_API_KEY: "${{secrets.RUBYGEMS_AUTH_TOKEN}}"

data/checksums/simple_service-2.1.4.gem.sha512

@@ -0,0 +1 @@
+cb567a382f07efd13ccbb083e1f8b876aaae4d752b188fd8d7fc42cc0fdba86d5c6d051187e4422aa3d9e5a7d9ad2db4789142fced9cd6cd3d6b08a99f3d40d3

data/lib/simple_service/result.rb

@@ -3,7 +3,7 @@ module SimpleService
     attr_accessor :value, :recorded_commands
 
     def initialize()
-      @recorded_commands = []
+      @recorded_commands = Set.new
       @verbose_tracking = SimpleService.configuration.verbose_tracking
     end
 

data/lib/simple_service/version.rb

@@ -1,3 +1,3 @@
 module SimpleService
-  VERSION = '2.1.3'
+  VERSION = '2.1.5'
 end

data/lib/simple_service.rb

@@ -63,7 +63,7 @@ module SimpleService
         if service.method(cmnd).arity.zero?
           service.public_send(cmnd)
         else
-          service.public_send(cmnd, service.result.value)
+          service.public_send(cmnd, **service.result.value)
         end
       end
 

data/simple_service.gemspec

@@ -19,9 +19,9 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'rake', '~> 12.0.0'
-  spec.add_development_dependency 'rspec', '~> 3.6.0'
-  spec.add_development_dependency 'pry', '~> 0.10.4'
+  spec.add_development_dependency 'rake', '~> 12.3.3'
+  spec.add_development_dependency 'rspec', '~> 3.12.0'
+  spec.add_development_dependency 'pry', '~> 0.14.2'
   spec.add_development_dependency 'simplecov'
   spec.add_development_dependency 'codeclimate-test-reporter'
 end

data/spec/simple_service_spec.rb

@@ -2,6 +2,7 @@ require 'spec_helper'
 require_relative 'support/basic_service'
 require_relative 'support/looping_service'
 require_relative 'support/empty_service'
+require_relative 'support/multiple_outcome_calls'
 
 RSpec.describe SimpleService do
 
@@ -87,31 +88,50 @@ RSpec.describe SimpleService do
   end
 
   context 'record commands' do
+    it 'value refects only one outcome call per command' do
+      result = MultipleOutcomeCalls.call(params.merge(foo: 'foo', bar: 'bar'))
+      expect(result.value).to eq(foo: 'FOO', bar: 'BAR')
+    end
+
+    it 'recorded commands has only one outcome call per command' do
+      result = MultipleOutcomeCalls.call(params.merge(foo: 'foo', bar: 'bar'))
+      expect(result.recorded_commands).to eq(Set.new([
+        {
+          class_name: 'MultipleOutcomeCalls',
+          command_name: :command_one,
+          success: true,
+        },
+        {
+          class_name: 'MultipleOutcomeCalls',
+          command_name: :command_two,
+          success: true,
+        },
+      ]))
+    end
+
     it 'records normal command execution' do
-      expect(result.recorded_commands).to eq(
-        [
-          {
-            class_name: 'BasicService',
-            command_name: :upcase_foo,
-            success: true,
-          },
-          {
-            class_name: 'BasicService',
-            command_name: :upcase_bar,
-            success: true,
-          },
-          {
-            class_name: 'ModifyFooBar',
-            command_name: :call,
-            success: true,
-          },
-          {
-            class_name: 'CombineFooBar',
-            command_name: :call,
-            success: true,
-          },
-        ]
-      )
+      expect(result.recorded_commands).to eq(Set.new([
+        {
+          class_name: 'BasicService',
+          command_name: :upcase_foo,
+          success: true,
+        },
+        {
+          class_name: 'BasicService',
+          command_name: :upcase_bar,
+          success: true,
+        },
+        {
+          class_name: 'ModifyFooBar',
+          command_name: :call,
+          success: true,
+        },
+        {
+          class_name: 'CombineFooBar',
+          command_name: :call,
+          success: true,
+        },
+      ]))
     end
 
     it 'records verbose command execution' do
@@ -119,7 +139,7 @@ RSpec.describe SimpleService do
         config.verbose_tracking = true
       end
 
-      expect(result.recorded_commands).to eq(
+      expect(result.recorded_commands).to eq(Set.new(
         [
           {
             class_name: 'BasicService',
@@ -181,7 +201,7 @@ RSpec.describe SimpleService do
             },
           },
         ]
-      )
+      ))
     end
   end
 end

data/spec/support/multiple_outcome_calls.rb

@@ -0,0 +1,16 @@
+class MultipleOutcomeCalls
+  include SimpleService
+
+  commands :command_one,
+           :command_two,
+
+  def command_one(**kwargs)
+    success(kwargs.merge(foo: kwargs[:foo].capitalize))
+    success(kwargs.merge(foo: kwargs[:foo].upcase))
+  end
+
+  def command_two(**kwargs)
+    success(bar: kwargs[:bar].capitalize)
+    success(foo: kwargs[:foo].upcase, bar: kwargs[:bar].upcase)
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simple_service
 version: !ruby/object:Gem::Version
-  version: 2.1.3
+  version: 2.1.5
 platform: ruby
 authors:
 - Jarrod Spillers
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-11-17 00:00:00.000000000 Z
+date: 2023-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -30,42 +30,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 12.0.0
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 12.0.0
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.6.0
+        version: 3.12.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.6.0
+        version: 3.12.0
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.4
+        version: 0.14.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.4
+        version: 0.14.2
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -102,6 +102,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/gem-push.yml"
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
@@ -110,6 +111,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- checksums/simple_service-2.1.4.gem.sha512
 - lib/simple_service.rb
 - lib/simple_service/configuration.rb
 - lib/simple_service/result.rb
@@ -122,11 +124,12 @@ files:
 - spec/support/empty_service.rb
 - spec/support/looping_service.rb
 - spec/support/modify_foo_bar.rb
+- spec/support/multiple_outcome_calls.rb
 homepage: https://github.com/jspillers/simple_service
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -141,9 +144,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.11
-signing_key: 
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
 summary: A minimal service object composer with support for individual commands and
   top level organizer objects
@@ -155,3 +157,4 @@ test_files:
 - spec/support/empty_service.rb
 - spec/support/looping_service.rb
 - spec/support/modify_foo_bar.rb
+- spec/support/multiple_outcome_calls.rb