simple_service 1.3.91 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e3f165a989654527ffc56c5a8b89ae3e14acfd64
-  data.tar.gz: 1811b820702a489371c75685f093084fe8832ef3
+  metadata.gz: 62bc0c7fd840718bc870a5b2a62d02c72def3b6e
+  data.tar.gz: 30cfd20fdfc0e43da4cde0d96b7d8a0675a744b8
 SHA512:
-  metadata.gz: 4519560c0ba043b3a42cfd423c5e84d4b3120b79e7f1f2acc339a27c690a5455aa4362f4153b1c1bd684dab61e00688064bcecaefb188b8a1319b8bcc83b2cb4
-  data.tar.gz: 2c33e1fc6ac560f743dd74e818af6a04b64d8847c7bfcb1b9ef67d8005cdafb2d73a58e5ea20ff770c3e1783d814e25f98a4b9952dcdb69f8b8942d840040e40
+  metadata.gz: 819f9b02b8f576f378201e44f034495225e10aaf4cde5df67864ecfc25e0422fce2f32a5e05b6643a13531d23b94719e29b4b50e9e71fada2c23b427c8d25fd7
+  data.tar.gz: 2845e7c5d198fbaba131778af47b63a8c077c0e49b558cff40f1b574189a32cd74c26af0cd2eae36041218dbb4fdbe32fcb8f1758113e4d6e043b53de806f993

data/lib/simple_service/context.rb

@@ -1,11 +1,16 @@
 module SimpleService
 
+  # TODO: move context logic here?
   module Context
 
     def success?
 
     end
 
+    def success!
+
+    end
+
     def failure?
 
     end

data/lib/simple_service/organizer.rb

@@ -28,8 +28,8 @@ module SimpleService
         _commands.each do |command|
 
           # halt further command calls if success has been set to false
-          # in a previously called command
-          break if context[:success] == false
+          # in a previously called command or halt is set
+          break if context[:success] == false || context[:halt] == true
 
           # if command class defines "expects" then only feed the command
           # those keys, otherwise just give it the entire context

data/lib/simple_service/service_base.rb

@@ -44,6 +44,10 @@ module SimpleService
         !successful?
       end
 
+      def halted?
+        context.has_key?(:halt) || context[:halt] == true
+      end
+
       def successful?
         !context.has_key?(:success) || context[:success] == true
       end
@@ -89,7 +93,7 @@ module SimpleService
       end
 
       def find_specified_return_keys
-        if returns.nil? || returns.empty? || failed?
+        if returns.nil? || returns.empty? || failed? || halted?
           context
         else
           returns.inject({}) do |to_return, return_param|
@@ -131,9 +135,16 @@ module SimpleService
 
       def failure!(message = nil)
         context[:success] = false
+        context[:halt] = true
         context[:message] = message || 'There was a problem'
       end
 
+      def success!(message = nil)
+        context[:success] = true
+        context[:halt] = true
+        context[:message] = message || 'Success! Returned early'
+      end
+
       def define_getters_and_setters
         all_context_keys.each do |key|
           self.class.class_eval do

data/lib/simple_service/version.rb

@@ -1,3 +1,3 @@
 module SimpleService
-  VERSION = '1.3.91'
+  VERSION = '1.4.0'
 end

data/simple_service.gemspec

@@ -18,10 +18,10 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake', '~> 10.4.2'
-  spec.add_development_dependency 'rspec', '~> 3.2.0'
-  spec.add_development_dependency 'pry', '~> 0.10.1'
+  spec.add_development_dependency 'bundler', '~> 1.15.3'
+  spec.add_development_dependency 'rake', '~> 12.0.0'
+  spec.add_development_dependency 'rspec', '~> 3.6.0'
+  spec.add_development_dependency 'pry', '~> 0.10.4'
   spec.add_development_dependency 'simplecov'
   spec.add_development_dependency 'codeclimate-test-reporter'
 end

data/spec/lib/organizer_spec.rb

@@ -158,6 +158,41 @@ describe SimpleService::Organizer do
 
   end
 
+  context 'service with command that calls success!' do
+
+    class SuccessAndReturnMessage < SimpleService::Command
+      returns :something
+      def call
+        context[:something] = 'yes!'
+        success!('success called prior to all commands being run')
+      end
+    end
+
+    class SuccessCalledThisShouldNotRun < SimpleService::Command
+      def call
+        raise 'should not have gotten here'
+      end
+    end
+
+    class SucceedAndReturn < SimpleService::Organizer
+      returns :something
+      commands SuccessAndReturnMessage, SuccessCalledThisShouldNotRun
+    end
+
+    it 'returns a message' do
+      expect(SucceedAndReturn.call[:message]).to eql(
+        'success called prior to all commands being run')
+    end
+
+    it 'returns success as true' do
+      expect(SucceedAndReturn.call[:success]).to eql(true)
+    end
+
+    it 'does not raise an exception' do
+      expect { SucceedAndReturn.call }.to_not raise_error
+    end
+  end
+
   context 'when arguments are not a hash' do
 
     class DoNothingCommand < SimpleService::Command

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simple_service
 version: !ruby/object:Gem::Version
-  version: 1.3.91
+  version: 1.4.0
 platform: ruby
 authors:
 - Jarrod Spillers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-22 00:00:00.000000000 Z
+date: 2017-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 1.15.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 1.15.3
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.4.2
+        version: 12.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.4.2
+        version: 12.0.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 3.6.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 3.6.0
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.1
+        version: 0.10.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.1
+        version: 0.10.4
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -154,7 +154,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: A minimal service object composer with support for individual commands and
@@ -168,3 +168,4 @@ test_files:
 - spec/lib/organizer_spec.rb
 - spec/simple_service_spec.rb
 - spec/spec_helper.rb
+has_rdoc: