simple_service 1.3.3 → 1.3.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 6421a16fa24d47b79310f8e5bac5918cfe3e9a17
4
- data.tar.gz: c0eb0c831932361a4e9d0cee529b26277cf27cdd
3
+ metadata.gz: 663f4f553e47f6dcb2d0faba3b2d79dc3a928d42
4
+ data.tar.gz: 60d46b2f68c95de1c4d974ff9fa3de2dc533025f
5
5
  SHA512:
6
- metadata.gz: 9bcca53d858a4995da61bc71abdf1555128da2c9610e8f3367d2477ec25da1c56338aaca3d4aa7db19d90c9d8d763195892f92b008a91e89daf478804664cc98
7
- data.tar.gz: 2eab993aa8522a064bc0260a56761203f11c4e429dd39ec7c17354db627cc2e524dd41f3c21a5b2c46d5f35f2731ac53570d037ad24b76ecff3a154fe335bad4
6
+ metadata.gz: eb746a3bac1ee1b061bd555c3f817cd9aae066488e715ea6f4d45afabdd8e9fae3ba82472519c04b202916624ba31857e5eb9c29be27d5503b329312d273e8f9
7
+ data.tar.gz: 547fa2ff4da101e5e76baabc7b9de7b41a27686fbf0ba9e174ca2f56db6e7778075aa6117e5e3553d314ff83615fcf991595b04e0afd4eaa8406eb36bd446d95
@@ -3,7 +3,8 @@ module SimpleService
3
3
 
4
4
  expects :expected_keys, :provided_keys, :provided_commands
5
5
 
6
- skip_validation true # false so as to not cause an infinite loop
6
+ # makes sure validtion is only done once, prevents an infinite loop
7
+ skip_validation true
7
8
 
8
9
  commands ValidatesExpectedKeys,
9
10
  ValidatesCommandsNotEmpty,
@@ -23,6 +23,7 @@ module SimpleService
23
23
  end
24
24
 
25
25
  def call
26
+ # underscores used to disambiguate local vars from methods with the same name
26
27
  with_validation do |_commands|
27
28
  _commands.each do |command|
28
29
 
@@ -58,6 +59,7 @@ module SimpleService
58
59
  private
59
60
 
60
61
  def with_validation
62
+ # don't mess with the context if we are doing internal validation
61
63
  add_validation_keys_to_context unless skip_validation
62
64
 
63
65
  # ensure that the organizer and commands are setup correctly
@@ -1,3 +1,3 @@
1
1
  module SimpleService
2
- VERSION = '1.3.3'
2
+ VERSION = '1.3.4'
3
3
  end
@@ -18,9 +18,9 @@ Gem::Specification.new do |spec|
18
18
  spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
19
19
  spec.require_paths = ['lib']
20
20
 
21
- spec.add_development_dependency 'bundler', '~> 1.3'
21
+ spec.add_development_dependency 'bundler', '~> 1.12.5'
22
22
  spec.add_development_dependency 'rake', '~> 10.4.2'
23
- spec.add_development_dependency 'rspec', '~> 3.2.0'
23
+ spec.add_development_dependency 'rspec', '~> 3.5.0'
24
24
  spec.add_development_dependency 'pry', '~> 0.10.1'
25
25
  spec.add_development_dependency 'codeclimate-test-reporter'
26
26
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: simple_service
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.3.3
4
+ version: 1.3.4
5
5
  platform: ruby
6
6
  authors:
7
7
  - Jarrod Spillers
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2015-05-19 00:00:00.000000000 Z
11
+ date: 2016-07-13 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: bundler
@@ -16,14 +16,14 @@ dependencies:
16
16
  requirements:
17
17
  - - "~>"
18
18
  - !ruby/object:Gem::Version
19
- version: '1.3'
19
+ version: 1.12.5
20
20
  type: :development
21
21
  prerelease: false
22
22
  version_requirements: !ruby/object:Gem::Requirement
23
23
  requirements:
24
24
  - - "~>"
25
25
  - !ruby/object:Gem::Version
26
- version: '1.3'
26
+ version: 1.12.5
27
27
  - !ruby/object:Gem::Dependency
28
28
  name: rake
29
29
  requirement: !ruby/object:Gem::Requirement
@@ -44,14 +44,14 @@ dependencies:
44
44
  requirements:
45
45
  - - "~>"
46
46
  - !ruby/object:Gem::Version
47
- version: 3.2.0
47
+ version: 3.5.0
48
48
  type: :development
49
49
  prerelease: false
50
50
  version_requirements: !ruby/object:Gem::Requirement
51
51
  requirements:
52
52
  - - "~>"
53
53
  - !ruby/object:Gem::Version
54
- version: 3.2.0
54
+ version: 3.5.0
55
55
  - !ruby/object:Gem::Dependency
56
56
  name: pry
57
57
  requirement: !ruby/object:Gem::Requirement
@@ -140,7 +140,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
140
140
  version: '0'
141
141
  requirements: []
142
142
  rubyforge_project:
143
- rubygems_version: 2.4.5
143
+ rubygems_version: 2.5.1
144
144
  signing_key:
145
145
  specification_version: 4
146
146
  summary: A minimal service object composer with support for individual commands and