simple_service 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c3411c81d77a21d53355ecbf0e36e8e8ab775d7f
-  data.tar.gz: ab7e72e01db7d9f4b759f8c3a2e2b6e1a255016c
+  metadata.gz: d7f97f4de9f329a4f7188fb1bb5b29e05552f7fc
+  data.tar.gz: 4ec23950462d5ead39a0011da3bb8faa34f3c46b
 SHA512:
-  metadata.gz: a3ec8495a52be6cd7ffa5e6e8b3a8d29e85c32011540dd4f85e2444da22ade6451a5853af1ec58ec84837a04766bfe75bbf47c74d7a9ceb1ccfb6cd1ffdb5362
-  data.tar.gz: 6d5eb35ca7b7bb0d68f1009e0062f84cb924330887e1dafc33ca1e4e13d7f13757803a0bd583d93266530d4b8a39aa7755904b0c95b213a9655ee7526ea33608
+  metadata.gz: e5294419ccca5e623bd821a414cd646cd5542e741421c6ebc2168a4fc96e59da8fa3059477283e9ebe105ea009d099fb64e601a65e133e3a47d798dbe9191096
+  data.tar.gz: 15eeeb65864d2c0e42f4d218f4929d6ccaac2c5691049559c8a42b85a8c3e897e2e818533ac9a9c38da29f86133c0fdc75c739db27aeaa464022ce5343c67d70

data/lib/simple_service/context.rb

@@ -0,0 +1,27 @@
+module SimpleService
+
+  module Context
+
+    def success?
+
+    end
+
+    def failure?
+
+    end
+
+    def failure!
+
+    end
+
+    def update_getters_and_setters
+
+    end
+
+    def prune!(*keys)
+
+    end
+
+  end
+
+end

data/lib/simple_service/organizer.rb

@@ -40,6 +40,10 @@ module SimpleService
 
     private
 
+    def successful?
+      context[:success] == true
+    end
+
     def with_validation
       add_validation_keys_to_context unless skip_validation
 

data/lib/simple_service/service_base.rb

@@ -13,10 +13,24 @@ module SimpleService
       def skip_validation(skip=true)
         @skip_validation = skip
       end
+
+      # allow execution of the service or commands from the
+      # class level for those that prefer that style
+      def call(context = {})
+        new(context).call
+      end
+
     end
 
     module InstanceMethods
 
+      # sets up an "after" filter for #call
+      #
+      # allows user to implement #call in their individual
+      # command and organizer # classes without having to
+      # rely on super or executing another other method
+      # to do post #call housekeeping such as returning
+      # only specific context keys
       def setup_call_chain
         self.class.class_eval do
 
@@ -24,9 +38,7 @@ module SimpleService
           call_method = instance_method(:call)
 
           # redefine the call method, execute the existing call method object,
-          # and then run return key checking... allows user to implement call in
-          # their individual command classes without having to call super or any
-          # other method to return only specific context keys
+          # and then run return key checking...
           define_method :call do
             call_method.bind(self).call
             return_context_with_success_status
@@ -44,6 +56,7 @@ module SimpleService
         _context = find_specified_return_keys
 
         # only automatically set context[:success] on Organizers and only if its not already set
+        # by a command calling #failure!
         if !_context.has_key?(:success) && self.class.ancestors.include?(SimpleService::Organizer)
           _context[:success] = true
         end

data/lib/simple_service/version.rb

@@ -1,3 +1,3 @@
 module SimpleService
-  VERSION = '1.3.0'
+  VERSION = '1.3.1'
 end

data/spec/lib/command_spec.rb

@@ -23,6 +23,14 @@ describe SimpleService::Command do
   class CallNotDefinedCommand < SimpleService::Command
   end
 
+  describe '.call' do
+    it 'returns the correct keys when using class method' do
+      expect(
+        ValidCommand.call(foo: 'blah', bar: 'meh')
+      ).to eql(bar: 'modified', baz: 'blah')
+    end
+  end
+
   describe '#call' do
 
     context 'when #returns is not empty' do

data/spec/lib/organizer_spec.rb

@@ -26,6 +26,14 @@ describe SimpleService::Organizer do
       commands TestCommandOne, TestCommandTwo
     end
 
+    describe '.call' do
+      it 'returns the correct hash' do
+        expect(
+          TestOrganizer.call(foo: 'foo')
+        ).to eql(foo: 'foo', bar: 'bar', baz: 'baz', success: true)
+      end
+    end
+
     describe '#call' do
       it 'returns the correct hash' do
         expect(

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simple_service
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Jarrod Spillers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-09 00:00:00.000000000 Z
+date: 2015-05-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -105,6 +105,7 @@ files:
 - lib/simple_service/commands/validates_commands_not_empty.rb
 - lib/simple_service/commands/validates_commands_properly_inherit.rb
 - lib/simple_service/commands/validates_expected_keys.rb
+- lib/simple_service/context.rb
 - lib/simple_service/ensure_organizer_is_valid.rb
 - lib/simple_service/exceptions.rb
 - lib/simple_service/organizer.rb