simple_ruby_service 1.0.1 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 43714cc68b788ec9560c521bea6b1f990c53df4355c1ea1926181a085d9995f5
-  data.tar.gz: 663f185df7329f6c11af20451accc328d00a62ca5fef47f484fc2075ceaf1b88
+  metadata.gz: fb4a3799e6b103c84e39eb31420d97e98205847c21da94846dca68f99375243d
+  data.tar.gz: 00bd40999f571f0dddc67ac5437320628b2953a332ca87e3769c0b3bc46f14a3
 SHA512:
-  metadata.gz: 9090c2b6e0cd08731df1094e0e9e1c73327b47c9c74ab853647fe0c48b898630a6800655e62a450d3a6ca932e14aeb807163129865b4bb9c2dcebf60c4f603ad
-  data.tar.gz: 49ba2e1b78455023bbeb560da3a89d2ee30375fab1beda505f525c03e789fa9a71949b698f0c8d534cc1120fd34dd25a583163a28d2cb526861943e7b0b760d5
+  metadata.gz: b0331afb163c7f276e22b8ca2d7f536ec1850a462afa0f347ed5bcdf5af8aed19574ade60704f9eed49085a10b94376deb8298913baccbd8f7b809627e599f1c
+  data.tar.gz: bc68c8a83661057d86a71b7d932f39c5ad46078a5cd1d5bfa1a543ea5995551a789691435045af7653676b86a7c010a032cdbb9482c4ebe95e2b5f838586eea2

data/.travis.yml

@@ -0,0 +1,12 @@
+# SEE: https://docs.travis-ci.com/user/languages/ruby/
+
+language: ruby
+rvm:
+  - 2.5.3
+before_install:
+  - gem install bundler:1.17.3
+install: bundle _1.17.3_ install --jobs=3 --retry=3
+env:
+  - 'TEST_RAILS_VERSION="~> 5.2.3"'
+  - 'TEST_RAILS_VERSION="~> 6.0.3"'
+  - 'TEST_RAILS_VERSION="~> 6.1.3.2"'

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## 1.0.4 (02-Jul-21)
+
+* Polished README (again)
+
+## 1.0.3 (01-Jul-21)
+
+* Polished README
+
+## 1.0.2 (01-Jul-21)
+
+* Integrated Travis CI and Codecov
+
 ## 1.0.1 (01-Jul-21)
 
 * Renamed SimpleRubyservice to SimpleRubyService

data/README.md

@@ -1,12 +1,33 @@
 # Simple Ruby Service
 
-Simple Ruby Service is a lightweight framework for Ruby that makes it easy to create Services and Service Objects (SOs).
+[![Build Status](https://travis-ci.com/amazing-jay/simple_ruby_service.svg?branch=master)](https://travis-ci.com/amazing-jay/simple_ruby_service)
+[![Test Coverage](https://codecov.io/gh/amazing-jay/simple_ruby_service/graph/badge.svg)](https://codecov.io/gh/amazing-jay/simple_ruby_service)
 
-The framework provides a simple DSL that:
+Simple Ruby Service is a lightweight framework for creating Services and Service Objects (SOs) in Ruby.
 
-1. Adds ActiveModel validations and error handling 
-2. Encourages a succinct, idiomatic coding style 
-3. Allows Service Objects to ducktype as Procs
+The framework makes Services and SOs look and feel like ActiveModels, complete with:
+
+1. Validations and robust error handling
+2. Workflows and method chaining
+3. Consistent interfaces
+
+Additionally, Simple Ruby Service Objects can stand in for Procs, wherever Procs are expected (via ducktyping).
+
+#### What problem does Simple Ruby Service solve?
+
+Currently, most ruby developers roll their own services from scratch. As a result, most services are hastely built (in isolation), and this leads to inconsistant interfaces that are difficult to read. Also, error handling tends to vary wildly within an application, and support code tends to be implemented over and over again.
+
+Simple Ruby Service addresses these problems and encourages succinct, idiomatic coding styles.
+
+#### Should I be using Services & SOs in Ruby / Rails?
+
+[LMGTFY](https://www.google.com/search?q=service+object+pattern+rails&rlz=1C5CHFA_enUS893US893&oq=service+object+pattern+rails) to learn more about Services & SOs.
+
+**TLDR** - Fat models and fat controllers are bad! Services and Service Objects help you DRY things up.
+
+#### How is a Service different from an SO?
+
+An SO is just a Service that encapsulates a single operation (i.e. **one, and only one, responsibility**).
 
 ## Requirements
 
@@ -34,12 +55,15 @@ Source code can be downloaded on GitHub
   [github.com/amazing-jay/simple_ruby_service/tree/master](https://github.com/amazing-jay/simple_ruby_service/tree/master)
 
 
-### The following examples illustrate how Simple Ruby Service can help you refactor complex business logic
+## Quick Start
 
 See [Usage](https://github.com/amazing-jay/simple_ruby_service#usage) & [Creating Simple Ruby Services](https://github.com/amazing-jay/simple_ruby_service#creating-simple-ruby-services) for more information.
 
+### How to refactor complex business logic with Simple Ruby Service
+
 #### ::Before:: Vanilla Rails with a fat controller (a contrived example)
 ```ruby
+# in app/controllers/some_controller.rb
 class SomeController < ApplicationController
   def show
     raise unless params[:id].present?
@@ -47,77 +71,124 @@ class SomeController < ApplicationController
     authorize! resource
     resource.do_something
     value = resource.do_something_related
+    raise unless resource.errors
     render value
   end
 end
 ```
 
-#### ::After:: Refactored using an SO
+#### ::After:: Refactored using an Simple Ruby Service Object
+```ruby
+# in app/controllers/some_controller.rb
+class SomeController < ApplicationController
+  def show
+    # NOTE: That's right... just one, readable line of code
+    render DoSomething.call!(params)
+  end
+end
+```
+ 
+#### ::Alternate After:: Refactored using a Simple Ruby Service
 ```ruby
+# in app/controllers/some_controller.rb
 class SomeController < ApplicationController
   def show
-    # NOTE: Simple Ruby Service Objects ducktype as Procs and do not need to be instantiated
-    render DoSomething.call(params).value
+    # NOTE: Simple Ruby Service methods can be chained together
+    render SomeService.new(params)
+      .do_something
+      .do_something_related
+      .value
+  end
+end
+```
+
+### Taking a peek under the hood
+
+`DoSomething.call!(params)` is deliberately designed to look and feel like `ActiveRecord::Base#save!`.
+
+The following (simplified) implementation illustrates what happens under the hood:
+
+```ruby
+module SimpleRubyService::Object
+  def self.call!(params)
+    instance = new(params)
+    raise Invalid unless instance.valid?
+    self.value = instance.call
+    raise Invalid unless instance.failed?
+    value
   end
 end
+```
 
+### Anatomy of a Simple Ruby Service Object
+```ruby
+# in app/service_objects/do_something.rb
 class DoSomething
   include SimpleRubyService::ServiceObject
   
+  # `attribute` behaves similar to ActiveRecord::Base#attribute, but is not typed, or bound to persistant storage
   attribute :id
   attr_accessor :resource
 
-  # NOTE: Validations are executed prior to the business logic encapsulated in `perform`
+  # Validations are executed prior to the business logic encapsulated in `perform`
   validate do                                 
     @resource ||= SomeModel.find(id)
     authorize! resource
   end
   
-  # NOTE: The return value of `perform` is automatically stored as the SO's `value`
+  # The result of `perform` is automatically stored as the SO's `value`
   def perform
-    resource.do_something
-    resource.do_something_related
+    resource.do_something    
+    result = resource.do_something_related  
+    
+    # Adding any kind of error indicates failure
+    add_errors_from_object resource    
+    result
   end
 end
 ```
 
-#### ::Alternate Form:: Refactored using a Service
+### Anatomy of a Simple Ruby Service
 ```ruby
-class SomeController < ApplicationController
-  def show
-    # NOTE: Simple Ruby Service methods can be chained together
-    render SomeService.new(params)
-      .do_something
-      .do_something_related
-      .value
-  end
-end
-
+# in app/services/do_something.rb
 class SomeService
   include SimpleRubyService::Service
   
   attribute :id
   attr_accessor :resource
 
-  # NOTE: Validations are executed prior to the first service method called
+  # Similar to SOs, validations are executed prior to the first service method called
   validate do
     @resource ||= SomeModel.find(id)
     authorize! @resource
   end
   
+  # Unlike SOs, Services can define an arbitrary number of service methods with arbitrary names
   service_methods do
     def do_something
-      resource.do_something_related
+      resource.do_something      
     end
 
-    # NOTE: Unlike SOs, `value` must be explicitely set for Service methods
+    # Unlike SOs, `value` must be explicitely set for Service methods
     def do_something_related
       self.value ||= resource.tap &:do_something_related
+      add_errors_from_object resource
     end
   end
 end
 ```
 
+## A special note about Simple Ruby Service Objects, Procs, and Ducktyping
+
+Simple Ruby Service Objects respond to (`#call`) so they can stand in for Procs, i.e.:
+```ruby
+# in app/models/some_model.rb
+class SomeModel < ApplicationRecord
+  validates :some_attribute, if: SomeServiceObject
+  [...]
+```
+_See [To bang!, or not to bang](https://github.com/amazing-jay/simple_ruby_service/tree/master#to-bang-or-not-to-bang) to learn about `.call!` vs. `.call`._
+
 ## Usage
 
 ### Service Objects
@@ -128,8 +199,6 @@ Service Object names should begin with a verb and should not include the words `
 
 Also, only one operation should be made public, it should always be named `call`, and it should not accept arguments (except for an optional block).
 
-_See [To bang!, or not to bang](https://github.com/amazing-jay/simple_ruby_service/tree/master#to-bang-or-not-to-bang) to learn about `.call!` vs. `.call`._
-
 #### Short form (_recommended_)
 
 ```ruby
@@ -188,9 +257,6 @@ Unlike Service Objects, Service class names should begin with a noun (and may in
 
 Also, any number of operations may be made public, any of these operations may be named `call`, and any of these operations may accept arguments.
 
-_See [To bang!, or not to bang](https://github.com/amazing-jay/simple_ruby_service/tree/master#to-bang-or-not-to-bang) to learn about `.service_method_name!` vs. `.service_method_name`._
-
-
 #### Short form
 
 _not available for Services_
@@ -245,7 +311,7 @@ end
 ## Creating Simple Ruby Services
 
 ### Service Objects
-To implement an Simple Ruby Service Object:
+To implement a Simple Ruby Service Object:
 
   1. include `SimpleRubyService::ServiceObject`
   2. declare attributes with the `attribute` keyword (class level DSL)
@@ -273,7 +339,7 @@ end
 ```
 
 ### Services
-To implement an Simple Ruby Service:
+To implement a Simple Ruby Service:
 
   1. include `SimpleRubyService::Service`
   2. declare attributes with the `attribute` keyword (class level DSL)
@@ -310,19 +376,46 @@ class SomeService
 end
 ```
 
-## FAQ
+### Workflows
+Simple Ruby Services are inherently a good fit for workflows because they support chaining, i.e.:
 
-### Why should I use Services & SOs?
+```ruby
+SomeService.new(params)
+  .do_something
+  .do_something_related
+  .value
+```
 
-[Click here](https://www.google.com/search?q=service+object+pattern+rails&rlz=1C5CHFA_enUS893US893&oq=service+object+pattern+rails) to learn more about the Services & SO design pattern.
+But SOs can also implement various workflows with dependency injection:
 
-**TLDR; fat models and fat controllers are bad! Services and Service Objects help you DRY things up.**
+```ruby
+class PerformSomeWorkflow < SimpleRubyService::ServiceObject
+  def perform
+    dependency = SimpleRubyService1.call!
+    result = SimpleRubyService2.call(dependency)
+    raise unless result.success?                 
+    SimpleRubyService3(dependency, result.value).call!
+  end
+end
+```
 
-### How is a Service different from an SO?
+## MISC
 
-An SO is just a Service that encapsulates a single operation (i.e. **one, and only one, responsibility**).
+### To bang!, or not to bang
+
+Use the bang! version of an operation whenever you expect the operation to succeed more often than fail, and you don't need to chain operations together.
+
+Similar in pattern to `ActiveRecord#save!`, the bang version of each operation:
+* raises `SimpleRubyService::Invalid` if `valid?` is falsey
+* raises `SimpleRubyService::Failure` if the block provided returns a falsey value
+* returns `@value`
 
-### When should I choose a Service over an SO, and vice-versa?
+Whereas, similar in pattern to `ActiveRecord#save`, the regular version of each operation:
+* doesn't raise any exceptions
+* passes the return value of the block provided to `#success?` 
+* returns self << _note: this is unlike `ActiveRecord#save`_
+
+### Service or SO?
 
 Use a `Service` when encapsulating related operations that share dependencies & validations.
 
@@ -333,9 +426,6 @@ i.e.:
 
 _note: Things get fuzzy when operations share some, but not all, dependencies & validations. Use your best judgement when operation `A` and operation `B` are related but `A` acts on a `User` while `B` acts on both a `User` & a `Company`._
 
-### Atomicity
-The framework does not include transaction support by default. You are responsible for wrapping with a transaction if atomicity is desired.
-
 ### Control Flow
 Rescue exceptions that represent internal control flow and propogate the rest.
 
@@ -343,7 +433,7 @@ For example, if an internal call to User.create! is expected to always succeed,
 
 Example::
 ```ruby
-class DoSomethingDangerous < SimpleRubyService::ObjectBase
+class DoSomethingDangerous < SimpleRubyService::ServiceObject
   attribute :attr1, :attr2             # should include all params required to execute
   validates_presence_of :attr1         # validate params to call
 
@@ -359,38 +449,6 @@ class DoSomethingDangerous < SimpleRubyService::ObjectBase
 end
 ```
 
-## Workflows
-SOs often need to call other SOs in order to implement various workflows:
-```ruby
-class PerformSomeWorkflow < SimpleRubyService::ObjectBase
-  def perform
-    dependency = SimpleRubyService1.call!
-    result = SimpleRubyService2.call(dependency)
-    raise unless result.success?                 
-    SimpleRubyService3(dependency, result.value).call!
-  end
-end
-```
-
-## MISC
-
-### Attributes
-The `attribute` and `attributes` keywords behaves similar to [ActiveRecord::Base.attribute](https://api.rubyonrails.org/v6.1.3.1/classes/ActiveRecord/Attributes/ClassMethods.html), but they are not typed or bound to persistant storage.
-
-### To bang!, or not to bang
-
-Use the bang! version of an operation whenever you expect the operation to succeed more often than fail, and you don't need to chain operations together.
-
-Similar in pattern to `ActiveRecord#save!`, the bang version of each operation:
-* raises `SimpleRubyService::Invalid` if `valid?` is falsey
-* raises `SimpleRubyService::Failure` if the block provided returns a falsey value
-* returns `@value`
-
-Whereas, similar in pattern to `ActiveRecord#save`, the regular version of each operation:
-* doesn't raise any exceptions
-* passes the return value of the block provided to `#success?` 
-* returns self << _note: this is unlike `ActiveRecord#save`_
-
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `bundle exec rspec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
@@ -407,6 +465,7 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## DEVELOPMENT ROADMAP
 
-1. Create a helper to dynamically generate default SOs for ActiveRecord models (`create`, `update`, and `destroy`) _(when used in a project that includes [ActiveRecord](https://github.com/rails/rails/tree/main/activerecord))_.
-2. Consider isolating validation errors from execution errors (so that invalid? is not always true when failed? is true)
+1. Create a class level DSL to stop before each Service method unless errors.empty?
+2. Create a helper to dynamically generate default SOs for ActiveRecord models (`create`, `update`, and `destroy`) _(when used in a project that includes [ActiveRecord](https://github.com/rails/rails/tree/main/activerecord))_.
+3. Consider isolating validation errors from execution errors (so that invalid? is not always true when failed? is true)
 

data/lib/simple_ruby_service/service.rb

@@ -6,6 +6,7 @@ module SimpleRubyService
     extend ActiveSupport::Concern
     include ActiveModel::AttributeAssignment
     include ActiveModel::Validations
+    include ActiveModel::Validations::Callbacks    
 
     included do
       attr_accessor :value

data/lib/simple_ruby_service/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SimpleRubyService
-  VERSION = '1.0.1'
+  VERSION = '1.0.5'
 end

data/simple_ruby_service.gemspec

@@ -10,8 +10,9 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Jay Crouch"]
   spec.email         = ["i.jaycrouch@gmail.com"]
 
-  spec.summary       = 'Simple Ruby Service is a lightweight framework for Ruby that makes it easy to create Services and Service Objects (SOs).'
-  spec.description   = 'Simple Ruby Service is a lightweight framework for Ruby that makes it easy to create Services and Service Objects (SOs). The framework provides a simple DSL that: adds ActiveModel validations and error handling; encourages a succinct, idiomatic coding style; and allows Service Objects to ducktype as Procs.'
+  spec.summary       = 'Simple Ruby Service is a lightweight framework for creating Services and Service Objects (SOs) in Ruby.'
+  spec.description   = 'Simple Ruby Service is a lightweight framework for creating Services and Service Objects (SOs) in Ruby. ' \
+                       'The framework makes Services and SOs look and feel like ActiveModels, complete with: 1. validations and robust error handling; 2. workflows and method chaining; and 3. consistent interfaces. Additionally, Simple Ruby Service Objects can stand in for Procs, wherever Procs are expected (via ducktyping).'
   spec.homepage      = 'https://github.com/amazing-jay/simple_ruby_service'
   spec.license       = "MIT"
 
@@ -39,7 +40,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'activemodel'
   spec.add_dependency 'activesupport'
 
-  # spec.add_development_dependency 'actionpack'
   spec.add_development_dependency "awesome_print", "~> 1.9.2"
   spec.add_development_dependency "bundler", "~> 1.17"
   spec.add_development_dependency "database_cleaner", "~> 2.0.1"
@@ -48,13 +48,21 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "faker", "~> 2.18"
   spec.add_development_dependency "listen", "~> 3.5.1"
   spec.add_development_dependency "pry-byebug", "~> 3.9"
-  spec.add_development_dependency "rails", "~> 6.1.3.2"
+
+  # must come before those below
+  if ENV['TEST_RAILS_VERSION'].nil?
+    spec.add_development_dependency 'rails', '~> 6.1.3.2'
+  else
+    spec.add_development_dependency 'rails', ENV['TEST_RAILS_VERSION'].to_s
+  end
+
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "rspec-rails", "~> 5.0.1"
   spec.add_development_dependency "rubocop", "~> 0.60"
   spec.add_development_dependency "rubocop-performance", "~> 1.5"
   spec.add_development_dependency "rubocop-rspec", "~> 1.37"
+  spec.add_development_dependency "codecov", "~> 0.5.2"
   spec.add_development_dependency "simplecov", "~> 0.16"
   spec.add_development_dependency "sqlite3", "~> 1.4.2"
   spec.add_development_dependency "webmock", "~> 3.13"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simple_ruby_service
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.5
 platform: ruby
 authors:
 - Jay Crouch
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-07-02 00:00:00.000000000 Z
+date: 2021-10-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -248,6 +248,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.37'
+- !ruby/object:Gem::Dependency
+  name: codecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.5.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.5.2
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -290,10 +304,11 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.13'
-description: 'Simple Ruby Service is a lightweight framework for Ruby that makes it
-  easy to create Services and Service Objects (SOs). The framework provides a simple
-  DSL that: adds ActiveModel validations and error handling; encourages a succinct,
-  idiomatic coding style; and allows Service Objects to ducktype as Procs.'
+description: 'Simple Ruby Service is a lightweight framework for creating Services
+  and Service Objects (SOs) in Ruby. The framework makes Services and SOs look and
+  feel like ActiveModels, complete with: 1. validations and robust error handling;
+  2. workflows and method chaining; and 3. consistent interfaces. Additionally, Simple
+  Ruby Service Objects can stand in for Procs, wherever Procs are expected (via ducktyping).'
 email:
 - i.jaycrouch@gmail.com
 executables: []
@@ -304,6 +319,7 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".simplecov"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -343,6 +359,6 @@ requirements: []
 rubygems_version: 3.0.9
 signing_key:
 specification_version: 4
-summary: Simple Ruby Service is a lightweight framework for Ruby that makes it easy
-  to create Services and Service Objects (SOs).
+summary: Simple Ruby Service is a lightweight framework for creating Services and
+  Service Objects (SOs) in Ruby.
 test_files: []