simple_queues 1.2.0 → 1.2.1

data/lib/simple_queues/redis.rb

@@ -6,7 +6,7 @@ module SimpleQueues
   #
   # Messages are enqueued to the right, dequeued from the left - thus the most recent messages are at the end of the list.
   class Redis
-    attr_reader :encoder
+    attr_accessor :encoder
 
     # @param redis A Redis instance, or something that looks like Redis.
     # @param options [Hash] A set of options.
@@ -93,12 +93,13 @@ module SimpleQueues
         _, result = @redis.blpop(q_name(queue_name), timeout.to_i)
         decode(result)
       else
-        raise "NOT DONE"
+        raise ArgumentError, "Expected 1 (timeout) or 2 (queue name, timeout) arguments, not #{args.length}"
       end
 
     end
 
-  private
+    protected
+
     def q_name(queue_name)
       queue_name &&= queue_name.to_s
       raise ArgumentError, "Queue name argument was nil - must not be" if queue_name.nil? || queue_name.empty?

data/lib/simple_queues/version.rb

@@ -1,3 +1,3 @@
 module SimpleQueues
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/spec/multi_dequeue_spec.rb

@@ -27,14 +27,14 @@ describe SimpleQueues::Redis, "multiple dequeue" do
   end
 
   context "#dequeue_with_timeout" do
-    it "should return the queue name when a message was dequeued" do
+    it "should return the queue name where the message was dequeued" do
       queue.on_dequeue(:a) {|message| message}
       queue.on_dequeue(:b) {|message| raise "not here"}
       queue.enqueue(:a, :sent_to => "a")
       queue.dequeue_with_timeout(1).should == "a"
     end
 
-    it "should return nil when no queues returned anything" do
+    it "should return nil when no messages were pending" do
       queue.on_dequeue(:a) {|message| raise "not here"}
       queue.dequeue_with_timeout(1).should be_nil
     end
@@ -47,9 +47,8 @@ describe SimpleQueues::Redis, "multiple dequeue" do
       queue.enqueue(:a, "sent_to" => "a", "serial" => 1)
       queue.enqueue(:b, "sent_to" => "b", "serial" => 1)
       queue.enqueue(:a, "sent_to" => "a", "serial" => 2)
-      while queue.dequeue_with_timeout(1)
-        # NOP
-      end
+
+      3.times { queue.dequeue_with_timeout(1) }
 
       a.should == [{"sent_to" => "a", "serial" => 1}, {"sent_to" => "a", "serial" => 2}]
       b.should == [{"sent_to" => "b", "serial" => 1}]

metadata

@@ -2,7 +2,7 @@
 name: simple_queues
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors: 
 - "Fran\xC3\xA7ois Beausoleil"
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-25 00:00:00 -04:00
+date: 2011-03-29 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency