simple_form_with_client_validation 0.0.0

data/test/action_view_extensions/form_helper_test.rb

@@ -0,0 +1,104 @@
+require 'test_helper'
+
+class FormHelperTest < ActionView::TestCase
+
+  test 'SimpleFormWithClientValidation for yields an instance of FormBuilder' do
+    simple_form_for :user do |f|
+      assert f.instance_of?(SimpleFormWithClientValidation::FormBuilder)
+    end
+  end
+
+  test 'SimpleFormWithClientValidation should add default class to form' do
+    with_concat_form_for(:user)
+    assert_select 'form.simple_form'
+  end
+
+  test 'SimpleFormWithClientValidation should use default browser validations by default' do
+    with_concat_form_for(:user)
+    assert_no_select 'form[novalidate]'
+  end
+
+  test 'SimpleFormWithClientValidation should not use default browser validations if specified in the configuration options' do
+    swap SimpleFormWithClientValidation, :browser_validations => false do
+      with_concat_form_for(:user)
+      assert_select 'form[novalidate="novalidate"]'
+    end
+  end
+
+  test 'a form specific disabled validation option should override the default enabled browser validation configuration option' do
+    with_concat_form_for(:user, :html => { :novalidate => true })
+    assert_select 'form[novalidate="novalidate"]'
+  end
+
+  test 'a form specific enabled validation option should override the disabled browser validation configuration option' do
+    swap SimpleFormWithClientValidation, :browser_validations => false do
+      with_concat_form_for(:user, :html => { :novalidate => false })
+      assert_no_select 'form[novalidate]'
+    end
+  end
+
+  test 'SimpleFormWithClientValidation should add object name as css class to form when object is not present' do
+    with_concat_form_for(:user, :html => { :novalidate => true })
+    assert_select 'form.simple_form.user'
+  end
+
+  test 'SimpleFormWithClientValidation should add :as option as css class to form when object is not present' do
+    with_concat_form_for(:user, :as => 'superuser')
+    assert_select 'form.simple_form.superuser'
+  end
+
+  test 'SimpleFormWithClientValidation should add object class name with new prefix as css class to form if record is not persisted' do
+    @user.new_record!
+    with_concat_form_for(@user)
+    assert_select 'form.simple_form.new_user'
+  end
+
+  test 'SimpleFormWithClientValidation should add :as option with new prefix as css class to form if record is not persisted' do
+    @user.new_record!
+    with_concat_form_for(@user, :as => 'superuser')
+    assert_select 'form.simple_form.new_superuser'
+  end
+
+  test 'SimpleFormWithClientValidation should add edit class prefix as css class to form if record is persisted' do
+    with_concat_form_for(@user)
+    assert_select 'form.simple_form.edit_user'
+  end
+
+  test 'SimpleFormWithClientValidation should add :as options with edit prefix as css class to form if record is persisted' do
+    with_concat_form_for(@user, :as => 'superuser')
+    assert_select 'form.simple_form.edit_superuser'
+  end
+
+  test 'SimpleFormWithClientValidation should not add object class to form if css_class is specified' do
+    with_concat_form_for(:user, :html => {:class => nil})
+    assert_no_select 'form.user'
+  end
+
+  test 'SimpleFormWithClientValidation should add custom class to form if css_class is specified' do
+    with_concat_form_for(:user, :html => {:class => 'my_class'})
+    assert_select 'form.my_class'
+  end
+
+  test 'pass options to SimpleFormWithClientValidation' do
+    with_concat_form_for(:user, :url => '/account', :html => { :id => 'my_form' })
+    assert_select 'form#my_form'
+    assert_select 'form[action=/account]'
+  end
+
+  test 'fields for yields an instance of FormBuilder' do
+    with_concat_form_for(:user) do |f|
+      assert f.instance_of?(SimpleFormWithClientValidation::FormBuilder)
+    end
+  end
+
+  test 'fields for with a hash like model yeilds an instance of FormBuilder' do
+    @hash_backed_author = HashBackedAuthor.new
+
+    with_concat_fields_for(:author, @hash_backed_author) do |f|
+      assert f.instance_of?(SimpleFormWithClientValidation::FormBuilder)
+      f.input :name
+    end
+
+    assert_select "input[name='author[name]'][value='hash backed author']"
+  end
+end

data/test/components/label_test.rb

@@ -0,0 +1,310 @@
+# encoding: UTF-8
+require 'test_helper'
+
+# Isolated tests for label without triggering f.label.
+class IsolatedLabelTest < ActionView::TestCase
+  setup do
+    SimpleFormWithClientValidation::Inputs::Base.reset_i18n_cache :translate_required_html
+  end
+
+  def with_label_for(object, attribute_name, type, options={})
+    with_concat_form_for(object) do |f|
+      options[:reflection] = Association.new(Company, :company, {}) if options.delete(:setup_association)
+      SimpleFormWithClientValidation::Inputs::Base.new(f, attribute_name, nil, type, options).label
+    end
+  end
+
+  test 'label should generate a default humanized description' do
+    with_label_for @user, :name, :string
+    assert_select 'label[for=user_name]', /Name/
+  end
+
+  test 'label should allow a customized description' do
+    with_label_for @user, :name, :string, :label => 'My label!'
+    assert_select 'label[for=user_name]', /My label!/
+  end
+
+  test 'label should use human attribute name from object when available' do
+    with_label_for @user, :description, :text
+    assert_select 'label[for=user_description]', /User Description!/
+  end
+
+  test 'label should use human attribute name based on association name' do
+    with_label_for @user, :company_id, :string, :setup_association => true
+    assert_select 'label', /Company Human Name!/
+  end
+
+  test 'label should use i18n based on model, action, and attribute to lookup translation' do
+    @controller.action_name = "new"
+    store_translations(:en, :simple_form => { :labels => { :user => {
+      :new => { :description => 'Nova descrição' }
+    } } } ) do
+      with_label_for @user, :description, :text
+      assert_select 'label[for=user_description]', /Nova descrição/
+    end
+  end
+
+  test 'label should fallback to new when action is create' do
+    @controller.action_name = "create"
+    store_translations(:en, :simple_form => { :labels => { :user => {
+      :new => { :description => 'Nova descrição' }
+    } } } ) do
+      with_label_for @user, :description, :text
+      assert_select 'label[for=user_description]', /Nova descrição/
+    end
+  end
+
+  test 'label should not explode while looking for i18n translation when action is not set' do
+    def @controller.action_name; nil; end
+
+    assert_nothing_raised do
+      with_label_for @user, :description, :text
+    end
+    assert_select 'label[for=user_description]'
+  end
+
+  test 'label should use i18n based on model and attribute to lookup translation' do
+    store_translations(:en, :simple_form => { :labels => { :user => {
+      :description => 'Descrição'
+    } } } ) do
+      with_label_for @user, :description, :text
+      assert_select 'label[for=user_description]', /Descrição/
+    end
+  end
+
+  test 'input should use i18n under defaults to lookup translation' do
+    store_translations(:en, :simple_form => { :labels => { :defaults => {:age => 'Idade'} } } ) do
+      with_label_for @user, :age, :integer
+      assert_select 'label[for=user_age]', /Idade/
+    end
+  end
+
+  test 'input should not use i18n label if translate is false' do
+    swap SimpleFormWithClientValidation, :translate_labels => false do
+      store_translations(:en, :simple_form => { :labels => { :defaults => {:age => 'Idade'} } } ) do
+        with_label_for @user, :age, :integer
+        assert_select 'label[for=user_age]', /Age/
+      end
+    end
+  end
+
+  test 'label should use i18n with lookup for association name' do
+    store_translations(:en, :simple_form => { :labels => {
+      :user => { :company => 'My company!' }
+    } } ) do
+      with_label_for @user, :company_id, :string, :setup_association => true
+      assert_select 'label[for=user_company_id]', /My company!/
+    end
+  end
+
+  test 'label should do correct i18n lookup for nested models with nested translation' do
+    @user.company = Company.new(1, 'Empresa')
+
+    store_translations(:en, :simple_form => { :labels => {
+      :user => { :name => 'Usuario', :company => { :name => 'Nome da empresa' } }
+    } } ) do
+      with_concat_form_for @user do |f|
+        concat f.input :name
+        concat(f.simple_fields_for(:company) do |company_form|
+          concat(company_form.input :name)
+        end)
+      end
+
+      assert_select 'label[for=user_name]', /Usuario/
+      assert_select 'label[for=user_company_attributes_name]', /Nome da empresa/
+    end
+  end
+
+  test 'label should do correct i18n lookup for nested models with no nested translation' do
+    @user.company = Company.new(1, 'Empresa')
+
+    store_translations(:en, :simple_form => { :labels => {
+      :user    => { :name => 'Usuario' },
+      :company => { :name => 'Nome da empresa' }
+    } } ) do
+      with_concat_form_for @user do |f|
+        concat f.input :name
+        concat(f.simple_fields_for(:company) do |company_form|
+          concat(company_form.input :name)
+        end)
+      end
+
+      assert_select 'label[for=user_name]', /Usuario/
+      assert_select 'label[for=user_company_attributes_name]', /Nome da empresa/
+    end
+  end
+
+  test 'label should do correct i18n lookup for nested has_many models with no nested translation' do
+    @user.tags = [Tag.new(1, 'Empresa')]
+
+    store_translations(:en, :simple_form => { :labels => {
+      :user => { :name => 'Usuario' },
+      :tags => { :name => 'Nome da empresa' }
+    } } ) do
+      with_concat_form_for @user do |f|
+        concat f.input :name
+        concat(f.simple_fields_for(:tags, :child_index => "new_index") do |tags_form|
+          concat(tags_form.input :name)
+        end)
+      end
+
+      assert_select 'label[for=user_name]', /Usuario/
+      assert_select 'label[for=user_tags_attributes_new_index_name]', /Nome da empresa/
+    end
+  end
+
+  test 'label should have css class from type' do
+    with_label_for @user, :name, :string
+    assert_select 'label.string'
+    with_label_for @user, :description, :text
+    assert_select 'label.text'
+    with_label_for @user, :age, :integer
+    assert_select 'label.integer'
+    with_label_for @user, :born_at, :date
+    assert_select 'label.date'
+    with_label_for @user, :created_at, :datetime
+    assert_select 'label.datetime'
+  end
+
+  test 'label should not have css class from type when generate_additional_classes_for does not include :label' do
+    swap SimpleFormWithClientValidation, :generate_additional_classes_for => [:wrapper, :input] do
+      with_label_for @user, :name, :string
+      assert_no_select 'label.string'
+      with_label_for @user, :description, :text
+      assert_no_select 'label.text'
+      with_label_for @user, :age, :integer
+      assert_no_select 'label.integer'
+      with_label_for @user, :born_at, :date
+      assert_no_select 'label.date'
+      with_label_for @user, :created_at, :datetime
+      assert_no_select 'label.datetime'
+    end
+  end
+
+  test 'label should obtain required from ActiveModel::Validations when it is included' do
+    with_label_for @validating_user, :name, :string
+    assert_select 'label.required'
+    with_label_for @validating_user, :status, :string
+    assert_select 'label.optional'
+  end
+
+  test 'label should not obtain required from ActiveModel::Validations when generate_additional_classes_for does not include :label' do
+    swap SimpleFormWithClientValidation, :generate_additional_classes_for => [:wrapper, :input] do
+      with_label_for @validating_user, :name, :string
+      assert_no_select 'label.required'
+      with_label_for @validating_user, :status, :string
+      assert_no_select 'label.optional'
+    end
+  end
+
+  test 'label should allow overriding required when ActiveModel::Validations is included' do
+    with_label_for @validating_user, :name, :string, :required => false
+    assert_select 'label.optional'
+    with_label_for @validating_user, :status, :string, :required => true
+    assert_select 'label.required'
+  end
+
+  test 'label should be required by default when ActiveModel::Validations is not included' do
+    with_label_for @user, :name, :string
+    assert_select 'label.required'
+  end
+
+  test 'label should be able to disable required when ActiveModel::Validations is not included' do
+    with_label_for @user, :name, :string, :required => false
+    assert_no_select 'label.required'
+  end
+
+  test 'label should add required text when required' do
+    with_label_for @user, :name, :string
+    assert_select 'label.required abbr[title=required]', '*'
+  end
+
+  test 'label should not have required text in no required inputs' do
+    with_label_for @user, :name, :string, :required => false
+    assert_no_select 'form label abbr'
+  end
+
+  test 'label should use i18n to find required text' do
+    store_translations(:en, :simple_form => { :required => { :text => 'campo requerido' }}) do
+      with_label_for @user, :name, :string
+      assert_select 'form label abbr[title=campo requerido]', '*'
+    end
+  end
+
+  test 'label should use i18n to find required mark' do
+    store_translations(:en, :simple_form => { :required => { :mark => '*-*' }}) do
+      with_label_for @user, :name, :string
+      assert_select 'form label abbr', '*-*'
+    end
+  end
+
+  test 'label should use i18n to find required string tag' do
+    store_translations(:en, :simple_form => { :required => { :html => '<span class="required" title="requerido">*</span>' }}) do
+      with_label_for @user, :name, :string
+      assert_no_select 'form label abbr'
+      assert_select 'form label span.required[title=requerido]', '*'
+    end
+  end
+
+  test 'label should allow overwriting input id' do
+    with_label_for @user, :name, :string, :input_html => { :id => 'my_new_id' }
+    assert_select 'label[for=my_new_id]'
+  end
+
+  test 'label should allow overwriting of for attribute' do
+    with_label_for @user, :name, :string, :label_html => { :for => 'my_new_id' }
+    assert_select 'label[for=my_new_id]'
+  end
+
+  test 'label should allow overwriting of for attribute with input_html not containing id' do
+    with_label_for @user, :name, :string, :label_html => { :for => 'my_new_id' }, :input_html => {:class => 'foo'}
+    assert_select 'label[for=my_new_id]'
+  end
+
+  test 'label should use default input id when it was not overridden' do
+    with_label_for @user, :name, :string, :input_html => { :class => 'my_new_id' }
+    assert_select 'label[for=user_name]'
+  end
+
+  test 'label should be generated properly when object is not present' do
+    with_label_for :project, :name, :string
+    assert_select 'label[for=project_name]', /Name/
+  end
+
+  test 'label should include for attribute for select collection' do
+    with_label_for @user, :sex, :select, :collection => [:male, :female]
+    assert_select 'label[for=user_sex]'
+  end
+
+  test 'label should use i18n properly when object is not present' do
+    store_translations(:en, :simple_form => { :labels => {
+      :project => { :name => 'Nome' }
+    } } ) do
+      with_label_for :project, :name, :string
+      assert_select 'label[for=project_name]', /Nome/
+    end
+  end
+
+  test 'label should add required by default when object is not present' do
+    with_label_for :project, :name, :string
+    assert_select 'label.required[for=project_name]'
+    with_label_for :project, :description, :string, :required => false
+    assert_no_select 'label.required[for=project_description]'
+  end
+
+  test 'label should add chosen label class' do
+    swap SimpleFormWithClientValidation, :label_class => :my_custom_class do
+      with_label_for @user, :name, :string
+      assert_select 'label.my_custom_class'
+    end
+  end
+
+  test 'label strips extra classes even when label_class is nil' do
+    swap SimpleFormWithClientValidation, :label_class => nil do
+      with_label_for @user, :name, :string
+      assert_select "label[class='string required']"
+      assert_no_select "label[class='string required ']"
+      assert_no_select "label[class=' string required']"
+    end
+  end
+end

data/test/form_builder/association_test.rb

@@ -0,0 +1,177 @@
+# encoding: UTF-8
+require 'test_helper'
+
+class AssociationTest < ActionView::TestCase
+  def with_association_for(object, *args)
+    with_concat_form_for(object) do |f|
+      f.association(*args)
+    end
+  end
+
+  test 'builder should not allow creating an association input when no object exists' do
+    assert_raise ArgumentError do
+      with_association_for :post, :author
+    end
+  end
+
+  test 'builder association with a block calls simple_fields_for' do
+    simple_form_for @user do |f|
+      f.association :posts do |posts_form|
+        assert posts_form.instance_of?(SimpleFormWithClientValidation::FormBuilder)
+      end
+    end
+  end
+
+  test 'builder association forwards collection to simple_fields_for' do
+    calls = 0
+    simple_form_for @user do |f|
+      f.association :company, :collection => Company.all do |c|
+        calls += 1
+      end
+    end
+
+    assert_equal 3, calls
+  end
+
+  test 'builder association marks input as required based on both association and attribute' do
+    swap SimpleFormWithClientValidation, :required_by_default => false do
+      with_association_for @validating_user, :company, :collection => []
+      assert_select 'label.required'
+    end
+  end
+
+  test 'builder preloads collection association' do
+    value = @user.tags
+    value.expects(:to_a).returns(value)
+    with_association_for @user, :tags
+    assert_select 'form select.select#user_tag_ids'
+    assert_select 'form select option[value=1]', 'Tag 1'
+    assert_select 'form select option[value=2]', 'Tag 2'
+    assert_select 'form select option[value=3]', 'Tag 3'
+  end
+
+  test 'builder does not preload collection association if preload is false' do
+    value = @user.company
+    value.expects(:to_a).never
+    with_association_for @user, :company, :preload => false
+    assert_select 'form select.select#user_company_id'
+    assert_select 'form select option[value=1]', 'Company 1'
+    assert_select 'form select option[value=2]', 'Company 2'
+    assert_select 'form select option[value=3]', 'Company 3'
+  end
+
+  test 'builder does not preload non-collection association' do
+    value = @user.company
+    value.expects(:to_a).never
+    with_association_for @user, :company, :preload => false
+    assert_select 'form select.select#user_company_id'
+    assert_select 'form select option[value=1]', 'Company 1'
+    assert_select 'form select option[value=2]', 'Company 2'
+    assert_select 'form select option[value=3]', 'Company 3'
+  end
+
+  # ASSOCIATIONS - BELONGS TO
+  test 'builder creates a select for belongs_to associations' do
+    with_association_for @user, :company
+    assert_select 'form select.select#user_company_id'
+    assert_select 'form select option[value=1]', 'Company 1'
+    assert_select 'form select option[value=2]', 'Company 2'
+    assert_select 'form select option[value=3]', 'Company 3'
+  end
+
+  test 'builder allows collection radio for belongs_to associations' do
+    with_association_for @user, :company, :as => :radio_buttons
+    assert_select 'form input.radio_buttons#user_company_id_1'
+    assert_select 'form input.radio_buttons#user_company_id_2'
+    assert_select 'form input.radio_buttons#user_company_id_3'
+  end
+
+  test 'builder marks the record which already belongs to the user' do
+    @user.company_id = 2
+    with_association_for @user, :company, :as => :radio_buttons
+    assert_no_select 'form input.radio_buttons#user_company_id_1[checked=checked]'
+    assert_select 'form input.radio_buttons#user_company_id_2[checked=checked]'
+    assert_no_select 'form input.radio_buttons#user_company_id_3[checked=checked]'
+  end
+
+  # ASSOCIATIONS - FINDERS
+  test 'builder should use reflection conditions to find collection' do
+    with_association_for @user, :special_company
+    assert_select 'form select.select#user_special_company_id'
+    assert_select 'form select option[value=1]'
+    assert_no_select 'form select option[value=2]'
+    assert_no_select 'form select option[value=3]'
+  end
+
+  test 'builder should allow overriding collection to association input' do
+    with_association_for @user, :company, :include_blank => false,
+                         :collection => [Company.new(999, 'Teste')]
+    assert_select 'form select.select#user_company_id'
+    assert_no_select 'form select option[value=1]'
+    assert_select 'form select option[value=999]', 'Teste'
+    assert_select 'form select option', :count => 1
+  end
+
+  # ASSOCIATIONS - has_*
+  test 'builder does not allow has_one associations' do
+    assert_raise RuntimeError do
+      with_association_for @user, :first_company, :as => :radio_buttons
+    end
+  end
+
+  test 'builder creates a select with multiple options for collection associations' do
+    with_association_for @user, :tags
+    assert_select 'form select.select#user_tag_ids'
+    assert_select 'form select[multiple=multiple][size=5]'
+    assert_select 'form select option[value=1]', 'Tag 1'
+    assert_select 'form select option[value=2]', 'Tag 2'
+    assert_select 'form select option[value=3]', 'Tag 3'
+  end
+
+  test 'builder allows size to be overwritten for collection associations' do
+    with_association_for @user, :tags, :input_html => { :size => 10 }
+    assert_select 'form select[multiple=multiple][size=10]'
+  end
+
+  test 'builder marks all selected records which already belongs to user' do
+    @user.tag_ids = [1, 2]
+    with_association_for @user, :tags
+    assert_select 'form select option[value=1][selected=selected]'
+    assert_select 'form select option[value=2][selected=selected]'
+    assert_no_select 'form select option[value=3][selected=selected]'
+  end
+
+  test 'builder allows a collection of check boxes for collection associations' do
+    @user.tag_ids = [1, 2]
+    with_association_for @user, :tags, :as => :check_boxes
+    assert_select 'form input#user_tag_ids_1[type=checkbox]'
+    assert_select 'form input#user_tag_ids_2[type=checkbox]'
+    assert_select 'form input#user_tag_ids_3[type=checkbox]'
+  end
+
+  test 'builder marks all selected records for collection boxes' do
+    @user.tag_ids = [1, 2]
+    with_association_for @user, :tags, :as => :check_boxes
+    assert_select 'form input[type=checkbox][value=1][checked=checked]'
+    assert_select 'form input[type=checkbox][value=2][checked=checked]'
+    assert_no_select 'form input[type=checkbox][value=3][checked=checked]'
+  end
+
+  test 'builder with collection support giving collection and item wrapper tags' do
+    with_association_for @user, :tags, :as => :check_boxes,
+      :collection_wrapper_tag => :ul, :item_wrapper_tag => :li
+
+    assert_select 'form ul', :count => 1
+    assert_select 'form ul li', :count => 3
+  end
+
+  test 'builder with collection support should not change the options hash' do
+    options = { :as => :check_boxes, :collection_wrapper_tag => :ul, :item_wrapper_tag => :li}
+    with_association_for @user, :tags, options
+
+    assert_select 'form ul', :count => 1
+    assert_select 'form ul li', :count => 3
+    assert_equal({ :as => :check_boxes, :collection_wrapper_tag => :ul, :item_wrapper_tag => :li},
+                 options)
+  end
+end