simple_form_password_with_hints 0.0.10 → 0.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d83415f47aa069c001ae4ef753a4f5c8adf2d51ecef3810f0b73c09d9d4cccd9
-  data.tar.gz: a617f17aa73ce03dfa9a014d0beb09403d802a608d375d566dd6ed7e112feac0
+  metadata.gz: a6066f856ad9bd7cb20038699df175148218fdbd44715a34faca291b6a8559c2
+  data.tar.gz: 5480b2dfa95a9c4b82cc4428689c479d40364035b5af4f7ca0b17e10778dc807
 SHA512:
-  metadata.gz: eca8cf2fc11d72662bb5c273716a9cda54fe71889e183971a4fd6516729f099a092c131cd645ab0ee1217acdf226aa82ffeed576e22a0d95ad30467777942382
-  data.tar.gz: 6d7e1328160d9f33a9a3f583ce466a6c2a7788d47e3ea6974d96e63eca717de3d8467d4f03b05b6f6c932a846bf3426b9bd4c0336a614e8d16a90bbafc6cc0cd
+  metadata.gz: de49dc0af3fbbda27f1b66585ecf4553b6169ea1752af49bd586d2aa3ec0103bd5118aaf4e71f21197d4495aecd009b6573306c4eb5a074a504c78c9bc0c3e54
+  data.tar.gz: 7cf4d043bc797cce6a2c072f9e1b46bb37d4f60d09ddb0d438e9be9a6bf3af20fa3c9b835837e8576aa453814d914399a254a64bf0b5bf617459152d1dfa31a3

data/.gitignore

@@ -6,4 +6,5 @@
 /pkg/
 /spec/reports/
 /tmp/
-/test/dummy/tmp/
+
+.DS_Store

data/Gemfile

@@ -11,4 +11,5 @@ gem 'pg', '~> 1.1'
 gem 'bootsnap', '>= 1.4.4', require: false
 gem 'devise'
 gem 'bootstrap'
+gem 'sassc-rails'
 gem 'jquery-rails'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    simple_form_password_with_hints (0.0.10)
+    simple_form_password_with_hints (0.0.12)
       rails
       simple_form
 
@@ -199,14 +199,31 @@ GEM
     responders (3.1.1)
       actionpack (>= 5.2)
       railties (>= 5.2)
+    sassc (2.4.0)
+      ffi (~> 1.9)
+    sassc-rails (2.1.2)
+      railties (>= 4.0.0)
+      sassc (>= 2.0)
+      sprockets (> 3.0)
+      sprockets-rails
+      tilt
     securerandom (0.3.1)
     simple_form (5.3.1)
       actionpack (>= 5.2)
       activemodel (>= 5.2)
+    sprockets (4.2.2)
+      concurrent-ruby (~> 1.0)
+      logger
+      rack (>= 2.2.4, < 4)
+    sprockets-rails (3.5.2)
+      actionpack (>= 6.1)
+      activesupport (>= 6.1)
+      sprockets (>= 3.0.0)
     sqlite3 (2.1.1)
       mini_portile2 (~> 2.8.0)
     stringio (3.1.1)
     thor (1.3.2)
+    tilt (2.7.0)
     timeout (0.4.1)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
@@ -229,6 +246,7 @@ DEPENDENCIES
   jquery-rails
   listen
   pg (~> 1.1)
+  sassc-rails
   simple_form
   simple_form_password_with_hints!
   sqlite3

data/README.md

@@ -58,11 +58,12 @@ becomes
 <%= f.input :password,
             as: :password_with_hints,  
             validators: {
-              length: 6,
+              minlength: 8,
+              maxlength: 128,
               uppercase_char: true,
               lowercase_char: true,
               numeric_char: true,
-              special_char: '#&@?!'
+              special_char: true
             } %>
 ```
 
@@ -92,8 +93,20 @@ Basically in your `User` model you will have to add a test like this:
 validate :password_complexity
 
 def password_complexity
-  # Regexp extracted from https://stackoverflow.com/questions/19605150/regex-for-password-must-contain-at-least-eight-characters-at-least-one-number-a
-  return if password.blank? || password =~ /^(?=.*?[A-Z])(?=.*?[a-z])(?=.*?[0-9])(?=.*?[#?!,@$%^&*+£µ-]).{8,70}$/
+  return if password.blank?
+
+  has_uppercase = password =~ /[A-Z]/
+  has_lowercase = password =~ /[a-z]/
+  has_number = password =~ /[0-9]/
+  has_special_char = password =~ /[^A-z0-9]/
+  is_right_length = (8..128).include?(password.length)
+
+  return if has_uppercase &&
+            has_lowercase &&
+            has_number &&
+            has_special_char &&
+            is_right_length
+
   errors.add :password, 'Your password is not strong enough'
 end
 ```
@@ -101,28 +114,28 @@ end
 This regex matches the validators:
 ```erb
 validators: {
-  length: 8,
+  minlength: 8,
+  maxlength: 128,
   uppercase_char: true,
   lowercase_char: true,
   numeric_char: true,
-  special_char: '#?!,@$%^&*+£µ-'
+  special_char: true,
 }
 ```
 
-If you use `Devise` you might want to use the gem setup directly. And maybe add the special chars list in the configuration.
-So in you `config/application.rb` you might add `config.allowed_special_chars = '#?!,@$%^&*+£µ-'`.
-And then your regex in the model file should look like that:
+If you use `Devise` you might want to use the gem setup directly. And then your validator in the model file should look like that:
 ```erb
-/^(?=.*?[A-Z])(?=.*?[a-z])(?=.*?[0-9])(?=.*?[#{Rails.application.config.allowed_special_chars}]).{#{Devise.password_length.first},#{Devise.password_length.last}}$/
+is_right_length = Devise.password_length.include?(password.length)
 ```
 and the validator:
 ```erb
 validators: {
-  length: Devise.password_length.first,
+  minlength: Devise.password_length.first,
+  maxlength: Devise.password_length.last,
   uppercase_char: true,
   lowercase_char: true,
   numeric_char: true,
-  special_char: Rails.application.config.allowed_special_chars
+  special_char: true
 }
 ```
 
@@ -147,6 +160,18 @@ possible to help us in fixing the potential bug. We also encourage you to help e
 
 https://github.com/noesya/simple_form_password_with_hints/issues
 
+## Testing
+
+```shell
+bundle install
+cd test/dummy
+bin/rails db:create db:migrate
+bin/rails server 
+````
+
+Manual test on the page http://localhost:3000/users/sign_up
+
+
 ## Maintainers
 
 * Pierre-André Boissinot (https://github.com/pabois)

data/app/assets/javascripts/simple_form_password_with_hints.js

@@ -73,17 +73,37 @@ Element.prototype.parent = function (selector) {
 
         check: function (container, key, value) {
             var check = container.querySelector('.js-sfpwh-hint-' + key),
-                regexKey,
-                regex;
-
-            if (check) {
-                regexKey = this.getRegex(key, check);
-                regex = new RegExp(regexKey);
-                if (value.match(regex)) {
-                    check.classList.remove('sfpwh-hint--invalid');
-                } else {
-                    check.classList.add('sfpwh-hint--invalid');
-                }
+                valid = true;
+
+            if (!check) {
+                return
+            }
+
+            switch (key) {
+                case 'uppercase':
+                    valid = new RegExp('[A-Z]').test(value);
+                    break;
+                case 'lowercase':
+                    valid = new RegExp('[a-z]').test(value);
+                    break;
+                case 'number':
+                    valid = new RegExp('[0-9]').test(value);
+                    break;
+                case 'length':
+                    var min = check.getAttribute('data-minlength'),
+                        max = check.getAttribute('data-maxlength');
+                    valid = value.length >= min && value.length <= max;
+                    break;
+                case 'special':
+                    valid = new RegExp('[^A-z0-9]').test(value);
+                default:
+                    break;
+            }
+
+            if (valid) {
+                check.classList.remove('sfpwh-hint--invalid');
+            } else {
+                check.classList.add('sfpwh-hint--invalid');
             }
         },
 
@@ -117,38 +137,6 @@ Element.prototype.parent = function (selector) {
 
             input.type = input.type === 'text' ? 'password' : 'text';
         },
-
-        // HELPERS
-
-        getRegex: function (key, element) {
-            var regex,
-                min,
-                chars;
-
-            switch (key) {
-            case 'uppercase':
-                regex = '[A-Z]';
-                break;
-            case 'lowercase':
-                regex = '[a-z]';
-                break;
-            case 'number':
-                regex = '[0-9]';
-                break;
-            case 'special':
-                // hyphen must be at the end
-                chars = element.getAttribute('data-chars');
-                regex = '[' + chars + ']';
-                break;
-            case 'length':
-                min = element.getAttribute('data-length');
-                regex = '.{' + min + ',128}';
-                break;
-            default:
-                break;
-            }
-            return regex;
-        }
     };
 
     if (document.readyState === 'complete' || document.readyState === 'interactive') {

data/config/locales/en.yml

@@ -1,6 +1,6 @@
 en:
   simple_form_password_with_hints:
-    test_chars: "%{min_length} characters minimum"
+    test_chars: "Between %{min_length} and %{max_length} characters"
     test_uppercase: 'Uppercase'
     test_lowercase: 'Lowercase'
     test_numeric: 'Number'

data/config/locales/fr.yml

@@ -1,6 +1,6 @@
 fr:
   simple_form_password_with_hints:
-    test_chars: "%{min_length} caractères minimum"
+    test_chars: "Entre %{min_length} et %{max_length} caractères"
     test_uppercase: 'Majuscule'
     test_lowercase: 'Minuscule'
     test_numeric: 'Chiffre'

data/lib/simple_form_password_with_hints/password_with_hints_input.rb

@@ -35,12 +35,19 @@ class PasswordWithHintsInput < ::SimpleForm::Inputs::Base
   end
 
   def length_div
-    template.content_tag(
-      :span,
-      t('simple_form_password_with_hints.test_chars', min_length: options[:validators][:length]),
-      data: { length: options[:validators][:length] },
-      class: 'sfpwh-hint sfpwh-hint--invalid sfpwh-hint--length js-sfpwh-hint-length'
-    ) if should_display?(:length)
+    # Retrocompatibility with the previous "length" param
+    if should_display?(:minlength) or should_display?(:length) then 
+      minlength = options[:validators][:minlength] || options[:validators][:length]
+      # Retrocompatibility with the previous "maxlength" default value
+      maxlength = options[:validators][:maxlength] || 128
+
+      template.content_tag(
+        :span,
+        t('simple_form_password_with_hints.test_chars', min_length: minlength, max_length: maxlength),
+        data: { minlength:, maxlength: },
+        class: 'sfpwh-hint sfpwh-hint--invalid sfpwh-hint--length js-sfpwh-hint-length'
+      ) 
+    end
   end
 
   def uppercase_div

data/lib/simple_form_password_with_hints/version.rb

@@ -1,3 +1,3 @@
 module SimpleFormPasswordWithHints
-  VERSION = "0.0.10".freeze
+  VERSION = "0.0.12".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simple_form_password_with_hints
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.12
 platform: ruby
 authors:
 - Pierre-andré Boissinot
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-10-28 00:00:00.000000000 Z
+date: 2026-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -72,7 +72,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".DS_Store"
 - ".eslintrc.yml"
 - ".gitignore"
 - ".sass-lint.yml"