simple_form_attachments 0.2.6 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ee4c708e8de9ee3b379ebed06b02e1ee276536f8
-  data.tar.gz: 9624ab7be6b0a93e2a11feb8b22205e1b698f6af
+  metadata.gz: 32937e7bfd5b986371b84849e0978f6351f1483c
+  data.tar.gz: 90721d27ee39824d4f6aeb3f6a8d32f84d15980a
 SHA512:
-  metadata.gz: 69dae6c84f549224206c4b41f96ccf75a9b42340057ad19af509076233c91f652532084d976fdd06b20d3e54a7f5eb6f61f8157348b11647a67e45b772a614a1
-  data.tar.gz: 3444e12acc217efb705b8c5881020f0a87af37794f932df9bb819372f457fc8e6679c3374719b2bb41365a199fc64946bf5afa8e58cc0f10a824b99d28a2dc80
+  metadata.gz: 4faa06b6077c22c05011becf23da50daaaea0bc926097b8d3a2b13527050e538cb6d4c15d2a641fae850ff112b3d8000955e889abdf4bbf4934c3e263a9b0a8b
+  data.tar.gz: b23ec5127609dd3b41a45c386e99ea12d24dddbab5a67f294d84e31d35eb4ade677ea83d8b56f950f6d8ca2522ecb4d5324e82ce8debda28f3b63ac99fdc3896

data/CHANGELOG.md

@@ -0,0 +1,6 @@
+# CHANGELOG
+
+## 1.0.0
+
+* css classes scoped in the `simple_form_attachments` namespace
+* markup changed from `table` to `div` for more flexibility

data/Gemfile

@@ -3,3 +3,5 @@ source 'https://rails-assets.org'
 
 # Specify your gem's dependencies in simple_form_epic_editor.gemspec
 gemspec
+
+gem 'rb-readline'

data/Gemfile.lock

@@ -1,8 +1,9 @@
 PATH
   remote: .
   specs:
-    simple_form_attachments (0.2.6)
+    simple_form_attachments (1.0.0)
       jquery-ui-rails
+      mongoid (> 4.0)
       rails (>= 4.2)
       rails-assets-blueimp-file-upload (>= 9.6.0)
       rails-assets-handlebars
@@ -13,66 +14,68 @@ GEM
   remote: https://rubygems.org/
   remote: https://rails-assets.org/
   specs:
-    actionmailer (4.2.7.1)
-      actionpack (= 4.2.7.1)
-      actionview (= 4.2.7.1)
-      activejob (= 4.2.7.1)
+    actioncable (5.1.1)
+      actionpack (= 5.1.1)
+      nio4r (~> 2.0)
+      websocket-driver (~> 0.6.1)
+    actionmailer (5.1.1)
+      actionpack (= 5.1.1)
+      actionview (= 5.1.1)
+      activejob (= 5.1.1)
       mail (~> 2.5, >= 2.5.4)
-      rails-dom-testing (~> 1.0, >= 1.0.5)
-    actionpack (4.2.7.1)
-      actionview (= 4.2.7.1)
-      activesupport (= 4.2.7.1)
-      rack (~> 1.6)
-      rack-test (~> 0.6.2)
-      rails-dom-testing (~> 1.0, >= 1.0.5)
+      rails-dom-testing (~> 2.0)
+    actionpack (5.1.1)
+      actionview (= 5.1.1)
+      activesupport (= 5.1.1)
+      rack (~> 2.0)
+      rack-test (~> 0.6.3)
+      rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (4.2.7.1)
-      activesupport (= 4.2.7.1)
+    actionview (5.1.1)
+      activesupport (= 5.1.1)
       builder (~> 3.1)
-      erubis (~> 2.7.0)
-      rails-dom-testing (~> 1.0, >= 1.0.5)
-      rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    activejob (4.2.7.1)
-      activesupport (= 4.2.7.1)
-      globalid (>= 0.3.0)
-    activemodel (4.2.7.1)
-      activesupport (= 4.2.7.1)
-      builder (~> 3.1)
-    activerecord (4.2.7.1)
-      activemodel (= 4.2.7.1)
-      activesupport (= 4.2.7.1)
-      arel (~> 6.0)
-    activesupport (4.2.7.1)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.0.3)
+    activejob (5.1.1)
+      activesupport (= 5.1.1)
+      globalid (>= 0.3.6)
+    activemodel (5.1.1)
+      activesupport (= 5.1.1)
+    activerecord (5.1.1)
+      activemodel (= 5.1.1)
+      activesupport (= 5.1.1)
+      arel (~> 8.0)
+    activesupport (5.1.1)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (~> 0.7)
-      json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
-      thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
-    addressable (2.4.0)
-    arel (6.0.4)
-    bson (3.2.6)
-    builder (3.2.2)
+    addressable (2.5.1)
+      public_suffix (~> 2.0, >= 2.0.2)
+    arel (8.0.0)
+    bson (4.2.1)
+    builder (3.2.3)
     coderay (1.1.1)
     concurrent-ruby (1.0.5)
-    connection_pool (2.2.0)
-    coveralls (0.8.15)
+    coveralls (0.8.21)
       json (>= 1.8, < 3)
-      simplecov (~> 0.12.0)
+      simplecov (~> 0.14.1)
       term-ansicolor (~> 1.3)
-      thor (~> 0.19.1)
-      tins (>= 1.6.0, < 2)
-    database_cleaner (1.5.3)
+      thor (~> 0.19.4)
+      tins (~> 1.6)
+    database_cleaner (1.6.1)
     docile (1.1.5)
-    dragonfly (1.0.12)
+    dragonfly (1.1.3)
       addressable (~> 2.3)
       multi_json (~> 1.0)
-      rack (>= 1.3.0)
-    erubis (2.7.0)
-    ffi (1.9.14)
+      rack (>= 1.3)
+    erubi (1.6.0)
+    ffi (1.9.18)
     formatador (0.2.5)
-    globalid (0.3.7)
-      activesupport (>= 4.1.0)
-    guard (2.14.0)
+    globalid (0.4.0)
+      activesupport (>= 4.2.0)
+    guard (2.14.1)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       lumberjack (~> 1.0)
@@ -85,105 +88,103 @@ GEM
     guard-minitest (2.4.6)
       guard-compat (~> 1.2)
       minitest (>= 3.0)
-    i18n (0.7.0)
+    i18n (0.8.4)
     jquery-ui-rails (6.0.1)
       railties (>= 3.2.16)
-    json (1.8.3)
+    json (2.1.0)
     listen (3.1.5)
       rb-fsevent (~> 0.9, >= 0.9.4)
       rb-inotify (~> 0.9, >= 0.9.7)
       ruby_dep (~> 1.2)
     loofah (2.0.3)
       nokogiri (>= 1.5.9)
-    lumberjack (1.0.10)
-    mail (2.6.4)
+    lumberjack (1.0.12)
+    mail (2.6.5)
       mime-types (>= 1.16, < 4)
     method_source (0.8.2)
     mime-types (3.1)
       mime-types-data (~> 3.2015)
     mime-types-data (3.2016.0521)
-    mini_portile2 (2.1.0)
-    minitest (5.9.0)
-    minitest-rails (2.2.1)
-      minitest (~> 5.7)
-      railties (~> 4.1)
-    mongoid (4.0.0)
-      activemodel (~> 4.0)
-      moped (~> 2.0.0)
-      origin (~> 2.1)
-      tzinfo (>= 0.3.37)
-    moped (2.0.7)
-      bson (~> 3.0)
-      connection_pool (~> 2.0)
-      optionable (~> 0.2.0)
+    mini_portile2 (2.2.0)
+    minitest (5.10.2)
+    minitest-rails (3.0.0)
+      minitest (~> 5.8)
+      railties (~> 5.0)
+    mongo (2.4.2)
+      bson (>= 4.2.1, < 5.0.0)
+    mongoid (6.2.0)
+      activemodel (~> 5.1)
+      mongo (>= 2.4.1, < 3.0.0)
     multi_json (1.12.1)
     nenv (0.3.0)
-    nokogiri (1.6.8)
-      mini_portile2 (~> 2.1.0)
-      pkg-config (~> 1.1.7)
+    nio4r (2.1.0)
+    nokogiri (1.8.0)
+      mini_portile2 (~> 2.2.0)
     notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    optionable (0.2.0)
-    origin (2.2.0)
-    pkg-config (1.1.7)
     pry (0.10.4)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
-    rack (1.6.4)
+    public_suffix (2.0.5)
+    rack (2.0.3)
     rack-test (0.6.3)
       rack (>= 1.0)
-    rails (4.2.7.1)
-      actionmailer (= 4.2.7.1)
-      actionpack (= 4.2.7.1)
-      actionview (= 4.2.7.1)
-      activejob (= 4.2.7.1)
-      activemodel (= 4.2.7.1)
-      activerecord (= 4.2.7.1)
-      activesupport (= 4.2.7.1)
+    rails (5.1.1)
+      actioncable (= 5.1.1)
+      actionmailer (= 5.1.1)
+      actionpack (= 5.1.1)
+      actionview (= 5.1.1)
+      activejob (= 5.1.1)
+      activemodel (= 5.1.1)
+      activerecord (= 5.1.1)
+      activesupport (= 5.1.1)
       bundler (>= 1.3.0, < 2.0)
-      railties (= 4.2.7.1)
-      sprockets-rails
+      railties (= 5.1.1)
+      sprockets-rails (>= 2.0.0)
     rails-assets-blueimp-canvas-to-blob (3.7.0)
-    rails-assets-blueimp-file-upload (9.17.0)
+    rails-assets-blueimp-file-upload (9.18.0)
       rails-assets-blueimp-canvas-to-blob (>= 2.1.1)
       rails-assets-blueimp-load-image (>= 1.13.0)
       rails-assets-blueimp-tmpl (>= 2.5.4)
       rails-assets-jquery (>= 1.6)
     rails-assets-blueimp-load-image (2.12.2)
     rails-assets-blueimp-tmpl (3.8.0)
-    rails-assets-handlebars (4.0.5)
-    rails-assets-jquery (3.1.1)
-    rails-deprecated_sanitizer (1.0.3)
-      activesupport (>= 4.2.0.alpha)
-    rails-dom-testing (1.0.7)
-      activesupport (>= 4.2.0.beta, < 5.0)
-      nokogiri (~> 1.6.0)
-      rails-deprecated_sanitizer (>= 1.0.1)
+    rails-assets-handlebars (4.0.10)
+    rails-assets-jquery (3.2.1)
+    rails-controller-testing (1.0.2)
+      actionpack (~> 5.x, >= 5.0.1)
+      actionview (~> 5.x, >= 5.0.1)
+      activesupport (~> 5.x)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
     rails-html-sanitizer (1.0.3)
       loofah (~> 2.0)
-    railties (4.2.7.1)
-      actionpack (= 4.2.7.1)
-      activesupport (= 4.2.7.1)
+    railties (5.1.1)
+      actionpack (= 5.1.1)
+      activesupport (= 5.1.1)
+      method_source
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
     rake (10.5.0)
-    rb-fsevent (0.9.7)
-    rb-inotify (0.9.7)
+    rb-fsevent (0.9.8)
+    rb-inotify (0.9.8)
       ffi (>= 0.5.0)
-    ruby_dep (1.4.0)
+    rb-readline (0.5.4)
+    ruby_dep (1.5.0)
     shellany (0.0.1)
-    simple_form (3.4.0)
-      actionpack (> 4, < 5.1)
-      activemodel (> 4, < 5.1)
-    simplecov (0.12.0)
+    simple_form (3.5.0)
+      actionpack (> 4, < 5.2)
+      activemodel (> 4, < 5.2)
+    simplecov (0.14.1)
       docile (~> 1.1.0)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.0)
-    slim (3.0.7)
-      temple (~> 0.7.6)
+    simplecov-html (0.10.1)
+    slim (3.0.8)
+      temple (>= 0.7.6, < 0.9)
       tilt (>= 1.3.3, < 2.1)
     slop (3.6.0)
     sprockets (3.7.1)
@@ -193,15 +194,18 @@ GEM
       actionpack (>= 4.0)
       activesupport (>= 4.0)
       sprockets (>= 3.0.0)
-    temple (0.7.7)
-    term-ansicolor (1.3.2)
+    temple (0.8.0)
+    term-ansicolor (1.6.0)
       tins (~> 1.0)
-    thor (0.19.1)
-    thread_safe (0.3.5)
-    tilt (2.0.6)
-    tins (1.12.0)
-    tzinfo (1.2.2)
+    thor (0.19.4)
+    thread_safe (0.3.6)
+    tilt (2.0.7)
+    tins (1.14.0)
+    tzinfo (1.2.3)
       thread_safe (~> 0.1)
+    websocket-driver (0.6.5)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.2)
 
 PLATFORMS
   ruby
@@ -215,9 +219,10 @@ DEPENDENCIES
   guard-minitest
   minitest (~> 5.0)
   minitest-rails
-  mongoid (~> 4.0)
+  rails-controller-testing
   rake (~> 10.0)
+  rb-readline
   simple_form_attachments!
 
 BUNDLED WITH
-   1.13.6
+   1.14.6

data/README.md

@@ -127,30 +127,46 @@ Sorting of attachments is turned on by default for `has_many_attachments` relati
 
 ### Views
 
-Uploaded attachments are displayed in a `table`. The gem will look for a partial using the normal rails partial lookup (with a fallback to the default partial), this makes it easy to define a partial for each of your attachment models.
+Uploaded attachments are displayed in a `div`. The gem will look for a partial using the normal rails partial lookup (with a fallback to the default partial), this makes it easy to define a partial for each of your attachment models.
+
+Here an example partial for a model called `AttachmentImage`:
 
-Here is an example partial for a model called `AttachmentImage`:
 ```slim
 / app/views/simple_form_attachments/attachment_images/_attachment_image.html.slim
-/ Note the simple_form_attachments prefix!
+/ (Note the nesting in 'simple_form_attachments' directory.)
 
-td.thumb
-  div.thumb
-    = image_tag attachment.thumb_url, alt: attachment.file_name
+div class=SimpleFormAttachments.dom_class(:attachment, [:col, :thumb])
+  = image_tag attachment.thumb_url
 
-td.file_info
-  = link_to attachment.file_name, attachment.file.url
-  span.mime_type = attachment.file_mime_type
-  span.size = attachment.file_size
+div class=SimpleFormAttachments.dom_class(:attachment, [:col, :file_info])
+  span class=SimpleFormAttachments.dom_class(:attachment, :col, :file_info, :name)
+    = link_to attachment.file_name, attachment.file.url
+  span class=SimpleFormAttachments.dom_class(:attachment, :col, :file_info, :mime_type)
+    = attachment.file_mime_type
+  span class=SimpleFormAttachments.dom_class(:attachment, :col, :file_info, :size) data-filesize=attachment.file_size
+    = attachment.file_size
 
 - if attachment.errors.to_a.any?
-  td.errors = render 'simple_form_attachments/errors', errors: attachment.errors.to_a
+  div class=SimpleFormAttachments.dom_class(:attachment, [:col, :errors])
+    = render 'simple_form_attachments/errors', errors: attachment.errors.to_a
 
 - else
-  td.fields
+  div class=SimpleFormAttachments.dom_class(:attachment, [:col, :fields])
     = fields.input :caption
 ```
 
+### Dom class and CSS
+
+The component is isolated in `simple_form_attachments` namespace. This gem comes with its own helper that geners corresponding class names – for example `SimpleFormAttachments.dom_class(:attachment, :file_info)` would generate `simple_form_attachments__file_info`.
+
+Basic styling can be achieved by including `simple_form_attachments.js` css in your app:
+
+```css
+/*
+*= require simple_form_attachments
+*/
+```
+
 #### Validation errors
 
 If you want to show validation errors in your partial, simply include the `simple_form_attachments/errors` partial as shown above.
@@ -166,12 +182,11 @@ class AttachmentsController < SimpleFormAttachments::UploadController
   # The default controller uses the attachment type passed from the form input
   # to determine which Attachment class to create.
   #
-  # This can be easily overriden, for instance if you want to determine
+  # This can be easily overridden, for instance if you want to infer
   # the class from the `mime type` of the file:
   #
   def attachment_class
     mime_type = params[:attachment][:file].content_type
-    # TODO: very smart code to determine the class from the mime_type
   end
 end
 ```

data/app/controllers/simple_form_attachments/upload_controller.rb

@@ -1,5 +1,7 @@
 module SimpleFormAttachments
   class UploadController < ActionController::Base
+    protect_from_forgery with: :exception
+
     def show
       @attachment = attachment_class.find(params[:id])
       render json: { html: attachment_html(@attachment) }, status: :ok
@@ -11,7 +13,7 @@ module SimpleFormAttachments
       render json: { html: attachment_html(@attachment) }, status: (res ? :ok : :unprocessable_entity)
     end
 
-    private # =============================================================
+    private
 
     def new_attachment
       attachment_class.new(attachment_params).tap do |att|

data/app/models/concerns/simple_form_attachments/attachment.rb

@@ -12,7 +12,7 @@ module SimpleFormAttachments
     end
 
     def to_simple_form_partial_path
-      ['simple_form_attachments', to_partial_path].join('/')
+      File.join('simple_form_attachments', to_partial_path)
     end
   end
 end

data/app/models/concerns/simple_form_attachments/has_attachments.rb

@@ -15,9 +15,9 @@ module SimpleFormAttachments
         attachment_accessor_names << accessor_name
 
         options = {
-          class_name: opts[:class_name] || 'SimpleFormAttachments::Attachment',
-          dependent: opts[:dependent],
-          inverse_of: nil
+          class_name: opts.fetch(:class_name, nil),
+          dependent: opts.fetch(:dependent, nil),
+          inverse_of: opts.fetch(:inverse_of, nil),
         }
 
         has_and_belongs_to_many accessor_name, options do
@@ -27,14 +27,16 @@ module SimpleFormAttachments
           # or at least we maintain the query and sort on the db level,
           # but as of not it is not possible to provide custom sort function to mongodb
           #
-          define_method 'sorted' do
-            target.sort_by { |attachment| base.send("#{accessor_name.to_s.singularize}_ids").index(attachment.id) }
+          define_method :sorted do
+            target.sort_by do |attachment|
+              base.send("#{accessor_name.to_s.singularize}_ids").index(attachment.id)
+            end
           end
         end
 
         accepts_nested_attributes_for accessor_name
 
-        define_method "mark_#{accessor_name}_permanent" do
+        define_method :"mark_#{accessor_name}_permanent" do
           send(accessor_name).update_all(temporary: false)
         end
       end
@@ -45,8 +47,9 @@ module SimpleFormAttachments
         attachment_accessor_names << accessor_name
 
         options = {
-          class_name: opts[:class_name] || 'SimpleFormAttachments::Attachment',
-          dependent: opts[:dependent]
+          class_name: opts.fetch(:class_name, nil),
+          dependent: opts.fetch(:dependent, nil),
+          optional: opts.fetch(:optional, true)
         }
 
         belongs_to accessor_name, options

data/app/views/layouts/simple_form_attachments/_attachment_layout.html.slim

@@ -1,14 +1,14 @@
-tr.attachment class=('uploaded' if attachment.present? && attachment.errors.to_a.blank?)
-  td.handle
+div class=[SimpleFormAttachments.dom_class(:attachment), (SimpleFormAttachments.dom_class(:attachment, :is_uploaded) if attachment.present? && attachment.errors.to_a.blank?)]
+
+  div class=SimpleFormAttachments.dom_class(:attachment, [:col, :handle])
 
   = yield
 
-  td.hidden
+  div class=SimpleFormAttachments.dom_class(:attachment, [:col, :hidden])
     = fields.hidden_field :id
     = form.hidden_field(relation_key, multiple: multiple, value: attachment.id) if attachment.errors.empty?
 
-  td.cancel.delete.close
-    - if attachment.errors.to_a.any?
-      button.button.close = I18n.t(:close, scope: 'simple_form_attachments.buttons')
-    - else
-      button.button.delete = I18n.t(:delete, scope: 'simple_form_attachments.buttons')
+  div class=SimpleFormAttachments.dom_class(:attachment, [:col, :actions])
+    - button_type = attachment.errors.to_a.any? ? :close : :delete
+    button class=SimpleFormAttachments.dom_class([:button, button_type])
+      = I18n.t(button_type, scope: 'simple_form_attachments.buttons')

data/app/views/simple_form_attachments/_errors.html.slim

@@ -1,4 +1,5 @@
 = I18n.t(:errors, scope: :simple_form_attachments, count: errors.to_a.length)
-ul.errors
-  - errors.map{ |k, v| "#{k} #{v}" }.each do |error|
-    li.error = error
+
+ul
+  - errors.map { |k, v| [k, v].join(' ') }.each do |error|
+    li = error

data/app/views/simple_form_attachments/attachments/_attachment.hbs.slim

@@ -1,17 +1,16 @@
-tr.attachment
-  td.handle
-  td.thumb
-  td.file_info
-    span.name
-      | {{ name }}
-    span.mime_type
-      | {{ mime_type }}
-    span.size
-      | {{ size }}
+div class=SimpleFormAttachments.dom_class(:attachment)
+  div class=SimpleFormAttachments.dom_class(:attachment, [:col, :handle])
+  div class=SimpleFormAttachments.dom_class(:attachment, [:col, :thumb])
 
-  td.progress
-    div.progress.container
-      div.progress.bar
+  div class=SimpleFormAttachments.dom_class(:attachment, [:col, :file_info])
+    div class=SimpleFormAttachments.dom_class(:attachment, :col, :file_info, :name) {{ name }}
+    div class=SimpleFormAttachments.dom_class(:attachment, :col, :file_info, :mime_type) {{ mime_type }}
+    div class=SimpleFormAttachments.dom_class(:attachment, :col, :file_info, :size) data-filesize='{{ size }}' {{ size }}
 
-  td.cancel.delete.close
-    button.button.cancel = I18n.t(:cancel, scope: 'simple_form_attachments.buttons')
+  div class=SimpleFormAttachments.dom_class(:attachment, [:col, :progress])
+    div class=SimpleFormAttachments.dom_class(:attachment, [:col, :progress, :container])
+      div class=SimpleFormAttachments.dom_class(:attachment, [:col, :progress, :bar])
+
+  div class=SimpleFormAttachments.dom_class(:attachment, [:col, :actions])
+    button class=SimpleFormAttachments.dom_class([:button, :cancel])
+      = I18n.t(:cancel, scope: 'simple_form_attachments.buttons')

data/app/views/simple_form_attachments/attachments/_attachment.html.slim

@@ -1,4 +1,6 @@
 - if attachment.errors.to_a.any?
-  td.errors = render 'simple_form_attachments/errors', errors: attachment.errors.to_a
+  div class=SimpleFormAttachments.dom_class(:attachment, [:col, :errors])
+    = render 'simple_form_attachments/errors', errors: attachment.errors.to_a
+
 - else
-  td
+  div

data/config/locales/simple_form_attachments/simple_form_attachments.en.yml

@@ -3,9 +3,14 @@ en:
     buttons:
       delete: Delete
       cancel: Cancel
-      close: ''
-      disabled: Uploading …
-      file_field: Select files
+      close: 'Close'
+      disabled: 'Uploading …'
+      file_field: 'Select files'
     errors:
       one: 'There was %{count} error:'
       other: 'There were %{count} errors:'
+    links:
+      choose_file:
+        zero: 'Choose file'
+        one: 'Choose file'
+        other: 'Choose files'

data/config/routes.rb

@@ -1,6 +1,6 @@
 SimpleFormAttachments::Engine.routes.draw do
   scope module: :simple_form_attachments do
-    get "attachments/:id" => "upload#show", as: :attachment
-    post "attachments" => "upload#create", as: :attachments
+    get 'attachments/:id' => 'upload#show', as: :attachment
+    post 'attachments' => 'upload#create', as: :attachments
   end
 end