simple_form 5.2.0 → 5.3.0

data/test/form_builder/association_test.rb

@@ -1,252 +0,0 @@
-# frozen_string_literal: true
-# encoding: UTF-8
-require 'test_helper'
-
-class AssociationTest < ActionView::TestCase
-  def with_association_for(object, *args)
-    with_concat_form_for(object) do |f|
-      f.association(*args)
-    end
-  end
-
-  test 'builder does not allow creating an association input when no object exists' do
-    assert_raise ArgumentError do
-      with_association_for :post, :author
-    end
-  end
-
-  test 'builder association works with decorated object responsive to #to_model' do
-    assert_nothing_raised do
-      with_association_for @decorated_user, :company
-    end
-  end
-
-  test 'builder association with a block calls simple_fields_for' do
-    simple_form_for @user do |f|
-      f.association :posts do |posts_form|
-        assert posts_form.instance_of?(SimpleForm::FormBuilder)
-      end
-    end
-  end
-
-  test 'builder association forwards collection to simple_fields_for' do
-    calls = 0
-    simple_form_for @user do |f|
-      f.association :company, collection: Company.all do |c|
-        calls += 1
-      end
-    end
-
-    assert_equal 3, calls
-  end
-
-  test 'builder association marks input as required based on both association and attribute' do
-    swap SimpleForm, required_by_default: false do
-      with_association_for @validating_user, :company, collection: []
-      assert_select 'label.required'
-    end
-  end
-
-  test 'builder preloads collection association' do
-    value = @user.tags = MiniTest::Mock.new
-    value.expect(:to_a, value)
-
-    with_association_for @user, :tags
-    assert_select 'form select.select#user_tag_ids'
-    assert_select 'form select option[value="1"]', 'Tag 1'
-    assert_select 'form select option[value="2"]', 'Tag 2'
-    assert_select 'form select option[value="3"]', 'Tag 3'
-
-    value.verify
-  end
-
-  test 'builder does not preload collection association if preload is false' do
-    value = @user.tags = MiniTest::Mock.new
-    value.expect(:to_a, nil)
-
-    with_association_for @user, :tags, preload: false
-    assert_select 'form select.select#user_tag_ids'
-    assert_select 'form select option[value="1"]', 'Tag 1'
-    assert_select 'form select option[value="2"]', 'Tag 2'
-    assert_select 'form select option[value="3"]', 'Tag 3'
-
-    assert_raises MockExpectationError do
-      value.verify
-    end
-  end
-
-  test 'builder does not preload non-collection association' do
-    value = @user.company = MiniTest::Mock.new
-    value.expect(:to_a, nil)
-
-    with_association_for @user, :company
-    assert_select 'form select.select#user_company_id'
-    assert_select 'form select option[value="1"]', 'Company 1'
-    assert_select 'form select option[value="2"]', 'Company 2'
-    assert_select 'form select option[value="3"]', 'Company 3'
-
-    assert_raises MockExpectationError do
-      value.verify
-    end
-  end
-
-  # ASSOCIATIONS - BELONGS TO
-  test 'builder creates a select for belongs_to associations' do
-    with_association_for @user, :company
-    assert_select 'form select.select#user_company_id'
-    assert_select 'form select option[value="1"]', 'Company 1'
-    assert_select 'form select option[value="2"]', 'Company 2'
-    assert_select 'form select option[value="3"]', 'Company 3'
-  end
-
-  test 'builder creates blank select if collection is nil' do
-    with_association_for @user, :company, collection: nil
-    assert_select 'form select.select#user_company_id'
-    assert_no_select 'form select option[value="1"]', 'Company 1'
-  end
-
-  test 'builder allows collection radio for belongs_to associations' do
-    with_association_for @user, :company, as: :radio_buttons
-    assert_select 'form input.radio_buttons#user_company_id_1'
-    assert_select 'form input.radio_buttons#user_company_id_2'
-    assert_select 'form input.radio_buttons#user_company_id_3'
-  end
-
-  test 'builder allows collection to have a proc as a condition' do
-    with_association_for @user, :extra_special_company
-    assert_select 'form select.select#user_extra_special_company_id'
-    assert_select 'form select option[value="1"]'
-    assert_no_select 'form select option[value="2"]'
-    assert_no_select 'form select option[value="3"]'
-  end
-
-  test 'builder allows collection to have a scope' do
-    with_association_for @user, :special_pictures
-    assert_select 'form select.select#user_special_picture_ids'
-    assert_select 'form select option[value="3"]', '3'
-    assert_no_select 'form select option[value="1"]'
-    assert_no_select 'form select option[value="2"]'
-  end
-
-  test 'builder allows collection to have a scope with parameter' do
-    with_association_for @user, :special_tags
-    assert_select 'form select.select#user_special_tag_ids'
-    assert_select 'form select[multiple=multiple]'
-    assert_select 'form select option[value="1"]', 'Tag 1'
-    assert_no_select 'form select option[value="2"]'
-    assert_no_select 'form select option[value="3"]'
-  end
-
-  test 'builder marks the record which already belongs to the user' do
-    @user.company_id = 2
-    with_association_for @user, :company, as: :radio_buttons
-    assert_no_select 'form input.radio_buttons#user_company_id_1[checked=checked]'
-    assert_select 'form input.radio_buttons#user_company_id_2[checked=checked]'
-    assert_no_select 'form input.radio_buttons#user_company_id_3[checked=checked]'
-  end
-
-  # ASSOCIATIONS - FINDERS
-  test 'builder uses reflection conditions to find collection' do
-    with_association_for @user, :special_company
-    assert_select 'form select.select#user_special_company_id'
-    assert_select 'form select option[value="1"]'
-    assert_no_select 'form select option[value="2"]'
-    assert_no_select 'form select option[value="3"]'
-  end
-
-  test 'builder allows overriding collection to association input' do
-    with_association_for @user, :company, include_blank: false,
-                         collection: [Company.new(999, 'Teste')]
-    assert_select 'form select.select#user_company_id'
-    assert_no_select 'form select option[value="1"]'
-    assert_select 'form select option[value="999"]', 'Teste'
-    assert_select 'form select option', count: 1
-  end
-
-  # ASSOCIATIONS - has_*
-  test 'builder does not allow has_one associations' do
-    assert_raise ArgumentError do
-      with_association_for @user, :first_company, as: :radio_buttons
-    end
-  end
-
-  test 'builder does not call where if the given association does not respond to it' do
-    with_association_for @user, :friends
-    assert_select 'form select.select#user_friend_ids'
-    assert_select 'form select[multiple=multiple]'
-    assert_select 'form select option[value="1"]', 'Friend 1'
-    assert_select 'form select option[value="2"]', 'Friend 2'
-    assert_select 'form select option[value="3"]', 'Friend 3'
-  end
-
-  test 'builder does not call order if the given association does not respond to it' do
-    with_association_for @user, :pictures
-    assert_select 'form select.select#user_picture_ids'
-    assert_select 'form select[multiple=multiple]'
-    assert_select 'form select option[value="1"]', 'Picture 1'
-    assert_select 'form select option[value="2"]', 'Picture 2'
-    assert_select 'form select option[value="3"]', 'Picture 3'
-  end
-
-  test 'builder creates a select with multiple options for collection associations' do
-    with_association_for @user, :tags
-    assert_select 'form select.select#user_tag_ids'
-    assert_select 'form select[multiple=multiple]'
-    assert_select 'form select option[value="1"]', 'Tag 1'
-    assert_select 'form select option[value="2"]', 'Tag 2'
-    assert_select 'form select option[value="3"]', 'Tag 3'
-  end
-
-  test 'builder allows size to be overwritten for collection associations' do
-    with_association_for @user, :tags, input_html: { size: 10 }
-    assert_select 'form select[multiple=multiple][size="10"]'
-  end
-
-  test 'builder marks all selected records which already belongs to user' do
-    @user.tag_ids = [1, 2]
-    with_association_for @user, :tags
-    assert_select 'form select option[value="1"][selected=selected]'
-    assert_select 'form select option[value="2"][selected=selected]'
-    assert_no_select 'form select option[value="3"][selected=selected]'
-  end
-
-  test 'builder allows a collection of check boxes for collection associations' do
-    @user.tag_ids = [1, 2]
-    with_association_for @user, :tags, as: :check_boxes
-    assert_select 'form input#user_tag_ids_1[type=checkbox]'
-    assert_select 'form input#user_tag_ids_2[type=checkbox]'
-    assert_select 'form input#user_tag_ids_3[type=checkbox]'
-  end
-
-  test 'builder marks all selected records for collection boxes' do
-    @user.tag_ids = [1, 2]
-    with_association_for @user, :tags, as: :check_boxes
-    assert_select 'form input[type=checkbox][value="1"][checked=checked]'
-    assert_select 'form input[type=checkbox][value="2"][checked=checked]'
-    assert_no_select 'form input[type=checkbox][value="3"][checked=checked]'
-  end
-
-  test 'builder with collection support giving collection and item wrapper tags' do
-    with_association_for @user, :tags, as: :check_boxes,
-      collection_wrapper_tag: :ul, item_wrapper_tag: :li
-
-    assert_select 'form ul', count: 1
-    assert_select 'form ul li', count: 3
-  end
-
-  test 'builder with collection support does not change the options hash' do
-    options = { as: :check_boxes, collection_wrapper_tag: :ul, item_wrapper_tag: :li }
-    with_association_for @user, :tags, options
-
-    assert_select 'form ul', count: 1
-    assert_select 'form ul li', count: 3
-    assert_equal({ as: :check_boxes, collection_wrapper_tag: :ul, item_wrapper_tag: :li },
-                 options)
-  end
-
-  test 'builder with group select considers multiple select by default' do
-    with_association_for @user, :tags, as: :grouped_select, group_method: :group_method
-
-    assert_select 'select[multiple="multiple"].grouped_select'
-  end
-end

data/test/form_builder/button_test.rb

@@ -1,48 +0,0 @@
-# frozen_string_literal: true
-# encoding: UTF-8
-require 'test_helper'
-
-class ButtonTest < ActionView::TestCase
-  def with_button_for(object, *args)
-    with_concat_form_for(object) do |f|
-      f.button(*args)
-    end
-  end
-
-  test 'builder creates buttons' do
-    with_button_for :post, :submit
-    assert_select 'form input.button[type=submit][value="Save Post"]'
-  end
-
-  test 'builder creates buttons with options' do
-    with_button_for :post, :submit, class: 'my_button'
-    assert_select 'form input.button.my_button[type=submit][value="Save Post"]'
-  end
-
-  test 'builder does not modify the options hash' do
-    options = { class: 'my_button' }
-    with_button_for :post, :submit, options
-    assert_select 'form input.button.my_button[type=submit][value="Save Post"]'
-    assert_equal({ class: 'my_button' }, options)
-  end
-
-  test 'builder creates buttons for records' do
-    @user.new_record!
-    with_button_for @user, :submit
-    assert_select 'form input.button[type=submit][value="Create User"]'
-  end
-
-  test "builder uses the default class from the configuration" do
-    swap SimpleForm, button_class: 'btn' do
-      with_button_for :post, :submit
-      assert_select 'form input.btn[type=submit][value="Save Post"]'
-    end
-  end
-
-  if ActionView::Helpers::FormBuilder.method_defined?(:button)
-    test "allows to use Rails button helper when available" do
-      with_button_for :post, :button, 'Save!'
-      assert_select 'form button.button[type=submit]', 'Save!'
-    end
-  end
-end

data/test/form_builder/error_notification_test.rb

@@ -1,80 +0,0 @@
-# frozen_string_literal: true
-# encoding: UTF-8
-require 'test_helper'
-
-# Tests for f.error_notification
-class ErrorNotificationTest < ActionView::TestCase
-  def with_error_notification_for(object, options = {}, &block)
-    with_concat_form_for(object) do |f|
-      f.error_notification(options)
-    end
-  end
-
-  test 'error notification is not generated when the object has no error' do
-    assert @validating_user.valid?
-
-    with_error_notification_for @validating_user
-    assert_no_select 'p.error_notification'
-  end
-
-  test 'error notification is not generated for forms without objects' do
-    with_error_notification_for :user
-    assert_no_select 'p.error_notification'
-  end
-
-  test 'error notification is generated when the object has some error' do
-    with_error_notification_for @user
-    assert_select 'p.error_notification', 'Please review the problems below:'
-  end
-
-  test 'error notification uses I18n based on model to generate the notification message' do
-    store_translations(:en, simple_form: { error_notification: { user:
-      'Alguns erros foram encontrados para o usuário:'
-    } }) do
-      with_error_notification_for @user
-      assert_select 'p.error_notification', 'Alguns erros foram encontrados para o usuário:'
-    end
-  end
-
-  test 'error notification uses I18n fallbacking to default message' do
-    store_translations(:en, simple_form: { error_notification: {
-      default_message: 'Opa! Alguns erros foram encontrados, poderia verificar?'
-    } }) do
-      with_error_notification_for @user
-      assert_select 'p.error_notification', 'Opa! Alguns erros foram encontrados, poderia verificar?'
-    end
-  end
-
-  test 'error notification allows passing the notification message' do
-    with_error_notification_for @user, message: 'Erro encontrado ao criar usuario'
-    assert_select 'p.error_notification', 'Erro encontrado ao criar usuario'
-  end
-
-  test 'error notification accepts other html options' do
-    with_error_notification_for @user, id: 'user_error_message', class: 'form_error'
-    assert_select 'p#user_error_message.form_error.error_notification'
-  end
-
-  test 'error notification allows configuring the wrapper element' do
-    swap SimpleForm, error_notification_tag: :div do
-      with_error_notification_for @user
-      assert_select 'div.error_notification'
-    end
-  end
-
-  test 'error notification can contain HTML tags' do
-    with_error_notification_for @user, message: 'Erro encontrado ao criar <b>usuário</b>'
-    assert_select 'p.error_notification', 'Erro encontrado ao criar usuário'
-    assert_select 'p.error_notification b', 'usuário'
-  end
-
-  test 'error notification uses I18n based on model to generate the notification message and accepts HTML' do
-    store_translations(:en, simple_form: { error_notification: { user:
-      'Alguns erros foram encontrados para o <b>usuário</b>:'
-    } }) do
-      with_error_notification_for @user
-      assert_select 'p.error_notification', 'Alguns erros foram encontrados para o usuário:'
-      assert_select 'p.error_notification b', 'usuário'
-    end
-  end
-end

data/test/form_builder/error_test.rb

@@ -1,281 +0,0 @@
-# frozen_string_literal: true
-require 'test_helper'
-
-# Tests for f.error and f.full_error
-class ErrorTest < ActionView::TestCase
-  def with_error_for(object, *args)
-    with_concat_form_for(object) do |f|
-      f.error(*args)
-    end
-  end
-
-  def with_full_error_for(object, *args)
-    with_concat_form_for(object) do |f|
-      f.full_error(*args)
-    end
-  end
-
-  test 'error does not generate content for attribute without errors' do
-    with_error_for @user, :active
-    assert_no_select 'span.error'
-  end
-
-  test 'error does not generate messages when object is not present' do
-    with_error_for :project, :name
-    assert_no_select 'span.error'
-  end
-
-  test "error does not generate messages when object doesn't respond to errors method" do
-    @user.instance_eval { undef errors }
-    with_error_for @user, :name
-    assert_no_select 'span.error'
-  end
-
-  test 'error generates messages for attribute with single error' do
-    with_error_for @user, :name
-    assert_select 'span.error', "cannot be blank"
-  end
-
-  test 'error generates messages with decorated object responsive to #to_model' do
-    with_error_for @decorated_user, :name
-    assert_select 'span.error', "cannot be blank"
-  end
-
-  test 'error generates messages for attribute with one error when using first' do
-    swap SimpleForm, error_method: :first do
-      with_error_for @user, :age
-      assert_select 'span.error', 'is not a number'
-    end
-  end
-
-  test 'error generates messages for attribute with several errors when using to_sentence' do
-    swap SimpleForm, error_method: :to_sentence do
-      with_error_for @user, :age
-      assert_select 'span.error', 'is not a number and must be greater than 18'
-    end
-  end
-
-  test 'error is able to pass html options' do
-    with_error_for @user, :name, id: 'error', class: 'yay'
-    assert_select 'span#error.error.yay'
-  end
-
-  test 'error does not modify the options hash' do
-    options = { id: 'error', class: 'yay' }
-    with_error_for @user, :name, options
-    assert_select 'span#error.error.yay'
-    assert_equal({ id: 'error', class: 'yay' }, options)
-  end
-
-  test 'error finds errors on attribute and association' do
-    with_error_for @user, :company_id, as: :select,
-      error_method: :to_sentence, reflection: Association.new(Company, :company, {})
-    assert_select 'span.error', 'must be valid and company must be present'
-  end
-
-  test 'error generates an error tag with a clean HTML' do
-    with_error_for @user, :name
-    assert_no_select 'span.error[error_html]'
-  end
-
-  test 'error generates an error tag with a clean HTML when errors options are present' do
-    with_error_for @user, :name, error_tag: :p, error_prefix: 'Name', error_method: :first
-    assert_no_select 'p.error[error_html]'
-    assert_no_select 'p.error[error_tag]'
-    assert_no_select 'p.error[error_prefix]'
-    assert_no_select 'p.error[error_method]'
-  end
-
-  test 'error escapes error prefix text' do
-    with_error_for @user, :name, error_prefix: '<b>Name</b>'
-    assert_no_select 'span.error b'
-  end
-
-  test 'error escapes error text' do
-    @user.errors.add(:action, 'must not contain <b>markup</b>')
-
-    with_error_for @user, :action
-
-    assert_select 'span.error'
-    assert_no_select 'span.error b', 'markup'
-  end
-
-  test 'error generates an error message with raw HTML tags' do
-    with_error_for @user, :name, error_prefix: '<b>Name</b>'.html_safe
-    assert_select 'span.error', "Name cannot be blank"
-    assert_select 'span.error b', "Name"
-  end
-
-  test 'error adds aria-invalid attribute to inputs' do
-    with_form_for @user, :name, error: true
-    assert_select "input#user_name[name='user[name]'][aria-invalid='true']"
-
-    with_form_for @user, :name, as: :text, error: true
-    assert_select "textarea#user_name[name='user[name]'][aria-invalid='true']"
-
-    @user.errors.add(:active, 'must select one')
-    with_form_for @user, :active, as: :radio_buttons
-    assert_select "input#user_active_true[type=radio][name='user[active]'][aria-invalid='true']"
-    assert_select "input#user_active_false[type=radio][name='user[active]'][aria-invalid='true']"
-
-    with_form_for @user, :active, as: :check_boxes
-    assert_select "input#user_active_true[type=checkbox][aria-invalid='true']"
-    assert_select "input#user_active_false[type=checkbox][aria-invalid='true']"
-
-    with_form_for @user, :company_id, as: :select, error: true
-    assert_select "select#user_company_id[aria-invalid='true']"
-
-    @user.errors.add(:password, 'must not be blank')
-    with_form_for @user, :password
-    assert_select "input#user_password[type=password][aria-invalid='true']"
-  end
-
-  # FULL ERRORS
-
-  test 'full error generates a full error tag for the attribute' do
-    with_full_error_for @user, :name
-    assert_select 'span.error', "Super User Name! cannot be blank"
-  end
-
-  test 'full error generates a full error tag with a clean HTML' do
-    with_full_error_for @user, :name
-    assert_no_select 'span.error[error_html]'
-  end
-
-  test 'full error allows passing options to full error tag' do
-    with_full_error_for @user, :name, id: 'name_error', error_prefix: "Your name"
-    assert_select 'span.error#name_error', "Your name cannot be blank"
-  end
-
-  test 'full error does not modify the options hash' do
-    options = { id: 'name_error' }
-    with_full_error_for @user, :name, options
-    assert_select 'span.error#name_error', "Super User Name! cannot be blank"
-    assert_equal({ id: 'name_error' }, options)
-  end
-
-  test 'full error escapes error text' do
-    @user.errors.add(:action, 'must not contain <b>markup</b>')
-
-    with_full_error_for @user, :action
-
-    assert_select 'span.error'
-    assert_no_select 'span.error b', 'markup'
-  end
-
-  # CUSTOM WRAPPERS
-
-  test 'error with custom wrappers works' do
-    swap_wrapper do
-      with_error_for @user, :name
-      assert_select 'span.omg_error', "cannot be blank"
-    end
-  end
-
-  # FULL_ERROR_WRAPPER
-
-  test 'full error finds errors on association' do
-    swap_wrapper :default, custom_wrapper_with_full_error do
-      with_form_for @user, :company_id, as: :select
-      assert_select 'span.error', 'Company must be valid'
-    end
-  end
-
-  test 'full error finds errors on association with reflection' do
-    swap_wrapper :default, custom_wrapper_with_full_error do
-      with_form_for @user, :company_id, as: :select,
-        reflection: Association.new(Company, :company, {})
-      assert_select 'span.error', 'Company must be valid'
-    end
-  end
-
-  test 'full error can be disabled' do
-    swap_wrapper :default, custom_wrapper_with_full_error do
-      with_form_for @user, :company_id, as: :select, full_error: false
-      assert_no_select 'span.error'
-    end
-  end
-
-  test 'full error can be disabled setting error to false' do
-    swap_wrapper :default, custom_wrapper_with_full_error do
-      with_form_for @user, :company_id, as: :select, error: false
-      assert_no_select 'span.error'
-    end
-  end
-
-  # CUSTOM ERRORS
-
-  test 'input with custom error works' do
-    error_text = "Super User Name! cannot be blank"
-    with_form_for @user, :name, error: error_text
-
-    assert_select 'span.error', error_text
-  end
-
-  test 'input with error option as true does not use custom error' do
-    with_form_for @user, :name, error: true
-
-    assert_select 'span.error', "cannot be blank"
-  end
-
-  test 'input with custom error does not generate the error if there is no error on the attribute' do
-    with_form_for @user, :active, error: "Super User Active! cannot be blank"
-
-    assert_no_select 'span.error'
-  end
-
-  test 'input with custom error works when form does not use a model' do
-    with_form_for :user, :active, error: "Super User Active! cannot be blank"
-
-    assert_select 'span.error'
-  end
-
-  test 'input with custom error works when using full_error component' do
-    swap_wrapper :default, custom_wrapper_with_full_error do
-      error_text = "Super User Name! cannot be blank"
-      with_form_for @user, :name, error: error_text
-
-      assert_select 'span.error', error_text
-    end
-  end
-
-  test 'input with custom error escapes the error text' do
-    with_form_for @user, :name, error: 'error must not contain <b>markup</b>'
-
-    assert_select 'span.error'
-    assert_no_select 'span.error b', 'markup'
-  end
-
-  test 'input with custom error does not escape the error text if it is safe' do
-    with_form_for @user, :name, error: 'error must contain <b>markup</b>'.html_safe
-
-    assert_select 'span.error'
-    assert_select 'span.error b', 'markup'
-  end
-
-  test 'input with custom error escapes the error text using full_error component' do
-    swap_wrapper :default, custom_wrapper_with_full_error do
-      with_form_for @user, :name, error: 'error must not contain <b>markup</b>'
-
-      assert_select 'span.error'
-      assert_no_select 'span.error b', 'markup'
-    end
-  end
-
-  test 'input with custom error does not escape the error text if it is safe using full_error component' do
-    swap_wrapper :default, custom_wrapper_with_full_error do
-      with_form_for @user, :name, error: 'error must contain <b>markup</b>'.html_safe
-
-      assert_select 'span.error'
-      assert_select 'span.error b', 'markup'
-    end
-  end
-
-  test 'input with custom error when using full_error component does not generate the error if there is no error on the attribute' do
-    swap_wrapper :default, custom_wrapper_with_full_error do
-      with_form_for @user, :active, error: "Super User Active! can't be blank"
-
-      assert_no_select 'span.error'
-    end
-  end
-end