simple_form 5.0.0 → 5.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a1bfd4d5f14c750caf9e2fa6287033c0331473215737a96b4bcece8e6f84a7a9
-  data.tar.gz: 9c09b014e449f5b8823c062092b864e538c638fd418d782919a9c0a3cd50df78
+  metadata.gz: 33ed74564d4101bac4d57185cb4f6353efd54710777b7b62164238a4d3df1157
+  data.tar.gz: 524a1c33d2f856eec0be831200a57bde6c9823ac05b3e34bdb12daf23b6b25b0
 SHA512:
-  metadata.gz: 620056c8b34f6f93229b2ee0771adb0aa7d267fcc22b9d94c214f62287061930e9b0e35a648f47a890452cb8098bc57643a1dce7bbed3df3c2058546b58c5090
-  data.tar.gz: 4fa4e5a106b9065405fbba77b8a84ed99e86d84ea4a4435d0a459ee0196a020afbec0ec62fcd2c79f8885d771e48700409ae055ea4858d15b2b5ddd9c3fb5168
+  metadata.gz: 26391a5a691422cf7956107e39273142e63fa3a4804f26e76fb722d70dbc868e1090fa04278f652dd1310c3d3a74e4affcea8864219d4bd09dc4aacd567e21f5
+  data.tar.gz: 05e515e1eacfe356c45409ad4db258a6da6ed4760050ccf8e44ec4e6ad7430a3f6ace82fd2392452d59fa5b38e1b94356415d0a478b029679abd861d03dd4a94

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## Unreleased
 
+## 5.0.1
+
+### Bug fix
+* Replace `_url` with `remote_url` when trying to guess file inputs [@tegon](https://github.com/tegon). This has the side-effect of changing carrierwave's support from `0.2.1` to `0.2.2`.
+
 ## 5.0.0
 
 ### Enhancements

data/README.md

@@ -1233,6 +1233,8 @@ sending us a pull request.
 
 https://github.com/plataformatec/simple_form/issues
 
+If you have discovered a security related bug, please do NOT use the GitHub issue tracker. Send an e-mail to opensource@plataformatec.com.br.
+
 ## Maintainers
 
 * José Valim (https://github.com/josevalim)

data/lib/simple_form/form_builder.rb

@@ -580,18 +580,17 @@ module SimpleForm
     #
     # Note: This does not support multiple file upload inputs, as this is very application-specific.
     #
-    # The order here was choosen based on the popularity of Gems and for commodity - e.g. the method
-    # with the suffix `_url` is present in three Gems, so it's checked with priority:
+    # The order here was chosen based on the popularity of Gems:
     #
     # - `#{attribute_name}_attachment` - ActiveStorage >= `5.2` and Refile >= `0.2.0` <= `0.4.0`
-    # - `#{attribute_name}_url` - Shrine >= `0.9.0`, Refile >= `0.6.0` and CarrierWave >= `0.2.1`
+    # - `remote_#{attribute_name}_url` - Refile >= `0.3.0` and CarrierWave >= `0.2.2`
     # - `#{attribute_name}_attacher` - Refile >= `0.4.0` and Shrine >= `0.9.0`
     # - `#{attribute_name}_file_name` - Paperclip ~> `2.0` (added for backwards compatibility)
     #
     # Returns a Boolean.
     def file_method?(attribute_name)
       @object.respond_to?("#{attribute_name}_attachment") ||
-        @object.respond_to?("#{attribute_name}_url") ||
+        @object.respond_to?("remote_#{attribute_name}_url") ||
         @object.respond_to?("#{attribute_name}_attacher") ||
         @object.respond_to?("#{attribute_name}_file_name")
     end

data/lib/simple_form/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SimpleForm
-  VERSION = "5.0.0".freeze
+  VERSION = "5.0.1".freeze
 end

data/test/form_builder/general_test.rb

@@ -244,7 +244,7 @@ class FormBuilderTest < ActionView::TestCase
     assert_select 'form input#user_with_attachment_avatar.file'
   end
 
-  test 'builder generates file input for Shrine >= 0.9.0, Refile >= 0.6.0 and CarrierWave >= 0.2.1' do
+  test 'builder generates file input for Refile >= 0.3.0 and CarrierWave >= 0.2.2' do
     with_form_for UserWithAttachment.build, :cover
     assert_select 'form input#user_with_attachment_cover.file'
   end

data/test/support/models.rb

@@ -339,7 +339,7 @@ class UserWithAttachment < User
     OpenStruct.new
   end
 
-  def cover_url
+  def remote_cover_url
     "/uploads/cover.png"
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simple_form
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.0.1
 platform: ruby
 authors:
 - José Valim
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-27 00:00:00.000000000 Z
+date: 2019-10-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -162,15 +162,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Forms made easy!