simple_form 3.1.0 → 5.0.0

data/test/inputs/string_input_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # encoding: UTF-8
 require 'test_helper'
 
@@ -7,6 +8,11 @@ class StringInputTest < ActionView::TestCase
     assert_select "input#user_name[type=text][name='user[name]'][value='New in SimpleForm!']"
   end
 
+  test 'input maps text field to citext attribute' do
+    with_input_for @user, :name, :citext
+    assert_select "input#user_name[type=text][name='user[name]'][value='New in SimpleForm!']"
+  end
+
   test 'input generates a password field for password attributes' do
     with_input_for @user, :password, :password
     assert_select "input#user_password.password[type=password][name='user[password]']"
@@ -32,9 +38,9 @@ class StringInputTest < ActionView::TestCase
     assert_select 'input.string[maxlength="25"]'
   end
 
-  test 'input does not get maxlength from validation when tokenizer present' do
-    with_input_for @validating_user, :action, :string
-    assert_no_select 'input.string[maxlength]'
+  test 'input infers minlength column definition from validation when present' do
+    with_input_for @validating_user, :name, :string
+    assert_select 'input.string[minlength="5"]'
   end
 
   test 'input gets maxlength from validation when :is option present' do
@@ -42,6 +48,11 @@ class StringInputTest < ActionView::TestCase
     assert_select 'input.string[maxlength="12"]'
   end
 
+  test 'input gets minlength from validation when :is option present' do
+    with_input_for @validating_user, :home_picture, :string
+    assert_select 'input.string[minlength="12"]'
+  end
+
   test 'input maxlength is the column limit plus one to make room for decimal point' do
     with_input_for @user, :credit_limit, :string
 
@@ -70,12 +81,12 @@ class StringInputTest < ActionView::TestCase
 
   test 'input infers pattern from attributes' do
     with_input_for @other_validating_user, :country, :string, pattern: true
-    assert_select 'input[pattern="\w+"]'
+    assert_select "input:match('pattern', ?)", /\w+/
   end
 
   test 'input infers pattern from attributes using proc' do
     with_input_for @other_validating_user, :name, :string, pattern: true
-    assert_select 'input[pattern="\w+"]'
+    assert_select "input:match('pattern', ?)", /\w+/
   end
 
   test 'input does not infer pattern from attributes if root default is false' do
@@ -87,7 +98,7 @@ class StringInputTest < ActionView::TestCase
 
   test 'input uses given pattern from attributes' do
     with_input_for @other_validating_user, :country, :string, input_html: { pattern: "\\d+" }
-    assert_select 'input[pattern="\d+"]'
+    assert_select "input:match('pattern', ?)", /\\d+/
   end
 
   test 'input does not use pattern if model has :without validation option' do
@@ -115,16 +126,7 @@ class StringInputTest < ActionView::TestCase
     end
   end
 
-  test 'input translates a key prefixed with _html and return the html markup' do
-    store_translations(:en, simple_form: { labels: { user: {
-      name_html: '<b>Name</b>'
-    } } }) do
-      with_input_for @user, :name, :string
-      assert_select 'label b', 'Name'
-    end
-  end
-
-  [:email, :url, :search, :tel].each do |type|
+  %i[email url search tel].each do |type|
     test "input allows type #{type}" do
       with_input_for @user, :name, type
       assert_select "input.string.#{type}"

data/test/inputs/text_input_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # encoding: UTF-8
 require 'test_helper'
 
@@ -12,6 +13,13 @@ class TextInputTest < ActionView::TestCase
     assert_select 'textarea.text[placeholder="Put in some text"]'
   end
 
+  test 'input generates a placeholder from the translations' do
+    store_translations(:en, simple_form: { placeholders: { user: { name: "placeholder from i18n en.simple_form.placeholders.user.name" } } }) do
+      with_input_for @user, :name, :text
+      assert_select 'textarea.text[placeholder="placeholder from i18n en.simple_form.placeholders.user.name"]'
+    end
+  end
+
   test 'input gets maxlength from column definition for text attributes' do
     with_input_for @user, :description, :text
     assert_select 'textarea.text[maxlength="200"]'
@@ -21,4 +29,9 @@ class TextInputTest < ActionView::TestCase
     with_input_for @validating_user, :description, :text
     assert_select 'textarea.text[maxlength="50"]'
   end
+
+  test 'input infers minlength column definition from validation when present for text attributes' do
+    with_input_for @validating_user, :description, :text
+    assert_select 'textarea.text[minlength="15"]'
+  end
 end

data/test/simple_form_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class SimpleFormTest < ActiveSupport::TestCase

data/test/support/discovery_inputs.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class StringInput < SimpleForm::Inputs::StringInput
   def input(wrapper_options = nil)
     "<section>#{super}</section>".html_safe
@@ -36,6 +37,13 @@ class CollectionSelectInput < SimpleForm::Inputs::CollectionSelectInput
   end
 end
 
+class FileInput < SimpleForm::Inputs::FileInput
+  def input_html_classes
+    super.delete_if { |html_class| html_class == :file }
+    super.push('file-upload')
+  end
+end
+
 module CustomInputs
   class CustomizedInput < SimpleForm::Inputs::StringInput
     def input_html_classes

data/test/support/misc_helpers.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module MiscHelpers
   def store_translations(locale, translations, &block)
     I18n.backend.store_translations locale, translations
@@ -46,7 +47,7 @@ module MiscHelpers
     end
   end
 
-  def swap_wrapper(name = :default, wrapper = self.custom_wrapper)
+  def swap_wrapper(name = :default, wrapper = custom_wrapper)
     old = SimpleForm.wrappers[name.to_s]
     SimpleForm.wrappers[name.to_s] = wrapper
     yield
@@ -91,6 +92,20 @@ module MiscHelpers
     end
   end
 
+  def custom_wrapper_with_input_data_modal
+    SimpleForm.build tag: :div, class: "custom_wrapper" do |b|
+      b.use :label
+      b.use :input, data: { modal: 'data-modal', wrapper: 'data-wrapper' }
+    end
+  end
+
+  def custom_wrapper_with_input_aria_modal
+    SimpleForm.build tag: :div, class: "custom_wrapper" do |b|
+      b.use :label
+      b.use :input, aria: { modal: 'aria-modal', wrapper: 'aria-wrapper' }
+    end
+  end
+
   def custom_wrapper_with_label_class
     SimpleForm.build tag: :div, class: "custom_wrapper" do |b|
       b.use :label, class: 'inline-class'
@@ -167,7 +182,7 @@ module MiscHelpers
   end
 
   def custom_wrapper_with_label_text
-    SimpleForm.build :label_text => proc { |label, required| "**#{label}**" } do |b|
+    SimpleForm.build label_text: proc { |label, required| "**#{label}**" } do |b|
       b.use :label_input
     end
   end
@@ -184,6 +199,27 @@ module MiscHelpers
     end
   end
 
+  def custom_wrapper_with_required_input
+    SimpleForm.build tag: :span, class: 'custom_wrapper' do |b|
+      b.use :html5
+      b.use :input, required: true
+    end
+  end
+
+  def custom_wrapper_with_input_error_class
+    SimpleForm.build tag: :div, class: "custom_wrapper", error_class: :field_with_errors do |b|
+      b.use :label
+      b.use :input, class: 'inline-class', error_class: 'is-invalid'
+    end
+  end
+
+  def custom_wrapper_with_input_valid_class
+    SimpleForm.build tag: :div, class: "custom_wrapper", valid_class: :field_without_errors do |b|
+      b.use :label
+      b.use :input, class: 'inline-class', valid_class: 'is-valid'
+    end
+  end
+
   def custom_form_for(object, *args, &block)
     simple_form_for(object, *args, { builder: CustomFormBuilder }, &block)
   end
@@ -219,6 +255,12 @@ module MiscHelpers
       f.input(attribute_name, options.merge(as: type))
     end
   end
+
+  def with_input_field_for(object, *args)
+    with_concat_form_for(object) do |f|
+      f.input_field(*args)
+    end
+  end
 end
 
 class CustomFormBuilder < SimpleForm::FormBuilder

data/test/support/mock_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class MockController
   attr_writer :action_name
 
@@ -9,7 +10,7 @@ class MockController
     defined?(@action_name) ? @action_name : "edit"
   end
 
-  def url_for(*args)
+  def url_for(*)
     "http://example.com"
   end
 
@@ -17,8 +18,13 @@ class MockController
     {}
   end
 
+  def polymorphic_mappings(*); {}; end
+
   def hash_for_user_path(*); end
+
   def hash_for_validating_user_path(*); end
+
   def hash_for_other_validating_user_path(*); end
+  
   def hash_for_users_path(*); end
 end

data/test/support/models.rb

@@ -1,17 +1,14 @@
+# frozen_string_literal: true
 Association = Struct.new(:klass, :name, :macro, :scope, :options)
 
 Column = Struct.new(:name, :type, :limit) do
-  # Returns +true+ if the column is either of type integer, float or decimal.
-  def number?
-    type == :integer || type == :float || type == :decimal
-  end
 end
 
 Relation = Struct.new(:records) do
   delegate :each, to: :records
 
   def where(conditions = nil)
-    self.class.new conditions ? records.first : records
+    self.class.new conditions ? [records.first] : records
   end
 
   def order(conditions = nil)
@@ -22,6 +19,12 @@ Relation = Struct.new(:records) do
   alias_method :to_ary, :records
 end
 
+Decorator = Struct.new(:object) do
+  def to_model
+    object
+  end
+end
+
 Picture = Struct.new(:id, :name) do
   extend ActiveModel::Naming
   include ActiveModel::Conversion
@@ -60,7 +63,24 @@ Company = Struct.new(:id, :name) do
   end
 end
 
-class Tag < Company; end
+Friend = Struct.new(:id, :name) do
+  extend ActiveModel::Naming
+  include ActiveModel::Conversion
+
+  def self.all
+    (1..3).map { |i| new(i, "#{name} #{i}") }
+  end
+
+  def persisted?
+    true
+  end
+end
+
+class Tag < Company
+  def group_method
+    ["category-1"]
+  end
+end
 
 TagGroup = Struct.new(:id, :name, :tags)
 
@@ -74,7 +94,8 @@ class User
     :avatar, :home_picture, :email, :status, :residence_country, :phone_number,
     :post_count, :lock_version, :amount, :attempts, :action, :credit_card, :gender,
     :extra_special_company_id, :pictures, :picture_ids, :special_pictures,
-    :special_picture_ids, :uuid
+    :special_picture_ids, :uuid, :friends, :friend_ids, :special_tags, :special_tag_ids,
+    :citext, :hstore, :json, :jsonb, :hourly, :favorite_color
 
   def self.build(extra_attributes = {})
     attributes = {
@@ -125,24 +146,65 @@ class User
       when :attempts      then :integer
       when :action        then :string
       when :credit_card   then :string
-      when :uuid          then :uuid
+      else attribute.to_sym
     end
     Column.new(attribute, column_type, limit)
   end
 
+  begin
+    require 'active_model/type'
+    begin
+      ActiveModel::Type.lookup(:text)
+    rescue ArgumentError        # :text is no longer an ActiveModel::Type
+      # But we don't want our tests to depend on ActiveRecord
+      class ::ActiveModel::Type::Text < ActiveModel::Type::String
+        def type; :text; end
+      end
+      ActiveModel::Type.register(:text, ActiveModel::Type::Text)
+    end
+    def type_for_attribute(attribute)
+      column_type, limit = case attribute
+        when 'name', 'status', 'password' then [:string, 100]
+        when 'description'   then [:text, 200]
+        when 'age'           then :integer
+        when 'credit_limit'  then [:decimal, 15]
+        when 'active'        then :boolean
+        when 'born_at'       then :date
+        when 'delivery_time' then :time
+        when 'created_at'    then :datetime
+        when 'updated_at'    then :datetime
+        when 'lock_version'  then :integer
+        when 'home_picture'  then :string
+        when 'amount'        then :integer
+        when 'attempts'      then :integer
+        when 'action'        then :string
+        when 'credit_card'   then :string
+        when 'uuid'          then :string
+        when 'citext'        then :string
+        when 'hstore'        then [:text, 200]
+        when 'json'          then [:text, 200]
+        when 'jsonb'         then [:text, 200]
+      end
+
+      ActiveModel::Type.lookup(column_type, limit: limit)
+    end
+  rescue LoadError
+  end
+
   def has_attribute?(attribute)
     case attribute.to_sym
       when :name, :status, :password, :description, :age,
         :credit_limit, :active, :born_at, :delivery_time,
         :created_at, :updated_at, :lock_version, :home_picture,
-        :amount, :attempts, :action, :credit_card, :uuid then true
+        :amount, :attempts, :action, :credit_card, :uuid,
+        :citext, :hstore, :json, :jsonb then true
       else false
     end
   end
 
   def self.human_attribute_name(attribute, options = {})
     case attribute
-      when 'name'
+      when 'name', :name
         'Super User Name!'
       when 'description'
         'User Description!'
@@ -159,16 +221,20 @@ class User
         Association.new(Company, association, :belongs_to, nil, {})
       when :tags
         Association.new(Tag, association, :has_many, nil, {})
+      when :special_tags
+        Association.new(Tag, association, :has_many, ->(user) { where(id: user.id) }, {})
       when :first_company
         Association.new(Company, association, :has_one, nil, {})
       when :special_company
-        Association.new(Company, association, :belongs_to, nil, { conditions: { id: 1 } })
+        Association.new(Company, association, :belongs_to, nil, conditions: { id: 1 })
       when :extra_special_company
-        Association.new(Company, association, :belongs_to, nil, { conditions: proc { { id: self.id } } })
+        Association.new(Company, association, :belongs_to, nil, conditions: proc { { id: self.id } })
       when :pictures
         Association.new(Picture, association, :has_many, nil, {})
       when :special_pictures
         Association.new(Picture, association, :has_many, proc { where(name: self.name) }, {})
+      when :friends
+        Association.new(Friend, association, :has_many, nil, {})
     end
   end
 
@@ -194,8 +260,8 @@ class ValidatingUser < User
   include ActiveModel::Validations
   validates :name, presence: true
   validates :company, presence: true
-  validates :age, presence: true, if: Proc.new { |user| user.name }
-  validates :amount, presence: true, unless: Proc.new { |user| user.age }
+  validates :age, presence: true, if: proc { |user| user.name }
+  validates :amount, presence: true, unless: proc { |user| user.age }
 
   validates :action,            presence: true, on: :create
   validates :credit_limit,      presence: true, on: :save
@@ -213,9 +279,8 @@ class ValidatingUser < User
     greater_than_or_equal_to: :min_attempts,
     less_than_or_equal_to: :max_attempts,
     only_integer: true
-  validates_length_of :name, maximum: 25
-  validates_length_of :description, maximum: 50
-  validates_length_of :action, maximum: 10, tokenizer: lambda { |str| str.scan(/\w+/) }
+  validates_length_of :name, maximum: 25, minimum: 5
+  validates_length_of :description, in: 15..50
   validates_length_of :home_picture, is: 12
 
   def min_amount
@@ -242,16 +307,16 @@ class OtherValidatingUser < User
     less_than: 100,
     only_integer: true
   validates_numericality_of :amount,
-    greater_than: Proc.new { |user| user.age },
-    less_than: Proc.new { |user| user.age + 100 },
+    greater_than: proc { |user| user.age },
+    less_than: proc { |user| user.age + 100 },
     only_integer: true
   validates_numericality_of :attempts,
-    greater_than_or_equal_to: Proc.new { |user| user.age },
-    less_than_or_equal_to: Proc.new { |user| user.age + 100 },
+    greater_than_or_equal_to: proc { |user| user.age },
+    less_than_or_equal_to: proc { |user| user.age + 100 },
     only_integer: true
 
   validates_format_of :country, with: /\w+/
-  validates_format_of :name, with: Proc.new { /\w+/ }
+  validates_format_of :name, with: proc { /\w+/ }
   validates_format_of :description, without: /\d+/
 end
 
@@ -268,3 +333,21 @@ end
 
 class UserNumber1And2 < User
 end
+
+class UserWithAttachment < User
+  def avatar_attachment
+    OpenStruct.new
+  end
+
+  def cover_url
+    "/uploads/cover.png"
+  end
+
+  def profile_image_attacher
+    OpenStruct.new
+  end
+
+  def portrait_file_name
+    "portrait.png"
+  end
+end

data/test/test_helper.rb

@@ -1,14 +1,13 @@
-require 'bundler/setup'
-
+# frozen_string_literal: true
 require 'minitest/autorun'
 
 require 'active_model'
 require 'action_controller'
 require 'action_view'
+
 ActionView::RoutingUrlFor.send(:include, ActionDispatch::Routing::UrlFor)
 
 require 'action_view/template'
-
 require 'action_view/test_case'
 
 module Rails
@@ -36,10 +35,18 @@ else
   ActionDispatch::Assertions::NO_STRIP << "label"
 end
 
+if ActiveSupport::TestCase.respond_to?(:test_order=)
+  ActiveSupport::TestCase.test_order = :random
+end
+
+require "rails/test_unit/line_filtering"
+
 class ActionView::TestCase
   include MiscHelpers
   include SimpleForm::ActionViewExtensions::FormHelper
 
+  extend Rails::LineFiltering
+
   setup :set_controller
   setup :setup_users
 
@@ -49,8 +56,11 @@ class ActionView::TestCase
 
   def setup_users(extra_attributes = {})
     @user = User.build(extra_attributes)
+    @decorated_user = Decorator.new(@user)
 
     @validating_user = ValidatingUser.build({
+      name: 'Tester McTesterson',
+      description: 'A test user of the most distinguised caliber',
       home_picture: 'Home picture',
       age: 19,
       amount: 15,
@@ -81,4 +91,5 @@ class ActionView::TestCase
   alias :validating_user_path :user_path
   alias :validating_users_path :user_path
   alias :other_validating_user_path :user_path
+  alias :user_with_attachment_path :user_path
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simple_form
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 5.0.0
 platform: ruby
 authors:
 - José Valim
@@ -10,36 +10,36 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-25 00:00:00.000000000 Z
+date: 2019-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '5.0'
 description: Forms made easy!
 email: opensource@plataformatec.com.br
 executables: []
@@ -70,6 +70,7 @@ files:
 - lib/simple_form/components/labels.rb
 - lib/simple_form/components/maxlength.rb
 - lib/simple_form/components/min_max.rb
+- lib/simple_form/components/minlength.rb
 - lib/simple_form/components/pattern.rb
 - lib/simple_form/components/placeholders.rb
 - lib/simple_form/components/readonly.rb
@@ -90,6 +91,7 @@ files:
 - lib/simple_form/inputs/collection_input.rb
 - lib/simple_form/inputs/collection_radio_buttons_input.rb
 - lib/simple_form/inputs/collection_select_input.rb
+- lib/simple_form/inputs/color_input.rb
 - lib/simple_form/inputs/date_time_input.rb
 - lib/simple_form/inputs/file_input.rb
 - lib/simple_form/inputs/grouped_collection_select_input.rb
@@ -112,6 +114,7 @@ files:
 - lib/simple_form/wrappers/single.rb
 - test/action_view_extensions/builder_test.rb
 - test/action_view_extensions/form_helper_test.rb
+- test/components/custom_components_test.rb
 - test/components/label_test.rb
 - test/form_builder/association_test.rb
 - test/form_builder/button_test.rb
@@ -127,6 +130,7 @@ files:
 - test/inputs/collection_check_boxes_input_test.rb
 - test/inputs/collection_radio_buttons_input_test.rb
 - test/inputs/collection_select_input_test.rb
+- test/inputs/color_input_test.rb
 - test/inputs/datetime_input_test.rb
 - test/inputs/disabled_test.rb
 - test/inputs/discovery_test.rb
@@ -165,45 +169,47 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: simple_form
-rubygems_version: 2.2.2
+rubyforge_project: 
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Forms made easy!
 test_files:
-- test/action_view_extensions/builder_test.rb
-- test/action_view_extensions/form_helper_test.rb
 - test/components/label_test.rb
-- test/form_builder/association_test.rb
-- test/form_builder/button_test.rb
-- test/form_builder/error_notification_test.rb
+- test/components/custom_components_test.rb
+- test/support/discovery_inputs.rb
+- test/support/misc_helpers.rb
+- test/support/mock_controller.rb
+- test/support/models.rb
+- test/test_helper.rb
 - test/form_builder/error_test.rb
-- test/form_builder/general_test.rb
 - test/form_builder/hint_test.rb
+- test/form_builder/error_notification_test.rb
+- test/form_builder/general_test.rb
+- test/form_builder/button_test.rb
 - test/form_builder/input_field_test.rb
 - test/form_builder/label_test.rb
 - test/form_builder/wrapper_test.rb
+- test/form_builder/association_test.rb
 - test/generators/simple_form_generator_test.rb
-- test/inputs/boolean_input_test.rb
+- test/action_view_extensions/builder_test.rb
+- test/action_view_extensions/form_helper_test.rb
+- test/simple_form_test.rb
+- test/inputs/string_input_test.rb
+- test/inputs/numeric_input_test.rb
+- test/inputs/readonly_test.rb
+- test/inputs/grouped_collection_select_input_test.rb
+- test/inputs/text_input_test.rb
 - test/inputs/collection_check_boxes_input_test.rb
-- test/inputs/collection_radio_buttons_input_test.rb
-- test/inputs/collection_select_input_test.rb
-- test/inputs/datetime_input_test.rb
+- test/inputs/boolean_input_test.rb
 - test/inputs/disabled_test.rb
 - test/inputs/discovery_test.rb
-- test/inputs/file_input_test.rb
+- test/inputs/collection_select_input_test.rb
 - test/inputs/general_test.rb
-- test/inputs/grouped_collection_select_input_test.rb
-- test/inputs/hidden_input_test.rb
-- test/inputs/numeric_input_test.rb
-- test/inputs/priority_input_test.rb
-- test/inputs/readonly_test.rb
+- test/inputs/color_input_test.rb
 - test/inputs/required_test.rb
-- test/inputs/string_input_test.rb
-- test/inputs/text_input_test.rb
-- test/simple_form_test.rb
-- test/support/discovery_inputs.rb
-- test/support/misc_helpers.rb
-- test/support/mock_controller.rb
-- test/support/models.rb
-- test/test_helper.rb
+- test/inputs/collection_radio_buttons_input_test.rb
+- test/inputs/priority_input_test.rb
+- test/inputs/hidden_input_test.rb
+- test/inputs/file_input_test.rb
+- test/inputs/datetime_input_test.rb