simple_form 3.1.0 → 3.5.0

data/test/form_builder/input_field_test.rb

@@ -2,10 +2,15 @@ require 'test_helper'
 
 # Tests for f.input_field
 class InputFieldTest < ActionView::TestCase
-  test "builder input_field only renders the input tag, nothing else" do
-    with_concat_form_for(@user) do |f|
-      f.input_field :name
+  def with_input_field_for(object, *args)
+    with_concat_form_for(object) do |f|
+      f.input_field(*args)
     end
+  end
+
+  test "builder input_field only renders the input tag, nothing else" do
+    with_input_field_for @user, :name
+
     assert_select 'form > input.required.string'
     assert_no_select 'div.string'
     assert_no_select 'label'
@@ -13,45 +18,34 @@ class InputFieldTest < ActionView::TestCase
   end
 
   test 'builder input_field allows overriding default input type' do
-    with_concat_form_for(@user) do |f|
-      f.input_field :name, as: :text
-    end
+    with_input_field_for @user, :name, as: :text
 
     assert_no_select 'input#user_name'
     assert_select 'textarea#user_name.text'
   end
 
   test 'builder input_field generates input type based on column type' do
-    with_concat_form_for(@user) do |f|
-      f.input_field :age
-    end
+    with_input_field_for @user, :age
 
     assert_select 'input[type=number].integer#user_age'
   end
 
   test 'builder input_field is able to disable any component' do
-    with_concat_form_for(@user) do |f|
-      f.input_field :age, html5: false
-    end
+    with_input_field_for @user, :age, html5: false
 
     assert_no_select 'input[html5=false]#user_age'
     assert_select 'input[type=text].integer#user_age'
   end
 
   test 'builder input_field allows passing options to input tag' do
-    with_concat_form_for(@user) do |f|
-      f.input_field :name, id: 'name_input', class: 'name'
-    end
+    with_input_field_for @user, :name, id: 'name_input', class: 'name'
 
     assert_select 'input.string.name#name_input'
   end
 
   test 'builder input_field does not modify the options hash' do
     options = { id: 'name_input', class: 'name' }
-
-    with_concat_form_for(@user) do |f|
-      f.input_field :name, options
-    end
+    with_input_field_for @user, :name, options
 
     assert_select 'input.string.name#name_input'
     assert_equal({ id: 'name_input', class: 'name' }, options)
@@ -59,9 +53,7 @@ class InputFieldTest < ActionView::TestCase
 
 
   test 'builder input_field generates an input tag with a clean HTML' do
-    with_concat_form_for(@user) do |f|
-      f.input_field :name, as: :integer, class: 'name'
-    end
+    with_input_field_for @user, :name, as: :integer, class: 'name'
 
     assert_no_select 'input.integer[input_html]'
     assert_no_select 'input.integer[as]'
@@ -71,67 +63,57 @@ class InputFieldTest < ActionView::TestCase
     store_translations(:en, simple_form: { placeholders: { user: {
       name: 'Name goes here'
     } } }) do
-
-      with_concat_form_for(@user) do |f|
-        f.input_field :name
-      end
+      with_input_field_for @user, :name
 
       assert_select 'input.string[placeholder="Name goes here"]'
     end
   end
 
   test 'builder input_field uses min_max component' do
-    with_concat_form_for(@other_validating_user) do |f|
-      f.input_field :age, as: :integer
-    end
+    with_input_field_for @other_validating_user, :age, as: :integer
 
     assert_select 'input[min="18"]'
   end
 
   test 'builder input_field does not use pattern component by default' do
-    with_concat_form_for(@other_validating_user) do |f|
-      f.input_field :country, as: :string
-    end
+    with_input_field_for @other_validating_user, :country, as: :string
 
     assert_no_select 'input[pattern="\w+"]'
   end
 
   test 'builder input_field infers pattern from attributes' do
-    with_concat_form_for(@other_validating_user) do |f|
-      f.input_field :country, as: :string, pattern: true
-    end
+    with_input_field_for @other_validating_user, :country, as: :string, pattern: true
 
     assert_select 'input[pattern="\w+"]'
   end
 
-  test 'builder input_field accepts custom patter' do
-    with_concat_form_for(@other_validating_user) do |f|
-      f.input_field :country, as: :string, pattern: '\d+'
-    end
+  test 'builder input_field accepts custom pattern' do
+    with_input_field_for @other_validating_user, :country, as: :string, pattern: '\d+'
 
     assert_select 'input[pattern="\d+"]'
   end
 
   test 'builder input_field uses readonly component' do
-    with_concat_form_for(@other_validating_user) do |f|
-      f.input_field :age, as: :integer, readonly: true
-    end
+    with_input_field_for @other_validating_user, :age, as: :integer, readonly: true
 
     assert_select 'input.integer.readonly[readonly]'
   end
 
   test 'builder input_field uses maxlength component' do
-    with_concat_form_for(@validating_user) do |f|
-      f.input_field :name, as: :string
-    end
+    with_input_field_for @validating_user, :name, as: :string
 
     assert_select 'input.string[maxlength="25"]'
   end
 
+  test 'builder input_field uses minlength component' do
+    with_input_field_for @validating_user, :name, as: :string
+
+    assert_select 'input.string[minlength="5"]'
+  end
+
   test 'builder collection input_field generates input tag with a clean HTML' do
-    with_concat_form_for(@user) do |f|
-      f.input_field :status, collection: ['Open', 'Closed'], class: 'status', label_method: :to_s, value_method: :to_s
-    end
+    with_input_field_for @user, :status, collection: ['Open', 'Closed'],
+      class: 'status', label_method: :to_s, value_method: :to_s
 
     assert_no_select 'select.status[input_html]'
     assert_no_select 'select.status[collection]'
@@ -140,48 +122,52 @@ class InputFieldTest < ActionView::TestCase
   end
 
   test 'build input_field does not treat "boolean_style" as a HTML attribute' do
-    with_concat_form_for(@user) do |f|
-      f.input_field :active, boolean_style: :nested
-    end
+    with_input_field_for @user, :active, boolean_style: :nested
 
     assert_no_select 'input.boolean[boolean_style]'
   end
 
+  test 'build input_field does not treat "prompt" as a HTML attribute' do
+    with_input_field_for @user, :attempts, collection: [1,2,3,4,5], prompt: :translate
+
+    assert_no_select 'select[prompt]'
+  end
+
   test 'build input_field without pattern component use the pattern string' do
-    swap_wrapper :default, self.custom_wrapper_with_html5_components do
-      with_concat_form_for(@user) do |f|
-        f.input_field :name, pattern: '\w+'
-      end
+    swap_wrapper :default, custom_wrapper_with_html5_components do
+      with_input_field_for @user, :name, pattern: '\w+'
 
       assert_select 'input[pattern="\w+"]'
     end
   end
 
   test 'build input_field without placeholder component use the placeholder string' do
-    swap_wrapper :default, self.custom_wrapper_with_html5_components do
-      with_concat_form_for(@user) do |f|
-        f.input_field :name, placeholder: 'Placeholder'
-      end
+    swap_wrapper :default, custom_wrapper_with_html5_components do
+      with_input_field_for @user, :name, placeholder: 'Placeholder'
 
       assert_select 'input[placeholder="Placeholder"]'
     end
   end
 
   test 'build input_field without maxlength component use the maxlength string' do
-    swap_wrapper :default, self.custom_wrapper_with_html5_components do
-      with_concat_form_for(@user) do |f|
-        f.input_field :name, maxlength: 5
-      end
+    swap_wrapper :default, custom_wrapper_with_html5_components do
+      with_input_field_for @user, :name, maxlength: 5
 
       assert_select 'input[maxlength="5"]'
     end
   end
 
+  test 'build input_field without minlength component use the minlength string' do
+    swap_wrapper :default, custom_wrapper_with_html5_components do
+      with_input_field_for @user, :name, minlength: 5
+
+      assert_select 'input[minlength="5"]'
+    end
+  end
+
   test 'build input_field without readonly component use the readonly string' do
-    swap_wrapper :default, self.custom_wrapper_with_html5_components do
-      with_concat_form_for(@user) do |f|
-        f.input_field :name, readonly: true
-      end
+    swap_wrapper :default, custom_wrapper_with_html5_components do
+      with_input_field_for @user, :name, readonly: true
 
       assert_select 'input[readonly="readonly"]'
     end

data/test/form_builder/label_test.rb

@@ -29,6 +29,16 @@ class LabelTest < ActionView::TestCase
     assert_select 'label.string.required[for=validating_user_name]', /Name/
   end
 
+  test 'builder adds a disabled class to label if the attribute is disabled' do
+    with_label_for @validating_user, :name, disabled: true
+    assert_select 'label.string.disabled[for=validating_user_name]', /Name/
+  end
+
+  test 'builder does not add a disabled class to label if the attribute is not disabled' do
+    with_label_for @validating_user, :name, disabled: false
+    assert_no_select 'label.string.disabled[for=validating_user_name]', /Name/
+  end
+
   test 'builder escapes label text' do
     with_label_for @user, :name, label: '<script>alert(1337)</script>', required: false
     assert_no_select 'label.string script'
@@ -80,7 +90,7 @@ class LabelTest < ActionView::TestCase
   end
 
   test 'configuration allow set label text for wrappers' do
-    swap_wrapper :default, self.custom_wrapper_with_label_text do
+    swap_wrapper :default, custom_wrapper_with_label_text do
       with_concat_form_for(@user) do |f|
         concat f.input :age
       end
@@ -89,7 +99,7 @@ class LabelTest < ActionView::TestCase
   end
 
   test 'configuration allow set rewrited label tag for wrappers' do
-    swap_wrapper :default, self.custom_wrapper_with_custom_label_component do
+    swap_wrapper :default, custom_wrapper_with_custom_label_component do
       with_concat_form_for(@user) do |f|
         concat f.input :age
       end
@@ -110,4 +120,11 @@ class LabelTest < ActionView::TestCase
       assert_select 'label[for=user_time_zone]', 'Time Zone:'
     end
   end
+
+  test 'builder allows label specific `label_text` option' do
+    with_label_for @user, :time_zone, label_text: lambda { |l, _, _| "#{l.titleize}:" }
+
+    assert_no_select 'label[label_text]'
+    assert_select 'label[for=user_time_zone]', 'Time Zone:'
+  end
 end

data/test/form_builder/wrapper_test.rb

@@ -129,7 +129,7 @@ class WrapperTest < ActionView::TestCase
   end
 
   test 'custom wrappers can have additional attributes' do
-    swap_wrapper :default, self.custom_wrapper_with_additional_attributes do
+    swap_wrapper :default, custom_wrapper_with_additional_attributes do
       with_form_for @user, :name
 
       assert_select "div.custom_wrapper[title='some title'][data-wrapper='test']"
@@ -137,7 +137,7 @@ class WrapperTest < ActionView::TestCase
   end
 
   test 'custom wrappers can have full error message on attributes' do
-    swap_wrapper :default, self.custom_wrapper_with_full_error do
+    swap_wrapper :default, custom_wrapper_with_full_error do
       with_form_for @user, :name
       assert_select 'span.error', "Name cannot be blank"
     end
@@ -188,7 +188,7 @@ class WrapperTest < ActionView::TestCase
   end
 
   test 'does not duplicate label classes for different inputs' do
-    swap_wrapper :default, self.custom_wrapper_with_label_html_option do
+    swap_wrapper :default, custom_wrapper_with_label_html_option do
       with_concat_form_for(@user) do |f|
         concat f.input :name, required: false
         concat f.input :email, as: :email, required: true
@@ -242,8 +242,40 @@ class WrapperTest < ActionView::TestCase
     assert_select "section.custom_wrapper div.another_wrapper input.string"
   end
 
+  test "input attributes class will merge with wrapper_options' classes" do
+    swap_wrapper :default, custom_wrapper_with_input_class do
+      with_concat_form_for @user do |f|
+        concat f.input :name, input_html: { class: 'another-class' }
+      end
+    end
+
+    assert_select "div.custom_wrapper input.string.inline-class.another-class"
+  end
+
+  test "input with data attributes will merge with wrapper_options' data" do
+    swap_wrapper :default, custom_wrapper_with_input_data_modal do
+      with_concat_form_for @user do |f|
+        concat f.input :name, input_html: { data: { modal: 'another-data', target: 'merge-data' } }
+      end
+    end
+
+    assert_select "input[data-wrapper='data-wrapper'][data-modal='another-data'][data-target='merge-data']"
+  end
+
+  test "input with aria attributes will merge with wrapper_options' aria" do
+    skip unless ActionPack::VERSION::MAJOR == '4' && ActionPack::VERSION::MINOR >= '2'
+
+    swap_wrapper :default, custom_wrapper_with_input_aria_modal do
+      with_concat_form_for @user do |f|
+        concat f.input :name, input_html: { aria: { modal: 'another-aria', target: 'merge-aria' } }
+      end
+    end
+
+    assert_select "input[aria-wrapper='aria-wrapper'][aria-modal='another-aria'][aria-target='merge-aria']"
+  end
+
   test 'input accepts attributes in the DSL' do
-    swap_wrapper :default, self.custom_wrapper_with_input_class do
+    swap_wrapper :default, custom_wrapper_with_input_class do
       with_concat_form_for @user do |f|
         concat f.input :name
       end
@@ -253,7 +285,7 @@ class WrapperTest < ActionView::TestCase
   end
 
   test 'label accepts attributes in the DSL' do
-    swap_wrapper :default, self.custom_wrapper_with_label_class do
+    swap_wrapper :default, custom_wrapper_with_label_class do
       with_concat_form_for @user do |f|
         concat f.input :name
       end
@@ -263,7 +295,7 @@ class WrapperTest < ActionView::TestCase
   end
 
   test 'label_input accepts attributes in the DSL' do
-    swap_wrapper :default, self.custom_wrapper_with_label_input_class do
+    swap_wrapper :default, custom_wrapper_with_label_input_class do
       with_concat_form_for @user do |f|
         concat f.input :name
       end
@@ -274,7 +306,7 @@ class WrapperTest < ActionView::TestCase
   end
 
   test 'input accepts data attributes in the DSL' do
-    swap_wrapper :default, self.custom_wrapper_with_input_attributes do
+    swap_wrapper :default, custom_wrapper_with_input_attributes do
       with_concat_form_for @user do |f|
         concat f.input :name
       end
@@ -284,7 +316,7 @@ class WrapperTest < ActionView::TestCase
   end
 
   test 'inline wrapper displays when there is content' do
-    swap_wrapper :default, self.custom_wrapper_with_wrapped_optional_component do
+    swap_wrapper :default, custom_wrapper_with_wrapped_optional_component do
       with_form_for @user, :name, hint: "cannot be blank"
       assert_select 'section.custom_wrapper div.no_output_wrapper p.omg_hint', "cannot be blank"
       assert_select 'p.omg_hint'
@@ -292,7 +324,7 @@ class WrapperTest < ActionView::TestCase
   end
 
   test 'inline wrapper does not display when there is no content' do
-    swap_wrapper :default, self.custom_wrapper_with_wrapped_optional_component do
+    swap_wrapper :default, custom_wrapper_with_wrapped_optional_component do
       with_form_for @user, :name
       assert_select 'section.custom_wrapper div.no_output_wrapper'
       assert_no_select 'p.omg_hint'
@@ -300,7 +332,7 @@ class WrapperTest < ActionView::TestCase
   end
 
   test 'optional wrapper does not display when there is content' do
-    swap_wrapper :default, self.custom_wrapper_with_unless_blank do
+    swap_wrapper :default, custom_wrapper_with_unless_blank do
       with_form_for @user, :name, hint: "can't be blank"
       assert_select 'section.custom_wrapper div.no_output_wrapper'
       assert_select 'div.no_output_wrapper'
@@ -309,7 +341,7 @@ class WrapperTest < ActionView::TestCase
   end
 
   test 'optional wrapper does not display when there is no content' do
-    swap_wrapper :default, self.custom_wrapper_with_unless_blank do
+    swap_wrapper :default, custom_wrapper_with_unless_blank do
       with_form_for @user, :name
       assert_no_select 'section.custom_wrapper div.no_output_wrapper'
       assert_no_select 'div.no_output_wrapper'

data/test/inputs/boolean_input_test.rb

@@ -137,6 +137,14 @@ class BooleanInputTest < ActionView::TestCase
     end
   end
 
+  test 'input with nested style allows disabling hidden field' do
+    swap SimpleForm, boolean_style: :nested do
+      with_input_for @user, :active, :boolean, include_hidden: false
+      assert_select "label.boolean > input.boolean"
+      assert_no_select "input[type=hidden] + label.boolean"
+    end
+  end
+
   test 'input boolean works using :input only in wrapper config (no label_input)' do
     swap_wrapper do
       with_input_for @user, :active, :boolean
@@ -156,6 +164,16 @@ class BooleanInputTest < ActionView::TestCase
     end
   end
 
+  test 'input boolean allows specifying boolean_label_class on a per-input basis' do
+    swap_wrapper do
+      swap SimpleForm, boolean_style: :nested, boolean_label_class: 'foo' do
+        with_input_for @user, :active, :boolean, boolean_label_class: 'baz'
+
+        assert_select 'label.boolean + input[type=hidden] + label.baz > input.boolean'
+      end
+    end
+  end
+
   test 'input boolean with nested style works using :input only in wrapper config (no label_input), adding the extra label wrapper with custom class' do
     swap_wrapper do
       swap SimpleForm, boolean_style: :nested, boolean_label_class: 'foo' do

data/test/inputs/datetime_input_test.rb

@@ -6,7 +6,11 @@ class DateTimeInputWithHtml5Test < ActionView::TestCase
   test 'input generates a datetime input for datetime attributes if HTML5 compatibility is explicitly enbled' do
     with_input_for @user, :created_at, :datetime, html5: true
 
-    assert_select 'input[type="datetime"]'
+    if ActionPack::VERSION::STRING >= '5'
+      assert_select 'input[type="datetime-local"]'
+    elsif ActionPack::VERSION::STRING < '5'
+      assert_select 'input[type="datetime"]'
+    end
   end
 
   test 'input generates a datetime select for datetime attributes' do
@@ -76,7 +80,11 @@ class DateTimeInputWithoutHtml5Test < ActionView::TestCase
     swap_wrapper do
       with_input_for @user, :created_at, :datetime, html5: true
 
-      assert_select 'input[type="datetime"]'
+      if ActionPack::VERSION::STRING >= '5'
+        assert_select 'input[type="datetime-local"]'
+      elsif ActionPack::VERSION::STRING < '5'
+        assert_select 'input[type="datetime"]'
+      end
     end
   end
 
@@ -169,4 +177,9 @@ class DateTimeInputWithoutHtml5Test < ActionView::TestCase
     with_input_for :project, :created_at, :time, html5: false
     assert_select 'label[for=project_created_at_4i]'
   end
+
+  test 'label points to attribute name if HTML5 compatibility is explicitly enabled' do
+    with_input_for :project, :created_at, :date, html5: true
+    assert_select 'label[for=project_created_at]'
+  end
 end

data/test/inputs/discovery_test.rb

@@ -14,6 +14,7 @@ class DiscoveryTest < ActionView::TestCase
         Object.send :remove_const, :CustomizedInput
         Object.send :remove_const, :DeprecatedInput
         Object.send :remove_const, :CollectionSelectInput
+        CustomInputs.send :remove_const, :CustomizedInput
         CustomInputs.send :remove_const, :PasswordInput
         CustomInputs.send :remove_const, :NumericInput
       end

data/test/inputs/numeric_input_test.rb

@@ -113,6 +113,9 @@ class NumericInputTest < ActionView::TestCase
 
     with_input_for @validating_user, :age, :integer
     assert_select 'input[step="1"]'
+
+    with_input_for @validating_user, :age, :integer, as: :decimal, input_html: { step: 0.5 }
+    assert_select 'input[step="0.5"]'
   end
 
   test 'numeric input does not generate placeholder by default' do

data/test/inputs/priority_input_test.rb

@@ -5,14 +5,22 @@ class PriorityInputTest < ActionView::TestCase
   test 'input generates a country select field' do
     with_input_for @user, :country, :country
     assert_select 'select#user_country'
-    assert_select 'select option[value=Brazil]', 'Brazil'
+    if ActionPack::VERSION::STRING >= '5'
+      assert_select 'select option[value=BR]', 'Brazil'
+    elsif ActionPack::VERSION::STRING < '5'
+      assert_select 'select option[value=Brazil]', 'Brazil'
+    end
     assert_no_select 'select option[value=""][disabled=disabled]'
   end
 
   test 'input generates a country select with SimpleForm default' do
     swap SimpleForm, country_priority: [ 'Brazil' ] do
       with_input_for @user, :country, :country
-      assert_select 'select option[value=""][disabled=disabled]'
+      if ActionPack::VERSION::STRING >= '5'
+        assert_select 'select option[value="---------------"][disabled=disabled]'
+      elsif ActionPack::VERSION::STRING < '5'
+        assert_select 'select option[value=""][disabled=disabled]'
+      end
     end
   end
 

data/test/inputs/required_test.rb

@@ -34,6 +34,38 @@ class RequiredTest < ActionView::TestCase
       with_input_for @user, :name, :string
       assert_select 'input[type=text].required'
       assert_no_select 'input[type=text][required]'
+      assert_no_select 'input[type=text][aria-required]'
+    end
+  end
+
+  test 'when not using browser validations, when required option is set to false, input does not generate required html attribute' do
+    swap SimpleForm, browser_validations: false do
+      with_input_for @user, :name, :string, required: false
+      assert_no_select 'input[type=text].required'
+      assert_no_select 'input[type=text][required]'
+      assert_no_select 'input[type=text][aria-required]'
+    end
+  end
+
+  test 'when not using browser validations, when required option is set to true, input generates required html attribute' do
+    swap SimpleForm, browser_validations: false do
+      with_input_for @user, :name, :string, required: true
+      assert_select 'input[type=text].required'
+      assert_select 'input[type=text][required]'
+      assert_select 'input[type=text][aria-required]'
+    end
+  end
+
+  test 'when not using browser validations, when required option is true in the wrapper, input does not generate required html attribute' do
+    swap SimpleForm, browser_validations: false do
+      swap_wrapper :default, self.custom_wrapper_with_required_input do
+        with_concat_form_for(@user) do |f|
+          concat f.input :name
+        end
+        assert_select 'input[type=text].required'
+        assert_no_select 'input[type=text][required]'
+        assert_no_select 'input[type=text][aria-required]'
+      end
     end
   end
 
@@ -110,4 +142,16 @@ class RequiredTest < ActionView::TestCase
     assert_no_select 'input[required]'
     assert_select 'input.optional#validating_user_phone_number'
   end
+
+  test 'builder input does not generate required html attribute when option is set to false when it is set to true in wrapper' do
+    swap SimpleForm, browser_validations: true do
+      swap_wrapper :default, self.custom_wrapper_with_required_input do
+        with_concat_form_for(@user) do |f|
+          concat f.input :name, required: false
+        end
+        assert_no_select 'input[type=text][required]'
+        assert_no_select 'input[type=text][aria-required]'
+      end
+    end
+  end
 end

data/test/inputs/string_input_test.rb

@@ -32,9 +32,21 @@ class StringInputTest < ActionView::TestCase
     assert_select 'input.string[maxlength="25"]'
   end
 
-  test 'input does not get maxlength from validation when tokenizer present' do
-    with_input_for @validating_user, :action, :string
-    assert_no_select 'input.string[maxlength]'
+  test 'input infers minlength column definition from validation when present' do
+    with_input_for @validating_user, :name, :string
+    assert_select 'input.string[minlength="5"]'
+  end
+
+  if ActionPack::VERSION::STRING < '5'
+    test 'input does not get maxlength from validation when tokenizer present' do
+      with_input_for @validating_user, :action, :string
+      assert_no_select 'input.string[maxlength]'
+    end
+
+    test 'input does not get minlength from validation when tokenizer present' do
+      with_input_for @validating_user, :action, :string
+      assert_no_select 'input.string[minlength]'
+    end
   end
 
   test 'input gets maxlength from validation when :is option present' do
@@ -42,6 +54,11 @@ class StringInputTest < ActionView::TestCase
     assert_select 'input.string[maxlength="12"]'
   end
 
+  test 'input gets minlength from validation when :is option present' do
+    with_input_for @validating_user, :home_picture, :string
+    assert_select 'input.string[minlength="12"]'
+  end
+
   test 'input maxlength is the column limit plus one to make room for decimal point' do
     with_input_for @user, :credit_limit, :string
 
@@ -115,15 +132,6 @@ class StringInputTest < ActionView::TestCase
     end
   end
 
-  test 'input translates a key prefixed with _html and return the html markup' do
-    store_translations(:en, simple_form: { labels: { user: {
-      name_html: '<b>Name</b>'
-    } } }) do
-      with_input_for @user, :name, :string
-      assert_select 'label b', 'Name'
-    end
-  end
-
   [:email, :url, :search, :tel].each do |type|
     test "input allows type #{type}" do
       with_input_for @user, :name, type

data/test/inputs/text_input_test.rb

@@ -12,6 +12,13 @@ class TextInputTest < ActionView::TestCase
     assert_select 'textarea.text[placeholder="Put in some text"]'
   end
 
+  test 'input generates a placeholder from the translations' do
+    store_translations(:en, simple_form: { placeholders: { user: { name: "placeholder from i18n en.simple_form.placeholders.user.name" } } }) do
+      with_input_for @user, :name, :text
+      assert_select 'textarea.text[placeholder="placeholder from i18n en.simple_form.placeholders.user.name"]'
+    end
+  end
+
   test 'input gets maxlength from column definition for text attributes' do
     with_input_for @user, :description, :text
     assert_select 'textarea.text[maxlength="200"]'
@@ -21,4 +28,9 @@ class TextInputTest < ActionView::TestCase
     with_input_for @validating_user, :description, :text
     assert_select 'textarea.text[maxlength="50"]'
   end
+
+  test 'input infers minlength column definition from validation when present for text attributes' do
+    with_input_for @validating_user, :description, :text
+    assert_select 'textarea.text[minlength="15"]'
+  end
 end