simple_form 3.1.0.rc1 → 3.1.0

data/test/inputs/disabled_test.rb

@@ -1,77 +1,77 @@
 require 'test_helper'
 
 class DisabledTest < ActionView::TestCase
-  test 'string input should be disabled when disabled option is true' do
+  test 'string input is disabled when disabled option is true' do
     with_input_for @user, :name, :string, disabled: true
     assert_select 'input.string.disabled[disabled]'
   end
 
-  test 'text input should be disabled when disabled option is true' do
+  test 'text input is disabled when disabled option is true' do
     with_input_for @user, :description, :text, disabled: true
     assert_select 'textarea.text.disabled[disabled]'
   end
 
-  test 'numeric input should be disabled when disabled option is true' do
+  test 'numeric input is disabled when disabled option is true' do
     with_input_for @user, :age, :integer, disabled: true
     assert_select 'input.integer.disabled[disabled]'
   end
 
-  test 'date input should be disabled when disabled option is true' do
+  test 'date input is disabled when disabled option is true' do
     with_input_for @user, :born_at, :date, disabled: true
     assert_select 'select.date.disabled[disabled]'
   end
 
-  test 'datetime input should be disabled when disabled option is true' do
+  test 'datetime input is disabled when disabled option is true' do
     with_input_for @user, :created_at, :datetime, disabled: true
     assert_select 'select.datetime.disabled[disabled]'
   end
 
-  test 'string input should not be disabled when disabled option is false' do
+  test 'string input does not be disabled when disabled option is false' do
     with_input_for @user, :name, :string, disabled: false
     assert_no_select 'input.string.disabled[disabled]'
   end
 
-  test 'text input should not be disabled when disabled option is false' do
+  test 'text input does not be disabled when disabled option is false' do
     with_input_for @user, :description, :text, disabled: false
     assert_no_select 'textarea.text.disabled[disabled]'
   end
 
-  test 'numeric input should not be disabled when disabled option is false' do
+  test 'numeric input does not be disabled when disabled option is false' do
     with_input_for @user, :age, :integer, disabled: false
     assert_no_select 'input.integer.disabled[disabled]'
   end
 
-  test 'date input should not be disabled when disabled option is false' do
+  test 'date input does not be disabled when disabled option is false' do
     with_input_for @user, :born_at, :date, disabled: false
     assert_no_select 'select.date.disabled[disabled]'
   end
 
-  test 'datetime input should not be disabled when disabled option is false' do
+  test 'datetime input does not be disabled when disabled option is false' do
     with_input_for @user, :created_at, :datetime, disabled: false
     assert_no_select 'select.datetime.disabled[disabled]'
   end
 
-  test 'string input should not be disabled when disabled option is not present' do
+  test 'string input does not be disabled when disabled option is not present' do
     with_input_for @user, :name, :string
     assert_no_select 'input.string.disabled[disabled]'
   end
 
-  test 'text input should not be disabled when disabled option is not present' do
+  test 'text input does not be disabled when disabled option is not present' do
     with_input_for @user, :description, :text
     assert_no_select 'textarea.text.disabled[disabled]'
   end
 
-  test 'numeric input should not be disabled when disabled option is not present' do
+  test 'numeric input does not be disabled when disabled option is not present' do
     with_input_for @user, :age, :integer
     assert_no_select 'input.integer.disabled[disabled]'
   end
 
-  test 'date input should not be disabled when disabled option is not present' do
+  test 'date input does not be disabled when disabled option is not present' do
     with_input_for @user, :born_at, :date
     assert_no_select 'select.date.disabled[disabled]'
   end
 
-  test 'datetime input should not be disabled when disabled option is not present' do
+  test 'datetime input does not be disabled when disabled option is not present' do
     with_input_for @user, :created_at, :datetime
     assert_no_select 'select.datetime.disabled[disabled]'
   end

data/test/inputs/discovery_test.rb

@@ -14,11 +14,13 @@ class DiscoveryTest < ActionView::TestCase
         Object.send :remove_const, :CustomizedInput
         Object.send :remove_const, :DeprecatedInput
         Object.send :remove_const, :CollectionSelectInput
+        CustomInputs.send :remove_const, :PasswordInput
+        CustomInputs.send :remove_const, :NumericInput
       end
     end
   end
 
-  test 'builder should not discover new inputs if cached' do
+  test 'builder does not discover new inputs if cached' do
     with_form_for @user, :name
     assert_select 'form input#user_name.string'
 
@@ -28,14 +30,14 @@ class DiscoveryTest < ActionView::TestCase
     end
   end
 
-  test 'builder should discover new inputs' do
+  test 'builder discovers new inputs' do
     discovery do
       with_form_for @user, :name, as: :customized
       assert_select 'form section input#user_name.string'
     end
   end
 
-  test 'builder should not discover new inputs if discovery is off' do
+  test 'builder does not discover new inputs if discovery is off' do
     with_form_for @user, :name
     assert_select 'form input#user_name.string'
 
@@ -47,20 +49,57 @@ class DiscoveryTest < ActionView::TestCase
     end
   end
 
-  test 'builder should discover new inputs from mappings if not cached' do
+  test 'builder discovers new inputs from mappings if not cached' do
     discovery do
       with_form_for @user, :name
       assert_select 'form section input#user_name.string'
     end
   end
 
-  test 'builder should discover new inputs from internal fallbacks if not cached' do
+  test 'builder discovers new inputs from internal fallbacks if not cached' do
     discovery do
       with_form_for @user, :age
       assert_select 'form section input#user_age.numeric.integer'
     end
   end
 
+  test 'builder discovers new maped inputs from configured namespaces if not cached' do
+    discovery do
+      swap SimpleForm, custom_inputs_namespaces: ['CustomInputs'] do
+        with_form_for @user, :password
+        assert_select 'form input#user_password.password-custom-input'
+      end
+    end
+  end
+
+  test 'builder discovers new maped inputs from configured namespaces before the ones from top level namespace' do
+    discovery do
+      swap SimpleForm, custom_inputs_namespaces: ['CustomInputs'] do
+        with_form_for @user, :age
+        assert_select 'form input#user_age.numeric-custom-input'
+      end
+    end
+  end
+
+  test 'builder discovers new custom inputs from configured namespace before the ones from top level namespace' do
+    discovery do
+      swap SimpleForm, custom_inputs_namespaces: ['CustomInputs'] do
+        with_form_for @user, :name, as: 'customized'
+        assert_select 'form input#user_name.customized-namespace-custom-input'
+      end
+    end
+  end
+
+  test 'raises error when configured namespace does not exists' do
+    discovery do
+      swap SimpleForm, custom_inputs_namespaces: ['InvalidNamespace'] do
+        assert_raise NameError do
+          with_form_for @user, :age
+        end
+      end
+    end
+  end
+
   test 'new inputs can override the input_html_options' do
     discovery do
       with_form_for @user, :active, as: :select

data/test/inputs/file_input_test.rb

@@ -2,12 +2,12 @@
 require 'test_helper'
 
 class FileInputTest < ActionView::TestCase
-  test 'input should generate a file field' do
+  test 'input generates a file field' do
     with_input_for @user, :name, :file
     assert_select 'input#user_name[type=file]'
   end
 
-  test "input should generate a file field that doesn't accept placeholder" do
+  test "input generates a file field that doesn't accept placeholder" do
     store_translations(:en, simple_form: { placeholders: { user: { name: "text" } } }) do
       with_input_for @user, :name, :file
       assert_no_select 'input[placeholder]'

data/test/inputs/general_test.rb

@@ -2,7 +2,7 @@
 require 'test_helper'
 
 class InputTest < ActionView::TestCase
-  test 'input should generate css class based on default input type' do
+  test 'input generates css class based on default input type' do
     with_input_for @user, :name, :string
     assert_select 'input.string'
     with_input_for @user, :description, :text
@@ -15,7 +15,7 @@ class InputTest < ActionView::TestCase
     assert_select 'select.datetime'
   end
 
-  test 'string input should generate autofocus attribute when autofocus option is true' do
+  test 'string input generates autofocus attribute when autofocus option is true' do
     with_input_for @user, :name, :string, autofocus: true
     assert_select 'input.string[autofocus]'
   end
@@ -36,94 +36,94 @@ class InputTest < ActionView::TestCase
     end
   end
 
-  test 'text input should generate autofocus attribute when autofocus option is true' do
+  test 'text input generates autofocus attribute when autofocus option is true' do
     with_input_for @user, :description, :text, autofocus: true
     assert_select 'textarea.text[autofocus]'
   end
 
-  test 'numeric input should generate autofocus attribute when autofocus option is true' do
+  test 'numeric input generates autofocus attribute when autofocus option is true' do
     with_input_for @user, :age, :integer, autofocus: true
     assert_select 'input.integer[autofocus]'
   end
 
-  test 'date input should generate autofocus attribute when autofocus option is true' do
+  test 'date input generates autofocus attribute when autofocus option is true' do
     with_input_for @user, :born_at, :date, autofocus: true
     assert_select 'select.date[autofocus]'
   end
 
-  test 'datetime input should generate autofocus attribute when autofocus option is true' do
+  test 'datetime input generates autofocus attribute when autofocus option is true' do
     with_input_for @user, :created_at, :datetime, autofocus: true
     assert_select 'select.datetime[autofocus]'
   end
 
-  test 'string input should generate autofocus attribute when autofocus option is false' do
+  test 'string input generates autofocus attribute when autofocus option is false' do
     with_input_for @user, :name, :string, autofocus: false
     assert_no_select 'input.string[autofocus]'
   end
 
-  test 'text input should generate autofocus attribute when autofocus option is false' do
+  test 'text input generates autofocus attribute when autofocus option is false' do
     with_input_for @user, :description, :text, autofocus: false
     assert_no_select 'textarea.text[autofocus]'
   end
 
-  test 'numeric input should generate autofocus attribute when autofocus option is false' do
+  test 'numeric input generates autofocus attribute when autofocus option is false' do
     with_input_for @user, :age, :integer, autofocus: false
     assert_no_select 'input.integer[autofocus]'
   end
 
-  test 'date input should generate autofocus attribute when autofocus option is false' do
+  test 'date input generates autofocus attribute when autofocus option is false' do
     with_input_for @user, :born_at, :date, autofocus: false
     assert_no_select 'select.date[autofocus]'
   end
 
-  test 'datetime input should generate autofocus attribute when autofocus option is false' do
+  test 'datetime input generates autofocus attribute when autofocus option is false' do
     with_input_for @user, :created_at, :datetime, autofocus: false
     assert_no_select 'select.datetime[autofocus]'
   end
 
-  test 'string input should generate autofocus attribute when autofocus option is not present' do
+  test 'string input generates autofocus attribute when autofocus option is not present' do
     with_input_for @user, :name, :string
     assert_no_select 'input.string[autofocus]'
   end
 
-  test 'text input should generate autofocus attribute when autofocus option is not present' do
+  test 'text input generates autofocus attribute when autofocus option is not present' do
     with_input_for @user, :description, :text
     assert_no_select 'textarea.text[autofocus]'
   end
 
-  test 'numeric input should generate autofocus attribute when autofocus option is not present' do
+  test 'numeric input generates autofocus attribute when autofocus option is not present' do
     with_input_for @user, :age, :integer
     assert_no_select 'input.integer[autofocus]'
   end
 
-  test 'date input should generate autofocus attribute when autofocus option is not present' do
+  test 'date input generates autofocus attribute when autofocus option is not present' do
     with_input_for @user, :born_at, :date
     assert_no_select 'select.date[autofocus]'
   end
 
-  test 'datetime input should generate autofocus attribute when autofocus option is not present' do
+  test 'datetime input generates autofocus attribute when autofocus option is not present' do
     with_input_for @user, :created_at, :datetime
     assert_no_select 'select.datetime[autofocus]'
   end
 
   # With no object
-  test 'input should be generated properly when object is not present' do
+  test 'input is generated properly when object is not present' do
     with_input_for :project, :name, :string
     assert_select 'input.string.required#project_name'
   end
 
-  test 'input as radio should be generated properly when object is not present ' do
+  test 'input as radio is generated properly when object is not present ' do
     with_input_for :project, :name, :radio_buttons
     assert_select 'input.radio_buttons#project_name_true'
     assert_select 'input.radio_buttons#project_name_false'
   end
 
-  test 'input as select with collection should be generated properly when object is not present' do
+  test 'input as select with collection is generated properly when object is not present' do
     with_input_for :project, :name, :select, collection: ['Jose', 'Carlos']
     assert_select 'select.select#project_name'
   end
 
-  test 'input should not generate empty css class' do
+  test 'input does not generate empty css class' do
     swap SimpleForm, generate_additional_classes_for: [:wrapper, :label] do
       with_input_for :project, :name, :string
       assert_no_select 'input#project_name[class]'

data/test/inputs/grouped_collection_select_input_test.rb

@@ -109,8 +109,8 @@ class GroupedCollectionSelectInputTest < ActionView::TestCase
 
     assert_select 'select.grouped_select#user_tag_ids' do
       assert_select 'optgroup[label=Second]' do
-        assert_select 'option[value=7]', 'Bond'
-        assert_select 'option[value=47]', 'Hitman'
+        assert_select 'option[value="7"]', 'Bond'
+        assert_select 'option[value="47"]', 'Hitman'
       end
     end
   end
@@ -130,7 +130,7 @@ class GroupedCollectionSelectInputTest < ActionView::TestCase
     end
   end
 
-  test 'grouped collection should allow overriding label and value methods using a lambda' do
+  test 'grouped collection allows overriding label and value methods using a lambda' do
     with_input_for @user, :tag_ids, :grouped_select,
       collection: { 'Authors' => ['Jose', 'Carlos'] },
       group_method: :last,
@@ -155,19 +155,19 @@ class GroupedCollectionSelectInputTest < ActionView::TestCase
       collection: tag_groups, group_method: :tags
 
     assert_select 'select.grouped_select#user_tag_ids' do
-      assert_select 'optgroup[label=Group of Tags]' do
-        assert_select 'option[value=1]', 'Tag 1'
-        assert_select 'option[value=2]', 'Tag 2'
+      assert_select 'optgroup[label="Group of Tags"]' do
+        assert_select 'option[value="1"]', 'Tag 1'
+        assert_select 'option[value="2"]', 'Tag 2'
       end
 
-      assert_select 'optgroup[label=Other group]' do
-        assert_select 'option[value=3]', 'Tag 3'
-        assert_select 'option[value=4]', 'Tag 4'
+      assert_select 'optgroup[label="Other group"]' do
+        assert_select 'option[value="3"]', 'Tag 3'
+        assert_select 'option[value="4"]', 'Tag 4'
       end
     end
   end
 
-  test 'grouped collection should accept html options as the last element of collection' do
+  test 'grouped collection accepts html options as the last element of collection' do
     with_input_for @user, :tag_ids, :grouped_select,
       collection: [['Authors', [['Jose', 'jose', class: 'foo'], ['Carlos', 'carlos', class: 'bar']]]],
       group_method: :last

data/test/inputs/hidden_input_test.rb

@@ -2,25 +2,25 @@
 require 'test_helper'
 
 class HiddenInputTest < ActionView::TestCase
-  test 'input should generate a hidden field' do
+  test 'input generates a hidden field' do
     with_input_for @user, :name, :hidden
     assert_no_select 'input[type=text]'
     assert_select 'input#user_name[type=hidden]'
   end
 
-  test 'hint should not be generated for hidden fields' do
+  test 'hint does not be generated for hidden fields' do
     store_translations(:en, simple_form: { hints: { user: { name: "text" } } }) do
       with_input_for @user, :name, :hidden
       assert_no_select 'span.hint'
     end
   end
 
-  test 'label should not be generated for hidden inputs' do
+  test 'label does not be generated for hidden inputs' do
     with_input_for @user, :name, :hidden
     assert_no_select 'label'
   end
 
-  test 'required/aria-required/optional options should not be generated for hidden inputs' do
+  test 'required/aria-required/optional options does not be generated for hidden inputs' do
     with_input_for @user, :name, :hidden
     assert_no_select 'input.required'
     assert_no_select 'input[required]'

data/test/inputs/numeric_input_test.rb

@@ -2,140 +2,140 @@
 require 'test_helper'
 
 class NumericInputTest < ActionView::TestCase
-  test 'input should generate an integer text field for integer attributes ' do
+  test 'input generates an integer text field for integer attributes ' do
     with_input_for @user, :age, :integer
     assert_select 'input[type=number].integer#user_age'
   end
 
-  test 'input should generate a float text field for float attributes ' do
+  test 'input generates a float text field for float attributes ' do
     with_input_for @user, :age, :float
     assert_select 'input[type=number].float#user_age'
   end
 
-  test 'input should generate a decimal text field for decimal attributes ' do
+  test 'input generates a decimal text field for decimal attributes ' do
     with_input_for @user, :age, :decimal
     assert_select 'input[type=number].decimal#user_age'
   end
 
-  test 'input should not generate min attribute by default' do
+  test 'input does not generate min attribute by default' do
     with_input_for @user, :age, :integer
     assert_no_select 'input[min]'
   end
 
-  test 'input should not generate max attribute by default' do
+  test 'input does not generate max attribute by default' do
     with_input_for @user, :age, :integer
     assert_no_select 'input[max]'
   end
 
-  test 'input should infer min value from integer attributes with greater than validation' do
+  test 'input infers min value from integer attributes with greater than validation' do
     with_input_for @other_validating_user, :age, :float
     assert_no_select 'input[min]'
 
     with_input_for @other_validating_user, :age, :integer
-    assert_select 'input[min=18]'
+    assert_select 'input[min="18"]'
   end
 
-  test 'input should infer min value from integer attributes with greater than validation using symbol' do
+  test 'input infers min value from integer attributes with greater than validation using symbol' do
     with_input_for @validating_user, :amount, :float
     assert_no_select 'input[min]'
 
     with_input_for @validating_user, :amount, :integer
-    assert_select 'input[min=11]'
+    assert_select 'input[min="11"]'
   end
 
-  test 'input should infer min value from integer attributes with greater than or equal to validation using symbol' do
+  test 'input infers min value from integer attributes with greater than or equal to validation using symbol' do
     with_input_for @validating_user, :attempts, :float
-    assert_select 'input[min=1]'
+    assert_select 'input[min="1"]'
 
     with_input_for @validating_user, :attempts, :integer
-    assert_select 'input[min=1]'
+    assert_select 'input[min="1"]'
   end
 
-  test 'input should infer min value from integer attributes with greater than validation using proc' do
+  test 'input infers min value from integer attributes with greater than validation using proc' do
     with_input_for @other_validating_user, :amount, :float
     assert_no_select 'input[min]'
 
     with_input_for @other_validating_user, :amount, :integer
-    assert_select 'input[min=20]'
+    assert_select 'input[min="20"]'
   end
 
-  test 'input should infer min value from integer attributes with greater than or equal to validation using proc' do
+  test 'input infers min value from integer attributes with greater than or equal to validation using proc' do
     with_input_for @other_validating_user, :attempts, :float
-    assert_select 'input[min=19]'
+    assert_select 'input[min="19"]'
 
     with_input_for @other_validating_user, :attempts, :integer
-    assert_select 'input[min=19]'
+    assert_select 'input[min="19"]'
   end
 
-  test 'input should infer max value from attributes with less than validation' do
+  test 'input infers max value from attributes with less than validation' do
     with_input_for @other_validating_user, :age, :float
     assert_no_select 'input[max]'
 
     with_input_for @other_validating_user, :age, :integer
-    assert_select 'input[max=99]'
+    assert_select 'input[max="99"]'
   end
 
-  test 'input should infer max value from attributes with less than validation using symbol' do
+  test 'input infers max value from attributes with less than validation using symbol' do
     with_input_for @validating_user, :amount, :float
     assert_no_select 'input[max]'
 
     with_input_for @validating_user, :amount, :integer
-    assert_select 'input[max=99]'
+    assert_select 'input[max="99"]'
   end
 
-  test 'input should infer max value from attributes with less than or equal to validation using symbol' do
+  test 'input infers max value from attributes with less than or equal to validation using symbol' do
     with_input_for @validating_user, :attempts, :float
-    assert_select 'input[max=100]'
+    assert_select 'input[max="100"]'
 
     with_input_for @validating_user, :attempts, :integer
-    assert_select 'input[max=100]'
+    assert_select 'input[max="100"]'
   end
 
-  test 'input should infer max value from attributes with less than validation using proc' do
+  test 'input infers max value from attributes with less than validation using proc' do
     with_input_for @other_validating_user, :amount, :float
     assert_no_select 'input[max]'
 
     with_input_for @other_validating_user, :amount, :integer
-    assert_select 'input[max=118]'
+    assert_select 'input[max="118"]'
   end
 
-  test 'input should infer max value from attributes with less than or equal to validation using proc' do
+  test 'input infers max value from attributes with less than or equal to validation using proc' do
     with_input_for @other_validating_user, :attempts, :float
-    assert_select 'input[max=119]'
+    assert_select 'input[max="119"]'
 
     with_input_for @other_validating_user, :attempts, :integer
-    assert_select 'input[max=119]'
+    assert_select 'input[max="119"]'
   end
 
-  test 'input should have step value of any except for integer attribute' do
+  test 'input has step value of any except for integer attribute' do
     with_input_for @validating_user, :age, :float
     assert_select 'input[step="any"]'
 
     with_input_for @validating_user, :age, :integer
-    assert_select 'input[step=1]'
+    assert_select 'input[step="1"]'
   end
 
-  test 'numeric input should not generate placeholder by default' do
+  test 'numeric input does not generate placeholder by default' do
     with_input_for @user, :age, :integer
     assert_no_select 'input[placeholder]'
   end
 
-  test 'numeric input should accept the placeholder option' do
+  test 'numeric input accepts the placeholder option' do
     with_input_for @user, :age, :integer, placeholder: 'Put in your age'
-    assert_select 'input.integer[placeholder=Put in your age]'
+    assert_select 'input.integer[placeholder="Put in your age"]'
   end
 
-  test 'numeric input should use i18n to translate placeholder text' do
+  test 'numeric input uses i18n to translate placeholder text' do
     store_translations(:en, simple_form: { placeholders: { user: {
       age: 'Age goes here'
     } } }) do
       with_input_for @user, :age, :integer
-      assert_select 'input.integer[placeholder=Age goes here]'
+      assert_select 'input.integer[placeholder="Age goes here"]'
     end
   end
 
   # Numeric input but HTML5 disabled
-  test ' when not using HTML5 input should not generate field with type number and use text instead' do
+  test 'when not using HTML5 input does not generate field with type number and use text instead' do
     swap_wrapper do
       with_input_for @user, :age, :integer
       assert_no_select "input[type=number]"
@@ -143,7 +143,7 @@ class NumericInputTest < ActionView::TestCase
     end
   end
 
-  test 'when not using HTML5 input should not use min or max or step attributes' do
+  test 'when not using HTML5 input does not use min or max or step attributes' do
     swap_wrapper do
       with_input_for @validating_user, :age, :integer
       assert_no_select "input[type=number]"
@@ -154,18 +154,18 @@ class NumericInputTest < ActionView::TestCase
   end
 
   [:integer, :float, :decimal].each do |type|
-    test "#{type} input should infer min value from attributes with greater than or equal validation" do
+    test "#{type} input infers min value from attributes with greater than or equal validation" do
       with_input_for @validating_user, :age, type
-      assert_select 'input[min=18]'
+      assert_select 'input[min="18"]'
     end
 
-    test "#{type} input should infer the max value from attributes with less than or equal to validation" do
+    test "#{type} input infers the max value from attributes with less than or equal to validation" do
       with_input_for @validating_user, :age, type
-      assert_select 'input[max=99]'
+      assert_select 'input[max="99"]'
     end
   end
 
-  test 'min_max should not emit max value as bare string' do
+  test 'min_max does not emit max value as bare string' do
     with_input_for @other_validating_user, :age, :integer
     assert_select 'input[max]'
     assert_no_select 'div', %r{^99}