simple_form 3.0.3 → 3.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 152972033f17ccec7bdd5545b5b22cecb7c6a3a9
-  data.tar.gz: b678a95634ea7b3738d4c1974bd7247042f5480e
+  metadata.gz: ffed0afbf1694b8176a255206fc6d658e4a539af
+  data.tar.gz: 7af2a7a0199551b2b17491d9510c2477aa125265
 SHA512:
-  metadata.gz: fe032128b5adddd88304b1217343d8eacc708c3ba09ea780c4bfd95402ec1ca139bdfee16b416bb4f65815a86586f9387376852e36aa82310ce7ef0d3cc3ed02
-  data.tar.gz: 118b632667f29674415488c07c3c881fd5f89746cf3d66764cc6e8ae597b9a04e67f2a89cf592d856abae6d2e0b213429942c7bd9f193e92840a4ea7cd11faf7
+  metadata.gz: bbf22389176622fe689c4d401526d5c973124245cb3b587b3ff2428053377930a358c31eaf8088ffb2b030cef016d0b59ee790984fdedd1219c4d3daab76ff23
+  data.tar.gz: a3e826bd625da954e73d5df1cfe546117024c5b7eb08a1ea9eb37e187e25b3479d9549a13b6e853520e68e8eb3d54ed1ead89e2f0de7318df3478d624654c611

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 3.0.4
+
+### bug fix
+  * Fix method reflection for Ruby 2.1+. [@badosu](https://github.com/badosu)
+  * Do not remove HTML attributes if components are not present.
+
 ## 3.0.3
 
 ### bug fix

data/lib/simple_form/form_builder.rb

@@ -136,11 +136,13 @@ module SimpleForm
     #        name="user[name]" type="text" value="Carlos" />
     #
     def input_field(attribute_name, options={})
+      components = (wrapper.components & ATTRIBUTE_COMPONENTS)
+
       options = options.dup
-      options[:input_html] = options.except(:as, :collection, :label_method, :value_method, *ATTRIBUTE_COMPONENTS)
+      options[:input_html] = options.except(:as, :collection, :label_method, :value_method, *components)
       options = @defaults.deep_dup.deep_merge(options) if @defaults
 
-      SimpleForm::Wrappers::Root.new(ATTRIBUTE_COMPONENTS + [:input], wrapper: false).render find_input(attribute_name, options)
+      SimpleForm::Wrappers::Root.new(components + [:input], wrapper: false).render find_input(attribute_name, options)
     end
 
     # Helper for dealing with association selects/radios, generating the

data/lib/simple_form/inputs/boolean_input.rb

@@ -35,7 +35,7 @@ module SimpleForm
       # reuse the method for nested boolean style, but with no unchecked value,
       # which won't generate the hidden checkbox. This is the default functionality
       # in Rails > 3.2.1, and is backported in SimpleForm AV helpers.
-      def build_check_box(unchecked_value = unchecked_value)
+      def build_check_box(unchecked_value = unchecked_value())
         @builder.check_box(attribute_name, input_html_options, checked_value, unchecked_value)
       end
 

data/lib/simple_form/version.rb

@@ -1,3 +1,3 @@
 module SimpleForm
-  VERSION = "3.0.3".freeze
+  VERSION = "3.0.4".freeze
 end

data/test/form_builder/input_field_test.rb

@@ -122,4 +122,44 @@ class InputFieldTest < ActionView::TestCase
     assert_no_select 'select.status[label_method]'
     assert_no_select 'select.status[value_method]'
   end
+
+  test 'build input_field without pattern component use the pattern string' do
+    swap_wrapper :default, self.custom_wrapper_with_html5_components do
+      with_concat_form_for(@user) do |f|
+        f.input_field :name, pattern: '\w+'
+      end
+
+      assert_select 'input[pattern="\w+"]'
+    end
+  end
+
+  test 'build input_field without placeholder component use the placeholder string' do
+    swap_wrapper :default, self.custom_wrapper_with_html5_components do
+      with_concat_form_for(@user) do |f|
+        f.input_field :name, placeholder: 'Placeholder'
+      end
+
+      assert_select 'input[placeholder="Placeholder"]'
+    end
+  end
+
+  test 'build input_field without maxlength component use the maxlength string' do
+    swap_wrapper :default, self.custom_wrapper_with_html5_components do
+      with_concat_form_for(@user) do |f|
+        f.input_field :name, maxlength: 5
+      end
+
+      assert_select 'input[maxlength="5"]'
+    end
+  end
+
+  test 'build input_field without readonly component use the readonly string' do
+    swap_wrapper :default, self.custom_wrapper_with_html5_components do
+      with_concat_form_for(@user) do |f|
+        f.input_field :name, readonly: true
+      end
+
+      assert_select 'input[readonly="readonly"]'
+    end
+  end
 end

data/test/support/misc_helpers.rb

@@ -112,6 +112,12 @@ module MiscHelpers
     end
   end
 
+  def custom_wrapper_with_html5_components
+    SimpleForm.build tag: :span, class: 'custom_wrapper' do |b|
+      b.use :label_text
+    end
+  end
+
   def custom_form_for(object, *args, &block)
     simple_form_for(object, *args, { builder: CustomFormBuilder }, &block)
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simple_form
 version: !ruby/object:Gem::Version
-  version: 3.0.3
+  version: 3.0.4
 platform: ruby
 authors:
 - José Valim
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-25 00:00:00.000000000 Z
+date: 2015-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -165,7 +165,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: simple_form
-rubygems_version: 2.2.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Forms made easy!
@@ -206,3 +206,4 @@ test_files:
 - test/support/mock_controller.rb
 - test/support/models.rb
 - test/test_helper.rb
+has_rdoc: