simple_form 2.0.1 → 2.0.2

data/test/action_view_extensions/form_helper_test.rb

@@ -9,95 +9,95 @@ class FormHelperTest < ActionView::TestCase
   end
 
   test 'SimpleForm should add default class to form' do
-    concat(simple_form_for(:user) do |f| end)
+    with_concat_form_for(:user)
     assert_select 'form.simple_form'
   end
 
   test 'SimpleForm should use default browser validations by default' do
-    concat(simple_form_for(:user) do |f| end)
+    with_concat_form_for(:user)
     assert_no_select 'form[novalidate]'
   end
 
   test 'SimpleForm should not use default browser validations if specified in the configuration options' do
     swap SimpleForm, :browser_validations => false do
-      concat(simple_form_for(:user) do |f| end)
+      with_concat_form_for(:user)
       assert_select 'form[novalidate="novalidate"]'
     end
   end
 
   test 'a form specific disabled validation option should override the default enabled browser validation configuration option' do
-    concat(simple_form_for(:user, :html => { :novalidate => true }) do |f| end)
+    with_concat_form_for(:user, :html => { :novalidate => true })
     assert_select 'form[novalidate="novalidate"]'
   end
 
   test 'a form specific enabled validation option should override the disabled browser validation configuration option' do
     swap SimpleForm, :browser_validations => false do
-      concat(simple_form_for(:user, :html => { :novalidate => false }) do |f| end)
+      with_concat_form_for(:user, :html => { :novalidate => false })
       assert_no_select 'form[novalidate]'
     end
   end
 
   test 'SimpleForm should add object name as css class to form when object is not present' do
-    concat(simple_form_for(:user) do |f| end)
+    with_concat_form_for(:user, :html => { :novalidate => true })
     assert_select 'form.simple_form.user'
   end
 
   test 'SimpleForm should add :as option as css class to form when object is not present' do
-    concat(simple_form_for(:user, :as => 'superuser') do |f| end)
+    with_concat_form_for(:user, :as => 'superuser')
     assert_select 'form.simple_form.superuser'
   end
 
   test 'SimpleForm should add object class name with new prefix as css class to form if record is not persisted' do
     @user.new_record!
-    concat(simple_form_for(@user) do |f| end)
+    with_concat_form_for(@user)
     assert_select 'form.simple_form.new_user'
   end
 
   test 'SimpleForm should add :as option with new prefix as css class to form if record is not persisted' do
     @user.new_record!
-    concat(simple_form_for(@user, :as => 'superuser') do |f| end)
+    with_concat_form_for(@user, :as => 'superuser')
     assert_select 'form.simple_form.new_superuser'
   end
 
   test 'SimpleForm should add edit class prefix as css class to form if record is persisted' do
-    concat(simple_form_for(@user) do |f| end)
+    with_concat_form_for(@user)
     assert_select 'form.simple_form.edit_user'
   end
 
   test 'SimpleForm should add :as options with edit prefix as css class to form if record is persisted' do
-    concat(simple_form_for(@user, :as => 'superuser') do |f| end)
+    with_concat_form_for(@user, :as => 'superuser')
     assert_select 'form.simple_form.edit_superuser'
   end
 
   test 'SimpleForm should not add object class to form if css_class is specified' do
-    concat(simple_form_for(:user, :html => {:class => nil}) do |f| end)
+    with_concat_form_for(:user, :html => {:class => nil})
     assert_no_select 'form.user'
   end
 
   test 'SimpleForm should add custom class to form if css_class is specified' do
-    concat(simple_form_for(:user, :html => {:class => 'my_class'}) do |f| end)
+    with_concat_form_for(:user, :html => {:class => 'my_class'})
     assert_select 'form.my_class'
   end
 
   test 'pass options to SimpleForm' do
-    concat(simple_form_for(:user, :url => '/account', :html => { :id => 'my_form' }) do |f| end)
+    with_concat_form_for(:user, :url => '/account', :html => { :id => 'my_form' })
     assert_select 'form#my_form'
     assert_select 'form[action=/account]'
   end
 
   test 'fields for yields an instance of FormBuilder' do
-    concat(simple_fields_for(:user) do |f|
+    with_concat_form_for(:user) do |f|
       assert f.instance_of?(SimpleForm::FormBuilder)
-    end)
+    end
   end
 
   test 'fields for with a hash like model yeilds an instance of FormBuilder' do
     @hash_backed_author = HashBackedAuthor.new
 
-    concat(simple_fields_for(:author, @hash_backed_author) do |f|
+    with_concat_fields_for(:author, @hash_backed_author) do |f|
       assert f.instance_of?(SimpleForm::FormBuilder)
       f.input :name
-    end)
+    end
 
     assert_select "input[name='author[name]'][value='hash backed author']"
   end

data/test/form_builder/association_test.rb

@@ -41,7 +41,7 @@ class AssociationTest < ActionView::TestCase
   end
 
   test 'builder preloads collection association' do
-    value = @user.tags
+    value = @user.tags = Object.new
     value.expects(:to_a).returns(value)
     with_association_for @user, :tags
     assert_select 'form select.select#user_tag_ids'
@@ -51,7 +51,7 @@ class AssociationTest < ActionView::TestCase
   end
 
   test 'builder does not preload collection association if preload is false' do
-    value = @user.company
+    value = @user.company = Object.new
     value.expects(:to_a).never
     with_association_for @user, :company, :preload => false
     assert_select 'form select.select#user_company_id'
@@ -61,7 +61,7 @@ class AssociationTest < ActionView::TestCase
   end
 
   test 'builder does not preload non-collection association' do
-    value = @user.company
+    value = @user.company = Object.new
     value.expects(:to_a).never
     with_association_for @user, :company, :preload => false
     assert_select 'form select.select#user_company_id'

data/test/form_builder/error_notification_test.rb

@@ -23,7 +23,7 @@ class ErrorNotificationTest < ActionView::TestCase
 
   test 'error notification is generated when the object has some error' do
     with_error_notification_for @user
-    assert_select 'p.error_notification', 'Some errors were found, please take a look:'
+    assert_select 'p.error_notification', 'Please review the problems below:'
   end
 
   test 'error notification uses I18n based on model to generate the notification message' do

data/test/form_builder/general_test.rb

@@ -305,6 +305,20 @@ class FormBuilderTest < ActionView::TestCase
     assert_no_select "input.string[name='user[credit_limit]']"
   end
 
+  test 'builder should receive a default argument and pass it to the inputs and nested form' do
+    @user.company = Company.new(1, 'Empresa')
+
+    with_concat_form_for @user, :defaults => { :input_html => { :class => 'default_class' } } do |f|
+      concat(f.input :name)
+      concat(f.simple_fields_for(:company) do |company_form|
+        concat(company_form.input :name)
+      end)
+    end
+
+    assert_select "input.string.default_class[name='user[name]']"
+    assert_select "input.string.default_class[name='user[company_attributes][name]']"
+  end
+
   # WITHOUT OBJECT
   test 'builder should generate properly when object is not present' do
     with_form_for :project, :name

data/test/form_builder/general_test.rb.orig

@@ -0,0 +1,380 @@
+# encoding: UTF-8
+require 'test_helper'
+
+class FormBuilderTest < ActionView::TestCase
+  def with_custom_form_for(object, *args, &block)
+    with_concat_custom_form_for(object) do |f|
+      f.input(*args, &block)
+    end
+  end
+
+  test 'nested simple fields should yield an instance of FormBuilder' do
+    simple_form_for :user do |f|
+      f.simple_fields_for :posts do |posts_form|
+        assert posts_form.instance_of?(SimpleForm::FormBuilder)
+      end
+    end
+  end
+
+  test 'builder input is html safe' do
+    simple_form_for @user do |f|
+      assert f.input(:name).html_safe?
+    end
+  end
+
+  test 'builder input should allow a block to configure input' do
+    with_form_for @user, :name do
+      text_field_tag :foo, :bar, :id => :cool
+    end
+    assert_no_select 'input.string'
+    assert_select 'input#cool'
+  end
+
+  test 'builder should allow adding custom input mappings for default input types' do
+    swap SimpleForm, :input_mappings => { /count$/ => :integer } do
+      with_form_for @user, :post_count
+      assert_no_select 'form input#user_post_count.string'
+      assert_select 'form input#user_post_count.numeric.integer'
+    end
+  end
+
+  test 'builder should allow to skip input_type class' do
+    swap SimpleForm, :generate_additional_classes_for => [:label, :wrapper] do
+      with_form_for @user, :post_count
+      assert_no_select "form input#user_post_count.integer"
+      assert_select "form input#user_post_count"
+    end
+  end
+
+  test 'builder should allow adding custom input mappings for integer input types' do
+    swap SimpleForm, :input_mappings => { /lock_version/ => :hidden } do
+      with_form_for @user, :lock_version
+      assert_no_select 'form input#user_lock_version.integer'
+      assert_select 'form input#user_lock_version.hidden'
+    end
+  end
+
+  test 'builder uses the first matching custom input map when more than one matches' do
+    swap SimpleForm, :input_mappings => { /count$/ => :integer, /^post_/ => :password } do
+      with_form_for @user, :post_count
+      assert_no_select 'form input#user_post_count.password'
+      assert_select 'form input#user_post_count.numeric.integer'
+    end
+  end
+
+  test 'builder uses the custom map only for matched attributes' do
+    swap SimpleForm, :input_mappings => { /lock_version/ => :hidden } do
+      with_form_for @user, :post_count
+      assert_no_select 'form input#user_post_count.hidden'
+      assert_select 'form input#user_post_count.string'
+    end
+  end
+
+  # INPUT TYPES
+  test 'builder should generate text fields for string columns' do
+    with_form_for @user, :name
+    assert_select 'form input#user_name.string'
+  end
+
+  test 'builder should generate text areas for text columns' do
+    with_form_for @user, :description
+    assert_select 'form textarea#user_description.text'
+  end
+
+  test 'builder should generate a checkbox for boolean columns' do
+    with_form_for @user, :active
+    assert_select 'form input[type=checkbox]#user_active.boolean'
+  end
+
+  test 'builder should use integer text field for integer columns' do
+    with_form_for @user, :age
+    assert_select 'form input#user_age.numeric.integer'
+  end
+
+  test 'builder should generate decimal text field for decimal columns' do
+    with_form_for @user, :credit_limit
+    assert_select 'form input#user_credit_limit.numeric.decimal'
+  end
+
+  test 'builder should generate password fields for columns that matches password' do
+    with_form_for @user, :password
+    assert_select 'form input#user_password.password'
+  end
+
+  test 'builder should generate country fields for columns that matches country' do
+    with_form_for @user, :residence_country
+    assert_select 'form select#user_residence_country.country'
+  end
+
+  test 'builder should generate time_zone fields for columns that matches time_zone' do
+    with_form_for @user, :time_zone
+    assert_select 'form select#user_time_zone.time_zone'
+  end
+
+  test 'builder should generate email fields for columns that matches email' do
+    with_form_for @user, :email
+    assert_select 'form input#user_email.string.email'
+  end
+
+  test 'builder should generate tel fields for columns that matches phone' do
+    with_form_for @user, :phone_number
+    assert_select 'form input#user_phone_number.string.tel'
+  end
+
+  test 'builder should generate url fields for columns that matches url' do
+    with_form_for @user, :url
+    assert_select 'form input#user_url.string.url'
+  end
+
+  test 'builder should generate date select for date columns' do
+    with_form_for @user, :born_at
+    assert_select 'form select#user_born_at_1i.date'
+  end
+
+  test 'builder should generate time select for time columns' do
+    with_form_for @user, :delivery_time
+    assert_select 'form select#user_delivery_time_4i.time'
+  end
+
+  test 'builder should generate datetime select for datetime columns' do
+    with_form_for @user, :created_at
+    assert_select 'form select#user_created_at_1i.datetime'
+  end
+
+  test 'builder should generate datetime select for timestamp columns' do
+    with_form_for @user, :updated_at
+    assert_select 'form select#user_updated_at_1i.datetime'
+  end
+
+  test 'builder should generate file for file columns' do
+    @user.avatar = mock("file")
+    @user.avatar.expects(:respond_to?).with(:mounted_as).returns(false)
+    @user.avatar.expects(:respond_to?).with(:file?).returns(false)
+    @user.avatar.expects(:respond_to?).with(:public_filename).returns(true)
+
+    with_form_for @user, :avatar
+    assert_select 'form input#user_avatar.file'
+  end
+
+  test 'builder should generate file for attributes that are real db columns but have file methods' do
+    @user.home_picture = mock("file")
+    @user.home_picture.expects(:respond_to?).with(:mounted_as).returns(true)
+
+    with_form_for @user, :home_picture
+    assert_select 'form input#user_home_picture.file'
+  end
+
+  test 'build should generate select if a collection is given' do
+    with_form_for @user, :age, :collection => 1..60
+    assert_select 'form select#user_age.select'
+  end
+
+  test 'builder should allow overriding default input type for text' do
+    with_form_for @user, :name, :as => :text
+    assert_no_select 'form input#user_name'
+    assert_select 'form textarea#user_name.text'
+
+    with_form_for @user, :active, :as => :radio_buttons
+    assert_no_select 'form input[type=checkbox]'
+    assert_select 'form input.radio_buttons[type=radio]', :count => 2
+
+    with_form_for @user, :born_at, :as => :string
+    assert_no_select 'form select'
+    assert_select 'form input#user_born_at.string'
+  end
+
+  # COMMON OPTIONS
+  test 'builder should add chosen form class' do
+    swap SimpleForm, :form_class => :my_custom_class do
+      with_form_for @user, :name
+      assert_select 'form.my_custom_class'
+    end
+  end
+
+  test 'builder should allow passing options to input' do
+    with_form_for @user, :name, :input_html => { :class => 'my_input', :id => 'my_input' }
+    assert_select 'form input#my_input.my_input.string'
+  end
+
+  test 'builder should not propagate input options to wrapper' do
+    with_form_for @user, :name, :input_html => { :class => 'my_input', :id => 'my_input' }
+    assert_no_select 'form div.input.my_input.string'
+    assert_select 'form input#my_input.my_input.string'
+  end
+
+  test 'builder should generate a input with label' do
+    with_form_for @user, :name
+    assert_select 'form label.string[for=user_name]', /Name/
+  end
+
+  test 'builder should be able to disable the label for a input' do
+    with_form_for @user, :name, :label => false
+    assert_no_select 'form label'
+  end
+
+  test 'builder should use custom label' do
+    with_form_for @user, :name, :label => 'Yay!'
+    assert_select 'form label', /Yay!/
+  end
+
+  test 'builder should pass options to label' do
+    with_form_for @user, :name, :label_html => { :id => "cool" }
+    assert_select 'form label#cool', /Name/
+  end
+
+  test 'builder should not generate hints for a input' do
+    with_form_for @user, :name
+    assert_no_select 'span.hint'
+  end
+
+  test 'builder should be able to add a hint for a input' do
+    with_form_for @user, :name, :hint => 'test'
+    assert_select 'span.hint', 'test'
+  end
+
+  test 'builder should be able to disable a hint even if it exists in i18n' do
+    store_translations(:en, :simple_form => { :hints => { :name => 'Hint test' } }) do
+      with_form_for @user, :name, :hint => false
+      assert_no_select 'span.hint'
+    end
+  end
+
+  test 'builder should pass options to hint' do
+    with_form_for @user, :name, :hint => 'test', :hint_html => { :id => "cool" }
+    assert_select 'span.hint#cool', 'test'
+  end
+
+  test 'builder should generate errors for attribute without errors' do
+    with_form_for @user, :credit_limit
+    assert_no_select 'span.errors'
+  end
+
+  test 'builder should generate errors for attribute with errors' do
+    with_form_for @user, :name
+    assert_select 'span.error', "can't be blank"
+  end
+
+  test 'builder should be able to disable showing errors for a input' do
+    with_form_for @user, :name, :error => false
+    assert_no_select 'span.error'
+  end
+
+  test 'builder should pass options to errors' do
+    with_form_for @user, :name, :error_html => { :id => "cool" }
+    assert_select 'span.error#cool', "can't be blank"
+  end
+
+  test 'placeholder should not be generated when set to false' do
+    store_translations(:en, :simple_form => { :placeholders => { :user => {
+      :name => 'Name goes here'
+    } } }) do
+      with_form_for @user, :name, :placeholder => false
+      assert_no_select 'input[placeholder]'
+    end
+  end
+
+  # DEFAULT OPTIONS
+  test 'builder should receive a default argument and pass it to the inputs' do
+    with_concat_form_for @user, :defaults => { :input_html => { :class => 'default_class' } } do |f|
+      f.input :name
+    end
+    assert_select 'input.default_class'
+  end
+
+  test 'builder should receive a default argument and pass it to the inputs, respecting the specific options' do
+    with_concat_form_for @user, :defaults => { :input_html => { :class => 'default_class' } } do |f|
+      f.input :name, :input_html => { :id => 'specific_id' }
+    end
+    assert_select 'input.default_class#specific_id'
+  end
+
+  test 'builder should receive a default argument and pass it to the inputs, overwriting the defaults with specific options' do
+    with_concat_form_for @user, :defaults => { :input_html => { :class => 'default_class', :id => 'default_id' } } do |f|
+      f.input :name, :input_html => { :id => 'specific_id' }
+    end
+    assert_select 'input.default_class#specific_id'
+  end
+
+  test 'builder should receive a default argument and pass it to the inputs without changing the defaults' do
+    with_concat_form_for @user, :defaults => { :input_html => { :class => 'default_class', :id => 'default_id' } } do |f|
+      concat(f.input :name)
+      concat(f.input :credit_limit)
+    end
+
+    assert_select "input.string.default_class[name='user[name]']"
+    assert_no_select "input.string[name='user[credit_limit]']"
+  end
+
+<<<<<<< HEAD
+  test 'builder should receive a default argument and pass it to the inputs and nested form' do
+    @user.company = Company.new(1, 'Empresa')
+
+    with_concat_form_for @user, :defaults => { :input_html => { :class => 'default_class' } } do |f|
+      concat(f.input :name)
+      concat(f.simple_fields_for(:company) do |company_form|
+        concat(company_form.input :name)
+      end)
+    end
+
+    assert_select "input.string.default_class[name='user[name]']"
+    assert_select "input.string.default_class[name='user[company_attributes][name]']"
+=======
+  test 'input size and maxlength should be the column limit plus one to make room for decimal point if the user uses text instead of number for field type' do
+    with_concat_form_for @user do |f|
+      concat(f.input(:credit_limit, :as => :string))
+    end
+
+    assert_select "input[type=text][name='user[credit_limit]'][maxlength=16][size=16]"
+    assert_no_select "input[type=text][name='user[credit_limit]'][maxlength=15][size=15]"
+>>>>>>> shwoodard-limit_with_decimal_point
+  end
+
+  # WITHOUT OBJECT
+  test 'builder should generate properly when object is not present' do
+    with_form_for :project, :name
+    assert_select 'form input.string#project_name'
+  end
+
+  test 'builder should generate password fields based on attribute name when object is not present' do
+    with_form_for :project, :password_confirmation
+    assert_select 'form input[type=password].password#project_password_confirmation'
+  end
+
+  test 'builder should generate text fields by default for all attributes when object is not present' do
+    with_form_for :project, :created_at
+    assert_select 'form input.string#project_created_at'
+    with_form_for :project, :budget
+    assert_select 'form input.string#project_budget'
+  end
+
+  test 'builder should allow overriding input type when object is not present' do
+    with_form_for :project, :created_at, :as => :datetime
+    assert_select 'form select.datetime#project_created_at_1i'
+    with_form_for :project, :budget, :as => :decimal
+    assert_select 'form input.decimal#project_budget'
+  end
+
+  # CUSTOM FORM BUILDER
+  test 'custom builder should inherit mappings' do
+    with_custom_form_for @user, :email
+    assert_select 'form input[type=email]#user_email.custom'
+  end
+
+  test 'form with CustomMapTypeFormBuilder should use custom map type builder' do
+    with_concat_custom_mapping_form_for(:user) do |user|
+      assert user.instance_of?(CustomMapTypeFormBuilder)
+    end
+  end
+
+  test 'form with CustomMapTypeFormBuilder should use custom mapping' do
+    with_concat_custom_mapping_form_for(:user) do |user|
+      assert_equal SimpleForm::Inputs::StringInput, user.class.mappings[:custom_type]
+    end
+  end
+
+  test 'form without CustomMapTypeFormBuilder should not use custom mapping' do
+    with_concat_form_for(:user) do |user|
+      assert_nil user.class.mappings[:custom_type]
+    end
+  end
+end

data/test/form_builder/hint_test.rb

@@ -41,6 +41,12 @@ class HintTest < ActionView::TestCase
     with_hint_for @user, :name, :hint => 'Yay!', :id => 'hint', :class => 'yay'
     assert_select 'span#hint.hint.yay'
   end
+  
+  test 'hint should be output as html_safe' do
+    with_hint_for @user, :name, :hint => '<b>Bold</b> and not...'
+    assert_select 'span.hint', 'Bold and not...'  
+  end
+  
 
   # Without attribute name
 
@@ -104,6 +110,16 @@ class HintTest < ActionView::TestCase
       assert_select 'span.hint', /My company!/
     end
   end
+  
+  test 'hint should output translations as html_safe' do
+    store_translations(:en, :simple_form => { :hints => { :user => {
+      :edit => { :name => '<b>This is bold</b> and this is not...' }
+    } } }) do
+      with_hint_for @user, :name
+      assert_select 'span.hint', 'This is bold and this is not...'
+    end
+  end
+  
 
   # No object
 

data/test/form_builder/wrapper_test.rb

@@ -99,16 +99,16 @@ class WrapperTest < ActionView::TestCase
 
   test 'custom wrappers on a form basis' do
     swap_wrapper :another do
-      concat simple_form_for(@user) { |f|
+      with_concat_form_for(@user) do |f|
         f.input :name
-      }
+      end
 
       assert_no_select "section.custom_wrapper div.another_wrapper label"
       assert_no_select "section.custom_wrapper div.another_wrapper input.string"
 
-      concat simple_form_for(@user, :wrapper => :another) { |f|
+      with_concat_form_for(@user, :wrapper => :another) do |f|
         f.input :name
-      }
+      end
 
       assert_select "section.custom_wrapper div.another_wrapper label"
       assert_select "section.custom_wrapper div.another_wrapper input.string"
@@ -141,6 +141,19 @@ class WrapperTest < ActionView::TestCase
     end
   end
 
+  test 'do not duplicate label classes for different inputs' do
+    swap_wrapper :default, self.custom_wrapper_with_label_html_option do
+      with_concat_form_for(@user) do |f|
+        concat f.input :name, :required => false
+        concat f.input :email, :as => :email, :required => true
+      end
+
+      assert_select "label.string.optional.extra-label-class[for='user_name']"
+      assert_select "label.email.required.extra-label-class[for='user_email']"
+      assert_no_select "label.string.optional.extra-label-class[for='user_email']"
+    end
+  end
+
   test 'raise error when wrapper not found' do
     assert_raise SimpleForm::WrapperNotFound do
       with_form_for @user, :name, :wrapper => :not_found

data/test/inputs/boolean_input_test.rb

@@ -29,6 +29,20 @@ class BooleanInputTest < ActionView::TestCase
     end
   end
 
+  test 'input boolean with nested allows :inline_label' do
+    swap SimpleForm, :boolean_style => :nested do
+      with_input_for @user, :active, :boolean, :label => false, :inline_label => 'I am so inline.'
+      assert_select 'label.checkbox', :text => 'I am so inline.'
+    end
+  end
+
+  test 'input boolean with nested style creates an inline label using the default label text when inline_label option set to true' do
+    swap SimpleForm, :boolean_style => :nested do
+      with_input_for @user, :active, :boolean, :label => false, :inline_label => true
+      assert_select 'label.checkbox', :text => 'Active'
+    end
+  end
+
   test 'input boolean with nested generates a manual hidden field for checkbox outside the label, to recreate Rails functionality with valid html5' do
     swap SimpleForm, :boolean_style => :nested do
       with_input_for @user, :active, :boolean

data/test/inputs/discovery_test.rb

@@ -12,6 +12,7 @@ class DiscoveryTest < ActionView::TestCase
         Object.send :remove_const, :StringInput
         Object.send :remove_const, :NumericInput
         Object.send :remove_const, :CustomizedInput
+        Object.send :remove_const, :CollectionSelectInput
       end
     end
   end
@@ -58,4 +59,11 @@ class DiscoveryTest < ActionView::TestCase
       assert_select 'form section input#user_age.numeric.integer'
     end
   end
-end
+
+  test 'new inputs can override the input_html_options' do
+    discovery do
+      with_form_for @user, :active, :as => :select
+      assert_select 'form select#user_active.select.chosen'
+    end
+  end
+end

data/test/inputs/numeric_input_test.rb

@@ -164,4 +164,10 @@ class NumericInputTest < ActionView::TestCase
       assert_select 'input[max=99]'
     end
   end
+
+  test 'min_max should not emit max value as bare string' do
+    with_input_for @other_validating_user, :age, :integer
+    assert_select 'input[max]'
+    assert_no_select 'div', %r{^99}
+  end
 end