simple_command 0.2.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8847792f86f2c4162d832d2603abfb7f0f40208110ad339484851dfaeeb99cf4
-  data.tar.gz: ba9e8c0e1d46fb25d8408f430ba462e14e2ca386e5cd7b4c611d7787523448a0
+  metadata.gz: 0bfe8377a98ac9d816954e6060c6fb39b0e0c6a8817a1f14ccc3695ff1f38711
+  data.tar.gz: f7ffdea8cec0b7988a8b4b71977986d1a0b2aa9ac5c2219ac9fd490c114c8b41
 SHA512:
-  metadata.gz: d4fa95128f6e3fcd15419705bf36d56c33b8da0ced34b068940a3ee3fe066feeada465f8257f5076a87f3e237bd0adfd83b377a1d68bf9e81a09240bae5be243
-  data.tar.gz: 8cc7cea6c22b3af310b039eee0f041f0ac5c48597d8cc13122771ffdef67a54dcf2ce8f2b77172ad3c6425e5598024d2ef48d95a7562083c94c3d1419348a7e0
+  metadata.gz: 11cde61466a2c6fea1c40cee0f358e3e299ea9bc3e98653fd9a8bafc414f5475a24bd3fa26537d1c7c86be8774f26d703e2aef44c6a325b441b7b9e9eb143be6
+  data.tar.gz: 03c2d3b58075237aa7e56d2a72dd4b7faafa5f7b7b13dd76fcc919b034e9eecd581c3099f9ce1aa4ba4efe91074699b2622f8e9be19bc1838edad7f282030c5b

data/.github/workflows/ci.yml

@@ -0,0 +1,23 @@
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: ["2.6", "2.7", "3.0", "3.1", ruby-head, jruby-9.3, jruby-head]
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        bundler-cache: true # 'bundle install' and cache gems
+        ruby-version: ${{ matrix.ruby }}
+    - name: Run tests
+      run: bundle exec rake

data/README.md

@@ -1,5 +1,5 @@
 [![Code Climate](https://codeclimate.com/github/nebulab/simple_command/badges/gpa.svg)](https://codeclimate.com/github/nebulab/simple_command)
-[ ![Codeship Status for nebulab/simple_command](https://app.codeship.com/projects/45ce7790-8daf-0132-1412-669677a474c3/status?branch=master)](https://app.codeship.com/projects/60741)
+![CI](https://github.com/nebulab/simple_command/actions/workflows/ci.yml/badge.svg)
 
 # SimpleCommand
 
@@ -7,7 +7,7 @@ A simple, standardized way to build and use _Service Objects_ (aka _Commands_) i
 
 ## Requirements
 
-* Ruby 2.0+
+* Ruby 2.6+
 
 ## Installation
 

data/lib/simple_command/errors.rb

@@ -10,7 +10,7 @@ module SimpleCommand
 
     def add_multiple_errors(errors_hash)
       errors_hash.each do |key, values|
-        values.each { |value| add key, value }
+        SimpleCommand::Utils.array_wrap(values).each { |value| add key, value }
       end
     end
 

data/lib/simple_command/utils.rb

@@ -0,0 +1,14 @@
+module SimpleCommand
+  module Utils
+    # Borrowed from active_support/core_ext/array/wrap
+    def self.array_wrap(object)
+      if object.nil?
+        []
+      elsif object.respond_to?(:to_ary)
+        object.to_ary || [object]
+      else
+        [object]
+      end
+    end
+  end
+end

data/lib/simple_command/version.rb

@@ -1,3 +1,3 @@
 module SimpleCommand
-  VERSION = '0.2.0'
+  VERSION = '1.0.1'
 end

data/lib/simple_command.rb

@@ -1,4 +1,5 @@
 require 'simple_command/version'
+require 'simple_command/utils'
 require 'simple_command/errors'
 
 module SimpleCommand

data/simple_command.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'simple_command/version'
 
 Gem::Specification.new do |s|
-  s.required_ruby_version = '>= 2.0'
+  s.required_ruby_version = '>= 2.6'
   s.name          = 'simple_command'
   s.version       = SimpleCommand::VERSION
   s.authors       = ['Andrea Pavoni']

data/spec/simple_command/errors_spec.rb

@@ -19,21 +19,33 @@ describe SimpleCommand::Errors do
   end
 
   describe '#add_multiple_errors' do
-    let(:errors_list) do
-      {
+    it 'populates itself with the added errors' do
+      errors_list = {
         some_error: ['some error description'],
         another_error: ['another error description']
       }
-    end
 
-    before do
       errors.add_multiple_errors errors_list
-    end
 
-    it 'populates itself with the added errors' do
       expect(errors[:some_error]).to eq(errors_list[:some_error])
       expect(errors[:another_error]).to eq(errors_list[:another_error])
     end
+
+    it 'copies errors from another SimpleCommand::Errors object' do
+      command_errors = SimpleCommand::Errors.new
+      command_errors.add :some_error, "was found"
+      command_errors.add :some_error, "happened again"
+
+      errors.add_multiple_errors command_errors
+
+      expect(errors[:some_error]).to eq(["was found", "happened again"])
+    end
+
+    it "ignores nil values" do
+      errors.add_multiple_errors({:foo => nil})
+
+      expect(errors[:foo]).to eq nil
+    end
   end
 
   describe '#each' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simple_command
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Andrea Pavoni
@@ -59,6 +59,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
@@ -69,6 +70,7 @@ files:
 - Rakefile
 - lib/simple_command.rb
 - lib/simple_command/errors.rb
+- lib/simple_command/utils.rb
 - lib/simple_command/version.rb
 - simple_command.gemspec
 - spec/factories/missed_call_command.rb
@@ -88,7 +90,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.0'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="