simple_action 1.6.3 → 2.0.4

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    OTZhMmE3YjRmMjU5OGE2YTM0YmRlMmNlM2Q3MjA3Y2U3MmEwMDI0Zg==
-  data.tar.gz: !binary |-
-    ODc4ZThmZDYwMjk3M2RmNjEyYzdhODRlMDA3ZGFlYzhhMGMwOGU0Mw==
+SHA256:
+  metadata.gz: 944f2bbe219621c486d4b86b702e34f39596b25fc1c883cd81e23874b7d0c10a
+  data.tar.gz: d18fc7220fef77f9c4fab2b2d3d616154e2bbd4061b2d0a344566b275693eb44
 SHA512:
-  metadata.gz: !binary |-
-    YjdkZmRjYTEzM2M1MzM3ZWIzNGNhMmFlYTkzMTIxYjA1OTdhYzc5ZjYyZmRk
-    ODdjYzA5ZmQ5MmU5Nzc5OTc5ZWZlZDE1Y2ExMjBmNTFmMWExNzU5YTg4ZDg3
-    MzM0OGM4OGY2NDc2YjBjZjM0NTY1YThkYWEzYTFkNTNjMzY3NTY=
-  data.tar.gz: !binary |-
-    ZTlkZDMwYTI5N2Q4YTUwNjQyMzljNmIzYTkxZTllNDkyYjQyZWFjMWNhZDEx
-    MzQ0YjgwNmY0ODZjNzNjMmQxNzJjMTUxMzE4MTc2MTllNjRiY2E2YWU2N2Uw
-    M2E4OTVmMWQ3MTAwYzA2YjY2YTMyNTEyM2UyOTY4NzU5MWU5N2I=
+  metadata.gz: 9644cdc6d8a5be7a8abf5ad304836f5a22660352ce76ce244d141da6e1ce2b737f698bd217e7eaeb3f1364544feec35ce3dee0bde6ed79b2469494d52f1878a5
+  data.tar.gz: 3864e69ac24ee0749d7666bbd24b44d02437d118ec8fe7540e7a5162ea1b31a1eeb5f97cca02d5dc922d2d764cc79207b46903b514b6ae47d6e9308dd6694f54

data/.gitignore

@@ -33,3 +33,6 @@ build/
 
 # unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
 .rvmrc
+
+.idea/*
+.env

data/.ruby-version

@@ -1 +1 @@
-ruby-1.9.3-p545
+2.5.0

data/Appraisals

@@ -0,0 +1,7 @@
+appraise 'simple_params-1' do
+  gem 'simple_params', '>= 1.0', '< 2.0'
+end
+
+appraise 'simple_params-2' do
+  gem 'simple_params', '>= 2.0', '< 3.0'
+end

data/Gemfile.lock

@@ -1,38 +1,41 @@
 PATH
   remote: .
   specs:
-    simple_action (1.6.1)
-      simple_params (>= 1.6.8, < 2.0)
+    simple_action (2.0.3)
+      simple_params
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (4.2.6)
-      activesupport (= 4.2.6)
-      builder (~> 3.1)
-    activesupport (4.2.6)
-      i18n (~> 0.7)
-      json (~> 1.7, >= 1.7.7)
+    activemodel (6.0.3.2)
+      activesupport (= 6.0.3.2)
+    activesupport (6.0.3.2)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
       minitest (~> 5.1)
-      thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
+      zeitwerk (~> 2.2, >= 2.2.2)
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
     axiom-types (0.1.1)
       descendants_tracker (~> 0.0.4)
       ice_nine (~> 0.11.0)
       thread_safe (~> 0.3, >= 0.3.1)
-    builder (3.2.2)
     coderay (1.1.0)
     coercible (1.0.0)
       descendants_tracker (~> 0.0.1)
+    concurrent-ruby (1.1.6)
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
     diff-lcs (1.2.5)
     equalizer (0.0.11)
-    i18n (0.7.0)
+    i18n (1.8.3)
+      concurrent-ruby (~> 1.0)
     ice_nine (0.11.2)
-    json (1.8.3)
     method_source (0.8.2)
-    minitest (5.9.0)
+    minitest (5.14.1)
     pry (0.10.1)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
@@ -46,31 +49,34 @@ GEM
     rspec-expectations (2.99.2)
       diff-lcs (>= 1.1.3, < 2.0)
     rspec-mocks (2.99.3)
-    shoulda-matchers (2.8.0)
-      activesupport (>= 3.0.0)
-    simple_params (1.6.8)
-      activemodel (>= 3.0, < 5.0)
-      shoulda-matchers (~> 2.8)
+    shoulda-matchers (4.3.0)
+      activesupport (>= 4.2.0)
+    simple_params (2.0.4)
+      activemodel (>= 3.0, <= 7.0)
+      shoulda-matchers (>= 2.8)
       virtus (>= 1.0.0)
     slop (3.6.0)
-    thread_safe (0.3.5)
-    tzinfo (1.2.2)
+    thor (0.20.0)
+    thread_safe (0.3.6)
+    tzinfo (1.2.7)
       thread_safe (~> 0.1)
     virtus (1.0.5)
       axiom-types (~> 0.1)
       coercible (~> 1.0)
       descendants_tracker (~> 0.0, >= 0.0.3)
       equalizer (~> 0.0, >= 0.0.9)
+    zeitwerk (2.4.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (~> 1.5)
+  appraisal
+  bundler (>= 1.5)
   pry
-  rake (~> 10.1)
-  rspec (~> 2.6)
+  rake
+  rspec (>= 2.6)
   simple_action!
 
 BUNDLED WITH
-   1.11.2
+   2.1.4

data/Rakefile

@@ -0,0 +1,2 @@
+require 'rubygems'
+require 'appraisal'

data/gemfiles/.bundle/config

@@ -0,0 +1,2 @@
+---
+BUNDLE_RETRY: "1"

data/gemfiles/simple_params_1.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "simple_params", ">= 1.0", "< 2.0"
+
+gemspec path: "../"

data/gemfiles/simple_params_1.gemfile.lock

@@ -0,0 +1,81 @@
+PATH
+  remote: ..
+  specs:
+    simple_action (2.0.3)
+      simple_params
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (4.2.10)
+      activesupport (= 4.2.10)
+      builder (~> 3.1)
+    activesupport (4.2.10)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      thread_safe (~> 0.3, >= 0.3.4)
+      tzinfo (~> 1.1)
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    axiom-types (0.1.1)
+      descendants_tracker (~> 0.0.4)
+      ice_nine (~> 0.11.0)
+      thread_safe (~> 0.3, >= 0.3.1)
+    builder (3.2.3)
+    coderay (1.1.2)
+    coercible (1.0.0)
+      descendants_tracker (~> 0.0.1)
+    concurrent-ruby (1.0.5)
+    descendants_tracker (0.0.4)
+      thread_safe (~> 0.3, >= 0.3.1)
+    diff-lcs (1.3)
+    equalizer (0.0.11)
+    i18n (0.9.0)
+      concurrent-ruby (~> 1.0)
+    ice_nine (0.11.2)
+    method_source (0.9.0)
+    minitest (5.10.3)
+    pry (0.11.2)
+      coderay (~> 1.1.0)
+      method_source (~> 0.9.0)
+    rake (10.5.0)
+    rspec (2.99.0)
+      rspec-core (~> 2.99.0)
+      rspec-expectations (~> 2.99.0)
+      rspec-mocks (~> 2.99.0)
+    rspec-core (2.99.2)
+    rspec-expectations (2.99.2)
+      diff-lcs (>= 1.1.3, < 2.0)
+    rspec-mocks (2.99.4)
+    shoulda-matchers (2.8.0)
+      activesupport (>= 3.0.0)
+    simple_params (1.6.9)
+      activemodel (>= 3.0, < 5.0)
+      shoulda-matchers (~> 2.8)
+      virtus (>= 1.0.0)
+    thor (0.20.0)
+    thread_safe (0.3.6)
+    tzinfo (1.2.4)
+      thread_safe (~> 0.1)
+    virtus (1.0.5)
+      axiom-types (~> 0.1)
+      coercible (~> 1.0)
+      descendants_tracker (~> 0.0, >= 0.0.3)
+      equalizer (~> 0.0, >= 0.0.9)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  appraisal
+  bundler (>= 1.5)
+  pry
+  rake
+  rspec (>= 2.6)
+  simple_action!
+  simple_params (>= 1.0, < 2.0)
+
+BUNDLED WITH
+   2.1.4

data/gemfiles/simple_params_2.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "simple_params", ">= 2.0", "< 3.0"
+
+gemspec path: "../"

data/gemfiles/simple_params_2.gemfile.lock

@@ -0,0 +1,79 @@
+PATH
+  remote: ..
+  specs:
+    simple_action (2.0.3)
+      simple_params
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (5.1.4)
+      activesupport (= 5.1.4)
+    activesupport (5.1.4)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    axiom-types (0.1.1)
+      descendants_tracker (~> 0.0.4)
+      ice_nine (~> 0.11.0)
+      thread_safe (~> 0.3, >= 0.3.1)
+    coderay (1.1.2)
+    coercible (1.0.0)
+      descendants_tracker (~> 0.0.1)
+    concurrent-ruby (1.0.5)
+    descendants_tracker (0.0.4)
+      thread_safe (~> 0.3, >= 0.3.1)
+    diff-lcs (1.3)
+    equalizer (0.0.11)
+    i18n (0.9.0)
+      concurrent-ruby (~> 1.0)
+    ice_nine (0.11.2)
+    method_source (0.9.0)
+    minitest (5.10.3)
+    pry (0.11.2)
+      coderay (~> 1.1.0)
+      method_source (~> 0.9.0)
+    rake (10.5.0)
+    rspec (2.99.0)
+      rspec-core (~> 2.99.0)
+      rspec-expectations (~> 2.99.0)
+      rspec-mocks (~> 2.99.0)
+    rspec-core (2.99.2)
+    rspec-expectations (2.99.2)
+      diff-lcs (>= 1.1.3, < 2.0)
+    rspec-mocks (2.99.4)
+    shoulda-matchers (3.1.2)
+      activesupport (>= 4.0.0)
+    simple_params (2.0.1)
+      activemodel (>= 3.0, <= 6.0)
+      shoulda-matchers (>= 2.8)
+      virtus (>= 1.0.0)
+    thor (0.20.0)
+    thread_safe (0.3.6)
+    tzinfo (1.2.4)
+      thread_safe (~> 0.1)
+    virtus (1.0.5)
+      axiom-types (~> 0.1)
+      coercible (~> 1.0)
+      descendants_tracker (~> 0.0, >= 0.0.3)
+      equalizer (~> 0.0, >= 0.0.9)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  appraisal
+  bundler (>= 1.5)
+  pry
+  rake
+  rspec (>= 2.6)
+  simple_action!
+  simple_params (>= 2.0, < 3.0)
+
+BUNDLED WITH
+   2.1.4

data/lib/simple_action/concerns/delegates_to_params.rb

@@ -49,7 +49,9 @@ module SimpleAction
     def delegatable_params_method?(sym)
       params_accessor?(sym) ||
       attributes_method?(sym) ||
-      build_method?(sym)
+      build_method?(sym) ||
+      validators_method?(sym) ||
+      client_side_validation_method?(sym)
     end
 
     def params_accessor?(sym)
@@ -64,5 +66,13 @@ module SimpleAction
     def build_method?(sym)
       sym.to_s.gsub('=', '').start_with?('build_')
     end
+
+    def validators_method?(sym)
+      sym.to_s.sub('?', '').end_with?('_validators')
+    end
+
+    def client_side_validation_method?(sym)
+      sym.to_s.start_with?('client_side_validation')
+    end
   end
 end

data/lib/simple_action/version.rb

@@ -1,3 +1,3 @@
 module SimpleAction
-  VERSION = "1.6.3"
+  VERSION = "2.0.4"
 end

data/simple_action.gemspec

@@ -4,23 +4,24 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'simple_action/version'
 
 Gem::Specification.new do |spec|
-  spec.name = "simple_action"
+  spec.name = 'simple_action'
   spec.version = SimpleAction::VERSION
-  spec.authors = ["brycesenz"]
-  spec.email = ["bryce.senz@gmail.com"]
+  spec.authors = ['brycesenz']
+  spec.email = ['bryce.senz@gmail.com']
   spec.description = %q{Simple Service Object class for services & API endpoints}
   spec.summary = %q{A DSL for specifying services objects, including parameters and execution}
-  spec.homepage = "https://github.com/brycesenz/simple_action"
-  spec.license = "MIT"
+  spec.homepage = 'https://github.com/brycesenz/simple_action'
+  spec.license = 'MIT'
 
   spec.files = `git ls-files`.split($/)
   spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_dependency "simple_params", ">= 1.6.9", "< 2.0"
-  spec.add_development_dependency "bundler", "~> 1.5"
-  spec.add_development_dependency "rake", "~> 10.1"
-  spec.add_development_dependency "rspec", "~> 2.6"
-  spec.add_development_dependency "pry"
+  spec.add_dependency 'simple_params'
+  spec.add_development_dependency 'appraisal'
+  spec.add_development_dependency 'bundler', '>= 1.5'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec', '>= 2.6'
+  spec.add_development_dependency 'pry'
 end

data/spec/acceptance_spec.rb

@@ -1,303 +1,612 @@
 require 'spec_helper'
 
 describe "SimpleAction acceptance spec" do
-  class SimpleActionAcceptance < SimpleAction::Service
-    params do
-      param :name, type: :string
-      param :date_of_birth, type: :date, optional: true
-      validate :name_has_vowels, if: :name
+  context "with non-namespaced class" do
+    class SimpleActionAcceptance < SimpleAction::Service
+      params do
+        param :name, type: :string
+        param :date_of_birth, type: :date, optional: true
+        validate :name_has_vowels, if: :name
+
+        nested_hash :address, optional: true do
+          param :street, optional: true
+        end
 
-      nested_hash :address, optional: true do
-        param :street, optional: true
-      end
+        nested_array :phones, with_ids: true do
+          param :phone_number
+        end
 
-      nested_array :phones, with_ids: true do
-        param :phone_number
+        def name_has_vowels
+          unless name.scan(/[aeiou]/).count >= 1
+            errors.add(:name, "must contain at least one vowel")
+          end
+        end
       end
 
-      def name_has_vowels
-        unless name.scan(/[aeiou]/).count >= 1
-          errors.add(:name, "must contain at least one vowel")
+      def execute
+        name.gsub!(/[^a-zA-Z ]/,'')
+        errors.add(:name, "can't be outlier") if name == "outlier"
+
+        formatted_name = if date_of_birth.present?
+          name.upcase + ' ' + date_of_birth.strftime("%m/%d/%Y")
+        else
+          name.upcase
         end
+
+        formatted_name + " with #{phones.count} phones."
       end
     end
 
-    def execute
-      name.gsub!(/[^a-zA-Z ]/,'')
-      errors.add(:name, "can't be outlier") if name == "outlier"
-
-      formatted_name = if date_of_birth.present?
-        name.upcase + ' ' + date_of_birth.strftime("%m/%d/%Y")
-      else
-        name.upcase
+    describe "#model_name", model_name: true do
+      it "equals class name" do
+        SimpleActionAcceptance.model_name.should eq("SimpleActionAcceptance")
       end
-
-      formatted_name + " with #{phones.count} phones."
     end
-  end
 
-  describe "#model_name", model_name: true do
-    it "equals class name" do
-      SimpleActionAcceptance.model_name.should eq("SimpleActionAcceptance")
-    end
-  end
-
-  describe "#validators_on", validators_on: true do
-    it "equals class name" do
-      SimpleActionAcceptance.validators_on.should eq([])
+    describe "#validators_on", validators_on: true do
+      it "equals class name" do
+        SimpleActionAcceptance.validators_on.should eq([])
+      end
     end
-  end
 
-  describe "params #model_name", params_model_name: true do
-    it "equals class name::Params" do
-      SimpleActionAcceptance.new.params.model_name.should eq("SimpleActionAcceptance::SimpleActionAcceptanceParams")
+    describe "params #model_name", params_model_name: true do
+      it "equals class name::Params" do
+        SimpleActionAcceptance.new.params.model_name.should eq("SimpleActionAcceptance::SimpleActionAcceptanceParams")
+      end
     end
-  end
 
-  describe "params accessors", params: true do
-    let(:instance) { SimpleActionAcceptance.new }
+    describe "params accessors", params: true do
+      let(:instance) { SimpleActionAcceptance.new }
 
-    it "allows setters and getters on param vars" do
-      instance.name = "Bob"
-      expect(instance.name).to eq("Bob")
-    end
+      it "allows setters and getters on param vars" do
+        instance.name = "Bob"
+        expect(instance.name).to eq("Bob")
+      end
 
-    it "allows setters and getters on nested_hash" do
-      instance.address = { street: "1 Main St." }
-      expect(instance.address.street).to eq("1 Main St.")
-    end
+      it "allows setters and getters on nested_hash" do
+        instance.address = { street: "1 Main St." }
+        expect(instance.address.street).to eq("1 Main St.")
+      end
 
-    it "allows setters and getters on nested_hash using _attributes" do
-      instance.address_attributes = { street: "1 Main St." }
-      expect(instance.address.street).to eq("1 Main St.")
-    end
+      it "allows setters and getters on nested_hash using _attributes" do
+        instance.address_attributes = { street: "1 Main St." }
+        expect(instance.address.street).to eq("1 Main St.")
+      end
 
-    it "responds to build_ methods" do
-      address = instance.build_address
-      address.class.name.should eq("SimpleActionAcceptance::SimpleActionAcceptanceParams::Address")
+      it "responds to build_ methods" do
+        address = instance.build_address
+        address.class.name.should eq("SimpleActionAcceptance::SimpleActionAcceptanceParams::Address")
+      end
     end
-  end
 
-  describe "class methods", class_methods: true do
-    describe "reflect_on_association", reflect_on_association: true do
-      it "returns Address class for :address" do
-        address_klass = SimpleActionAcceptance.reflect_on_association(:address)
-        address_klass.klass.should eq(SimpleActionAcceptance::SimpleActionAcceptanceParams::Address)
+    describe "class methods", class_methods: true do
+      describe "reflect_on_association", reflect_on_association: true do
+        it "returns Address class for :address" do
+          address_klass = SimpleActionAcceptance.reflect_on_association(:address)
+          address_klass.klass.should eq(SimpleActionAcceptance::SimpleActionAcceptanceParams::Address)
+        end
       end
     end
-  end
 
-  describe "acceptance cases" do
-    context "with nil params" do
-      let(:params) do
-        {
-          name: nil
-        }
-      end
+    describe "acceptance cases" do
+      context "with nil params" do
+        let(:params) do
+          {
+            name: nil
+          }
+        end
 
-      describe "outcome" do
-        subject { SimpleActionAcceptance.run(params) }
+        describe "outcome" do
+          subject { SimpleActionAcceptance.run(params) }
 
-        it { should_not be_valid }
-        it { should_not be_success }
+          it { should_not be_valid }
+          it { should_not be_success }
 
-        it "should have name error" do
-          subject.errors[:name].should eq(["can't be blank"])
+          it "should have name error" do
+            subject.errors[:name].should eq(["can't be blank"])
+          end
         end
-      end
 
-      describe "result" do
-        subject { SimpleActionAcceptance.run(params).result }
+        describe "result" do
+          subject { SimpleActionAcceptance.run(params).result }
+
+          it { should be_nil }
+        end
 
-        it { should be_nil }
+        describe "effects" do
+        end
       end
 
-      describe "effects" do
+      context "with invalid params" do
+        let!(:name) { "sdfg" }
+
+        let(:params) do
+          {
+            name: name
+          }
+        end
+
+        describe "outcome" do
+          subject { SimpleActionAcceptance.run(params) }
+
+          it { should_not be_valid }
+          it { should_not be_success }
+
+          it "should have name error" do
+            subject.errors[:name].should eq(["must contain at least one vowel"])
+          end
+        end
+
+        describe "result" do
+          subject { SimpleActionAcceptance.run(params).result }
+
+          it { should be_nil }
+        end
+
+        describe "effects" do
+          it "does not alter name" do
+            SimpleActionAcceptance.run(params)
+            name.should eq("sdfg")
+          end
+        end
       end
-    end
 
-    context "with invalid params" do
-      let!(:name) { "sdfg" }
+      context "with valid params" do
+        let!(:name) { "billy12" }
+
+        let(:params) do
+          {
+            name: name,
+            phones: [
+              "0" => {
+                phone_number: "8005551212"
+              }
+            ]
+          }
+        end
+
+        describe "outcome" do
+          subject { SimpleActionAcceptance.run(params) }
+
+          it { should be_valid }
+          it { should be_success }
+        end
+
+        describe "result" do
+          subject { SimpleActionAcceptance.run(params).result }
+
+          it { should eq("BILLY with 1 phones.") }
+        end
 
-      let(:params) do
-        {
-          name: name
-        }
+        describe "effects" do
+          it "strips numbers from name" do
+            SimpleActionAcceptance.run(params)
+            name.should eq("billy")
+          end
+        end
       end
 
-      describe "outcome" do
-        subject { SimpleActionAcceptance.run(params) }
+      context "with date coercion params" do
+        let!(:name) { "billy12" }
+
+        let(:params) do
+          {
+            name: name,
+            "date_of_birth(3i)" => "5",
+            "date_of_birth(2i)" => "6",
+            "date_of_birth(1i)" => "1984",
+            phones: [
+              "0" => {
+                phone_number: "8005551212"
+              }
+            ]
+          }
+        end
+
+        describe "outcome" do
+          subject { SimpleActionAcceptance.run(params) }
+
+          it { should be_valid }
+          it { should be_success }
+        end
+
+        describe "result" do
+          subject { SimpleActionAcceptance.run(params).result }
 
-        it { should_not be_valid }
-        it { should_not be_success }
+          it { should eq("BILLY 06/05/1984 with 1 phones.") }
+        end
 
-        it "should have name error" do
-          subject.errors[:name].should eq(["must contain at least one vowel"])
+        describe "effects" do
+          it "strips numbers from name" do
+            SimpleActionAcceptance.run(params)
+            name.should eq("billy")
+          end
         end
       end
 
-      describe "result" do
-        subject { SimpleActionAcceptance.run(params).result }
+      context "with destroyed phones" do
+        let!(:name) { "billy12" }
+
+        let(:params) do
+          {
+            name: name,
+            date_of_birth: Date.new(1984, 6, 5),
+            phones: {
+              "0" => {
+                phone_number: "8005551210",
+                _destroy: "1"
+              },
+              "1" => {
+                phone_number: "8005551212"
+              }
+            }
+          }
+        end
+
+        describe "outcome" do
+          subject { SimpleActionAcceptance.run(params) }
+
+          it { should be_valid }
+          it { should be_success }
+        end
+
+        describe "result" do
+          subject { SimpleActionAcceptance.run(params).result }
+
+          it { should eq("BILLY 06/05/1984 with 1 phones.") }
+        end
 
-        it { should be_nil }
+        describe "effects" do
+          it "strips numbers from name" do
+            SimpleActionAcceptance.run(params)
+            name.should eq("billy")
+          end
+        end
       end
 
-      describe "effects" do
-        it "does not alter name" do
-          SimpleActionAcceptance.run(params)
-          name.should eq("sdfg")
+      context "with outlier case" do
+        let!(:name) { "outlier12" }
+
+        let(:params) do
+          {
+            name: name,
+            phones: [
+              "0" => {
+                phone_number: "8005551212"
+              }
+            ]
+          }
+        end
+
+        describe "outcome" do
+          subject { SimpleActionAcceptance.run(params) }
+
+          it { should_not be_valid }
+          it { should_not be_success }
+
+          it "should have name error" do
+            subject.errors[:name].should eq(["can't be outlier"])
+          end
+        end
+
+        describe "result" do
+          subject { SimpleActionAcceptance.run(params).result }
+
+          it { should be_nil }
+        end
+
+        describe "effects" do
+          it "alter names" do
+            SimpleActionAcceptance.run(params)
+            name.should eq("outlier")
+          end
         end
       end
     end
+  end
 
-    context "with valid params" do
-      let!(:name) { "billy12" }
+  context "with namespaced class" do
+    module MyModule
+    end
 
-      let(:params) do
-        {
-          name: name,
-          phones: [
-            "0" => {
-              phone_number: "8005551212"
-            }
-          ]
-        }
-      end
+    class MyModule::SimpleActionAcceptance < ::SimpleAction::Service
+      params do
+        param :name, type: :string
+        param :date_of_birth, type: :date, optional: true
+        validate :name_has_vowels, if: :name
 
-      describe "outcome" do
-        subject { SimpleActionAcceptance.run(params) }
+        nested_hash :address, optional: true do
+          param :street, optional: true
+        end
+
+        nested_array :phones, with_ids: true do
+          param :phone_number
+        end
 
-        it { should be_valid }
-        it { should be_success }
+        def name_has_vowels
+          unless name.scan(/[aeiou]/).count >= 1
+            errors.add(:name, "must contain at least one vowel")
+          end
+        end
       end
 
-      describe "result" do
-        subject { SimpleActionAcceptance.run(params).result }
+      def execute
+        name.gsub!(/[^a-zA-Z ]/,'')
+        errors.add(:name, "can't be outlier") if name == "outlier"
+
+        formatted_name = if date_of_birth.present?
+          name.upcase + ' ' + date_of_birth.strftime("%m/%d/%Y")
+        else
+          name.upcase
+        end
 
-        it { should eq("BILLY with 1 phones.") }
+        formatted_name + " with #{phones.count} phones."
       end
+    end
 
-      describe "effects" do
-        it "strips numbers from name" do
-          SimpleActionAcceptance.run(params)
-          name.should eq("billy")
-        end
+    describe "#model_name", model_name: true do
+      it "equals class name" do
+        MyModule::SimpleActionAcceptance.model_name.should eq("MyModule::SimpleActionAcceptance")
       end
     end
 
-    context "with date coercion params" do
-      let!(:name) { "billy12" }
-
-      let(:params) do
-        {
-          name: name,
-          "date_of_birth(3i)" => "5",
-          "date_of_birth(2i)" => "6",
-          "date_of_birth(1i)" => "1984",
-          phones: [
-            "0" => {
-              phone_number: "8005551212"
-            }
-          ]
-        }
+    describe "#validators_on", validators_on: true do
+      it "equals class name" do
+        MyModule::SimpleActionAcceptance.validators_on.should eq([])
+      end
+    end
+
+    describe "params #model_name", params_model_name: true do
+      it "equals class name::Params" do
+        MyModule::SimpleActionAcceptance.new.params.model_name.should eq("MyModule::SimpleActionAcceptance::SimpleActionAcceptanceParams")
       end
+    end
 
-      describe "outcome" do
-        subject { SimpleActionAcceptance.run(params) }
+    describe "params accessors", params: true do
+      let(:instance) { MyModule::SimpleActionAcceptance.new }
+
+      it "allows setters and getters on param vars" do
+        instance.name = "Bob"
+        expect(instance.name).to eq("Bob")
+      end
 
-        it { should be_valid }
-        it { should be_success }
+      it "allows setters and getters on nested_hash" do
+        instance.address = { street: "1 Main St." }
+        expect(instance.address.street).to eq("1 Main St.")
       end
 
-      describe "result" do
-        subject { SimpleActionAcceptance.run(params).result }
+      it "allows setters and getters on nested_hash using _attributes" do
+        instance.address_attributes = { street: "1 Main St." }
+        expect(instance.address.street).to eq("1 Main St.")
+      end
 
-        it { should eq("BILLY 06/05/1984 with 1 phones.") }
+      it "responds to build_ methods" do
+        address = instance.build_address
+        address.class.name.should eq("MyModule::SimpleActionAcceptance::SimpleActionAcceptanceParams::Address")
       end
+    end
 
-      describe "effects" do
-        it "strips numbers from name" do
-          SimpleActionAcceptance.run(params)
-          name.should eq("billy")
+    describe "class methods", class_methods: true do
+      describe "reflect_on_association", reflect_on_association: true do
+        it "returns Address class for :address" do
+          address_klass = MyModule::SimpleActionAcceptance.reflect_on_association(:address)
+          address_klass.klass.should eq(MyModule::SimpleActionAcceptance::SimpleActionAcceptanceParams::Address)
         end
       end
     end
 
-    context "with destroyed phones" do
-      let!(:name) { "billy12" }
-
-      let(:params) do
-        {
-          name: name,
-          date_of_birth: Date.new(1984, 6, 5),
-          phones: {
-            "0" => {
-              phone_number: "8005551210",
-              _destroy: "1"
-            },
-            "1" => {
-              phone_number: "8005551212"
-            }
+    describe "acceptance cases" do
+      context "with nil params" do
+        let(:params) do
+          {
+            name: nil
           }
-        }
-      end
+        end
 
-      describe "outcome" do
-        subject { SimpleActionAcceptance.run(params) }
+        describe "outcome" do
+          subject { MyModule::SimpleActionAcceptance.run(params) }
 
-        it { should be_valid }
-        it { should be_success }
-      end
+          it { should_not be_valid }
+          it { should_not be_success }
+
+          it "should have name error" do
+            subject.errors[:name].should eq(["can't be blank"])
+          end
+        end
 
-      describe "result" do
-        subject { SimpleActionAcceptance.run(params).result }
+        describe "result" do
+          subject { MyModule::SimpleActionAcceptance.run(params).result }
+
+          it { should be_nil }
+        end
 
-        it { should eq("BILLY 06/05/1984 with 1 phones.") }
+        describe "effects" do
+        end
       end
 
-      describe "effects" do
-        it "strips numbers from name" do
-          SimpleActionAcceptance.run(params)
-          name.should eq("billy")
+      context "with invalid params" do
+        let!(:name) { "sdfg" }
+
+        let(:params) do
+          {
+            name: name
+          }
+        end
+
+        describe "outcome" do
+          subject { MyModule::SimpleActionAcceptance.run(params) }
+
+          it { should_not be_valid }
+          it { should_not be_success }
+
+          it "should have name error" do
+            subject.errors[:name].should eq(["must contain at least one vowel"])
+          end
+        end
+
+        describe "result" do
+          subject { MyModule::SimpleActionAcceptance.run(params).result }
+
+          it { should be_nil }
+        end
+
+        describe "effects" do
+          it "does not alter name" do
+            MyModule::SimpleActionAcceptance.run(params)
+            name.should eq("sdfg")
+          end
         end
       end
-    end
 
-    context "with outlier case" do
-      let!(:name) { "outlier12" }
+      context "with valid params" do
+        let!(:name) { "billy12" }
+
+        let(:params) do
+          {
+            name: name,
+            phones: [
+              "0" => {
+                phone_number: "8005551212"
+              }
+            ]
+          }
+        end
+
+        describe "outcome" do
+          subject { MyModule::SimpleActionAcceptance.run(params) }
 
-      let(:params) do
-        {
-          name: name,
-          phones: [
-            "0" => {
-              phone_number: "8005551212"
-            }
-          ]
-        }
+          it { should be_valid }
+          it { should be_success }
+        end
+
+        describe "result" do
+          subject { MyModule::SimpleActionAcceptance.run(params).result }
+
+          it { should eq("BILLY with 1 phones.") }
+        end
+
+        describe "effects" do
+          it "strips numbers from name" do
+            MyModule::SimpleActionAcceptance.run(params)
+            name.should eq("billy")
+          end
+        end
       end
 
-      describe "outcome" do
-        subject { SimpleActionAcceptance.run(params) }
+      context "with date coercion params" do
+        let!(:name) { "billy12" }
+
+        let(:params) do
+          {
+            name: name,
+            "date_of_birth(3i)" => "5",
+            "date_of_birth(2i)" => "6",
+            "date_of_birth(1i)" => "1984",
+            phones: [
+              "0" => {
+                phone_number: "8005551212"
+              }
+            ]
+          }
+        end
+
+        describe "outcome" do
+          subject { MyModule::SimpleActionAcceptance.run(params) }
+
+          it { should be_valid }
+          it { should be_success }
+        end
 
-        it { should_not be_valid }
-        it { should_not be_success }
+        describe "result" do
+          subject { MyModule::SimpleActionAcceptance.run(params).result }
+
+          it { should eq("BILLY 06/05/1984 with 1 phones.") }
+        end
 
-        it "should have name error" do
-          subject.errors[:name].should eq(["can't be outlier"])
+        describe "effects" do
+          it "strips numbers from name" do
+            MyModule::SimpleActionAcceptance.run(params)
+            name.should eq("billy")
+          end
         end
       end
 
-      describe "result" do
-        subject { SimpleActionAcceptance.run(params).result }
+      context "with destroyed phones" do
+        let!(:name) { "billy12" }
+
+        let(:params) do
+          {
+            name: name,
+            date_of_birth: Date.new(1984, 6, 5),
+            phones: {
+              "0" => {
+                phone_number: "8005551210",
+                _destroy: "1"
+              },
+              "1" => {
+                phone_number: "8005551212"
+              }
+            }
+          }
+        end
+
+        describe "outcome" do
+          subject { MyModule::SimpleActionAcceptance.run(params) }
+
+          it { should be_valid }
+          it { should be_success }
+        end
+
+        describe "result" do
+          subject { MyModule::SimpleActionAcceptance.run(params).result }
 
-        it { should be_nil }
+          it { should eq("BILLY 06/05/1984 with 1 phones.") }
+        end
+
+        describe "effects" do
+          it "strips numbers from name" do
+            MyModule::SimpleActionAcceptance.run(params)
+            name.should eq("billy")
+          end
+        end
       end
 
-      describe "effects" do
-        it "alter names" do
-          SimpleActionAcceptance.run(params)
-          name.should eq("outlier")
+      context "with outlier case" do
+        let!(:name) { "outlier12" }
+
+        let(:params) do
+          {
+            name: name,
+            phones: [
+              "0" => {
+                phone_number: "8005551212"
+              }
+            ]
+          }
+        end
+
+        describe "outcome" do
+          subject { MyModule::SimpleActionAcceptance.run(params) }
+
+          it { should_not be_valid }
+          it { should_not be_success }
+
+          it "should have name error" do
+            subject.errors[:name].should eq(["can't be outlier"])
+          end
+        end
+
+        describe "result" do
+          subject { MyModule::SimpleActionAcceptance.run(params).result }
+
+          it { should be_nil }
+        end
+
+        describe "effects" do
+          it "alter names" do
+            MyModule::SimpleActionAcceptance.run(params)
+            name.should eq("outlier")
+          end
         end
       end
     end