simple_action 1.0.6 → 1.1.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ODA5YjFiOWVlMDg1NDQ1MzlkNGE5ODIwNTFmNjI2Yzc1NGU4NWQwMg==
+    ZGY1MmExZDFjZDI5M2JjMzUzM2YxMmVkOTdiYjJhMzIzZTFmNDg5MQ==
   data.tar.gz: !binary |-
-    ZTIxNTNhZWI1N2ZjMDQxZDhjNWQ3NTM3NmU3ZDRlZGY1YmI0ZTJkYg==
+    NzdiNzY0ZTdmOTlmNjFiN2RiMWY0MTljNDkxNTk3MTc5NTYyYTk3Zg==
 SHA512:
   metadata.gz: !binary |-
-    YjIyMzU4MzBlNTgxYWU2MGQ2YWYxODZkYTdkZTZmMDAyZTBiYjI0OTMwMDEx
-    ODUzZGVjY2E2MmNiMGRmMTE4MTJlNjgwMDk4MTg4N2I3N2MwZmJmZjNmYmU3
-    YTY4ODA4M2M4NTgzMjljZmI5YzZmNzhmMTQzNzE0NWM5NDdhNWU=
+    ZWNjMzhiZWY1NzgzOTYxMjY0NGM5NzkxMzU5MDBkY2E2MjRkOGMxY2E3Njlm
+    ODA4MmRhZTk1ZjA4MmE2OWY1MWE1ZjBiMWQ5NTAxNGJkNjIwZWQwOWIxYTNm
+    OTEyYTQ4YzY3NTU4MTI1YjY0NzRmZDExYTA4YThiNDk1M2NlMTU=
   data.tar.gz: !binary |-
-    OTZlNGRlMjY3MGQ0ZDYxODRiN2FjYjliMTFjZjM0ZTJkYTViNmY1MTdmYTc1
-    M2ZlYzFmZTIwMjYwZTVhZDBmNjMzMjhjMTdjYmQ3MDZiNjA3ZGQxOTY5MmVj
-    MTc3ZWI3N2IyMTY0MGI4MzUwYTUyN2JhYzY2ZDYyYTVmNjRkZTE=
+    NWIxODhhYjBiNzA5ZTUxNmQ4YjU5YmI0NzEzOGM2ZDg1MDRmNDJhY2MzODEx
+    ODMwMWQwY2IzODlmMGFjNzcwMDMxZTI4ZjUwMTU4NGMwOTdkNGRiNzE1Y2Ni
+    MjU3ZmZjZGVjNmZhMzNhOGNkN2M3ZDlmMWI2NjFkYjVlNWE5MDQ=

data/Gemfile.lock

@@ -1,16 +1,16 @@
 PATH
   remote: .
   specs:
-    simple_action (1.0.5)
-      simple_params (>= 1.0.2, < 2.0)
+    simple_action (1.0.6)
+      simple_params (>= 1.1, < 2.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (4.2.2)
-      activesupport (= 4.2.2)
+    activemodel (4.2.4)
+      activesupport (= 4.2.4)
       builder (~> 3.1)
-    activesupport (4.2.2)
+    activesupport (4.2.4)
       i18n (~> 0.7)
       json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
@@ -32,7 +32,7 @@ GEM
     ice_nine (0.11.1)
     json (1.8.3)
     method_source (0.8.2)
-    minitest (5.7.0)
+    minitest (5.8.0)
     pry (0.10.1)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
@@ -48,7 +48,7 @@ GEM
     rspec-mocks (2.99.3)
     shoulda-matchers (2.8.0)
       activesupport (>= 3.0.0)
-    simple_params (1.0.2)
+    simple_params (1.1.0)
       activemodel (>= 3.0, < 5.0)
       shoulda-matchers (~> 2.8)
       virtus (>= 1.0.0)

data/README.md

@@ -86,6 +86,27 @@ class UserController < ApplicationController
 Because the service class behaves like an ActiveModel object with regards to it's attribute assignment and parameter validation, it will continue to work with Rails forms.
 
 
+# Strict/Flexible Parameter Enforcement
+
+By default, SimpleAction via SimpleParams will throw an error if you try to assign a parameter not defined within your class.  However, you can override this setting to allow for flexible parameter assignment.
+
+```ruby
+class FlexibleParams < SimpleAction::Service
+  params do
+    allow_undefined_params
+    param :name
+    param :age, type: :integer, default: 23
+  end
+
+params = FlexibleParams.new(name: "Bryce", age: 30, weight: 160, dog: { name: "Bailey", breed: "Shiba Inu" })
+
+params.name #=> "Bryce"
+params.age #=> 30
+params.weight #=> 160
+params.dog.name #=> "Bailey"
+params.dog.breed #=> "Shiba Inu"
+```
+
 # ApiPie Documentation
 
 If your project is using [apipie-rails](http://example.com/ "apipie-rails"),

data/lib/simple_action/version.rb

@@ -1,3 +1,3 @@
 module SimpleAction
-  VERSION = "1.0.6"
+  VERSION = "1.1.0"
 end

data/simple_action.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "simple_params", ">= 1.0.2", "< 2.0"
+  spec.add_dependency "simple_params", ">= 1.1", "< 2.0"
   spec.add_development_dependency "bundler", "~> 1.5"
   spec.add_development_dependency "rake", "~> 10.1"
   spec.add_development_dependency "rspec", "~> 2.6"

data/spec/acceptance_spec.rb

@@ -4,6 +4,7 @@ describe "SimpleAction acceptance spec" do
   class SimpleActionAcceptance < SimpleAction::Service
     params do
       param :name, type: :string
+      param :date_of_birth, type: :date, optional: true
       validate :name_has_vowels, if: :name
 
       def name_has_vowels
@@ -17,6 +18,8 @@ describe "SimpleAction acceptance spec" do
       name.gsub!(/[^a-zA-Z ]/,'')
       if name == "outlier"
         errors.add(:name, "can't be outlier")
+      elsif date_of_birth.present?
+        name.upcase + ' ' + date_of_birth.strftime("%m/%d/%Y")
       else
         name.upcase
       end
@@ -128,6 +131,39 @@ describe "SimpleAction acceptance spec" do
       end
     end
 
+    context "with date coercion params" do
+      let!(:name) { "billy12" }
+
+      let(:params) do
+        {
+          name: name,
+          "date_of_birth(3i)" => "5",
+          "date_of_birth(2i)" => "6",
+          "date_of_birth(1i)" => "1984"
+        }
+      end
+
+      describe "outcome" do
+        subject { SimpleActionAcceptance.run(params) }
+
+        it { should be_valid }
+        it { should be_success }
+      end
+
+      describe "result" do
+        subject { SimpleActionAcceptance.run(params).result }
+
+        it { should eq("BILLY 06/05/1984") }
+      end
+
+      describe "effects" do
+        it "strips numbers from name" do
+          SimpleActionAcceptance.run(params)
+          name.should eq("billy")
+        end
+      end
+    end
+
     context "with outlier case" do
       let!(:name) { "outlier12" }
 

data/spec/fixtures/flexible_params_spec_class.rb

@@ -0,0 +1,11 @@
+class FlexibleParamsSpecClass < SimpleAction::Service
+  params do
+    allow_undefined_params
+    param :name
+    param :age, type: :integer, default: 23
+  end
+
+  def execute
+    (age * 3) + name.length
+  end
+end

data/spec/fixtures/unflexible_params_spec_class.rb

@@ -0,0 +1,10 @@
+class UnflexibleParamsSpecClass < SimpleAction::Service
+  params do
+    param :name
+    param :age, type: :integer, default: 23
+  end
+
+  def execute
+    (age * 3) + name.length
+  end
+end

data/spec/flexible_params_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+require 'fixtures/flexible_params_spec_class'
+
+describe SimpleAction::Service do 
+  describe "#run", run: true do
+    context "with undefined params" do
+      let(:outcome) { FlexibleParamsSpecClass.run(name: "Matthew", age: 12, weight: 150, height: "tall") }
+
+      it "returns errors" do
+        outcome.errors[:weight].should_not eq(["can't be blank"])
+      end
+    end
+  end
+end

data/spec/unflexible_params_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+require 'fixtures/unflexible_params_spec_class'
+
+describe SimpleAction::Service do 
+  describe "#run!", run!: true do
+    context "with undefined params" do
+      it "raises error" do
+        expect { UnflexibleParamsSpecClass.run!(name: "Matthew", age: 36, weight: 220) }.to raise_error(SimpleParamsError,
+          "parameter weight= is not defined."
+        )
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simple_action
 version: !ruby/object:Gem::Version
-  version: 1.0.6
+  version: 1.1.0
 platform: ruby
 authors:
 - brycesenz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-23 00:00:00.000000000 Z
+date: 2015-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simple_params
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.0.2
+        version: '1.1'
     - - <
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.0.2
+        version: '1.1'
     - - <
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -112,11 +112,15 @@ files:
 - simple_action.gemspec
 - spec/acceptance_spec.rb
 - spec/fixtures/dummy_service_object_class.rb
+- spec/fixtures/flexible_params_spec_class.rb
 - spec/fixtures/params_spec_class.rb
 - spec/fixtures/service_spec_class.rb
+- spec/fixtures/unflexible_params_spec_class.rb
+- spec/flexible_params_spec.rb
 - spec/params_spec.rb
 - spec/service_spec.rb
 - spec/spec_helper.rb
+- spec/unflexible_params_spec.rb
 homepage: https://github.com/brycesenz/simple_action
 licenses:
 - MIT
@@ -144,8 +148,12 @@ summary: A DSL for specifying services objects, including parameters and executi
 test_files:
 - spec/acceptance_spec.rb
 - spec/fixtures/dummy_service_object_class.rb
+- spec/fixtures/flexible_params_spec_class.rb
 - spec/fixtures/params_spec_class.rb
 - spec/fixtures/service_spec_class.rb
+- spec/fixtures/unflexible_params_spec_class.rb
+- spec/flexible_params_spec.rb
 - spec/params_spec.rb
 - spec/service_spec.rb
 - spec/spec_helper.rb
+- spec/unflexible_params_spec.rb