simple_action 1.0.2 → 1.0.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MWQxOTQ2YzM0ODJmYmI4NWMzZTUxYjIxZDg3M2Q1ZTNmNmUxMTgxMA==
+    OTk3Nzg3MTBhMmRmMmIwZjJkNWIxZDBjODA5ZjdjZWE1YWU2ZGIwYw==
   data.tar.gz: !binary |-
-    MjYwMTI3ZDc3MWM3ZmUzNjMyZmU5MmMzYTUzYWIyZjI5Zjg1MjY4NA==
+    YTJlNzYyMDI1ZGJiM2ExODE0MzRlNmEyMTY0MGIzMWU4YjI1NGViNg==
 SHA512:
   metadata.gz: !binary |-
-    ZDkwZjUxMGYwYjJmMTM4YjgzNTg5ZDQ3ZmZmNjU3NDVlZTUwOGU1YzRhOTVh
-    YmUxMjVhY2RkMjFmMzBmMWZhNDk0NDljMjQ3ODdmNjljOWY0Yzk4NWZkMTAy
-    ZjdlOGMzY2U4OTk4ODNiMjA5ZjEyNTBlNjVjNmE5MDg5MjU5MTA=
+    M2UxODIxMzk4NTFiMDc3NThjYWFlMTQ5YTUyOGRhZmVmOTI5Mzk2MzdjNzU0
+    MGE3OThhNzY2NTc4ZmFkNjJkYTZkNjUwNWE3YWJhMGU5MTc1N2Q5MGMwNTA0
+    YTk5Njg3ZWIwMmY1MDc0OWE2NDZmMjMyY2QwNzliMTJkYzdiMjI=
   data.tar.gz: !binary |-
-    M2QyYjVmODA1ZmE5OTM3YTBmY2E3ODU3NDE1MjBkZDk3Mjg5MTMwYzViMTBm
-    OTgzNDdmNjE0NjFkYmVhNmFkNWZkNDI1Mzg1ZDRmMGRmZThkNjY5ZGQ0YjA3
-    YzYxMjkyNmI4N2FlZjE2YjdkOWZiZGMxODdiNmJiYmVkZTM1Nzk=
+    NWM0ZWQyMTUyOTc4Mjk3MzdkODU2MmNiYWQ2MmQ4Mzg1MTU0NzA5ZDJjOGZh
+    NDdlN2ZjNGFmNjZkZGQ3NTNlMWJkZjI0M2QzYzhjMDIzOGJhMjQ3NWI0ODMw
+    OTQ3MWE1MDM2ODFmOWU4NTE5MDI0MGY5NzA2N2Y5YjM3ODNlZTk=

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    simple_action (0.0.1.pre5)
-      simple_params (>= 0.0.3, < 1.0)
+    simple_action (1.0.2)
+      simple_params (>= 1.0.1, < 2.0)
 
 GEM
   remote: https://rubygems.org/
@@ -30,7 +30,7 @@ GEM
     equalizer (0.0.11)
     i18n (0.7.0)
     ice_nine (0.11.1)
-    json (1.8.2)
+    json (1.8.3)
     method_source (0.8.2)
     minitest (5.7.0)
     pry (0.10.1)
@@ -48,7 +48,7 @@ GEM
     rspec-mocks (2.99.3)
     shoulda-matchers (2.8.0)
       activesupport (>= 3.0.0)
-    simple_params (0.0.5)
+    simple_params (1.0.1)
       activemodel (>= 3.0, < 5.0)
       shoulda-matchers (~> 2.8)
       virtus (>= 1.0.0)

data/lib/simple_action/service.rb

@@ -12,7 +12,10 @@ module SimpleAction
       def run(params = {})
         instance = self.new(params)
         result = transaction do
-          instance.execute if instance.valid?
+          if instance.valid?
+            outcome = instance.execute
+            instance.errors.empty? ? outcome : nil
+          end
         end
         Response.new(instance, result)
       end
@@ -30,7 +33,7 @@ module SimpleAction
     def initialize(params={})
       @raw_params = params
       @params = self.class.params_class.new(params)
-      @validity = nil
+      @initial_params_valid = nil
     end
 
     def params
@@ -38,13 +41,7 @@ module SimpleAction
     end
 
     def valid?
-      # Adding this so that I don't assert validity each time.
-      # TODO: I Still need a proper test for this.
-      if @validity.nil?
-        @validity = @params.valid?
-      else
-        @validity
-      end
+      initial_params_valid? && errors.empty?
     end
 
     def errors
@@ -54,5 +51,14 @@ module SimpleAction
     def execute
       raise ImplementationError, "subclasses must implement 'execute' method."
     end
+
+    private
+    def initial_params_valid?
+      if @initial_params_valid.nil?
+        @initial_params_valid = @params.valid?
+      else
+        @initial_params_valid
+      end
+    end
   end
 end

data/lib/simple_action/version.rb

@@ -1,3 +1,3 @@
 module SimpleAction
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

data/spec/acceptance_spec.rb

@@ -14,7 +14,12 @@ describe "SimpleAction acceptance spec" do
     end
 
     def execute
-      name.upcase
+      name.gsub!(/[^a-zA-Z ]/,'')
+      if name == "outlier"
+        errors.add(:name, "can't be outlier")
+      else
+        name.upcase
+      end
     end
   end
 
@@ -41,12 +46,17 @@ describe "SimpleAction acceptance spec" do
 
       it { should be_nil }
     end
+
+    describe "effects" do
+    end
   end
 
   context "with invalid params" do
+    let!(:name) { "sdfg" }
+
     let(:params) do
       {
-        name: "sdfg"
+        name: name
       }
     end
 
@@ -66,12 +76,21 @@ describe "SimpleAction acceptance spec" do
 
       it { should be_nil }
     end
+
+    describe "effects" do
+      it "does not alter name" do
+        SimpleActionAcceptance.run(params)
+        name.should eq("sdfg")
+      end
+    end
   end
 
   context "with valid params" do
+    let!(:name) { "billy12" }
+
     let(:params) do
       {
-        name: "billy"
+        name: name
       }
     end
 
@@ -87,5 +106,46 @@ describe "SimpleAction acceptance spec" do
 
       it { should eq("BILLY") }
     end
+
+    describe "effects" do
+      it "strips numbers from name" do
+        SimpleActionAcceptance.run(params)
+        name.should eq("billy")
+      end
+    end
+  end
+
+  context "with outlier case" do
+    let!(:name) { "outlier12" }
+
+    let(:params) do
+      {
+        name: name
+      }
+    end
+
+    describe "outcome" do
+      subject { SimpleActionAcceptance.run(params) }
+
+      it { should_not be_valid }
+      it { should_not be_success }
+
+      it "should have name error", failing: true do
+        subject.errors[:name].should eq(["can't be outlier"])
+      end
+    end
+
+    describe "result" do
+      subject { SimpleActionAcceptance.run(params).result }
+
+      it { should be_nil }
+    end
+
+    describe "effects" do
+      it "alter names" do
+        SimpleActionAcceptance.run(params)
+        name.should eq("outlier")
+      end
+    end
   end
 end

data/spec/params_spec.rb

@@ -166,12 +166,12 @@ describe SimpleAction::Params do
         param:reference, Object, desc:'', required: false
         param :name, String, desc: '', required: true
         param :age, Integer, desc: '', required: false
-        param :color, String, desc: '', required: true
+        param :color, String, desc: '', required: false
         param :address, Hash, desc: '', required: true do
           param :street, String, desc: '', required: true
           param :city, String, desc: '', required: true
           param :zip_code, String, desc: '', required: false
-          param :state, String, desc: '', required: true
+          param :state, String, desc: '', required: false
         end
       API_PIE_DOCS
 

data/spec/service_spec.rb

@@ -35,7 +35,7 @@ describe SimpleAction::Service do
           outcome.should be_success
         end
 
-        it "has result equal to output of execute", failing: true do
+        it "has result equal to output of execute" do
           outcome.result.should eq(41)
         end
 
@@ -65,7 +65,7 @@ describe SimpleAction::Service do
 
     describe "#api_pie_documentation", api_pie_documentation: true do
       it "equals params api_pie_documentation" do
-        ServiceSpecClass.api_pie_documentation.should eq("param :name, String, desc: '', required: true\nparam :age, Integer, desc: '', required: true")
+        ServiceSpecClass.api_pie_documentation.should eq("param :name, String, desc: '', required: true\nparam :age, Integer, desc: '', required: false")
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simple_action
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - brycesenz