simple-sql 0.5.28 → 0.5.33

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f29429815715916d62f0f03dc831d97e0e0312152f431a49c092a09f1bd48d9e
-  data.tar.gz: d02ced1cda31cdca64bbe1f43035cf628d40b80b20c1782bb16e44aee5f15ea8
+  metadata.gz: 567c2dd86ca2849c533ced2e9d3dcc14705ca71659bbe19e63fc82fe2907e15d
+  data.tar.gz: 1a799e2970974d7acbcc0587a14547674124686f1361ddc0f8049811eb0653e8
 SHA512:
-  metadata.gz: 1f5c9709450f03cd4b7f8691738f182667b5b53a90fc5e22b4ef00a6c7778bbd7f6f78f153839205e5ecea8a14be9beb84da3d9857e418fc09a7d5f0248881e2
-  data.tar.gz: 6ab77cad786ea2f2d2f2b6bea6d49e5b2e76e3bfa5ed15b9d856dd5b8852b2d1c376b841f5c5c78f1b92964dd0c90f87f89247a0879cf8581f5ccd2a647cbdba
+  metadata.gz: ef6c51b2827d93e11b68c0094052604b55f790e8bca3a5667e6113f6d413b6f0c663b3e3e0f718e46e4ae492972216ae5495f51c03e72fbf8b6b40cae511f266
+  data.tar.gz: 5a51b78d962fac7ba6fe651ed08d34fa9d3854749fb9708855b83c29ee8d1a6cabb2b97d007c658cd447324e45e30123113c9f72b2674cded7144eec289f0e0b

data/.ruby-version

@@ -0,0 +1 @@
+2.7

data/VERSION

@@ -1 +1 @@
-0.5.28
+0.5.33

data/config/database.yml

@@ -2,7 +2,8 @@ defaults: &defaults
   adapter: postgresql
   encoding: utf8
   host: '127.0.0.1'
-  # username: postgres
+  username: admin
+  password: admin
   pool: 5
   timeout: 5000
 

data/lib/simple/sql/connection/scope.rb

@@ -84,6 +84,7 @@ class Simple::SQL::Connection::Scope
     dupe.instance_variable_set :@page, @page
     dupe.instance_variable_set :@order_by_fragment, @order_by_fragment
     dupe.instance_variable_set :@limit, @limit
+    dupe.instance_variable_set :@offset, @offset
     dupe
   end
 

data/lib/simple/sql/connection/scope/order.rb

@@ -3,8 +3,16 @@ class Simple::SQL::Connection::Scope
     duplicate.send(:order_by!, sql_fragment)
   end
 
-  def limit(count)
-    duplicate.send(:limit!, count)
+  def limit(limit)
+    raise ArgumentError, "limit must be >= 0" unless limit >= 0
+
+    duplicate.send(:limit!, limit)
+  end
+
+  def offset(offset)
+    raise ArgumentError, "offset must be >= 0" unless offset >= 0
+
+    duplicate.send(:offset!, offset)
   end
 
   private
@@ -21,10 +29,16 @@ class Simple::SQL::Connection::Scope
     self
   end
 
+  def offset!(offset)
+    @offset = offset
+    self
+  end
+
   # called from to_sql
   def apply_order_and_limit(sql)
     sql = "#{sql} ORDER BY #{@order_by_fragment}" if @order_by_fragment
     sql = "#{sql} LIMIT #{@limit}" if @limit
+    sql = "#{sql} OFFSET #{@offset}" if @offset
 
     sql
   end

data/lib/simple/sql/connection/scope/pagination.rb

@@ -3,6 +3,9 @@
 class Simple::SQL::Connection::Scope
   # Set pagination
   def paginate(per:, page:)
+    raise ArgumentError, "per must be > 0" unless per > 0
+    raise ArgumentError, "page must be > 0" unless page > 0
+
     duplicate.send(:paginate!, per: per, page: page)
   end
 
@@ -23,8 +26,7 @@ class Simple::SQL::Connection::Scope
   def apply_pagination(sql, pagination:)
     return sql unless pagination == :auto && @per && @page
 
-    raise ArgumentError, "per must be > 0" unless @per > 0
-    raise ArgumentError, "page must be > 0" unless @page > 0
+    raise ArgumentError, "You cannot mix 'paginate' and 'offset'/'limit'" if @offset || @limit
 
     "#{sql} LIMIT #{@per} OFFSET #{(@page - 1) * @per}"
   end

data/lib/simple/sql/helpers/encoder.rb

@@ -8,11 +8,27 @@ module Simple::SQL::Helpers::Encoder
 
   def encode_arg(connection, arg)
     return arg unless arg.is_a?(Array)
+    return "{}" if arg.empty?
 
-    if arg.first.is_a?(String)
-      "{#{arg.map { |a| "\"#{connection.escape(a)}\"" }.join(',')}}"
+    encoded_ary = encode_array(connection, arg)
+    "{" + encoded_ary.join(",") + "}"
+  end
+
+  def encode_array(connection, ary)
+    case ary.first
+    when String
+      ary.map do |str|
+        str = connection.escape(str)
+
+        # These fixes have been discovered during tests. see spec/simple/sql/conversion_spec.rb
+        str = str.gsub("\"", "\\\"")
+        str = str.gsub("''", "'")
+        "\"#{str}\""
+      end
+    when Integer
+      ary
     else
-      "{#{arg.join(',')}}"
+      raise ArgumentError, "Don't know how to encode array of #{ary.first.class}"
     end
   end
 end

data/lib/simple/sql/helpers/immutable.rb

@@ -1,3 +1,5 @@
+require "simple-immutable"
+
 module Simple
   module SQL
     module Helpers

data/lib/simple/sql/monkey_patches.rb

@@ -7,14 +7,7 @@ module Simple::SQL::MonkeyPatches
 
     @@warned[msg] = true
 
-    msg = <<~MSG
-      == patching notice: ======================================================================================
-      Note that simple-sql changes the behaviour of underlying gems in subtle ways:
-      #{msg}
-      ==========================================================================================================
-    MSG
-
-    STDERR.puts msg
+    STDERR.puts "== monkeypatch warning: #{msg}"
   end
 end
 
@@ -34,7 +27,7 @@ when /^5.2/
   class ActiveRecord::ConnectionAdapters::ConnectionPool::Reaper
     def run
       return unless frequency && frequency > 0
-      Simple::SQL::MonkeyPatches.warn "disable Reaper for all ActiveRecord connection pools, see https://github.com/rails/rails/issues/33600"
+      Simple::SQL::MonkeyPatches.warn "simple-sql disables reapers for all connection pools, see https://github.com/rails/rails/issues/33600"
     end
   end
 
@@ -50,7 +43,7 @@ when /^6/
   class ActiveRecord::ConnectionAdapters::ConnectionPool::Reaper
     def run
       return unless frequency && frequency > 0
-      Simple::SQL::MonkeyPatches.warn "disable Reaper for all ActiveRecord connection pools, see https://github.com/rails/rails/issues/33600"
+      Simple::SQL::MonkeyPatches.warn "simple-sql disables reapers for all connection pools, see https://github.com/rails/rails/issues/33600"
     end
   end
 end

data/lib/simple/sql/version.rb

@@ -5,6 +5,7 @@ module Simple
 
       def version(name)
         spec = Gem.loaded_specs[name]
+        return "unreleased" unless spec
         version = spec.version.to_s
         version += "+unreleased" if unreleased?(spec)
         version

data/simple-sql.gemspec

@@ -33,9 +33,9 @@ Gem::Specification.new do |gem|
   # during tests we check the SIMPLE_SQL_ACTIVERECORD_SPECS environment setting.
   # Run make tests to run all tests
   if ENV["SIMPLE_SQL_ACTIVERECORD_SPECS"]
-    gem.add_dependency 'activerecord', '> 4.2', *(ENV["SIMPLE_SQL_ACTIVERECORD_SPECS"].split(","))
+    gem.add_dependency 'activerecord', '>= 5.2.4.5', *(ENV["SIMPLE_SQL_ACTIVERECORD_SPECS"].split(","))
   else
-    gem.add_dependency 'activerecord', '> 4.2', '< 7'
+    gem.add_dependency 'activerecord', '>= 5.2.4.5', '< 7'
   end
 
   # optional gems (required by some of the parts)

data/spec/simple/sql/conversion_spec.rb

@@ -23,6 +23,7 @@ describe "Simple::SQL conversions" do
       expects "foo,\"bar}", "SELECT $1::varchar", "foo,\"bar}"
       expects ["one", "two", "3.5", "foo,\"bar}"], "SELECT ARRAY['one', 'two', '3.5', 'foo,\"bar}']"
       expects ["foo", "foo,bar}"], "SELECT $1::varchar[]", ["foo", "foo,bar}"]
+      expects "foo'bar", 'SELECT $1', "foo'bar"
     end
 
     it "parses JSON as expected" do
@@ -42,13 +43,15 @@ describe "Simple::SQL conversions" do
     it "converts hstore" do
       expects({ a: "1", b: "3" }, "SELECT 'a=>1,b=>3'::hstore")
     end
-
-    xit "fails sometimes w/ malformed array literal, pt. 1" do
-      expects  0, 'SELECT $1::varchar[]', [ "foo", 'foo,"bar}' ]
-    end
-
-    xit "fails sometimes w/ malformed array literal, pt. 2" do
-      expects  0, 'SELECT $1::varchar[]', [ "foo", 'foo,"bar}' ]
+  end
+  
+  describe "arra conversions" do
+    it "works with strings" do
+      expects  [ "foo", "bar" ], 'SELECT $1::varchar[]', [ "foo", "bar" ]
+
+      # test escaping
+      expects  [ "foo", "foo'bar\"baz" ], 'SELECT $1::varchar[]', [ "foo", "foo'bar\"baz" ]
+      expects  [ ], 'SELECT $1::varchar[]', []
     end
   end
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: simple-sql
 version: !ruby/object:Gem::Version
-  version: 0.5.28
+  version: 0.5.33
 platform: ruby
 authors:
 - radiospiel
 - mediapeers GmbH
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-03-04 00:00:00.000000000 Z
+date: 2021-03-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pg_array_parser
@@ -91,9 +91,9 @@ dependencies:
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: 5.2.4.5
     - - "<"
       - !ruby/object:Gem::Version
         version: '7'
@@ -101,9 +101,9 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: 5.2.4.5
     - - "<"
       - !ruby/object:Gem::Version
         version: '7'
@@ -185,6 +185,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rubocop.yml"
+- ".ruby-version"
 - ".tm_properties"
 - Gemfile
 - Makefile
@@ -271,7 +272,7 @@ files:
 homepage: http://github.com/radiospiel/simple-sql
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -286,8 +287,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: SQL with a simple interface
 test_files: