simple-spreadsheet-extractor 0.2.2 → 0.2.3

data/README.rdoc

@@ -1,7 +1,7 @@
 = Simple Spreadsheet Extractor
 
 Authors::    Stuart Owen
-Version::    0.2.2
+Version::    0.2.3
 Contact::    mailto:stuart.owen@manchester.ac.uk
 Licence::    BSD (See LICENCE or http://www.opensource.org/licenses/bsd-license.php)
 Copyright::  (c) 2010 The University of Manchester, UK
@@ -9,7 +9,7 @@ Copyright::  (c) 2010 The University of Manchester, UK
 
 == Synopsis
 
-This is a simple gem that provides a facility to read and XLS or XLSX spreadsheet and produce an XML representation of its contents
+This is a simple gem that provides a facility to read an XLS or XLSX Excel spreadsheet document and produce an XML representation of its content.
 
 Internally it uses Apache POI, using the sister [http://github.com/myGrid/simple-spreadsheet-extractor] tool.
 
@@ -26,6 +26,7 @@ Java 1.6 (JRE) is required.
 * require 'simple-spreadsheet-extractor'
 * include the module SysMODB::SpreadsheetExtractor
 * pass an IO object to the method spreedsheet_to_xml which responds with the XML for the contents of the sheet.
+* if something goes wrong with the extraction then a SysMODB::SpreadsheetExtractionException will be thrown
   
 e.g.
 
@@ -35,4 +36,8 @@ e.g.
    include SysMODB::SpreadsheetExtractor
 
    f=open("/tmp/test-spreadsheet.xls")
-   puts spreadsheet_to_xml f
+   begin
+   	   puts spreadsheet_to_xml f
+   rescue SysMODB::SpreadsheetExtractionException=>e
+       puts "Something went wrong #{e.message}"
+   end

data/lib/simple-spreadsheet-extractor.rb

@@ -1,32 +1,40 @@
-require 'open3'
+require 'rubygems'
+require 'open4'
 
 module SysMODB
+  
+  class SpreadsheetExtractionException < Exception
+  end
+  
   module SpreadsheetExtractor
     
     JAR_PATH = File.dirname(__FILE__) + "/../jars"
     
     def spreadsheet_to_xml spreadsheet_data
       command = "java -jar #{JAR_PATH}/simple-spreadsheet-extractor-0.2.jar"
-      stdin,stdout,stderr = Open3.popen3(command)          
-      
-      while ((line = spreadsheet_data.gets) != nil) do        
-        stdin << line
+      output = ""
+      err_message = ""
+      status = Open4::popen4(command) do |pid, stdin, stdout, stderr|
+        while ((line = spreadsheet_data.gets) != nil) do        
+          stdin << line
+        end
+        stdin.close
+                     
+        while ((line = stdout.gets) != nil) do
+          output << line
+        end      
+        stdout.close
+                
+        while ((line=stderr.gets)!= nil) do
+          err_message << line
+        end
+        stderr.close
+      end
+            
+      if status.to_i != 0                 
+        raise SpreadsheetExtractionException.new(err_message)             
       end
-      stdin.close
-      
-#      if !(line=stderr.gets).nil?
-#        msg=line
-#        while ((line=stderr.gets)!= nil) do
-#          msg << line
-#        end
-#        raise Exception.new(msg)
-#      end
-      
-      output = ""      
-      while ((line = stdout.gets) != nil) do
-        output << line
-      end      
-      
+                  
       return output
     end
     

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: simple-spreadsheet-extractor
 version: !ruby/object:Gem::Version 
-  hash: 19
+  hash: 17
   prerelease: false
   segments: 
   - 0
   - 2
-  - 2
-  version: 0.2.2
+  - 3
+  version: 0.2.3
 platform: ruby
 authors: 
 - Stuart Owen
@@ -17,8 +17,23 @@ cert_chain: []
 
 date: 2010-07-23 00:00:00 +01:00
 default_executable: 
-dependencies: []
-
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: open4
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - "="
+      - !ruby/object:Gem::Version 
+        hash: 21
+        segments: 
+        - 1
+        - 0
+        - 1
+        version: 1.0.1
+  type: :runtime
+  version_requirements: *id001
 description: Takes a stream to a spreadsheet file and produces and XML representation of its contents
 email: stuart.owen@manchester.ac.uk
 executables: []