simple-navigation 4.4.1 → 4.5.0

data/spec/simple_navigation/renderer/breadcrumbs_spec.rb

@@ -1,115 +1,113 @@
-module SimpleNavigation
-  module Renderer
-    describe Breadcrumbs do
-      let!(:navigation) { setup_navigation('nav_id', 'nav_class') }
+# frozen_string_literal: true
 
-      let(:item) { nil }
-      let(:options) {{ level: :all }}
-      let(:output) { renderer.render(navigation) }
-      let(:renderer) { Breadcrumbs.new(options) }
+RSpec.describe SimpleNavigation::Renderer::Breadcrumbs do
+  let!(:navigation) { setup_navigation('nav_id', 'nav_class') }
 
-      before { select_an_item(navigation[item]) if item }
+  let(:item) { nil }
+  let(:options) { { level: :all } }
+  let(:output) { renderer.render(navigation) }
+  let(:renderer) { described_class.new(options) }
 
-      describe '#render' do
-        it "renders a 'div' tag for the navigation" do
-          expect(output).to have_css('div')
-        end
+  before { select_an_item(navigation[item]) if item }
 
-        it "sets the right html id on the rendered 'div' tag" do
-          expect(output).to have_css('div#nav_id')
-        end
+  describe '#render' do
+    it "renders a 'div' tag for the navigation" do
+      expect(output).to have_css('div')
+    end
 
-        it "sets the right html classes on the rendered 'div' tag" do
-          expect(output).to have_css('div.nav_class')
-        end
+    it "sets the right html id on the rendered 'div' tag" do
+      expect(output).to have_css('div#nav_id')
+    end
 
-        context 'when no item is selected' do
-          it "doesn't render any 'a' tag in the 'div' tag" do
-            expect(output).not_to have_css('div a')
-          end
-        end
+    it "sets the right html classes on the rendered 'div' tag" do
+      expect(output).to have_css('div.nav_class')
+    end
 
-        context 'when an item is selected' do
-          let(:item) { :invoices }
+    context 'when no item is selected' do
+      it "doesn't render any 'a' tag in the 'div' tag" do
+        expect(output).to have_no_css('div a')
+      end
+    end
 
-          it "renders the selected 'a' tag" do
-            expect(output).to have_css('div a')
-          end
+    context 'when an item is selected' do
+      let(:item) { :invoices }
 
-          it "remders the 'a' tag without any html id" do
-            expect(output).not_to have_css('div a[id]')
-          end
+      it "renders the selected 'a' tag" do
+        expect(output).to have_css('div a')
+      end
 
-          it "renders the 'a' tag without any html class" do
-            expect(output).not_to have_css('div a[class]')
-          end
+      it "remders the 'a' tag without any html id" do
+        expect(output).to have_no_css('div a[id]')
+      end
+
+      it "renders the 'a' tag without any html class" do
+        expect(output).to have_no_css('div a[class]')
+      end
 
-          context 'and the :allow_classes_and_ids option is true' do
-            let(:options) {{ level: :all, allow_classes_and_ids: true }}
+      context 'when the :allow_classes_and_ids option is true' do
+        let(:options) { { level: :all, allow_classes_and_ids: true } }
 
-            it "renders the 'a' tag with the selected class" do
-              expect(output).to have_css('div a.selected')
-            end
+        it "renders the 'a' tag with the selected class" do
+          expect(output).to have_css('div a.selected')
+        end
 
-            context "and the item hasn't any id explicitly set" do
-              it "renders the 'a' tag without any html id" do
-                expect(output).not_to have_css('div a[id]')
-              end
-            end
+        context "when the item hasn't any id explicitly set" do
+          it "renders the 'a' tag without any html id" do
+            expect(output).to have_no_css('div a[id]')
+          end
+        end
 
-            context 'and the item has an explicitly set id' do
-              let(:item) { :users }
+        context 'when the item has an explicitly set id' do
+          let(:item) { :users }
 
-              it "renders the 'a' tag with an html id" do
-                expect(output).to have_css('div a#breadcrumb_users_link_id')
-              end
-            end
+          it "renders the 'a' tag with an html id" do
+            expect(output).to have_css('div a#breadcrumb_users_link_id')
           end
         end
+      end
+    end
 
-        context 'and the :prefix option is set' do
-          let(:options) {{ prefix: 'You are here: ' }}
+    context 'when the :prefix option is set' do
+      let(:options) { { prefix: 'You are here: ' } }
 
-          context 'and there are no items to render' do
-            let(:item) { nil }
+      context 'when there are no items to render' do
+        let(:item) { nil }
 
-            it "doesn't render the prefix before the breadcrumbs" do
-              expect(output).not_to match(/^<div.+>You are here: /)
-            end
-          end
+        it "doesn't render the prefix before the breadcrumbs" do
+          expect(output).not_to match(/^<div.+>You are here: /)
+        end
+      end
 
-          context 'and there are items to render' do
-            let(:item) { :invoices }
+      context 'when there are items to render' do
+        let(:item) { :invoices }
 
-            it 'renders the prefix before the breadcrumbs' do
-              expect(output).to match(/^<div.+>You are here: /)
-            end
-          end
+        it 'renders the prefix before the breadcrumbs' do
+          expect(output).to match(/^<div.+>You are here: /)
         end
+      end
+    end
 
-        context 'when a sub navigation item is selected' do
-          before do
-            allow(navigation[:invoices]).to receive_messages(selected?: true)
+    context 'when a sub navigation item is selected' do
+      before do
+        allow(navigation[:invoices]).to receive_messages(selected?: true)
 
-            allow(navigation[:invoices].sub_navigation[:unpaid]).to \
-              receive_messages(selected?: true, selected_by_condition?: true)
-          end
+        allow(navigation[:invoices].sub_navigation[:unpaid]).to \
+          receive_messages(selected?: true, selected_by_condition?: true)
+      end
 
-          it 'renders all items as links' do
-            expect(output).to have_css('div a', 2)
-          end
+      it 'renders all items as links' do
+        expect(output).to have_css('div a', 2)
+      end
 
-          context 'when the :static_leaf option is true' do
-            let(:options) {{ level: :all, static_leaf: true }}
+      context 'when the :static_leaf option is true' do
+        let(:options) { { level: :all, static_leaf: true } }
 
-            it 'renders the items as links' do
-              expect(output).to have_css('div a')
-            end
+        it 'renders the items as links' do
+          expect(output).to have_css('div a')
+        end
 
-            it 'renders the last item as simple text' do
-              expect(output).to have_css('div span')
-            end
-          end
+        it 'renders the last item as simple text' do
+          expect(output).to have_css('div span')
         end
       end
     end

data/spec/simple_navigation/renderer/json_spec.rb

@@ -1,73 +1,66 @@
-module SimpleNavigation
-  module Renderer
-    describe Json do
-      describe '#render' do
-        let!(:navigation) { setup_navigation('nav_id', 'nav_class') }
+# frozen_string_literal: true
 
-        let(:item) { :invoices }
-        let(:options) {{ level: :all }}
-        let(:output) { renderer.render(navigation) }
-        let(:parsed_output) { JSON.parse(output) }
-        let(:renderer) { Json.new(options) }
+RSpec.describe SimpleNavigation::Renderer::Json do
+  describe '#render' do
+    let!(:navigation) { setup_navigation('nav_id', 'nav_class') }
 
-        before { select_an_item(navigation[item]) if item }
+    let(:item) { :invoices }
+    let(:options) { { level: :all } }
+    let(:output) { renderer.render(navigation) }
+    let(:parsed_output) { JSON.parse(output) }
+    let(:renderer) { described_class.new(options) }
 
-        context 'when an item is selected' do
+    before { select_an_item(navigation[item]) if item }
 
-          it 'renders the selected page' do
-            invoices_item = parsed_output.find { |item| item['name'] == 'Invoices' }
-            expect(invoices_item).to include('selected' => true)
-          end
-        end
+    context 'when an item is selected' do
+      it 'renders the selected page' do
+        invoices_item = parsed_output.find { |item| item['name'] == 'Invoices' }
+        expect(invoices_item).to include('selected' => true)
+      end
+    end
 
-        context 'when the :as_hash option is true' do
-          let(:options) {{ level: :all, as_hash: true }}
+    context 'when the :as_hash option is true' do
+      let(:options) { { level: :all, as_hash: true } }
 
-          it 'returns every item as a hash' do
-            expect(output).to be_an Array
+      it 'returns every item as a hash' do # rubocop:disable RSpec/MultipleExpectations
+        expect(output).to be_an Array
 
-            output.each do |item|
-              expect(item).to be_an Hash
-            end
-          end
+        expect(output).to all(be_an Hash)
+      end
 
-          it 'renders the selected page' do
-            invoices_item = output.find { |item| item[:name] == 'Invoices' }
-            expect(invoices_item).to include(selected: true)
-          end
-        end
+      it 'renders the selected page' do
+        invoices_item = output.find { |item| item[:name] == 'Invoices' }
+        expect(invoices_item).to include(selected: true)
+      end
+    end
 
-        context 'with options' do
-          it 'should render options for each item' do
-            parsed_output.each do |item|
-              expect(item).to have_key('options')
-            end
-          end
-        end
+    context 'with options' do
+      it 'renders options for each item' do
+        expect(parsed_output).to all(have_key('options'))
+      end
+    end
 
-        context 'when a sub navigation item is selected' do
-          let(:invoices_item) do
-            parsed_output.find { |item| item['name'] == 'Invoices' }
-          end
-          let(:unpaid_item) do
-            invoices_item['items'].find { |item| item['name'] == 'Unpaid' }
-          end
+    context 'when a sub navigation item is selected' do
+      let(:invoices_item) do
+        parsed_output.find { |item| item['name'] == 'Invoices' }
+      end
+      let(:unpaid_item) do
+        invoices_item['items'].find { |item| item['name'] == 'Unpaid' }
+      end
 
-          before do
-            allow(navigation[:invoices]).to receive_messages(selected?: true)
+      before do
+        allow(navigation[:invoices]).to receive_messages(selected?: true)
 
-            allow(navigation[:invoices].sub_navigation[:unpaid]).to \
-              receive_messages(selected?: true, selected_by_condition?: true)
-          end
+        allow(navigation[:invoices].sub_navigation[:unpaid]).to \
+          receive_messages(selected?: true, selected_by_condition?: true)
+      end
 
-          it 'marks all the parent items as selected' do
-            expect(invoices_item).to include('selected' => true)
-          end
+      it 'marks all the parent items as selected' do
+        expect(invoices_item).to include('selected' => true)
+      end
 
-          it 'marks the item as selected' do
-            expect(unpaid_item).to include('selected' => true)
-          end
-        end
+      it 'marks the item as selected' do
+        expect(unpaid_item).to include('selected' => true)
       end
     end
   end

data/spec/simple_navigation/renderer/links_spec.rb

@@ -1,86 +1,84 @@
-module SimpleNavigation
-  module Renderer
-    describe Links do
-      describe '#render' do
-        let!(:navigation) { setup_navigation('nav_id', 'nav_class') }
-
-        let(:item) { nil }
-        let(:options) { { level: :all } }
-        let(:output) { renderer.render(navigation) }
-        let(:renderer) { Links.new(options) }
-
-        before { select_an_item(navigation[item]) if item }
-
-        it "renders a 'div' tag for the navigation" do
-          expect(output).to have_css('div')
-        end
-
-        it "sets the right html id on the rendered 'div' tag" do
-          expect(output).to have_css('div#nav_id')
-        end
-
-        it "sets the right html classes on the rendered 'div' tag" do
-          expect(output).to have_css('div.nav_class')
-        end
-
-        it "renders an 'a' tag for each item" do
-          expect(output).to have_css('a', 3)
-        end
-
-        it "renders the 'a' tags with the corresponding item's :html_options" do
-          expect(output).to have_css('a[style="float:right"]')
-        end
-
-        context 'when an item has a specified id' do
-          it "renders the 'a' tags with the specified id" do
-            expect(output).to have_css('a#users_id')
-          end
-        end
-
-        context 'when an item has no specified id' do
-          it "uses a default id by stringifying the item's key" do
-            expect(output).to have_css('a#invoices')
-          end
-        end
-
-        context 'when no item is selected' do
-          it "renders items without the 'selected' class" do
-            expect(output).not_to have_css('a.selected')
-          end
-        end
-
-        context 'when an item is selected' do
-          let(:item) { :invoices }
-
-          it "renders the selected item with the 'selected' class" do
-            expect(output).to have_css('a#invoices.selected')
-          end
-        end
-
-        context "when the :join_with option is set" do
-          let(:options) {{ level: :all, join_with: ' | ' }}
-
-          it 'separates the items with the specified separator' do
-            expect(output.scan(' | ').size).to eq 3
-          end
-        end
-
-        context 'when a sub navigation item is selected' do
-          before do
-            allow(navigation[:invoices]).to receive_messages(selected?: true)
-
-            allow(navigation[:invoices].sub_navigation[:unpaid]).to \
-              receive_messages(selected?: true, selected_by_condition?: true)
-          end
-
-          it 'renders the main parent as selected' do
-            expect(output).to have_css('a#invoices.selected')
-          end
-
-          it "doesn't render the nested item's link" do
-            expect(output).not_to have_css('a#unpaid')
-          end
-        end
+# frozen_string_literal: true
+
+RSpec.describe SimpleNavigation::Renderer::Links do
+  describe '#render' do
+    let!(:navigation) { setup_navigation('nav_id', 'nav_class') }
+
+    let(:item) { nil }
+    let(:options) { { level: :all } }
+    let(:output) { renderer.render(navigation) }
+    let(:renderer) { described_class.new(options) }
+
+    before { select_an_item(navigation[item]) if item }
+
+    it "renders a 'div' tag for the navigation" do
+      expect(output).to have_css('div')
+    end
+
+    it "sets the right html id on the rendered 'div' tag" do
+      expect(output).to have_css('div#nav_id')
+    end
+
+    it "sets the right html classes on the rendered 'div' tag" do
+      expect(output).to have_css('div.nav_class')
+    end
+
+    it "renders an 'a' tag for each item" do
+      expect(output).to have_css('a', 3)
+    end
+
+    it "renders the 'a' tags with the corresponding item's :html_options" do
+      expect(output).to have_css('a[style="float:right"]')
+    end
+
+    context 'when an item has a specified id' do
+      it "renders the 'a' tags with the specified id" do
+        expect(output).to have_css('a#users_id')
+      end
+    end
+
+    context 'when an item has no specified id' do
+      it "uses a default id by stringifying the item's key" do
+        expect(output).to have_css('a#invoices')
+      end
+    end
+
+    context 'when no item is selected' do
+      it "renders items without the 'selected' class" do
+        expect(output).to have_no_css('a.selected')
+      end
+    end
+
+    context 'when an item is selected' do
+      let(:item) { :invoices }
+
+      it "renders the selected item with the 'selected' class" do
+        expect(output).to have_css('a#invoices.selected')
+      end
+    end
+
+    context 'when the :join_with option is set' do
+      let(:options) { { level: :all, join_with: ' | ' } }
+
+      it 'separates the items with the specified separator' do
+        expect(output.scan(' | ').size).to eq 3
+      end
+    end
+
+    context 'when a sub navigation item is selected' do
+      before do
+        allow(navigation[:invoices]).to receive_messages(selected?: true)
+
+        allow(navigation[:invoices].sub_navigation[:unpaid]).to \
+          receive_messages(selected?: true, selected_by_condition?: true)
+      end
+
+      it 'renders the main parent as selected' do
+        expect(output).to have_css('a#invoices.selected')
+      end
+
+      it "doesn't render the nested item's link" do
+        expect(output).to have_no_css('a#unpaid')
       end
     end
   end