simple-navigation 4.0.4 → 4.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9fed9ef827f77e17a268919f549633011c3ad2da
-  data.tar.gz: 8438a20df8657b3d8ade790442ead078074f3ae0
+  metadata.gz: 517a3078bcdee06d396acd50e301c2d595316ebb
+  data.tar.gz: b4da0b90ffa1a1996a6ce0ad5af542ae586f3936
 SHA512:
-  metadata.gz: a0934ad4673e57f30a29e9188af3d784a2a25d5f98f115f74e3e643de4d1c74128e66810594e672c55f1722a915a126900871c0c4c41272c7439618e5a8c4d7b
-  data.tar.gz: 689c5ef4056e973c43dc1261eae8bbdff92a0f5495a9b4d52c5c3a376d3e71b5cbb3a180c396571a4d5d176be435dce2fcdb7ea49223a357d9dbd4588e98281e
+  metadata.gz: a976b0a7c53937f03c25cad0fb84cc004a09e1d5f0f71a23e298cf5c03ed3ffb74600132c46d8eb78de5c1b4266f81f16f83e0b517278aa330cd2db7f64028fd
+  data.tar.gz: 7a2e60a09ae9126e6a97349e3fe6118744b316acf5d797bb7432ebed49f02b3d326048e788db962988d7dafb8f162d548388c41f25f56e2203d3d2f0f943e38d

data/.travis.yml

@@ -2,9 +2,8 @@ before_install:
   - gem install bundler
 
 rvm:
-  - 2.0.0
-  - 2.1.5
-  - 2.2.1
+  - 2.2.6
+  - 2.3.3
 
 gemfile:
   - gemfiles/rails-4-2-stable.gemfile

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 4.0.5
+
+* Fix #188 Blank url and highligh_on_subpath = true causes error. Credits to Tristan Harmer (gondalez) and Ilia Pozhilov (ilyapoz).
+
 ## 4.0.4
 
 * Fix #184 uninitialized constant Rails::Railtie (NameError). Credits to n-rodriguez.

data/README.md

@@ -5,7 +5,7 @@
 [![Code Climate](https://codeclimate.com/github/codeplant/simple-navigation.png)](https://codeclimate.com/github/codeplant/simple-navigation)
 [![Coverage Status](https://coveralls.io/repos/codeplant/simple-navigation/badge.png)](https://coveralls.io/r/codeplant/simple-navigation)
 
-Simple Navigation is a ruby library for creating navigations (with multiple levels) for your Rails 2, Rails 3, Rails 4, Sinatra or Padrino applications. It runs with all ruby versions (including ruby 2.x).
+Simple Navigation is a ruby library for creating navigations (with multiple levels) for your Rails, Sinatra or Padrino applications. It runs with all ruby versions (including ruby 2.x).
 
 ## Documentation
 

data/Rakefile

@@ -8,7 +8,7 @@ require 'rdoc/task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task default: 'spec:all'
+task default: 'spec'
 
 namespace :spec do
   mappers = %w[

data/gemfiles/rails-3-2-stable.gemfile

@@ -1,5 +1,6 @@
 source 'https://rubygems.org'
 
+gem 'rake', '< 11.0'
 gem 'railties', '~> 3.2.0'
 gem 'rspec-rails', '~> 3.2.1'
 

data/gemfiles/rails-4-1-stable.gemfile

@@ -1,5 +1,6 @@
 source 'https://rubygems.org'
 
+gem 'rake', '< 11.0'
 gem 'railties', '~> 4.1.0'
 gem 'rspec-rails', '~> 3.2.1'
 

data/gemfiles/rails-4-2-stable.gemfile

@@ -1,6 +1,6 @@
 source 'https://rubygems.org'
 
-gem 'launchy'
+gem 'rake', '< 11.0'
 gem 'railties', '~> 4.2.0'
 gem 'rspec-rails', '~> 3.2.1'
 

data/lib/simple_navigation/item.rb

@@ -153,6 +153,7 @@ module SimpleNavigation
 
     def selected_by_autohighlight?
       return false unless auto_highlight?
+      return false unless self.url
 
       root_path_match? ||
       (url_for_autohighlight && SimpleNavigation.current_page?(url_for_autohighlight)) ||

data/lib/simple_navigation/version.rb

@@ -1,3 +1,3 @@
 module SimpleNavigation
-  VERSION = '4.0.4'
+  VERSION = '4.0.5'
 end

data/spec/simple_navigation/item_spec.rb

@@ -246,6 +246,14 @@ module SimpleNavigation
               double(:config, auto_highlight: true, highlight_on_subpath: true, ignore_query_params_on_auto_highlight: true, ignore_anchors_on_auto_highlight: true)
             end
 
+            context "but item has no url" do
+              let(:url) { nil }
+
+              it 'returns false' do
+                expect(item.selected?).to be false
+              end
+            end
+
             context "and the current url is a sub path of the item's url" do
               before do
                 allow(adapter).to \

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simple-navigation
 version: !ruby/object:Gem::Version
-  version: 4.0.4
+  version: 4.0.5
 platform: ruby
 authors:
 - Andi Schacke
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-07 00:00:00.000000000 Z
+date: 2017-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -257,7 +257,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.7
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: simple-navigation is a ruby library for creating navigations (with multiple