simplabs-excellent 1.2.1 → 1.2.2

data/spec/checks/flog_block_check_spec.rb

@@ -9,12 +9,12 @@ describe Simplabs::Excellent::Checks::FlogBlockCheck do
   describe '#evaluate' do
 
     it 'should calculate the score correctly' do
-      content = <<-END
+      code = <<-END
         method_name do
           puts 'test'
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
       warnings = @excellent.warnings
 
       warnings.should_not be_empty

data/spec/checks/flog_class_check_spec.rb

@@ -9,12 +9,12 @@ describe Simplabs::Excellent::Checks::FlogClassCheck do
   describe '#evaluate' do
 
     it 'should calculate the score correctly' do
-      content = <<-END
+      code = <<-END
         class User < ActiveRecord::Base
           has_many :projects
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
       warnings = @excellent.warnings
 
       warnings.should_not be_empty

data/spec/checks/flog_method_check_spec.rb

@@ -9,17 +9,17 @@ describe Simplabs::Excellent::Checks::FlogMethodCheck do
   describe '#evaluate' do
 
     it 'should calculate the score correctly' do
-      content = <<-END
+      code = <<-END
         def method_name
           puts 'test'
         end
       END
 
-      verify_content_score(content, 1)
+      verify_code_score(code, 1)
     end
 
     it 'should calculate the score that uses special metaprogramming methods correctly' do
-      content = <<-END
+      code = <<-END
         def method_name
           @instance.instance_eval do
             def some_method
@@ -28,13 +28,13 @@ describe Simplabs::Excellent::Checks::FlogMethodCheck do
         end
       END
 
-      verify_content_score(content, 6)
+      verify_code_score(code, 6)
     end
 
   end
 
-  def verify_content_score(content, score)
-    @excellent.check_content(content)
+  def verify_code_score(code, score)
+    @excellent.check_code(code)
     warnings = @excellent.warnings
 
     warnings.should_not be_empty

data/spec/checks/for_loop_check_spec.rb

@@ -9,38 +9,38 @@ describe Simplabs::Excellent::Checks::ForLoopCheck do
   describe '#evaluate' do
 
     it 'should accept iterators' do
-      content = <<-END
+      code = <<-END
         [:sym1, :sym2].each do |sym|
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
       warnings = @excellent.warnings
 
       warnings.should be_empty
     end
 
     it 'should reject for loops on ranges' do
-      content = <<-END
+      code = <<-END
         for i in 1..2
         end
       END
 
-      verify_warning_found(content)
+      verify_warning_found(code)
     end
 
     it 'should reject for loops on enumerations' do
-      content = <<-END
+      code = <<-END
         for symbol in [:sym1, :sym2]
         end
       END
 
-      verify_warning_found(content)
+      verify_warning_found(code)
     end
 
   end
 
-  def verify_warning_found(content)
-    @excellent.check_content(content)
+  def verify_warning_found(code)
+    @excellent.check_code(code)
     warnings = @excellent.warnings
 
     warnings.should_not be_empty

data/spec/checks/method_line_count_check_spec.rb

@@ -9,33 +9,33 @@ describe Simplabs::Excellent::Checks::MethodLineCountCheck do
   describe '#evaluate' do
 
     it 'should accept methods with less lines than the threshold' do
-      content = <<-END
+      code = <<-END
         def one_line_method
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
 
       @excellent.warnings.should be_empty
     end
 
     it 'should accept methods with the same number of lines as the threshold' do
-      content = <<-END
+      code = <<-END
         def two_line_method
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
 
       @excellent.warnings.should be_empty
     end
 
     it 'should reject methods with more lines than the threshold' do
-      content = <<-END
+      code = <<-END
         def four_line_method
           puts 1
           puts 2
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
       warnings = @excellent.warnings
 
       warnings.should_not be_empty

data/spec/checks/method_name_check_spec.rb

@@ -9,51 +9,51 @@ describe Simplabs::Excellent::Checks::MethodNameCheck do
   describe '#evaluate' do
 
     it 'should accept method names with underscores' do
-      content = <<-END
+      code = <<-END
         def good_method_name
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
 
       @excellent.warnings.should be_empty
     end
 
     it 'should accept method names with numbers' do
-      content = <<-END
+      code = <<-END
         def good_method_name_1
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
 
       @excellent.warnings.should be_empty
     end
 
     it 'should accept method names ending with a question mark' do
-      content = <<-END
+      code = <<-END
         def good_method_name?
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
 
       @excellent.warnings.should be_empty
     end
 
     it 'should accept method names ending with an exclamation mark' do
-      content = <<-END
+      code = <<-END
         def good_method_name!
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
 
       @excellent.warnings.should be_empty
     end
 
     it 'should accept method names ending an equals sign' do
-      content = <<-END
+      code = <<-END
         def good_method_name=
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
 
       @excellent.warnings.should be_empty
     end
@@ -61,11 +61,11 @@ describe Simplabs::Excellent::Checks::MethodNameCheck do
     ['<<', '>>', '==', '<', '<=', '>', '>=', '[]', '[]=', '+', '-', '*', '~', '/', '%', '&', '^', '|'].each do |operator|
 
       it "should accept #{operator} as a method name" do
-        content = <<-END
+        code = <<-END
           def #{operator}
           end
         END
-        @excellent.check_content(content)
+        @excellent.check_code(code)
 
         @excellent.warnings.should be_empty
       end
@@ -75,11 +75,11 @@ describe Simplabs::Excellent::Checks::MethodNameCheck do
   end
 
   it 'should reject camel cased method names' do
-    content = <<-END
+    code = <<-END
       def badMethodName
       end
     END
-    @excellent.check_content(content)
+    @excellent.check_code(code)
     warnings = @excellent.warnings
 
     warnings.should_not be_empty
@@ -89,7 +89,7 @@ describe Simplabs::Excellent::Checks::MethodNameCheck do
   end
 
   it "should correctly return the method's full name" do
-    content = <<-END
+    code = <<-END
       class Class
         def badMethodName
         end
@@ -97,7 +97,7 @@ describe Simplabs::Excellent::Checks::MethodNameCheck do
         end
       end
     END
-    @excellent.check_content(content)
+    @excellent.check_code(code)
     warnings = @excellent.warnings
 
     warnings.should_not be_empty

data/spec/checks/module_line_count_check_spec.rb

@@ -9,32 +9,32 @@ describe Simplabs::Excellent::Checks::ModuleLineCountCheck do
   describe '#evaluate' do
 
     it 'should accept modules with less lines than the threshold' do
-      content = <<-END
+      code = <<-END
         module OneLineModule; end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
 
       @excellent.warnings.should be_empty
     end
 
     it 'should accept modules with the same number of lines as the threshold' do
-      content = <<-END
+      code = <<-END
         module TwoLinesModule
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
 
       @excellent.warnings.should be_empty
     end
 
     it 'should reject modules with more lines than the threshold' do
-      content = <<-END
+      code = <<-END
         module FourLinesModule
           @foo = 1
           @bar = 2
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
       warnings = @excellent.warnings
 
       warnings.should_not be_empty

data/spec/checks/module_name_check_spec.rb

@@ -9,31 +9,31 @@ describe Simplabs::Excellent::Checks::ModuleNameCheck do
   describe '#evaluate' do
 
     it 'should accept camel case module names starting in capitals' do
-      content = <<-END
+      code = <<-END
         module GoodModuleName 
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
 
       @excellent.warnings.should be_empty
     end
 
     it 'should accept namespaced modules' do
-      content = <<-END
+      code = <<-END
         module Outer::Inner::GoodModuleName 
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
 
       @excellent.warnings.should be_empty
     end
 
     it 'should reject module names with underscores' do
-      content = <<-END
+      code = <<-END
         module Bad_ModuleName 
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
       warnings = @excellent.warnings
 
       warnings.should_not be_empty
@@ -43,11 +43,11 @@ describe Simplabs::Excellent::Checks::ModuleNameCheck do
     end
 
     it 'should correctly report bad names of namespaced modules' do
-      content = <<-END
+      code = <<-END
         module Outer::Inner::Bad_ModuleName
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
       warnings = @excellent.warnings
 
       warnings.should_not be_empty

data/spec/checks/nested_iterators_check_spec.rb

@@ -9,13 +9,13 @@ describe Simplabs::Excellent::Checks::NestedIteratorsCheck do
   describe '#evaluate' do
 
     it 'should reject a block inside a block' do
-      content = <<-END
+      code = <<-END
         method1 do
           method2 do
           end
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
       warnings = @excellent.warnings
 
       warnings.should_not be_empty
@@ -25,7 +25,7 @@ describe Simplabs::Excellent::Checks::NestedIteratorsCheck do
     end
 
     it 'should accept 2 blocks inside a method that are not nested' do
-      content = <<-END
+      code = <<-END
         def method
           method1 do
           end
@@ -33,7 +33,7 @@ describe Simplabs::Excellent::Checks::NestedIteratorsCheck do
           end
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
       warnings = @excellent.warnings
 
       warnings.should be_empty

data/spec/checks/parameter_number_check_spec.rb

@@ -9,83 +9,83 @@ describe Simplabs::Excellent::Checks::ParameterNumberCheck do
   describe '#evaluate' do
 
     it 'should accept methods with less parameters than the threshold' do
-      content = <<-END
+      code = <<-END
         def zero_parameter_method
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
 
       @excellent.warnings.should be_empty
     end
 
     it 'should accept methods with the same number of parameters as the threshold' do
-      content = <<-END
+      code = <<-END
         def one_parameter_method(first_parameter)
         end
       END
-      @excellent.check_content(content)
+      @excellent.check_code(code)
 
       @excellent.warnings.should be_empty
     end
 
     it 'should reject methods with more parameters than the threshold' do
-      content = <<-END
+      code = <<-END
         def two_parameter_method(first_parameter, second_parameter)
         end
       END
 
-      verify_warning_found(content, 'two_parameter_method')
+      verify_warning_found(code, 'two_parameter_method')
     end
 
     it 'should work with default values on parameters' do
-      content = <<-END
+      code = <<-END
         def two_parameter_method(first_parameter = 1, second_parameter = 2)
         end
       END
 
-      verify_warning_found(content, 'two_parameter_method')
+      verify_warning_found(code, 'two_parameter_method')
     end
 
     it 'should work with methods defined on objects' do
-      content = <<-END
+      code = <<-END
         def object.two_parameter_method(first_parameter = 1, second_parameter = 2)
         end
       END
 
-      verify_warning_found(content, 'object.two_parameter_method')
+      verify_warning_found(code, 'object.two_parameter_method')
     end
 
     it 'should work with methods defined directly on classes' do
-      content = <<-END
+      code = <<-END
         def Class.two_parameter_method(first_parameter = 1, second_parameter = 2)
         end
       END
 
-      verify_warning_found(content, 'Class.two_parameter_method')
+      verify_warning_found(code, 'Class.two_parameter_method')
     end
 
     it 'should reject yield calls with more parameters than the threshold' do
-      content = <<-END
+      code = <<-END
         two_parameter_method do |first_parameter, second_parameter|
         end
       END
 
-      verify_warning_found(content, 'block')
+      verify_warning_found(code, 'block')
     end
 
     it 'should reject yield calls on a receiver with more parameters than the threshold' do
-      content = <<-END
+      code = <<-END
         receiver.two_parameter_method do |first_parameter, second_parameter|
         end
       END
 
-      verify_warning_found(content, 'block')
+      verify_warning_found(code, 'block')
     end
 
   end
 
-  def verify_warning_found(content, name)
-    @excellent.check_content(content)
+  def verify_warning_found(code, name)
+    @excellent.check_code(code)
     warnings = @excellent.warnings
 
     warnings.should_not be_empty