simp-rspec-puppet-facts 3.13.0 → 4.0.0

data/spec/acceptance/suites/default/00_default_spec.rb

@@ -9,20 +9,21 @@ describe 'look out muppets' do
     let(:os_info) { fact_on(host, 'os') }
     let(:os_arch) { fact_on(host, 'architecture') }
 
-    let(:fact_collection) { File.join(collection_dir, [os_info['name'], os_info['release']['major'].gsub(/\s/,'_'), os_arch].join('-').downcase + '.facts') }
+    let(:fact_collection) { File.join(collection_dir, [os_info['name'], os_info['release']['major'].gsub(%r{\s}, '_'), os_arch].join('-').downcase + '.facts') }
 
-    let(:host_data) { JSON.load(File.read(fact_collection)) }
+    let(:host_data) { JSON.parse(File.read(fact_collection)) }
 
+    # rubocop:disable RSpec/InstanceVariable
     context "on #{host}" do
       before(:all) do
         @output = []
       end
 
-      it 'should install the simp_core module' do
+      it 'installs the simp_core module' do
         on(host, 'puppet module install simp/simp_core')
       end
 
-      it 'should disable the secondary network interface' do
+      it 'disables the secondary network interface' do
         interfaces = fact_on(host, 'interfaces').strip.split(',')
 
         ifaces = {
@@ -31,43 +32,44 @@ describe 'look out muppets' do
           'Ethernet 2' => 'netsh interface set interface "Ethernet 2" disable'
         }
 
-        ifaces.keys.each do |iface|
+        ifaces.each_key do |iface|
           on(host, ifaces[iface]) if interfaces.include?(iface)
         end
       end
 
-      it 'should collect valid fact data' do
+      it 'collects valid fact data' do
         output = on(host, 'puppet facts show --show-legacy --render-as json').stdout.lines.last
 
-        expect do
+        expect {
           parsed_output = JSON.parse(output)
 
           # Something changed in the puppet facts output so handle both cases
           @output.push(parsed_output['values'] || parsed_output)
-        end.to_not raise_error
+        }.not_to raise_error
       end
 
       # This should work regardless of OS
-      it 'should have the "puppet_settings" fact' do
+      it 'has the "puppet_settings" fact' do
         expect(@output.first['puppet_settings']).to be_a(Hash)
       end
 
-      it 'should clean up the data' do
+      it 'cleans up the data' do
         str_data = JSON.generate(@output.first)
 
-        str_data = str_data.gsub(fact_on(host, 'fqdn'), 'foo.example.com').
-          gsub(fact_on(host, 'domain'), 'example.com').
-          gsub(%(:"#{fact_on(host, 'hostname')}"), ':"foo"').
-          gsub(%(:"#{fact_on(host, 'networking')['ip']}"), ':"10.0.2.15"').
-          gsub(%(:"#{fact_on(host, 'networking')['netmask']}"), ':"255.255.0.0"').
-          gsub(%(:"#{fact_on(host, 'networking')['network']}"), ':"10.0.2.0"').
-          gsub(%r("dhcp":"(.+?)"), '"dhcp":"10.0.2.2"')
+        str_data = str_data.gsub(fact_on(host, 'fqdn'), 'foo.example.com')
+                           .gsub(fact_on(host, 'domain'), 'example.com')
+                           .gsub(%(:"#{fact_on(host, 'hostname')}"), ':"foo"')
+                           .gsub(%(:"#{fact_on(host, 'networking')['ip']}"), ':"10.0.2.15"')
+                           .gsub(%(:"#{fact_on(host, 'networking')['netmask']}"), ':"255.255.0.0"')
+                           .gsub(%(:"#{fact_on(host, 'networking')['network']}"), ':"10.0.2.0"')
+                           .gsub(%r{"dhcp":"(.+?)"}, '"dhcp":"10.0.2.2"')
 
-        expect{JSON.parse(str_data)}.to_not raise_error
+        expect { JSON.parse(str_data) }.not_to raise_error
 
         FileUtils.mkdir_p(collection_dir) unless File.directory?(collection_dir)
-        File.open(fact_collection, 'w'){ |fh| fh.puts(JSON.pretty_generate(JSON.parse(str_data))) }
+        File.open(fact_collection, 'w') { |fh| fh.puts(JSON.pretty_generate(JSON.parse(str_data))) }
       end
     end
+    # rubocop:enable RSpec/InstanceVariable
   end
 end

data/spec/fixtures/metadata.json

@@ -7,39 +7,22 @@
   "source": "https://github.com/op-ct/pupmod-simp-dummy",
   "project_page": "https://github.com/op-ct/pupmod-simp-dummy",
   "issues_url": "https://github.com/op-ct/pupmod-simp-dummy/issues",
-  "dependencies": [
-  ],
-  "requirements": [
-  ],
+  "dependencies": [],
+  "requirements": [],
   "operatingsystem_support": [
     {
       "operatingsystem": "CentOS",
       "operatingsystemrelease": [
-        "7",
-        "8"
+        "9",
+        "10"
       ]
     },
     {
       "operatingsystem": "RedHat",
       "operatingsystemrelease": [
-        "7",
-        "8"
+        "9",
+        "10"
       ]
     }
-  ],
-  "puppet_version": [
-    "5.5",
-    "6.0",
-    "6.4",
-    "6.5",
-    "6.6",
-    "6.16",
-    "6.18",
-    "6.22",
-    "7.0",
-    "7.0",
-    "7.4",
-    "7.5",
-    "7.6"
   ]
 }

data/spec/spec_helper_acceptance.rb

@@ -13,18 +13,14 @@ include BeakerWindows::WindowsFeature
 unless ENV['BEAKER_provision'] == 'no'
   to_skip = []
 
-  facter_ng = ( ENV['BEAKER_facter_ng'] == 'yes' ? true : false )
-
   hosts.each do |host|
-    # Install Puppet
-    if host.is_pe?
-      install_pe
-    elsif ENV['FACTER_GEM_VERSION']
+    # Install OpenVox
+    if ENV['FACTER_GEM_VERSION']
       begin
         install_puppet_from_gem_on(
           host,
           version: ENV['PUPPET_VERSION'],
-          facter_version: ENV['FACTER_GEM_VERSION']
+          facter_version: ENV['FACTER_GEM_VERSION'],
         )
 
         # Make scaffold dirs?
@@ -41,10 +37,6 @@ unless ENV['BEAKER_provision'] == 'no'
       end
     else
       install_puppet
-
-      if facter_ng
-        on(host, 'puppet config set facterng true')
-      end
     end
   end
 
@@ -53,37 +45,6 @@ unless ENV['BEAKER_provision'] == 'no'
   end
 end
 
-hosts.each do |host|
-  # https://petersouter.xyz/testing-windows-with-beaker-without-cygwin/
-  case host['platform']
-  when /windows/
-    GEOTRUST_GLOBAL_CA = <<-EOM.freeze
------BEGIN CERTIFICATE-----
-MIIDVDCCAjygAwIBAgIDAjRWMA0GCSqGSIb3DQEBBQUAMEIxCzAJBgNVBAYTAlVT
-MRYwFAYDVQQKEw1HZW9UcnVzdCBJbmMuMRswGQYDVQQDExJHZW9UcnVzdCBHbG9i
-YWwgQ0EwHhcNMDIwNTIxMDQwMDAwWhcNMjIwNTIxMDQwMDAwWjBCMQswCQYDVQQG
-EwJVUzEWMBQGA1UEChMNR2VvVHJ1c3QgSW5jLjEbMBkGA1UEAxMSR2VvVHJ1c3Qg
-R2xvYmFsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA2swYYzD9
-9BcjGlZ+W988bDjkcbd4kdS8odhM+KhDtgPpTSEHCIjaWC9mOSm9BXiLnTjoBbdq
-fnGk5sRgprDvgOSJKA+eJdbtg/OtppHHmMlCGDUUna2YRpIuT8rxh0PBFpVXLVDv
-iS2Aelet8u5fa9IAjbkU+BQVNdnARqN7csiRv8lVK83Qlz6cJmTM386DGXHKTubU
-1XupGc1V3sjs0l44U+VcT4wt/lAjNvxm5suOpDkZALeVAjmRCw7+OC7RHQWa9k0+
-bw8HHa8sHo9gOeL6NlMTOdReJivbPagUvTLrGAMoUgRx5aszPeE4uwc2hGKceeoW
-MPRfwCvocWvk+QIDAQABo1MwUTAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBTA
-ephojYn7qwVkDBF9qn1luMrMTjAfBgNVHSMEGDAWgBTAephojYn7qwVkDBF9qn1l
-uMrMTjANBgkqhkiG9w0BAQUFAAOCAQEANeMpauUvXVSOKVCUn5kaFOSPeCpilKIn
-Z57QzxpeR+nBsqTP3UEaBU6bS+5Kb1VSsyShNwrrZHYqLizz/Tt1kL/6cdjHPTfS
-tQWVYrmm3ok9Nns4d0iXrKYgjy6myQzCsplFAMfOEVEiIuCl6rYVSAlk6l5PdPcF
-PseKUgzbFbS9bZvlxrFUaKnjaZC2mqUPuLk/IH2uSrW4nOQdtqvmlKXBx4Ot2/Un
-hw4EbNX/3aBd7YdStysVAq45pmp06drE57xNNB6pXE0zX5IJL4hmXXeXxx12E6nV
-5fEWCRE11azbJHFwLJhWC9kXtNHjUStedejV0NxPNO3CBWaAocvmMw==
------END CERTIFICATE-----
-    EOM
-    install_cert_on_windows(host, 'geotrustglobal', GEOTRUST_GLOBAL_CA)
-  end
-end
-
-
 RSpec.configure do |c|
   # ensure that environment OS is ready on each host
   fix_errata_on(hosts)
@@ -93,15 +54,11 @@ RSpec.configure do |c|
 
   # Configure all nodes in nodeset
   c.before :suite do
-    begin
-      # Install modules and dependencies from spec/fixtures/modules
-      copy_fixture_modules_to( hosts )
-    rescue StandardError, ScriptError => e
-      if ENV['PRY']
-        require 'pry'; binding.pry
-      else
-        raise e
-      end
-    end
+    # Install modules and dependencies from spec/fixtures/modules
+    copy_fixture_modules_to(hosts)
+  rescue StandardError, ScriptError => e
+    raise e unless ENV['PRY']
+    require 'pry'
+    binding.pry # rubocop:disable Lint/Debugger
   end
 end

data/spec/unit/data_normalization_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+describe 'Simp::RspecPuppetFacts' do
+  facts_top_path = File.expand_path('../../facts', File.dirname(__FILE__))
+  facter_paths = Dir[File.join(facts_top_path, '?.?')].sort
+
+  facter_paths.each do |facter_path|
+    warn "=== facter_path = '#{facter_path}'"
+    facter_version = File.basename(facter_path)
+    describe "factsets for Facter #{facter_version}" do
+      Dir[File.join(facter_path, '*.facts')].each do |facts_file|
+        os = File.basename(facts_file).sub(%r{\.facts$}, '')
+        context "for #{os}" do
+          let(:facts) { YAML.load_file facts_file }
+
+          it 'uses the fqdn "foo.example.com"' do
+            expect(facts['networking']['fqdn']).to eq 'foo.example.com'
+          end
+
+          it 'uses the ipaddress "10.0.2.15"' do
+            expect(facts['networking']['ip']).to eq '10.0.2.15'
+          end
+
+          it 'has a grub_version' do
+            if facts['kernel'] == 'windows'
+              expect(facts).not_to have_key('grub_version')
+            else
+              expect(facts['grub_version']).to match(%r{^(0\.9|2\.)})
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/spec/unit/simp_rspec_puppet_facts_spec.rb

@@ -0,0 +1,206 @@
+require 'spec_helper'
+
+describe 'Simp::RspecPuppetFacts' do
+  describe '#on_supported_os' do
+    context 'Without parameter' do
+      subject(:subject_on_supported_os) { on_supported_os }
+
+      context 'Without a metadata.json file' do
+        it { expect { subject_on_supported_os }.to raise_error(StandardError, %r{Can't find metadata\.json}) }
+      end
+
+      context 'With a metadata.json file' do
+        before(:each) do
+          Dir.chdir(File.join(File.dirname(__FILE__), '../fixtures'))
+        end
+
+        after(:each) do
+          Dir.chdir(File.join(File.dirname(__FILE__), '../..'))
+        end
+
+        it 'returns a hash' do
+          expect(on_supported_os.class).to eq Hash
+        end
+        it 'has 4 elements' do
+          expect(subject_on_supported_os.size).to be >= 4
+        end
+        it 'returns supported OS' do
+          expect(subject_on_supported_os.keys.sort).to include 'centos-9-x86_64'
+          expect(subject_on_supported_os.keys.sort).to include 'centos-10-x86_64'
+          expect(subject_on_supported_os.keys.sort).to include 'redhat-9-x86_64'
+          expect(subject_on_supported_os.keys.sort).to include 'redhat-10-x86_64'
+        end
+        it 'returns SIMP-specific OS facts' do
+          grub_version_facts = subject_on_supported_os.map do |os, data|
+            { os => data.slice(:uid_min, :grub_version) }
+          end
+          expect(grub_version_facts).to include(
+            { 'centos-10-x86_64' => { uid_min: '1000', grub_version: '2.12' } },
+          )
+          expect(grub_version_facts).to include(
+            { 'centos-9-x86_64' => { uid_min: '1000', grub_version: '2.06' } },
+          )
+          expect(grub_version_facts).to include(
+            { 'redhat-10-x86_64' => { uid_min: '1000', grub_version: '2.12' } },
+          )
+          expect(grub_version_facts).to include(
+            { 'redhat-9-x86_64' => { uid_min: '1000', grub_version: '2.06' } },
+          )
+        end
+      end
+    end
+
+    context 'When specifying supported_os=redhat-8-x86_64,redhat-9-x86_64' do
+      subject(:subject_on_supported_os) do
+        on_supported_os(
+          {
+            supported_os: [
+              {
+                'operatingsystem' => 'RedHat',
+                'operatingsystemrelease' => [
+                  '8',
+                  '9',
+                ]
+              },
+            ]
+          },
+        )
+      end
+
+      it 'returns a hash' do
+        expect(subject_on_supported_os.class).to eq Hash
+      end
+      it 'has 2 elements' do
+        expect(subject_on_supported_os.size).to eq 2
+      end
+      it 'returns supported OS' do
+        expect(subject_on_supported_os.keys.sort).to eq [
+          'redhat-8-x86_64',
+          'redhat-9-x86_64',
+        ]
+      end
+    end
+
+    context 'When specifying SIMP_FACTS_OS=centos,redhat-9-x86_64' do
+      subject(:subject_on_supported_os) do
+        x = ENV['SIMP_FACTS_OS']
+        ENV['SIMP_FACTS_OS'] = 'centos,redhat-9-x86_64'
+        h = on_supported_os
+        ENV['SIMP_FACTS_OS'] = x
+        h
+      end
+
+      it 'returns a hash' do
+        expect(subject_on_supported_os.class).to eq Hash
+      end
+      it 'has 3 elements' do
+        expect(subject_on_supported_os.size).to eq 3
+      end
+      it 'returns supported OS' do
+        expect(subject_on_supported_os.keys.sort).to eq [
+          'centos-10-x86_64',
+          'centos-9-x86_64',
+          'redhat-9-x86_64',
+        ]
+      end
+    end
+
+    context 'When specifying wrong supported_os' do
+      subject(:subject_on_supported_os) do
+        on_supported_os(
+          {
+            supported_os: [
+              {
+                'operatingsystem' => 'Debian',
+                'operatingsystemrelease' => [
+                  'X',
+                ],
+              },
+            ]
+          },
+        )
+      end
+
+      it 'outputs warning message', skip: 'rspec issue: No longer able to catch message on stdout or stderr' do
+        expect { subject_on_supported_os }.to output(%r{No facts were found in the FacterDB}).to_stdout
+      end
+    end
+  end
+
+  describe '#selinux_facts' do
+    context 'When :enforcing' do
+      subject(:subject_selinux_facts) { selinux_facts(:enforcing, {}) }
+
+      it 'returns a hash' do
+        expect(subject_selinux_facts.class).to eq Hash
+      end
+      context 'when facts include `:tmp_mount_dev_shm => "rw,noatime"`' do
+        subject(:subject_selinux_facts) { selinux_facts(:enforcing, { tmp_mount_dev_shm: 'rw,noatime' }) }
+
+        it 'has a :tmp_mount_dev_shm key' do
+          expect(subject_selinux_facts.key?(:tmp_mount_dev_shm)).to be true
+        end
+        it ':tmp_mount_dev_shm should include "seclabel"' do
+          expect(subject_selinux_facts[:tmp_mount_dev_shm]).to match(%r{\bseclabel\b})
+        end
+      end
+      context 'when facts include `:tmp_mount_dev_shm => "rw,noatime,seclabel"`' do
+        subject(:subject_selinux_facts) { selinux_facts(:enforcing, { tmp_mount_dev_shm: 'rw,noatime,seclabel' }) }
+
+        it ':tmp_mount_dev_shm should include "seclabel"' do
+          expect(subject_selinux_facts[:tmp_mount_dev_shm]).to match(%r{\bseclabel\b})
+        end
+      end
+    end
+
+    context 'When :permissive' do
+      subject(:subject_selinux_facts) { selinux_facts(:permissive, {}) }
+
+      it 'returns a hash' do
+        expect(subject_selinux_facts.class).to eq Hash
+      end
+      context 'when facts include `:tmp_mount_dev_shm => "rw,noatime"`' do
+        subject(:subject_selinux_facts) { selinux_facts(:permissive, { tmp_mount_dev_shm: 'rw,noatime' }) }
+
+        it 'has a :tmp_mount_dev_shm key' do
+          expect(subject_selinux_facts.key?(:tmp_mount_dev_shm)).to be true
+        end
+        it ':tmp_mount_dev_shm should include "seclabel"' do
+          expect(subject_selinux_facts[:tmp_mount_dev_shm]).to match(%r{\bseclabel\b})
+        end
+      end
+      context 'when facts include `:tmp_mount_dev_shm => "rw,noatime,seclabel"`' do
+        subject(:subject_selinux_facts) { selinux_facts(:permissive, { tmp_mount_dev_shm: 'rw,noatime,seclabel' }) }
+
+        it ':tmp_mount_dev_shm should include "seclabel"' do
+          expect(subject_selinux_facts[:tmp_mount_dev_shm]).to match(%r{\bseclabel\b})
+        end
+      end
+    end
+
+    context 'When :disabled' do
+      subject(:subject_selinux_facts) { selinux_facts(:disabled, {}) }
+
+      it 'returns a hash' do
+        expect(subject_selinux_facts.class).to eq Hash
+      end
+      context 'when facts include `:tmp_mount_dev_shm => "rw,noatime"`' do
+        subject(:subject_selinux_facts) { selinux_facts(:disabled, { tmp_mount_dev_shm: 'rw,noatime' }) }
+
+        it 'has a :tmp_mount_dev_shm key' do
+          expect(subject_selinux_facts.key?(:tmp_mount_dev_shm)).to be true
+        end
+        it ':tmp_mount_dev_shm should not include "seclabel"' do
+          expect(subject_selinux_facts[:tmp_mount_dev_shm]).not_to match(%r{\bseclabel\b})
+        end
+      end
+      context 'when facts include `:tmp_mount_dev_shm => "rw,noatime,seclabel"`' do
+        subject(:subject_selinux_facts) { selinux_facts(:disabled, { tmp_mount_dev_shm: 'rw,noatime,seclabel' }) }
+
+        it ':tmp_mount_dev_shm should not include "seclabel"' do
+          expect(subject_selinux_facts[:tmp_mount_dev_shm]).not_to match(%r{\bseclabel\b})
+        end
+      end
+    end
+  end
+end