simp-rake-helpers 2.5.7 → 3.0.0

data/lib/simp/rpm.rb

@@ -1,3 +1,5 @@
+require 'securerandom'
+
 module Simp
   # Simp::RPM represents a single package that is built and packaged by the Simp team.
   class Simp::RPM
@@ -33,6 +35,7 @@ module Simp
       @full_version = info[:full_version]
       @name = "#{@basename}-#{@full_version}"
       @sources = Array.new
+      @verbose = false
     end
 
     # Copies specific content from one directory to another.
@@ -51,6 +54,30 @@ module Simp
       end
     end
 
+    # Executes a command and returns a hash with the exit status,
+    # stdout output and stderr output.
+    # cmd:: command to be executed
+    def self.execute(cmd)
+      #puts "Executing: [#{cmd}]"
+      outfile = File.join('/tmp', "#{ENV['USER']}_#{SecureRandom.hex}")
+      errfile = File.join('/tmp', "#{ENV['USER']}_#{SecureRandom.hex}")
+      pid = spawn(cmd, :out=>outfile, :err=>errfile)
+
+      begin
+        pid,status = Process.wait2(pid)
+      rescue Errno::ECHILD
+        # process exited before status could be determined
+      end
+
+      exit_status = status.nil? ? nil : status.exitstatus
+      stdout = IO.read(outfile)
+      stderr = IO.read(errfile)
+
+      { :exit_status => exit_status, :stdout => stdout, :stderr => stderr }
+    ensure
+      FileUtils.rm_f([outfile, errfile])
+    end
+
     # Parses information, such as the version, from the given specfile or RPM
     # into a hash.
     #
@@ -65,40 +92,36 @@ module Simp
       rpm_cmd = "rpm -q --queryformat '%{NAME} %{VERSION} %{RELEASE}\n'"
 
       if mock_hash
-        rpm_cmd = mock_hash[:command] + ' ' + '"' + rpm_cmd + ' ' + mock_hash[:rpm_extras] + ' 2>/dev/null "'
+        # Suppression of error messages is a hack for the following
+        # scenario:
+        # * The RPM spec file has an invalid date in its %changelog.
+        # * The 'bogus date' warning message from rpmbuild
+        #   is sent to stderr, while RPM name, version, and release
+        #   info is sent to stdout.
+        # * mock combines stdout and stderr in the command run.
+        # * The 'bogus date' warning message is parsed to generate
+        #   the RPM info, instead of the RPM info message.
+        rpm_cmd = mock_hash[:command] + ' ' + '"' + rpm_cmd + ' ' + mock_hash[:rpm_extras] + ' 2>/dev/null"'
       end
 
       if File.readable?(rpm_source)
         if rpm_source.split('.').last == 'rpm'
-          rpm_info = %x(#{rpm_cmd} -p #{rpm_source} 2>/dev/null).strip
-
-          if rpm_info.empty?
-            raise <<-EOE
-            Error getting RPM info.
-            Run '#{rpm_cmd.gsub("\n",'\\n')} -p #{rpm_source}' to debug the issue.
-            EOE
-          end
+          results = execute("#{rpm_cmd} -p #{rpm_source}")
         elsif mock_hash
-          rpm_info = %x(#{rpm_cmd}).strip
-
-          if rpm_info.empty?
-            raise <<-EOE
-            Error getting RPM info.
-            Run '#{rpm_cmd.gsub("\n",'\\n')}' to debug the issue.
-            EOE
-          end
+          results = execute("#{rpm_cmd}")
         else
-          rpm_info = %x(#{rpm_cmd} --specfile #{rpm_source} 2>/dev/null).strip
+          results = execute("#{rpm_cmd} --specfile #{rpm_source}")
+        end
 
-          if rpm_info.empty?
-            raise <<-EOE
-            Error getting RPM info.
-            Run '#{rpm_cmd.gsub("\n",'\\n')} --specfile #{rpm_source}' to debug the issue.
-            EOE
-          end
+        if results[:exit_status] != 0
+          raise <<-EOE
+#{indent('Error getting RPM info:', 2)}
+#{indent(results[:stderr].strip, 5)}
+#{indent("Run '#{rpm_cmd.gsub("\n",'\\n')} --specfile #{rpm_source}' to recreate the issue.", 2)}
+EOE
         end
 
-        info[:name],info[:version],info[:release] = rpm_info.split("\n").first.split(' ')
+        info[:name],info[:version],info[:release] = results[:stdout].strip.split("\n").first.split(' ')
       else
         raise "Error: unable to read '#{rpm_source}'"
       end
@@ -108,6 +131,10 @@ module Simp
       return info
     end
 
+    def self.indent(message, indent_length)
+       message.split("\n").map {|line| ' '*indent_length + line }.join("\n")
+    end
+
     # Loads metadata for a GPG key. The GPG key is to be used to sign RPMs. The
     # value of gpg_key should be the full path of the directory where the key
     # resides. If the metadata cannot be found, then the user will be prompted

data/spec/acceptance/files/simplib/CHANGELOG

@@ -0,0 +1,2 @@
+* Sat Dec 13 2014 Richard Stallman <rms@gnu.org> - 0.0.1-0
+- Behold, there was a brave GNU world....

data/spec/acceptance/files/simplib/Rakefile

@@ -0,0 +1,3 @@
+require 'simp/rake/pkg'
+
+Simp::Rake::Pkg.new( File.dirname( __FILE__ ) )

data/spec/acceptance/files/simplib/build/rpm_metadata/requires

@@ -0,0 +1 @@
+Requires: pupmod-simp-foo >= 1.2.3

data/spec/acceptance/files/simplib/metadata.json

@@ -0,0 +1,33 @@
+{
+  "name":    "simp-simplib",
+  "version": "1.2.3",
+  "author":  "simp",
+  "summary": "A fake SIMP simplib for Testing Test Things",
+  "license": "Apache-2.0",
+  "source":  "https://github.com/simp/pupmod-imatest",
+  "project_page": "https://github.com/simp/pupmod-imatest",
+  "issues_url":   "https://simp/project.atlassian.net",
+  "tags": [ "simp", "test"],
+  "dependencies": [
+    {
+     "name": "simp/compliance_markup",
+     "version_requirement": ">= 1.0.0"
+    }
+  ],
+  "operatingsystem_support": [
+    {
+      "operatingsystem": "CentOS",
+      "operatingsystemrelease": [
+        "6",
+        "7"
+      ]
+    },
+    {
+      "operatingsystem": "RedHat",
+      "operatingsystemrelease": [
+        "6",
+        "7"
+      ]
+    }
+  ]
+}

data/spec/acceptance/files/testpackage_missing_license/CHANGELOG

@@ -0,0 +1,2 @@
+* Sat Dec 13 2014 Richard Stallman <rms@gnu.org> - 0.0.1-0
+- Behold, there was a brave GNU world....

data/spec/acceptance/files/testpackage_missing_license/Rakefile

@@ -0,0 +1,3 @@
+require 'simp/rake/pkg'
+
+Simp::Rake::Pkg.new( File.dirname( __FILE__ ) )

data/spec/acceptance/files/testpackage_missing_license/build/rpm_metadata/requires

@@ -0,0 +1 @@
+Requires: pupmod-simp-foo >= 1.2.3

data/spec/acceptance/files/testpackage_missing_license/metadata.json

@@ -0,0 +1,32 @@
+{
+  "name":    "simp-testpackage",
+  "version": "0.0.1",
+  "author":  "simp",
+  "summary": "A SIMP Test Package for Testing Test Things",
+  "source":  "https://github.com/simp/pupmod-imatest",
+  "project_page": "https://github.com/simp/pupmod-imatest",
+  "issues_url":   "https://simp/project.atlassian.net",
+  "tags": [ "simp", "test"],
+  "dependencies": [
+    {
+      "name": "simp/simplib",
+      "version_requirement": ">= 1.1.0"
+    }
+  ],
+  "operatingsystem_support": [
+    {
+      "operatingsystem": "CentOS",
+      "operatingsystemrelease": [
+        "6",
+        "7"
+      ]
+    },
+    {
+      "operatingsystem": "RedHat",
+      "operatingsystemrelease": [
+        "6",
+        "7"
+      ]
+    }
+  ]
+}

data/spec/acceptance/files/testpackage_missing_metadata_file/CHANGELOG

@@ -0,0 +1,2 @@
+* Sat Dec 13 2014 Richard Stallman <rms@gnu.org> - 0.0.1-0
+- Behold, there was a brave GNU world....

data/spec/acceptance/files/testpackage_missing_metadata_file/Rakefile

@@ -0,0 +1,3 @@
+require 'simp/rake/pkg'
+
+Simp::Rake::Pkg.new( File.dirname( __FILE__ ) )

data/spec/acceptance/files/testpackage_missing_metadata_file/build/rpm_metadata/requires

@@ -0,0 +1 @@
+Requires: pupmod-simp-foo >= 1.2.3

data/spec/acceptance/files/testpackage_missing_name/CHANGELOG

@@ -0,0 +1,2 @@
+* Sat Dec 13 2014 Richard Stallman <rms@gnu.org> - 0.0.1-0
+- Behold, there was a brave GNU world....

data/spec/acceptance/files/testpackage_missing_name/Rakefile

@@ -0,0 +1,3 @@
+require 'simp/rake/pkg'
+
+Simp::Rake::Pkg.new( File.dirname( __FILE__ ) )

data/spec/acceptance/files/testpackage_missing_name/build/rpm_metadata/requires

@@ -0,0 +1 @@
+Requires: pupmod-simp-foo >= 1.2.3

data/spec/acceptance/files/testpackage_missing_name/metadata.json

@@ -0,0 +1,32 @@
+{
+  "version": "0.0.1",
+  "author":  "simp",
+  "summary": "A SIMP Test Package for Testing Test Things",
+  "license": "Apache-2.0",
+  "source":  "https://github.com/simp/pupmod-imatest",
+  "project_page": "https://github.com/simp/pupmod-imatest",
+  "issues_url":   "https://simp/project.atlassian.net",
+  "tags": [ "simp", "test"],
+  "dependencies": [
+    {
+      "name": "simp/simplib",
+      "version_requirement": ">= 1.1.0"
+    }
+  ],
+  "operatingsystem_support": [
+    {
+      "operatingsystem": "CentOS",
+      "operatingsystemrelease": [
+        "6",
+        "7"
+      ]
+    },
+    {
+      "operatingsystem": "RedHat",
+      "operatingsystemrelease": [
+        "6",
+        "7"
+      ]
+    }
+  ]
+}

data/spec/acceptance/files/testpackage_missing_source/CHANGELOG

@@ -0,0 +1,2 @@
+* Sat Dec 13 2014 Richard Stallman <rms@gnu.org> - 0.0.1-0
+- Behold, there was a brave GNU world....

data/spec/acceptance/files/testpackage_missing_source/Rakefile

@@ -0,0 +1,3 @@
+require 'simp/rake/pkg'
+
+Simp::Rake::Pkg.new( File.dirname( __FILE__ ) )

data/spec/acceptance/files/testpackage_missing_source/build/rpm_metadata/requires

@@ -0,0 +1 @@
+Requires: pupmod-simp-foo >= 1.2.3

data/spec/acceptance/files/testpackage_missing_source/metadata.json

@@ -0,0 +1,32 @@
+{
+  "name":    "simp-testpackage",
+  "version": "0.0.1",
+  "author":  "simp",
+  "summary": "A SIMP Test Package for Testing Test Things",
+  "license": "Apache-2.0",
+  "project_page": "https://github.com/simp/pupmod-imatest",
+  "issues_url":   "https://simp/project.atlassian.net",
+  "tags": [ "simp", "test"],
+  "dependencies": [
+    {
+      "name": "simp/simplib",
+      "version_requirement": ">= 1.1.0"
+    }
+  ],
+  "operatingsystem_support": [
+    {
+      "operatingsystem": "CentOS",
+      "operatingsystemrelease": [
+        "6",
+        "7"
+      ]
+    },
+    {
+      "operatingsystem": "RedHat",
+      "operatingsystemrelease": [
+        "6",
+        "7"
+      ]
+    }
+  ]
+}

data/spec/acceptance/files/testpackage_missing_summary/CHANGELOG

@@ -0,0 +1,2 @@
+* Sat Dec 13 2014 Richard Stallman <rms@gnu.org> - 0.0.1-0
+- Behold, there was a brave GNU world....

data/spec/acceptance/files/testpackage_missing_summary/Rakefile

@@ -0,0 +1,3 @@
+require 'simp/rake/pkg'
+
+Simp::Rake::Pkg.new( File.dirname( __FILE__ ) )

data/spec/acceptance/files/testpackage_missing_summary/build/rpm_metadata/requires

@@ -0,0 +1 @@
+Requires: pupmod-simp-foo >= 1.2.3

data/spec/acceptance/files/testpackage_missing_summary/metadata.json

@@ -0,0 +1,32 @@
+{
+  "name":    "simp-testpackage",
+  "version": "0.0.1",
+  "author":  "simp",
+  "license": "Apache-2.0",
+  "source":  "https://github.com/simp/pupmod-imatest",
+  "project_page": "https://github.com/simp/pupmod-imatest",
+  "issues_url":   "https://simp/project.atlassian.net",
+  "tags": [ "simp", "test"],
+  "dependencies": [
+    {
+      "name": "simp/simplib",
+      "version_requirement": ">= 1.1.0"
+    }
+  ],
+  "operatingsystem_support": [
+    {
+      "operatingsystem": "CentOS",
+      "operatingsystemrelease": [
+        "6",
+        "7"
+      ]
+    },
+    {
+      "operatingsystem": "RedHat",
+      "operatingsystemrelease": [
+        "6",
+        "7"
+      ]
+    }
+  ]
+}

data/spec/acceptance/files/testpackage_missing_version/CHANGELOG

@@ -0,0 +1,2 @@
+* Sat Dec 13 2014 Richard Stallman <rms@gnu.org> - 0.0.1-0
+- Behold, there was a brave GNU world....

data/spec/acceptance/files/testpackage_missing_version/Rakefile

@@ -0,0 +1,3 @@
+require 'simp/rake/pkg'
+
+Simp::Rake::Pkg.new( File.dirname( __FILE__ ) )

data/spec/acceptance/files/testpackage_missing_version/build/rpm_metadata/requires

@@ -0,0 +1 @@
+Requires: pupmod-simp-foo >= 1.2.3

data/spec/acceptance/files/testpackage_missing_version/metadata.json

@@ -0,0 +1,32 @@
+{
+  "name":    "simp-testpackage",
+  "author":  "simp",
+  "summary": "A SIMP Test Package for Testing Test Things",
+  "license": "Apache-2.0",
+  "source":  "https://github.com/simp/pupmod-imatest",
+  "project_page": "https://github.com/simp/pupmod-imatest",
+  "issues_url":   "https://simp/project.atlassian.net",
+  "tags": [ "simp", "test"],
+  "dependencies": [
+    {
+      "name": "simp/simplib",
+      "version_requirement": ">= 1.1.0"
+    }
+  ],
+  "operatingsystem_support": [
+    {
+      "operatingsystem": "CentOS",
+      "operatingsystemrelease": [
+        "6",
+        "7"
+      ]
+    },
+    {
+      "operatingsystem": "RedHat",
+      "operatingsystemrelease": [
+        "6",
+        "7"
+      ]
+    }
+  ]
+}

data/spec/acceptance/files/testpackage_with_bad_changelog_date/CHANGELOG

@@ -0,0 +1,2 @@
+* Wed Dec 13 2014 Richard Stallman <rms@gnu.org> - 0.0.1-0
+- Behold, there was a brave GNU world....

data/spec/acceptance/files/testpackage_with_bad_changelog_date/Rakefile

@@ -0,0 +1,3 @@
+require 'simp/rake/pkg'
+
+Simp::Rake::Pkg.new( File.dirname( __FILE__ ) )

data/spec/acceptance/files/testpackage_with_bad_changelog_date/build/rpm_metadata/requires

@@ -0,0 +1 @@
+Requires: pupmod-simp-foo >= 1.2.3

data/spec/acceptance/files/testpackage_with_bad_changelog_date/metadata.json

@@ -0,0 +1,33 @@
+{
+  "name":    "simp-testpackage",
+  "version": "0.0.1",
+  "author":  "simp",
+  "summary": "A SIMP Test Package for Testing Test Things",
+  "license": "Apache-2.0",
+  "source":  "https://github.com/simp/pupmod-imatest",
+  "project_page": "https://github.com/simp/pupmod-imatest",
+  "issues_url":   "https://simp/project.atlassian.net",
+  "tags": [ "simp", "test"],
+  "dependencies": [
+    {
+      "name": "simp/simplib",
+      "version_requirement": ">= 1.1.0"
+    }
+  ],
+  "operatingsystem_support": [
+    {
+      "operatingsystem": "CentOS",
+      "operatingsystemrelease": [
+        "6",
+        "7"
+      ]
+    },
+    {
+      "operatingsystem": "RedHat",
+      "operatingsystemrelease": [
+        "6",
+        "7"
+      ]
+    }
+  ]
+}