simp-metadata 0.4.4 → 0.5.2

data/lib/simp/metadata/version.rb

@@ -0,0 +1,9 @@
+module Simp
+  module Metadata
+    class Version
+      def self.version
+      '0.5.2'.freeze
+      end
+    end
+  end
+end

data/spec/simp/media/command_spec.rb

@@ -1,12 +1,11 @@
-require 'spec_helper'
+require_relative '../../spec_helper'
 require 'simp/media'
 require 'simp/media/command'
 
 describe Simp::Media::Command do
-  xit "Should display help when no options are passed" do
+  xit 'Should display help when no options are passed' do
     # Create an output capture system.
-    command = Simp::Media::Command.new()
+    command = Simp::Media::Command.new
     command.run([])
   end
-
-end
+end

data/spec/simp/media/engine_spec.rb

@@ -1,28 +1,28 @@
-require 'spec_helper'
+require_relative '../../spec_helper'
 require 'simp/media'
 
 describe Simp::Media::Engine do
-  it "should throw an error if input_type is nil" do
-    expect { engine = Simp::Media::Engine.new({"version" => "test-stub", "input_type" => nil}) }.to raise_error(RuntimeError, "input_type must be specified")
+  it 'should throw an error if input_type is nil' do
+    expect { engine = Simp::Media::Engine.new('version' => 'test-stub', 'input_type' => nil) }.to raise_error(RuntimeError, 'input_type must be specified')
   end
-  it "should throw an error if output_type is nil" do
-    expect { engine = Simp::Media::Engine.new({"version" => "test-stub", "output_type" => nil}) }.to raise_error(RuntimeError, "output_type must be specified")
+  it 'should throw an error if output_type is nil' do
+    expect { engine = Simp::Media::Engine.new('version' => 'test-stub', 'output_type' => nil) }.to raise_error(RuntimeError, 'output_type must be specified')
   end
-  it "should instantiate without errors" do
-    tempdir = Dir.mktmpdir("simp-media-rspec")
-    engine = Simp::Media::Engine.new({"version" => "test-stub", "edition" => "community", "output_type" => "tar", "output" => "#{tempdir}/test.tgz"})
+  it 'should instantiate without errors' do
+    tempdir = Dir.mktmpdir('simp-media-rspec')
+    engine = Simp::Media::Engine.new('version' => 'test-stub', 'edition' => 'community', 'output_type' => 'tar', 'output' => "#{tempdir}/test.tgz")
     expect(engine.loaded?).to match(true)
-    engine.cleanup()
+    engine.cleanup
     engine = nil
     FileUtils.rmtree(tempdir)
   end
-  it "should run without errors" do
-    tempdir = Dir.mktmpdir("simp-media-rspec")
-    engine = Simp::Media::Engine.new({"version" => "test-stub", "edition" => "community", "output_type" => "tar", "output" => "#{tempdir}/test.tgz"})
+  it 'should run without errors' do
+    tempdir = Dir.mktmpdir('simp-media-rspec')
+    engine = Simp::Media::Engine.new('version' => 'test-stub', 'edition' => 'community', 'output_type' => 'tar', 'output' => "#{tempdir}/test.tgz")
     expect(engine.loaded?).to match(true)
     engine.run
-    engine.cleanup()
+    engine.cleanup
     engine = nil
     FileUtils.rmtree(tempdir)
   end
-end
+end

data/spec/simp/media/type/control_repo_spec.rb

@@ -1,23 +1,21 @@
-require 'spec_helper'
+require_relative '../../../spec_helper'
 require 'simp/media'
 
 describe Simp::Media::Type::Control_repo do
-
-  it "should throw an error if output is nil" do
-    expect { engine = Simp::Media::Engine.new({"version" => "test-stub", "output" => nil}) }.to raise_error(RuntimeError, "output must be specified for control-repo output")
+  it 'should throw an error if output is nil' do
+    expect { engine = Simp::Media::Engine.new('version' => 'test-stub', 'output' => nil) }.to raise_error(RuntimeError, 'output must be specified for control-repo output')
   end
   it "should throw an error if output is not a git repo and it's not a local directory" do
-    expect { engine = Simp::Media::Engine.new({"version" => "test-stub", "output" => "https://localhost:6666/repo.git"}) }.to raise_error(RuntimeError, "output is not a valid control-repo")
+    expect { engine = Simp::Media::Engine.new('version' => 'test-stub', 'output' => 'https://localhost:6666/repo.git') }.to raise_error(RuntimeError, 'output is not a valid control-repo')
   end
 
-  it "should create a bare repo when .git is part of the path" do
-    tempdir = Dir.mktmpdir("simp-media-rspec")
-    engine = Simp::Media::Engine.new({"version" => "test-stub", "output" => "file://#{tempdir}/control-repo.git"})
+  it 'should create a bare repo when .git is part of the path' do
+    tempdir = Dir.mktmpdir('simp-media-rspec')
+    engine = Simp::Media::Engine.new('version' => 'test-stub', 'output' => "file://#{tempdir}/control-repo.git")
     expect(engine.loaded?).to match(true)
-    engine.run()
-    engine.cleanup()
+    engine.run
+    engine.cleanup
     engine = nil
     FileUtils.rmtree(tempdir)
   end
-
-end
+end

data/spec/simp/media/type/internet_spec.rb

@@ -1,29 +1,29 @@
-require 'spec_helper'
+require_relative '../../../spec_helper'
 require 'simp/media'
 
 describe Simp::Media::Type::Internet do
   describe "with edition == 'community'" do
-    it "should run without errors" do
-      tempdir = Dir.mktmpdir("simp-media-rspec")
-      engine = Simp::Media::Engine.new({"version" => "test-stub", "edition" => "community", "output_type" => "tar", "output" => "#{tempdir}/test.tgz"})
+    it 'should run without errors' do
+      tempdir = Dir.mktmpdir('simp-media-rspec')
+      engine = Simp::Media::Engine.new('version' => 'test-stub', 'edition' => 'community', 'output_type' => 'tar', 'output' => "#{tempdir}/test.tgz")
       expect(engine.loaded?).to match(true)
       engine.run
-      engine.cleanup()
+      engine.cleanup
       engine = nil
       FileUtils.rmtree(tempdir)
     end
   end
-  if (ENV.fetch("SIMP_LICENSE_KEY", nil) != nil)
+  if ENV.fetch('SIMP_LICENSE_KEY', nil) != nil
     describe "with edition == 'enterprise'" do
-      it "should run without errors" do
-        tempdir = Dir.mktmpdir("simp-media-rspec")
-        engine = Simp::Media::Engine.new({"version" => "test-stub", "edition" => "enterprise", "output_type" => "tar", "output" => "#{tempdir}/test.tgz"})
+      it 'should run without errors' do
+        tempdir = Dir.mktmpdir('simp-media-rspec')
+        engine = Simp::Media::Engine.new('version' => 'test-stub', 'edition' => 'enterprise', 'output_type' => 'tar', 'output' => "#{tempdir}/test.tgz")
         expect(engine.loaded?).to match(true)
         engine.run
-        engine.cleanup()
+        engine.cleanup
         engine = nil
         FileUtils.rmtree(tempdir)
       end
     end
   end
-end
+end

data/spec/simp/media/type/iso_spec.rb

@@ -1,15 +1,14 @@
-require 'spec_helper'
+require_relative '../../../spec_helper'
 require 'simp/media'
 
 describe Simp::Media::Type::Iso do
-  xit "should run without errors" do
-    tempdir = Dir.mktmpdir("simp-media-rspec")
-    engine = Simp::Media::Engine.new({"version" => "test-stub", "edition" => "community", "output_type" => "iso", "output" => "#{tempdir}/test.iso"})
+  xit 'should run without errors' do
+    tempdir = Dir.mktmpdir('simp-media-rspec')
+    engine = Simp::Media::Engine.new('version' => 'test-stub', 'edition' => 'community', 'output_type' => 'iso', 'output' => "#{tempdir}/test.iso")
     expect(engine.loaded?).to match(true)
     engine.run
-    engine.cleanup()
+    engine.cleanup
     engine = nil
     FileUtils.rmtree(tempdir)
   end
-
-end
+end

data/spec/simp/media/type/local_spec.rb

@@ -1,16 +1,14 @@
-require 'spec_helper'
+require_relative '../../../spec_helper'
 require 'simp/media'
 
 describe Simp::Media::Type::Local do
-
-  xit "should run without errors" do
-    tempdir = Dir.mktmpdir("simp-media-rspec")
-    engine = Simp::Media::Engine.new({"version" => "test-stub", "edition" => "community", "output_type" => "local", "output" => "#{tempdir}"})
+  xit 'should run without errors' do
+    tempdir = Dir.mktmpdir('simp-media-rspec')
+    engine = Simp::Media::Engine.new('version' => 'test-stub', 'edition' => 'community', 'output_type' => 'local', 'output' => tempdir.to_s)
     expect(engine.loaded?).to match(true)
     engine.run
-    engine.cleanup()
+    engine.cleanup
     engine = nil
     FileUtils.rmtree(tempdir)
   end
-
-end
+end

data/spec/simp/media/type/tar_spec.rb

@@ -1,16 +1,14 @@
-require 'spec_helper'
+require_relative '../../../spec_helper'
 require 'simp/media'
 
 describe Simp::Media::Type::Tar do
-
-  it "should run without errors" do
-    tempdir = Dir.mktmpdir("simp-media-rspec")
-    engine = Simp::Media::Engine.new({"version" => "test-stub", "edition" => "community", "output_type" => "tar", "output" => "#{tempdir}/test.tgz"})
+  it 'should run without errors' do
+    tempdir = Dir.mktmpdir('simp-media-rspec')
+    engine = Simp::Media::Engine.new('version' => 'test-stub', 'edition' => 'community', 'output_type' => 'tar', 'output' => "#{tempdir}/test.tgz")
     expect(engine.loaded?).to match(true)
     engine.run
-    engine.cleanup()
+    engine.cleanup
     engine = nil
     FileUtils.rmtree(tempdir)
   end
-
-end
+end

data/spec/simp/metadata/buildinfo_spec.rb

@@ -1,63 +1,65 @@
-require 'spec_helper'
+require_relative '../../spec_helper'
 require 'simp/metadata'
+
 def test_buildinfo(type)
   Simp::Metadata::Buildinfo.new(test_component, type)
 end
+
 def diff_buildinfo(type)
   Simp::Metadata::Buildinfo.new(diff_component, type)
 end
-describe Simp::Metadata::Buildinfo do
 
-  describe "#keys" do
+describe Simp::Metadata::Buildinfo do
+  describe '#keys' do
     it 'should return an Array' do
-      expect(test_buildinfo("rpm").keys.class.to_s).to eql("Array")
+      expect(test_buildinfo('rpm').keys.class.to_s).to eql('Array')
     end
-    it "should return an Array of Strings" do
-      expect(test_buildinfo("rpm").keys.all? {|output| output.class.to_s == "String"}).to eql(true)
+    it 'should return an Array of Strings' do
+      expect(test_buildinfo('rpm').keys.all? { |output| output.class.to_s == 'String' }).to eql(true)
     end
   end
-  describe "#type" do
+  describe '#type' do
     context "when type == 'rpm'" do
       it 'should return a String' do
-        expect(test_buildinfo("rpm").type.class.to_s).to eql("String")
+        expect(test_buildinfo('rpm').type.class.to_s).to eql('String')
       end
       it "should return 'rpm'" do
-        expect(test_buildinfo("rpm").type).to eql("rpm")
+        expect(test_buildinfo('rpm').type).to eql('rpm')
       end
     end
   end
   describe "#['type']" do
     context "when type == 'rpm'" do
       it 'should return a String' do
-        expect(test_buildinfo("rpm")['type'].class.to_s).to eql("String")
+        expect(test_buildinfo('rpm')['type'].class.to_s).to eql('String')
       end
       it "should return 'rpm'" do
-        expect(test_buildinfo("rpm")['type']).to eql("rpm")
+        expect(test_buildinfo('rpm')['type']).to eql('rpm')
       end
     end
   end
-  describe "#build_method" do
+  describe '#build_method' do
     context "when type == 'rpm'" do
       it 'should return a String' do
-        expect(test_buildinfo("rpm").build_method.class.to_s).to eql("String")
+        expect(test_buildinfo('rpm').build_method.class.to_s).to eql('String')
       end
       it "should return 'simp-core'" do
-        expect(test_buildinfo("rpm").build_method).to eql("simp-core")
+        expect(test_buildinfo('rpm').build_method).to eql('simp-core')
       end
     end
     context "when simp-metadata == 'metadata-build'" do
       it "should return 'metadata-build'" do
-        expect(diff_buildinfo("rpm").build_method).to eql("metadata-build")
+        expect(diff_buildinfo('rpm').build_method).to eql('metadata-build')
       end
     end
   end
   describe "#['build_method']" do
     context "when type == 'rpm'" do
       it 'should return a String' do
-        expect(test_buildinfo("rpm")['build_method'].class.to_s).to eql("String")
+        expect(test_buildinfo('rpm')['build_method'].class.to_s).to eql('String')
       end
       it "should return 'simp-core'" do
-        expect(test_buildinfo("rpm")['build_method']).to eql("simp-core")
+        expect(test_buildinfo('rpm')['build_method']).to eql('simp-core')
       end
     end
   end

data/spec/simp/metadata/commands/clone_spec.rb

@@ -1,8 +1,9 @@
-require 'spec_helper'
+require_relative '../../../spec_helper'
 require 'simp/metadata'
 require 'simp/metadata/commands/clone'
+
 describe Simp::Metadata::Commands::Clone do
-  xit "should execute successfully" do
+  xit 'should execute successfully' do
     # We need to stub the writable urls here.
   end
-end
+end

data/spec/simp/metadata/component_spec.rb

@@ -1,89 +1,78 @@
-require 'spec_helper'
+require_relative '../../spec_helper'
 require 'simp/metadata'
 require 'simp/metadata/commands/clone'
 describe Simp::Metadata::Component do
-
-  describe "#view" do
+  describe '#view' do
     context 'when attribute = nil' do
-      it "should return all information" do
-        release = 'test-stub'
-        component = 'pupmod-simp-activemq'
+      it 'should return all information' do
         attribute = nil
-        test = component_view_instance(release, component, attribute)
-        expect(test).to eql("asset_name" => "activemq",
-                            "authoritative" => "true",
-                            "branch" => "master",
-                            "component_source" => "simp-metadata",
-                            "component_type" => "puppet-module",
-                            "extension" => "tgz",
-                            "extract" => "false",
-                            "format" => "git",
-                            "location" => {"extract" => "false", "primary" => "false", "method" => "git", "url" => "https://gitlab.com/simp/simp-activemq"},
-                            "method" => "git",
-                            "module_name" => "activemq",
-                            "ref" => "488f5a0d5b53063c125b93a596626193b71aaa08",
-                            "release_source" => "simp-metadata",
-                            "tag" => "1.1.1",
-                            "url" => "https://github.com/simp/pupmod-simp-activemq",
-                            "version" => "1.1.1",
-                        )
+        test = component_view_instance(attribute)
+        expect(test).to eql('asset_name' => 'activemq',
+                            'authoritative' => 'true',
+                            'branch' => 'master',
+                            'component_source' => 'simp-metadata',
+                            'component_type' => 'puppet-module',
+                            'extension' => 'tgz',
+                            'extract' => 'false',
+                            'location' => { 'extract' => 'false', 'primary' => 'true', 'method' => 'git', 'url' => 'https://github.com/simp/pupmod-simp-activemq' },
+                            'method' => 'git',
+                            'module_name' => 'activemq',
+                            'ref' => '488f5a0d5b53063c125b93a596626193b71aaa08',
+                            'release_source' => 'simp-metadata',
+                            'revision' => '0',
+                            'tag' => '1.1.1',
+                            'target' => 'noarch',
+                            'url' => 'https://github.com/simp/pupmod-simp-activemq',
+                            'version' => '1.1.1')
       end
     end
     context 'when attribute = version' do
-      it "should return only the version" do
-        release = 'test-stub'
-        component = 'pupmod-simp-activemq'
+      it 'should return only the version' do
         attribute = 'version'
-        test = component_view_instance(release, component, attribute)
-        expect(test).to eql("version" => "1.1.1")
+        test = component_view_instance(attribute)
+        expect(test).to eql('version' => '1.1.1')
       end
     end
   end
 
-  describe "#diff" do
+  describe '#diff' do
     context 'when attribute = nil' do
-      it "should return all information" do
-        release1 = 'test-stub'
-        release2 = 'test-diff'
+      it 'should return all information' do
         attribute = nil
-        component = 'pupmod-simp-activemq'
-        test = component_diff_instance(release1, release2, component, attribute)
-        expect(test).to eql("branch" => {"original" => "master", "changed" => "develop"},
-                            "ref" => {"original" => "488f5a0d5b53063c125b93a596626193b71aaa08", "changed" => "3987ra0d5b53063f493b93a596626193b71dddd4"},
-                            "tag" => {"original" => "1.1.1", "changed" => "1.1.2"},
-                            "version" => {"original" => "1.1.1", "changed" => "1.1.2"})
+        test = component_diff_instance(attribute)
+        expect(test).to eql('branch' => { 'original' => 'master', 'changed' => 'develop' },
+                            'ref' => { 'original' => '488f5a0d5b53063c125b93a596626193b71aaa08', 'changed' => '3987ra0d5b53063f493b93a596626193b71dddd4' },
+                            'tag' => { 'original' => '1.1.1', 'changed' => '1.1.2' },
+                            'version' => { 'original' => '1.1.1', 'changed' => '1.1.2' })
       end
     end
     context 'when attribute = version' do
-      it "should return only the version" do
-        release1 = 'test-stub'
-        release2 = 'test-diff'
+      it 'should return only the version' do
         attribute = 'version'
-        component = 'pupmod-simp-activemq'
-        test = component_diff_instance(release1, release2, component, attribute)
-        expect(test).to eql("version" => {"original" => "1.1.1", "changed" => "1.1.2"})
+        test = component_diff_instance(attribute)
+        expect(test).to eql('version' => { 'original' => '1.1.1', 'changed' => '1.1.2' })
       end
     end
   end
-  describe "#buildinfo" do
+  describe '#buildinfo' do
     context 'when type = nil' do
-      it "should return a Hash" do
-        expect(test_component.buildinfo().class.to_s).to eql("Hash")
+      it 'should return a Hash' do
+        expect(test_component.buildinfo.class.to_s).to eql('Hash')
       end
-      it "should contain only Simp::Metadata::Buildinfo objects" do
-        expect(test_component.buildinfo.all? { |buildinfo| buildinfo.class.to_s == "Simp::Metadata::Buildinfo"}).to eql(true)
+      it 'should contain only Simp::Metadata::Buildinfo objects' do
+        expect(test_component.buildinfo.all? { |buildinfo| buildinfo.class.to_s == 'Simp::Metadata::Buildinfo' }).to eql(true)
       end
     end
 
     context "when type = 'rpm'" do
-      it "should return a Simp::Metadata::Buildinfo object" do
-        expect(test_component.buildinfo("rpm").class.to_s).to eql("Simp::Metadata::Buildinfo")
+      it 'should return a Simp::Metadata::Buildinfo object' do
+        expect(test_component.buildinfo('rpm').class.to_s).to eql('Simp::Metadata::Buildinfo')
       end
       it "should be of type 'rpm'" do
-        expect(test_component.buildinfo("rpm").type).to eql("rpm")
+        expect(test_component.buildinfo('rpm').type).to eql('rpm')
       end
       it "should be of build_method 'simp-core'" do
-        expect(test_component.buildinfo("rpm").build_method).to eql("simp-core")
+        expect(test_component.buildinfo('rpm').build_method).to eql('simp-core')
       end
     end
   end

data/spec/simp/metadata/engine_spec.rb

@@ -1,70 +1,67 @@
-require 'spec_helper'
+require_relative '../../spec_helper'
 require 'simp/metadata'
 describe Simp::Metadata::Engine do
-
-  it "should instantiate without errors" do
-    expect {
+  it 'should instantiate without errors' do
+    expect do
       engine = Simp::Metadata::Engine.new
 
-      engine.cleanup()
+      engine.cleanup
       engine = nil
-    }.not_to raise_error()
+    end.not_to raise_error
   end
-  it "dirty? should return false" do
-
+  it 'dirty? should return false' do
     engine = Simp::Metadata::Engine.new
     expect(engine.dirty?).to eql(false)
-    engine.cleanup()
+    engine.cleanup
     engine = nil
   end
-  it "save should run without errors" do
-    expect {
+  it 'save should run without errors' do
+    expect do
       engine = Simp::Metadata::Engine.new
 
-      engine.save()
-      engine.cleanup()
+      engine.save
+      engine.cleanup
       engine = nil
-    }.not_to raise_error()
+    end.not_to raise_error
   end
-  it "cleanup should run without errors" do
-    expect {
+  it 'cleanup should run without errors' do
+    expect do
       engine = Simp::Metadata::Engine.new
 
-      engine.cleanup()
+      engine.cleanup
       engine = nil
-    }.not_to raise_error()
+    end.not_to raise_error
   end
-  describe "components" do
-      it "should run without errors" do
-        expect {
-          engine = Simp::Metadata::Engine.new
-
-          engine.components()
-          engine = nil
-        }.not_to raise_error()
-      end
-      it "should return a Simp::Metadata::Components object" do
+  describe 'components' do
+    it 'should run without errors' do
+      expect do
         engine = Simp::Metadata::Engine.new
-        expect(engine.components.class.to_s).to eql("Simp::Metadata::Components")
-        engine.cleanup()
+
+        engine.components
         engine = nil
-      end
+      end.not_to raise_error
+    end
+    it 'should return a Simp::Metadata::Components object' do
+      engine = Simp::Metadata::Engine.new
+      expect(engine.components.class.to_s).to eql('Simp::Metadata::Components')
+      engine.cleanup
+      engine = nil
+    end
   end
-  describe "releases" do
-    it "should run without errors" do
-      expect {
+  describe 'releases' do
+    it 'should run without errors' do
+      expect do
         engine = Simp::Metadata::Engine.new
 
-        engine.releases()
+        engine.releases
         engine = nil
-      }.not_to raise_error()
+      end.not_to raise_error
     end
-    it "should return a Simp::Metadata::Releases object" do
+    it 'should return a Simp::Metadata::Releases object' do
       engine = Simp::Metadata::Engine.new
-      expect(engine.releases.class.to_s).to eql("Simp::Metadata::Releases")
-      engine.cleanup()
+      expect(engine.releases.class.to_s).to eql('Simp::Metadata::Releases')
+      engine.cleanup
       engine = nil
     end
   end
-
-end
+end